first attempt implementing module - not working

app.py

@@ -1,11 +1,12 @@
 import os
-from shiny import App, ui, render, reactive
+from shiny import module, App, ui, render, reactive
 import fastf1 as ff1
 import matplotlib.pyplot as plt
 from matplotlib.collections import LineCollection
 from matplotlib import cm
 import numpy as np
 import shinyswatch
+from modules import plot
 
 # Define cache folder path
 cache_path = os.getcwd() + "/cache"
@@ -83,7 +84,7 @@ app_ui = ui.page_fluid(
             ui.row(
                 ui.column(
                     6,
-                    ui.output_plot("gear_1"),
+                    plot.plot1_ui("gear_1"),
                     ui.output_text("fastest_driver_1"),
                     ui.output_text("laptime_1")
                 ),
@@ -119,38 +120,6 @@ def server(input, output, session):
             choices=driver_options,
             selected=input.driver2_select()
         )
-    
-    # Get required data for driver 1 based on selection
-    @reactive.Calc
-    def get_data_1():
-        try:
-            ui.notification_show("Data takes a couple seconds to load.", duration=3, type = 'default')
-            
-            f1_session = ff1.get_session(int(input.year()), input.track_select(), input.session_type())
-            f1_session.load()
-
-            # Check if user input == fastest driver
-            if input.driver1_select() == "Fastest driver":
-                lap = f1_session.laps.pick_fastest()
-            else:
-                laps_driver = f1_session.laps.pick_driver(input.driver1_select())
-                lap = laps_driver.pick_fastest()
-            
-            tel = lap.get_telemetry()
-            driver = lap['Driver']
-
-            #converting data to numpy data tables
-            x = np.array(tel['X'].values)
-            y = np.array(tel['Y'].values)
-
-            points = np.array([x, y]).T.reshape(-1, 1, 2)
-            segments = np.concatenate([points[:-1], points[1:]], axis=1)
-            gear = tel['nGear'].to_numpy().astype(float)
-            lap_time = lap['LapTime']
-            return segments, gear, driver, lap_time
-
-        except Exception:
-            ui.notification_show("Data not available. Select another track or driver.", duration=10, type = 'error')
 
     # Get required data for driver 2 based on selection
     @reactive.Calc
@@ -186,7 +155,7 @@ def server(input, output, session):
     @output
     @render.text
     def fastest_driver_1():
-        segments, gear, driver, lap_time = get_data_1()
+        segments, gear, driver, lap_time = plot.plot1_server("get_data_1")
         #print(f"The driver of the fastest lap this session is: {driver}")
         return f"Graph shows the fastest lap of: {driver}"
     
@@ -200,7 +169,7 @@ def server(input, output, session):
     @output
     @render.text
     def laptime_1():
-        segments, gear, driver, lap_time = get_data_1()
+        segments, gear, driver, lap_time = plot.plot1_server("get_data_1")
         delta_str= str(lap_time)
         # Split the time delta string to extract hours, minutes, and seconds
         time_parts = delta_str.split(" ")[-1].split(":")
@@ -225,29 +194,7 @@ def server(input, output, session):
 
         return f"The lap time is: {formatted_time}"
 
-    @output
-    @render.plot
-    def gear_1():
-        try:
-            segments, gear, driver, lap_time = get_data_1()
-            
-            cmap = cm.get_cmap('Paired')
-            lc_comp = LineCollection(segments, norm=plt.Normalize(1, cmap.N+1), cmap=cmap)
-            lc_comp.set_array(gear)
-            lc_comp.set_linewidth(4)
-
-            plt.gca().add_collection(lc_comp)
-            plt.axis('equal')
-            plt.tick_params(labelleft=False, left=False, labelbottom=False, bottom=False)
-
-            cbar = plt.colorbar(mappable=lc_comp, label="Gear", boundaries=np.arange(1, 10))
-            cbar.set_ticks(np.arange(1.5, 9.5))
-            cbar.set_ticklabels(np.arange(1, 9))
-    
-            plt
-
-        except Exception:
-            pass
+    plot.plot1_server("gear_1")
 
     @output
     @render.plot

modules/plot.py

@@ -1,16 +1,22 @@
-from shiny import module, ui, render, reactive, event, App
+import os
+from shiny import module, App, ui, render, reactive
 import fastf1 as ff1
+import matplotlib.pyplot as plt
+from matplotlib.collections import LineCollection
+from matplotlib import cm
 import numpy as np
+import shinyswatch
 
 # UI
 @module.ui
-def plot1_ui():
-    return ui.ouput_plot("gear_1")
-
+def plot1_ui(label: str = 'plot1_ui'):
+    return ui.div(
+        ui.output_plot('gear_1')
+    )
 
 # Server
 @module.server
-def plot1_server():
+def plot1_server(input, output, session):
     @reactive.Calc
     # Get required data for driver 1 based on selection
     def get_data_1():
@@ -41,4 +47,28 @@ def plot1_server():
             return segments, gear, driver, lap_time
 
         except Exception:
-            ui.notification_show("Data not available. Select another track or driver.", duration=10, type = 'error')
+            ui.notification_show("Data not available. Select another track or driver.", duration=10, type = 'error')
+
+        @output
+        @render.plot
+        def gear_1():
+            try:
+                segments, gear, driver, lap_time = get_data_1()
+                
+                cmap = cm.get_cmap('Paired')
+                lc_comp = LineCollection(segments, norm=plt.Normalize(1, cmap.N+1), cmap=cmap)
+                lc_comp.set_array(gear)
+                lc_comp.set_linewidth(4)
+
+                plt.gca().add_collection(lc_comp)
+                plt.axis('equal')
+                plt.tick_params(labelleft=False, left=False, labelbottom=False, bottom=False)
+
+                cbar = plt.colorbar(mappable=lc_comp, label="Gear", boundaries=np.arange(1, 10))
+                cbar.set_ticks(np.arange(1.5, 9.5))
+                cbar.set_ticklabels(np.arange(1, 9))
+        
+                plt
+
+            except Exception:
+                pass