issue_id
int64 2.04k
425k
| title
stringlengths 9
251
| body
stringlengths 4
32.8k
⌀ | status
stringclasses 6
values | after_fix_sha
stringlengths 7
7
| project_name
stringclasses 6
values | repo_url
stringclasses 6
values | repo_name
stringclasses 6
values | language
stringclasses 1
value | issue_url
null | before_fix_sha
null | pull_url
null | commit_datetime
unknown | report_datetime
unknown | updated_file
stringlengths 23
187
| chunk_content
stringlengths 1
22k
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindWriteReferencesInWorkingSetAction.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui.search;
import org.eclipse.jdt.core.IField;
import org.eclipse.jdt.core.search.IJavaSearchConstants;
public class FindWriteReferencesInWorkingSetAction extends FindReferencesInWorkingSetAction {
public FindWriteReferencesInWorkingSetAction() {
super(SearchMessages.getString("Search.FindWriteReferencesInWorkingSetAction.label"), new Class[] {IField.class} );
setToolTipText(SearchMessages.getString("Search.FindWriteReferencesInWorkingSetAction.tooltip"));
}
protected int getLimitTo() {
return IJavaSearchConstants.WRITE_REFERENCES;
}
} |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui.search;
import java.io.BufferedReader;
import java.io.IOException;
import java.io.StringReader; |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | import java.lang.reflect.InvocationTargetException;
import java.util.ArrayList;
import java.util.List;
import org.eclipse.core.resources.IMarker;
import org.eclipse.core.resources.IWorkspace;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IAdaptable;
import org.eclipse.swt.SWT;
import org.eclipse.swt.events.ModifyEvent;
import org.eclipse.swt.events.ModifyListener;
import org.eclipse.swt.events.SelectionAdapter;
import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Combo;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Group;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.jface.dialogs.DialogPage;
import org.eclipse.jface.text.ITextSelection;
import org.eclipse.jface.util.Assert;
import org.eclipse.jface.viewers.ILabelProvider;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.ui.IEditorInput;
import org.eclipse.ui.IEditorPart;
import org.eclipse.ui.IWorkbenchPage; |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | import org.eclipse.ui.IWorkbenchWindow;
import org.eclipse.ui.help.WorkbenchHelp;
import org.eclipse.ui.model.IWorkbenchAdapter;
import org.eclipse.search.ui.ISearchPage;
import org.eclipse.search.ui.ISearchPageContainer;
import org.eclipse.search.ui.ISearchResultViewEntry;
import org.eclipse.search.ui.IWorkingSet;
import org.eclipse.jdt.core.IClassFile;
import org.eclipse.jdt.core.ICodeAssist;
import org.eclipse.jdt.core.ICompilationUnit;
import org.eclipse.jdt.core.IField;
import org.eclipse.jdt.core.IImportDeclaration;
import org.eclipse.jdt.core.IJavaElement;
import org.eclipse.jdt.core.IMethod;
import org.eclipse.jdt.core.IType;
import org.eclipse.jdt.core.JavaCore;
import org.eclipse.jdt.core.JavaModelException;
import org.eclipse.jdt.core.search.IJavaSearchConstants;
import org.eclipse.jdt.core.search.IJavaSearchScope;
import org.eclipse.jdt.core.search.SearchEngine;
import org.eclipse.jdt.ui.IWorkingCopyManager;
import org.eclipse.jdt.ui.JavaElementLabelProvider;
import org.eclipse.jdt.internal.ui.IJavaHelpContextIds;
import org.eclipse.jdt.internal.ui.JavaPlugin;
import org.eclipse.jdt.internal.ui.dialogs.ElementListSelectionDialog;
import org.eclipse.jdt.internal.ui.javaeditor.IClassFileEditorInput;
import org.eclipse.jdt.internal.ui.util.ExceptionHandler;
import org.eclipse.jdt.internal.ui.util.JavaModelUtil;
import org.eclipse.jdt.internal.ui.util.RowLayouter;
public class JavaSearchPage extends DialogPage implements ISearchPage, IJavaSearchConstants { |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | public static final String EXTENSION_POINT_ID= "org.eclipse.jdt.ui.JavaSearchPage";
private static List fgPreviousSearchPatterns= new ArrayList(20);
private Combo fPattern;
private String fInitialPattern;
private boolean fFirstTime= true;
private ISearchPageContainer fContainer;
private Button[] fSearchFor;
private String[] fSearchForText= {
SearchMessages.getString("SearchPage.searchFor.type"),
SearchMessages.getString("SearchPage.searchFor.method"),
SearchMessages.getString("SearchPage.searchFor.package"),
SearchMessages.getString("SearchPage.searchFor.constructor"),
SearchMessages.getString("SearchPage.searchFor.field")};
private Button[] fLimitTo;
private String[] fLimitToText= {
SearchMessages.getString("SearchPage.limitTo.declarations"),
SearchMessages.getString("SearchPage.limitTo.implementors"),
SearchMessages.getString("SearchPage.limitTo.references"),
SearchMessages.getString("SearchPage.limitTo.allOccurrences"),
SearchMessages.getString("SearchPage.limitTo.readReferences"),
SearchMessages.getString("SearchPage.limitTo.writeReferences")};
private IJavaElement fJavaElement;
private static class SearchPatternData { |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | int searchFor;
int limitTo;
String pattern;
IJavaElement javaElement;
int scope;
IWorkingSet workingSet;
public SearchPatternData(int s, int l, String p, IJavaElement element) {
this(s, l, p, element, ISearchPageContainer.WORKSPACE_SCOPE, null);
}
public SearchPatternData(int s, int l, String p, IJavaElement element, int scope, IWorkingSet workingSet) {
searchFor= s; |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | limitTo= l;
pattern= p;
javaElement= element;
this.scope= scope;
this.workingSet= workingSet;
}
}
public boolean performAction() {
SearchPatternData data= getPatternData();
IWorkspace workspace= JavaPlugin.getWorkspace();
IJavaSearchScope scope= null;
String scopeDescription= "";
switch (getContainer().getSelectedScope()) {
case ISearchPageContainer.WORKSPACE_SCOPE:
scopeDescription= SearchMessages.getString("WorkspaceScope");
scope= SearchEngine.createWorkspaceScope();
break;
case ISearchPageContainer.SELECTION_SCOPE:
scopeDescription= SearchMessages.getString("SelectionScope");
scope= JavaSearchScopeFactory.getInstance().createJavaSearchScope(getSelection());
break;
case ISearchPageContainer.WORKING_SET_SCOPE:
IWorkingSet workingSet= getContainer().getSelectedWorkingSet();
if (workingSet == null)
return false;
scopeDescription= SearchMessages.getFormattedString("WorkingSetScope", new String[] {workingSet.getName()}); |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | scope= JavaSearchScopeFactory.getInstance().createJavaSearchScope(getContainer().getSelectedWorkingSet());
}
JavaSearchResultCollector collector= new JavaSearchResultCollector();
JavaSearchOperation op= null;
if (data.javaElement != null && getPattern().equals(fInitialPattern))
op= new JavaSearchOperation(workspace, data.javaElement, data.limitTo, scope, scopeDescription, collector);
else {
data.javaElement= null;
op= new JavaSearchOperation(workspace, data.pattern, data.searchFor, data.limitTo, scope, scopeDescription, collector);
}
Shell shell= getControl().getShell();
try {
getContainer().getRunnableContext().run(true, true, op);
} catch (InvocationTargetException ex) {
ExceptionHandler.handle(ex, shell, SearchMessages.getString("Search.Error.search.title"), SearchMessages.getString("Search.Error.search.message"));
return false;
} catch (InterruptedException ex) {
return false;
}
return true;
}
private int getLimitTo() {
for (int i= 0; i < fLimitTo.length; i++) {
if (fLimitTo[i].getSelection())
return i;
}
return -1;
} |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | private void setLimitTo(int searchFor) {
fLimitTo[DECLARATIONS].setEnabled(true);
fLimitTo[IMPLEMENTORS].setEnabled(false);
fLimitTo[REFERENCES].setEnabled(true);
fLimitTo[ALL_OCCURRENCES].setEnabled(true);
fLimitTo[READ_REFERENCES].setEnabled(false);
fLimitTo[WRITE_REFERENCES].setEnabled(false);
if (!(searchFor == TYPE || searchFor == INTERFACE) && fLimitTo[IMPLEMENTORS].getSelection()) {
fLimitTo[IMPLEMENTORS].setSelection(false);
fLimitTo[REFERENCES].setSelection(true);
}
if (!(searchFor == FIELD) && (getLimitTo() == READ_REFERENCES || getLimitTo() == WRITE_REFERENCES)) {
fLimitTo[getLimitTo()].setSelection(false);
fLimitTo[REFERENCES].setSelection(true);
}
switch (searchFor) {
case TYPE | INTERFACE:
fLimitTo[IMPLEMENTORS].setEnabled(true);
case FIELD:
fLimitTo[READ_REFERENCES].setEnabled(true);
fLimitTo[WRITE_REFERENCES].setEnabled(true);
break;
default :
break;
}
}
private String[] getPreviousSearchPatterns() {
int patternCount= fgPreviousSearchPatterns.size(); |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | String [] patterns= new String[patternCount];
for (int i= 0; i < patternCount; i++)
patterns[i]= ((SearchPatternData) fgPreviousSearchPatterns.get(patternCount - 1 - i)).pattern;
return patterns;
}
private int getSearchFor() {
for (int i= 0; i < fSearchFor.length; i++) {
if (fSearchFor[i].getSelection())
return i;
}
Assert.isTrue(false, SearchMessages.getString("SearchPage.shouldNeverHappen"));
return -1;
}
private String getPattern() {
return fPattern.getText();
}
/**
* Return search pattern data and update previous searches.
* An existing entry will be updated.
*/
private SearchPatternData getPatternData() {
String pattern= getPattern();
SearchPatternData match= null;
int i= 0;
int size= fgPreviousSearchPatterns.size();
while (match == null && i < size) {
match= (SearchPatternData) fgPreviousSearchPatterns.get(i);
i++; |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | if (!pattern.equals(match.pattern))
match= null;
};
if (match == null) {
match= new SearchPatternData(
getSearchFor(),
getLimitTo(),
getPattern(),
fJavaElement,
getContainer().getSelectedScope(),
getContainer().getSelectedWorkingSet());
fgPreviousSearchPatterns.add(match);
}
else {
match.searchFor= getSearchFor();
match.limitTo= getLimitTo();
match.javaElement= fJavaElement;
match.scope= getContainer().getSelectedScope();
match.workingSet= getContainer().getSelectedWorkingSet();
};
return match;
}
/*
* Implements method from IDialogPage
*/
public void setVisible(boolean visible) {
if (visible && fPattern != null) {
if (fFirstTime) {
fFirstTime= false; |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | fPattern.setItems(getPreviousSearchPatterns());
initSelections();
}
fPattern.setFocus();
getContainer().setPerformActionEnabled(fPattern.getText().length() > 0 && getContainer().hasValidScope());
}
super.setVisible(visible);
}
public boolean isValid() {
return true;
}
/**
* Creates the page's content.
*/
public void createControl(Composite parent) {
GridData gd;
Composite result= new Composite(parent, SWT.NONE);
GridLayout layout= new GridLayout();
layout.numColumns= 2; layout.makeColumnsEqualWidth= true;
layout.horizontalSpacing= 10;
result.setLayout(layout);
RowLayouter layouter= new RowLayouter(layout.numColumns);
gd= new GridData();
gd.horizontalAlignment= gd.FILL;
layouter.setDefaultGridData(gd, 0);
layouter.setDefaultGridData(gd, 1);
layouter.setDefaultSpan(); |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | layouter.perform(createExpression(result));
layouter.perform(createSearchFor(result), createLimitTo(result), -1);
SelectionAdapter javaElementInitializer= new SelectionAdapter() {
public void widgetSelected(SelectionEvent event) {
fJavaElement= null;
setLimitTo(getSearchFor());
}
};
fSearchFor[TYPE].addSelectionListener(javaElementInitializer);
fSearchFor[METHOD].addSelectionListener(javaElementInitializer);
fSearchFor[FIELD].addSelectionListener(javaElementInitializer);
fSearchFor[CONSTRUCTOR].addSelectionListener(javaElementInitializer);
fSearchFor[PACKAGE].addSelectionListener(javaElementInitializer);
setControl(result);
WorkbenchHelp.setHelp(result, new Object[] { IJavaHelpContextIds.JAVA_SEARCH_PAGE });
}
private Control createExpression(Composite parent) {
Group result= new Group(parent, SWT.NONE);
result.setText(SearchMessages.getString("SearchPage.expression.label"));
GridLayout layout= new GridLayout();
layout.numColumns= 1;
result.setLayout(layout);
fPattern= new Combo(result, SWT.SINGLE | SWT.BORDER);
fPattern.addSelectionListener(new SelectionAdapter() {
public void widgetSelected(SelectionEvent e) { |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | handlePatternSelected();
}
});
fPattern.addModifyListener(new ModifyListener() {
public void modifyText(ModifyEvent e) {
getContainer().setPerformActionEnabled(getPattern().length() > 0 && getContainer().hasValidScope());
}
});
GridData gd= new GridData(GridData.FILL_HORIZONTAL);
gd.widthHint= convertWidthInCharsToPixels(30);
fPattern.setLayoutData(gd);
Label label= new Label(result, SWT.LEFT);
label.setText(SearchMessages.getString("SearchPage.expression.pattern"));
return result;
}
private void handlePatternSelected() {
if (fPattern.getSelectionIndex() < 0)
return;
int index= fgPreviousSearchPatterns.size() - 1 - fPattern.getSelectionIndex();
SearchPatternData values= (SearchPatternData) fgPreviousSearchPatterns.get(index);
for (int i= 0; i < fSearchFor.length; i++)
fSearchFor[i].setSelection(false);
for (int i= 0; i < fLimitTo.length; i++)
fLimitTo[i].setSelection(false);
fSearchFor[values.searchFor].setSelection(true);
setLimitTo(values.searchFor);
fLimitTo[values.limitTo].setSelection(true); |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | fInitialPattern= values.pattern;
fPattern.setText(fInitialPattern);
fJavaElement= values.javaElement;
if (values.workingSet != null)
getContainer().setSelectedWorkingSet(values.workingSet);
else
getContainer().setSelectedScope(values.scope);
}
private Control createSearchFor(Composite parent) {
Group result= new Group(parent, SWT.NONE);
result.setText(SearchMessages.getString("SearchPage.searchFor.label"));
GridLayout layout= new GridLayout();
layout.numColumns= 3;
result.setLayout(layout);
result.setLayoutData(new GridData(GridData.FILL_VERTICAL));
fSearchFor= new Button[fSearchForText.length];
for (int i= 0; i < fSearchForText.length; i++) {
Button button= new Button(result, SWT.RADIO);
button.setText(fSearchForText[i]);
fSearchFor[i]= button;
}
return result;
}
private Control createLimitTo(Composite parent) {
Group result= new Group(parent, SWT.NONE);
result.setText(SearchMessages.getString("SearchPage.limitTo.label"));
GridLayout layout= new GridLayout();
layout.numColumns= 2; |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | result.setLayout(layout);
fLimitTo= new Button[fLimitToText.length];
for (int i= 0; i < fLimitToText.length; i++) {
Button button= new Button(result, SWT.RADIO);
button.setText(fLimitToText[i]);
fLimitTo[i]= button;
}
return result;
}
private void initSelections() {
fJavaElement= null;
ISelection selection= getSelection();
SearchPatternData values= null;
values= tryTypedTextSelection(selection);
if (values == null)
values= trySelection(selection);
if (values == null)
values= trySimpleTextSelection(selection);
if (values == null)
values= getDefaultInitValues();
fSearchFor[values.searchFor].setSelection(true);
setLimitTo(values.searchFor);
fLimitTo[values.limitTo].setSelection(true);
fInitialPattern= values.pattern;
fPattern.setText(fInitialPattern);
fJavaElement= values.javaElement;
}
private SearchPatternData tryTypedTextSelection(ISelection selection) { |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | if (selection instanceof ITextSelection) {
IEditorPart e= getEditorPart();
if (e != null) {
ITextSelection ts= (ITextSelection)selection;
ICodeAssist assist= getCodeAssist(e);
if (assist != null) {
IJavaElement[] elements= null;
try {
elements= assist.codeSelect(ts.getOffset(), ts.getLength());
} catch (JavaModelException ex) {
ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.createJavaElement.title"), SearchMessages.getString("Search.Error.createJavaElement.message"));
}
if (elements != null && elements.length > 0) {
if (elements.length == 1)
fJavaElement= elements[0];
else
fJavaElement= chooseFromList(elements);
if (fJavaElement != null)
return determineInitValuesFrom(fJavaElement);
}
}
}
}
return null;
}
private ICodeAssist getCodeAssist(IEditorPart editorPart) {
IEditorInput input= editorPart.getEditorInput();
if (input instanceof IClassFileEditorInput)
return ((IClassFileEditorInput)input).getClassFile(); |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager();
return manager.getWorkingCopy(input);
}
private SearchPatternData trySelection(ISelection selection) {
SearchPatternData result= null;
if (selection == null)
return result;
Object o= null;
if (selection instanceof IStructuredSelection)
o= ((IStructuredSelection)selection).getFirstElement();
if (o instanceof IJavaElement) {
fJavaElement= (IJavaElement)o;
result= determineInitValuesFrom(fJavaElement);
} else if (o instanceof ISearchResultViewEntry) {
fJavaElement= getJavaElement(((ISearchResultViewEntry)o).getSelectedMarker());
result= determineInitValuesFrom(fJavaElement);
} else if (o instanceof IAdaptable) {
IJavaElement element= (IJavaElement)((IAdaptable)o).getAdapter(IJavaElement.class);
if (element != null) {
result= determineInitValuesFrom(element);
} else {
IWorkbenchAdapter adapter= (IWorkbenchAdapter)((IAdaptable)o).getAdapter(IWorkbenchAdapter.class);
result= new SearchPatternData(TYPE, REFERENCES, adapter.getLabel(o), null);
}
}
return result;
}
private IJavaElement getJavaElement(IMarker marker) {
try {
return JavaCore.create((String)marker.getAttribute(IJavaSearchUIConstants.ATT_JE_HANDLE_ID)); |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | } catch (CoreException ex) {
ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.createJavaElement.title"), SearchMessages.getString("Search.Error.createJavaElement.message"));
return null;
}
}
private SearchPatternData determineInitValuesFrom(IJavaElement element) {
if (element == null)
return null;
int searchFor= UNKNOWN;
int limitTo= UNKNOWN;
String pattern= null;
switch (element.getElementType()) {
case IJavaElement.PACKAGE_FRAGMENT:
searchFor= PACKAGE;
limitTo= REFERENCES;
pattern= element.getElementName();
break;
case IJavaElement.PACKAGE_FRAGMENT_ROOT:
searchFor= PACKAGE;
limitTo= REFERENCES;
pattern= element.getElementName();
break;
case IJavaElement.PACKAGE_DECLARATION:
searchFor= PACKAGE;
limitTo= REFERENCES;
pattern= element.getElementName();
break;
case IJavaElement.IMPORT_DECLARATION:
pattern= element.getElementName(); |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | IImportDeclaration declaration= (IImportDeclaration)element;
if (declaration.isOnDemand()) {
searchFor= PACKAGE;
int index= pattern.lastIndexOf('.');
pattern= pattern.substring(0, index);
} else {
searchFor= TYPE;
}
limitTo= DECLARATIONS;
break;
case IJavaElement.TYPE:
searchFor= TYPE;
limitTo= REFERENCES;
pattern= JavaModelUtil.getFullyQualifiedName((IType)element);
break;
case IJavaElement.COMPILATION_UNIT:
ICompilationUnit cu= (ICompilationUnit)element;
String mainTypeName= element.getElementName().substring(0, element.getElementName().indexOf("."));
IType mainType= cu.getType(mainTypeName);
mainTypeName= JavaModelUtil.getTypeQualifiedName(mainType);
try {
mainType= JavaModelUtil.findTypeInCompilationUnit(cu, mainTypeName);
if (mainType == null) {
IType[] types= cu.getTypes();
if (types.length > 0)
mainType= types[0];
else
break;
} |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | } catch (JavaModelException ex) {
ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.javaElementAccess.title"), SearchMessages.getString("Search.Error.javaElementAccess.message"));
break;
}
searchFor= TYPE;
element= mainType;
limitTo= REFERENCES;
pattern= JavaModelUtil.getFullyQualifiedName((IType)mainType);
break;
case IJavaElement.CLASS_FILE:
IClassFile cf= (IClassFile)element;
try {
mainType= cf.getType();
} catch (JavaModelException ex) {
ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.javaElementAccess.title"), SearchMessages.getString("Search.Error.javaElementAccess.message"));
break;
}
if (mainType == null)
break;
element= mainType;
searchFor= TYPE;
limitTo= REFERENCES;
pattern= JavaModelUtil.getFullyQualifiedName(mainType);
break;
case IJavaElement.FIELD:
searchFor= FIELD;
limitTo= REFERENCES;
IType type= ((IField)element).getDeclaringType();
StringBuffer buffer= new StringBuffer();
buffer.append(JavaModelUtil.getFullyQualifiedName(type)); |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | buffer.append('.');
buffer.append(element.getElementName());
pattern= buffer.toString();
break;
case IJavaElement.METHOD:
searchFor= METHOD;
try {
IMethod method= (IMethod)element;
if (method.isConstructor())
searchFor= CONSTRUCTOR;
} catch (JavaModelException ex) {
ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.javaElementAccess.title"), SearchMessages.getString("Search.Error.javaElementAccess.message"));
break;
}
limitTo= REFERENCES;
pattern= PrettySignature.getMethodSignature((IMethod)element);
break;
}
if (searchFor != UNKNOWN && limitTo != UNKNOWN && pattern != null)
return new SearchPatternData(searchFor, limitTo, pattern, element);
return null;
}
private SearchPatternData trySimpleTextSelection(ISelection selection) {
SearchPatternData result= null;
if (selection instanceof ITextSelection) {
BufferedReader reader= new BufferedReader(new StringReader(((ITextSelection)selection).getText()));
String text;
try { |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | text= reader.readLine();
if (text == null)
text= "";
} catch (IOException ex) {
text= "";
}
result= new SearchPatternData(TYPE, REFERENCES, text, null);
}
return result;
}
private SearchPatternData getDefaultInitValues() {
return new SearchPatternData(TYPE, REFERENCES, "", null);
}
private IJavaElement chooseFromList(IJavaElement[] openChoices) {
ILabelProvider labelProvider= new JavaElementLabelProvider(
JavaElementLabelProvider.SHOW_DEFAULT
| JavaElementLabelProvider.SHOW_CONTAINER_QUALIFICATION);
ElementListSelectionDialog dialog= new ElementListSelectionDialog(getShell(), labelProvider);
dialog.setTitle(SearchMessages.getString("SearchElementSelectionDialog.title"));
dialog.setMessage(SearchMessages.getString("SearchElementSelectionDialog.message"));
dialog.setElements(openChoices);
if (dialog.open() == dialog.OK)
return (IJavaElement)dialog.getFirstResult();
return null;
}
/*
* Implements method from ISearchPage
*/
public void setContainer(ISearchPageContainer container) { |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java | fContainer= container;
}
/**
* Returns the search page's container.
*/
private ISearchPageContainer getContainer() {
return fContainer;
}
/**
* Returns the current active selection.
*/
private ISelection getSelection() {
return fContainer.getSelection();
}
/**
* Returns the current active editor part.
*/
private IEditorPart getEditorPart() {
IWorkbenchWindow window= JavaPlugin.getActiveWorkbenchWindow();
if (window != null) {
IWorkbenchPage page= window.getActivePage();
if (page != null)
return page.getActiveEditor();
}
return null;
}
} |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchSubGroup.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui.search;
import org.eclipse.jface.action.GroupMarker;
import org.eclipse.jface.action.IMenuManager;
import org.eclipse.jface.action.MenuManager;
import org.eclipse.jface.util.Assert;
import org.eclipse.jdt.internal.ui.JavaPlugin;
import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup;
import org.eclipse.jdt.internal.ui.actions.GroupContext;
import org.eclipse.jdt.ui.IContextMenuConstants;
/**
* Contribute Java search specific menu elements.
*/
public abstract class JavaSearchSubGroup extends ContextMenuGroup {
public static final String GROUP_ID= IContextMenuConstants.GROUP_SEARCH; |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchSubGroup.java | private final ElementSearchAction[] fActions;
public JavaSearchSubGroup() {
fActions= getActions();
}
abstract protected ElementSearchAction[] getActions();
abstract protected String getName();
public void fill(IMenuManager manager, GroupContext context) {
MenuManager javaSearchMM= new MenuManager(getName(), GROUP_ID);
for (int i= 0; i < fActions.length; i++) {
ElementSearchAction action= fActions[i];
if (action.canOperateOn(context.getSelection()))
javaSearchMM.add(action);
}
if (!javaSearchMM.isEmpty())
manager.add(javaSearchMM);
}
public MenuManager getMenuManagerForGroup(boolean isTextSelectionEmpty) {
MenuManager javaSearchMM= new MenuManager(getName(), GROUP_ID);
if (!isTextSelectionEmpty) {
for (int i= 0; i < fActions.length; i++)
javaSearchMM.add(fActions[i]);
}
return javaSearchMM;
}
} |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/ReadReferencesSearchGroup.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui.search;
/**
* Contribute Java search specific menu elements.
*/
public class ReadReferencesSearchGroup extends JavaSearchSubGroup {
public static final String GROUP_NAME= SearchMessages.getString("group.readReferences");
protected ElementSearchAction[] getActions() {
return new ElementSearchAction[] {
new FindReadReferencesAction(),
new FindReadReferencesInHierarchyAction(),
new FindReadReferencesInWorkingSetAction(),
};
}
protected String getName() {
return GROUP_NAME;
}
} |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/ReferencesSearchGroup.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui.search;
/**
* Contribute Java search specific menu elements.
*/
public class ReferencesSearchGroup extends JavaSearchSubGroup {
public static final String GROUP_NAME= SearchMessages.getString("group.references");
protected ElementSearchAction[] getActions() {
return new ElementSearchAction[] {
new FindReferencesAction(),
new FindReferencesInHierarchyAction(),
new FindReferencesInWorkingSetAction(),
};
}
protected String getName() {
return GROUP_NAME;
}
} |
3,672 | Bug 3672 DCR: Add working set support | Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider | verified fixed | 7049e8f | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-07T16:23:46Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/WriteReferencesSearchGroup.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui.search;
/**
* Contribute Java search specific menu elements.
*/
public class WriteReferencesSearchGroup extends JavaSearchSubGroup {
public static final String GROUP_NAME= SearchMessages.getString("group.writeReferences");
protected ElementSearchAction[] getActions() {
return new ElementSearchAction[] {
new FindWriteReferencesAction(),
new FindWriteReferencesInHierarchyAction(),
new FindWriteReferencesInWorkingSetAction(),
};
}
protected String getName() {
return GROUP_NAME;
}
} |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchOperation.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui.search;
import org.eclipse.core.resources.IWorkspace;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.jface.resource.ImageDescriptor;
import org.eclipse.ui.actions.WorkspaceModifyOperation;
import org.eclipse.jdt.core.IJavaElement;
import org.eclipse.jdt.core.IMethod;
import org.eclipse.jdt.core.search.IJavaSearchConstants;
import org.eclipse.jdt.core.search.IJavaSearchScope;
import org.eclipse.jdt.core.search.SearchEngine;
import org.eclipse.jdt.internal.ui.JavaPluginImages;
public class JavaSearchOperation extends WorkspaceModifyOperation {
private IWorkspace fWorkspace;
private IJavaElement fElementPattern;
private int fLimitTo;
private String fStringPattern; |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchOperation.java | private int fSearchFor;
private IJavaSearchScope fScope;
private String fScopeDescription;
private JavaSearchResultCollector fCollector;
protected JavaSearchOperation(
IWorkspace workspace,
int limitTo,
IJavaSearchScope scope,
String scopeDescription,
JavaSearchResultCollector collector) {
fWorkspace= workspace;
fLimitTo= limitTo;
fScope= scope;
fScopeDescription= scopeDescription;
fCollector= collector;
fCollector.setOperation(this);
}
public JavaSearchOperation(
IWorkspace workspace,
IJavaElement pattern,
int limitTo,
IJavaSearchScope scope,
String scopeDescription,
JavaSearchResultCollector collector) {
this(workspace, limitTo, scope, scopeDescription, collector);
fElementPattern= pattern;
} |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchOperation.java | public JavaSearchOperation(
IWorkspace workspace,
String pattern,
int searchFor,
int limitTo,
IJavaSearchScope scope,
String scopeDescription,
JavaSearchResultCollector collector) {
this(workspace, limitTo, scope, scopeDescription, collector);
fStringPattern= pattern;
fSearchFor= searchFor;
}
protected void execute(IProgressMonitor monitor) throws CoreException {
fCollector.setProgressMonitor(monitor);
SearchEngine engine= new SearchEngine();
if (fElementPattern != null)
engine.search(fWorkspace, fElementPattern, fLimitTo, fScope, fCollector);
else
engine.search(fWorkspace, fStringPattern, fSearchFor, fLimitTo, fScope, fCollector);
}
String getDescription() {
String desc= null;
if (fElementPattern != null) {
if (fLimitTo == IJavaSearchConstants.REFERENCES
&& fElementPattern.getElementType() == IJavaElement.METHOD)
desc= PrettySignature.getUnqualifiedMethodSignature((IMethod)fElementPattern);
else
desc= fElementPattern.getElementName();
if ("".equals(desc) && fElementPattern.getElementType() == IJavaElement.PACKAGE_FRAGMENT) |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchOperation.java | desc= SearchMessages.getString("JavaSearchOperation.default_package");
}
else
desc= fStringPattern;
String[] args= new String[] {desc, "{0}", fScopeDescription};
switch (fLimitTo) {
case IJavaSearchConstants.IMPLEMENTORS:
return SearchMessages.getFormattedString("JavaSearchOperation.implementorsPostfix", args);
case IJavaSearchConstants.DECLARATIONS:
return SearchMessages.getFormattedString("JavaSearchOperation.declarationsPostfix", args);
case IJavaSearchConstants.REFERENCES:
return SearchMessages.getFormattedString("JavaSearchOperation.referencesPostfix", args);
case IJavaSearchConstants.ALL_OCCURRENCES:
return SearchMessages.getFormattedString("JavaSearchOperation.occurrencesPostfix", args);
case IJavaSearchConstants.READ_REFERENCES:
return SearchMessages.getFormattedString("JavaSearchOperation.readReferencesPostfix", args);
case IJavaSearchConstants.WRITE_REFERENCES:
return SearchMessages.getFormattedString("JavaSearchOperation.writeReferencesPostfix", args);
default:
return SearchMessages.getFormattedString("JavaSearchOperation.occurrencesPostfix", args);
}
}
ImageDescriptor getImageDescriptor() {
if (fLimitTo == IJavaSearchConstants.IMPLEMENTORS || fLimitTo == IJavaSearchConstants.DECLARATIONS)
return JavaPluginImages.DESC_OBJS_SEARCH_DECL;
else
return JavaPluginImages.DESC_OBJS_SEARCH_REF;
}
} |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui.search;
import java.text.MessageFormat;
import java.util.HashMap;
import org.eclipse.core.resources.IMarker;
import org.eclipse.core.resources.IResource;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.jface.action.IMenuManager;
import org.eclipse.jface.viewers.IInputSelectionProvider;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.ui.IWorkbenchPage; |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java | import org.eclipse.ui.IWorkbenchWindow;
import org.eclipse.search.ui.IContextMenuContributor;
import org.eclipse.search.ui.ISearchResultView;
import org.eclipse.search.ui.ISearchResultViewEntry;
import org.eclipse.search.ui.SearchUI;
import org.eclipse.jdt.core.IJavaElement;
import org.eclipse.jdt.core.IMember;
import org.eclipse.jdt.core.JavaCore;
import org.eclipse.jdt.core.search.IJavaSearchResultCollector;
import org.eclipse.jdt.ui.JavaUI;
import org.eclipse.jdt.internal.ui.JavaPlugin;
import org.eclipse.jdt.internal.ui.actions.GroupContext;
import org.eclipse.jdt.internal.ui.util.ExceptionHandler;
import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil;
import org.eclipse.jdt.internal.ui.util.SelectionUtil;
public class JavaSearchResultCollector implements IJavaSearchResultCollector {
private static final String MATCH= SearchMessages.getString("SearchResultCollector.match");
private static final String MATCHES= SearchMessages.getString("SearchResultCollector.matches");
private static final String DONE= SearchMessages.getString("SearchResultCollector.done");
private static final String SEARCHING= SearchMessages.getString("SearchResultCollector.searching");
private static final Integer POTENTIAL_MATCH_VALUE= new Integer(POTENTIAL_MATCH);
private IProgressMonitor fMonitor;
private IContextMenuContributor fContextMenu;
private ISearchResultView fView;
private JavaSearchOperation fOperation;
private int fMatchCount= 0;
private Integer[] fMessageFormatArgs= new Integer[1];
private class ContextMenuContributor implements IContextMenuContributor { |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java | public void fill(IMenuManager menu, IInputSelectionProvider inputProvider) {
JavaPlugin.createStandardGroups(menu);
new JavaSearchGroup().fill(menu, new GroupContext(inputProvider));
OpenTypeHierarchyUtil.addToMenu(getWorbenchWindow(), menu, convertSelection(inputProvider.getSelection()));
}
private Object convertSelection(ISelection selection) {
Object element= SelectionUtil.getSingleElement(selection);
if (!(element instanceof ISearchResultViewEntry))
return null;
IMarker marker= ((ISearchResultViewEntry)element).getSelectedMarker();
try {
return JavaCore.create((String) ((IMarker) marker).getAttribute(IJavaSearchUIConstants.ATT_JE_HANDLE_ID));
} catch (CoreException ex) {
ExceptionHandler.log(ex, SearchMessages.getString("Search.Error.createJavaElement.message"));
return null;
}
}
}
public JavaSearchResultCollector() {
fContextMenu= new ContextMenuContributor();
}
/**
* @see IJavaSearchResultCollector#aboutToStart().
*/
public void aboutToStart() {
fView= SearchUI.getSearchResultView();
fMatchCount= 0;
if (fView != null) { |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java | fView.searchStarted(
JavaSearchPage.EXTENSION_POINT_ID,
fOperation.getDescription(),
fOperation.getImageDescriptor(),
fContextMenu,
JavaSearchResultLabelProvider.INSTANCE,
new GotoMarkerAction(),
new GroupByKeyComputer(),
fOperation);
}
if (!getProgressMonitor().isCanceled())
getProgressMonitor().subTask(SEARCHING);
}
/**
* @see IJavaSearchResultCollector#accept
*/
public void accept(IResource resource, int start, int end, IJavaElement enclosingElement, int accuracy) throws CoreException {
IMarker marker= resource.createMarker(SearchUI.SEARCH_MARKER);
HashMap attributes;
Object groupKey= enclosingElement;
if (accuracy == POTENTIAL_MATCH) {
attributes= new HashMap(6);
attributes.put(IJavaSearchUIConstants.ATT_ACCURACY, POTENTIAL_MATCH_VALUE);
if (groupKey == null)
groupKey= "?:null";
else
groupKey= "?:" + enclosingElement.getHandleIdentifier();
} else
attributes= new HashMap(5); |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java | JavaCore.addJavaElementMarkerAttributes(attributes, enclosingElement);
attributes.put(IJavaSearchUIConstants.ATT_JE_HANDLE_ID, enclosingElement.getHandleIdentifier());
attributes.put(IMarker.CHAR_START, new Integer(Math.max(start, 0)));
attributes.put(IMarker.CHAR_END, new Integer(Math.max(end, 0)));
if (enclosingElement instanceof IMember && ((IMember)enclosingElement).isBinary())
attributes.put(IWorkbenchPage.EDITOR_ID_ATTR, JavaUI.ID_CF_EDITOR);
else
attributes.put(IWorkbenchPage.EDITOR_ID_ATTR, JavaUI.ID_CU_EDITOR);
marker.setAttributes(attributes);
fView.addMatch(enclosingElement.getElementName(), groupKey, resource, marker);
fMatchCount++;
if (!getProgressMonitor().isCanceled())
getProgressMonitor().subTask(getFormattedMatchesString(fMatchCount));
}
/**
* @see IJavaSearchResultCollector#done().
*/
public void done() {
if (!getProgressMonitor().isCanceled()) {
String matchesString= getFormattedMatchesString(fMatchCount);
getProgressMonitor().setTaskName(MessageFormat.format(DONE, new String[]{matchesString}));
}
if (fView != null)
fView.searchFinished();
fView= null;
fMonitor= null;
} |
5,356 | Bug 5356 Search Result descriptions don't use singular | Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match | resolved fixed | acb4754 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:09:19Z" | "2001-10-30T16:40:00Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java | /**
* @see IJavaSearchResultCollector#getProgressMonitor().
*/
public IProgressMonitor getProgressMonitor() {
return fMonitor;
};
void setProgressMonitor(IProgressMonitor pm) {
fMonitor= pm;
}
void setOperation(JavaSearchOperation operation) {
fOperation= operation;
}
private String getFormattedMatchesString(int count) {
if (fMatchCount == 1)
return MATCH;
fMessageFormatArgs[0]= new Integer(count);
return MessageFormat.format(MATCHES, fMessageFormatArgs);
}
private IWorkbenchWindow getWorbenchWindow() {
IWorkbenchWindow wbWindow= null;
if (fView != null && fView.getSite() != null)
wbWindow= fView.getSite().getWorkbenchWindow();
if (wbWindow == null)
wbWindow= JavaPlugin.getActiveWorkbenchWindow();
return wbWindow;
}
} |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | package org.eclipse.jdt.internal.ui.preferences;
/*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
import java.util.ArrayList;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.Set;
import org.eclipse.core.resources.IWorkspaceRoot;
import org.eclipse.jdt.core.IJavaElement;
import org.eclipse.jdt.core.IJavaModel;
import org.eclipse.jdt.core.IJavaProject;
import org.eclipse.jdt.core.IPackageFragment;
import org.eclipse.jdt.core.IType;
import org.eclipse.jdt.core.JavaCore;
import org.eclipse.jdt.core.JavaModelException;
import org.eclipse.jdt.core.search.SearchEngine;
import org.eclipse.jdt.debug.core.JDIDebugModel;
import org.eclipse.jdt.internal.ui.IJavaHelpContextIds;
import org.eclipse.jdt.internal.ui.IPreferencesConstants;
import org.eclipse.jdt.internal.ui.JavaPlugin;
import org.eclipse.jdt.internal.ui.JavaPluginImages;
import org.eclipse.jdt.internal.ui.dialogs.ElementListSelectionDialog;
import org.eclipse.jdt.internal.ui.util.ExceptionHandler;
import org.eclipse.jdt.ui.IJavaElementSearchConstants;
import org.eclipse.jdt.ui.JavaElementLabelProvider; |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | import org.eclipse.jdt.ui.JavaUI;
import org.eclipse.jface.dialogs.IDialogConstants;
import org.eclipse.jface.dialogs.ProgressMonitorDialog;
import org.eclipse.jface.preference.IPreferenceStore;
import org.eclipse.jface.preference.PreferencePage;
import org.eclipse.jface.viewers.CheckStateChangedEvent;
import org.eclipse.jface.viewers.CheckboxTableViewer;
import org.eclipse.jface.viewers.ICellEditorValidator;
import org.eclipse.jface.viewers.ICellModifier;
import org.eclipse.jface.viewers.ICheckStateListener;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.jface.viewers.ISelectionChangedListener;
import org.eclipse.jface.viewers.IStructuredContentProvider;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.jface.viewers.ITableLabelProvider;
import org.eclipse.jface.viewers.LabelProvider;
import org.eclipse.jface.viewers.SelectionChangedEvent;
import org.eclipse.jface.viewers.Viewer;
import org.eclipse.swt.SWT;
import org.eclipse.swt.custom.TableEditor;
import org.eclipse.swt.events.FocusAdapter;
import org.eclipse.swt.events.FocusEvent;
import org.eclipse.swt.events.KeyAdapter;
import org.eclipse.swt.events.KeyEvent;
import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.events.SelectionListener;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Button; |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Event;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Listener;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.swt.widgets.Table;
import org.eclipse.swt.widgets.TableItem;
import org.eclipse.swt.widgets.Text;
import org.eclipse.ui.IWorkbench;
import org.eclipse.ui.IWorkbenchPreferencePage;
import org.eclipse.ui.dialogs.SelectionDialog;
import org.eclipse.ui.help.DialogPageContextComputer;
import org.eclipse.ui.help.WorkbenchHelp;
import org.eclipse.ui.model.WorkbenchViewerSorter;
/**
* Preference page for debug preferences that apply specifically to
* Java Debugging.
*/
public class JavaDebugPreferencePage extends PreferencePage implements IWorkbenchPreferencePage, Listener {
private static final String SHOW_HEX= IPreferencesConstants.SHOW_HEX_VALUES;
private static final String SHOW_CHARS= IPreferencesConstants.SHOW_CHAR_VALUES;
private static final String SHOW_UNSIGNED= IPreferencesConstants.SHOW_UNSIGNED_VALUES;
private static final String DEFAULT_NEW_FILTER_TEXT = "";
private static final Image IMG_CUNIT = JavaPluginImages.get(JavaPluginImages.IMG_OBJS_CUNIT);
private static final Image IMG_PKG = JavaPluginImages.get(JavaPluginImages.IMG_OBJS_PACKAGE); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | private Button fHexButton;
private Button fCharButton;
private Button fUnsignedButton;
private CheckboxTableViewer fFilterViewer;
private Table fFilterTable;
private Button fUseFiltersCheckbox;
private Button fAddPackageButton;
private Button fAddTypeButton;
private Button fRemoveFilterButton;
private Button fAddFilterButton;
private Button fFilterSyntheticButton;
private Button fFilterStaticButton;
private Button fFilterConstructorButton;
private Text fEditorText;
private TableEditor fTableEditor;
private TableItem fNewTableItem;
private StepFilter fNewStepFilter;
private static final String[] TABLE_COLUMN_PROPERTIES = {"filter_name"};
private static final int FILTERNAME_PROP= 0;
private StepFilterContentProvider fStepFilterContentProvider;
private ICellEditorValidator fCellValidator;
/**
* Model object that represents a single entry in the table
*/
protected class StepFilter { |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | private String fName;
private boolean fChecked;
public StepFilter(String name, boolean checked) {
setName(name);
setChecked(checked);
}
public String getName() {
return fName;
}
public void setName(String name) {
fName = name;
}
public boolean isChecked() {
return fChecked;
}
public void setChecked(boolean checked) {
fChecked = checked;
}
}
/**
* Content provider for the table. Content consists of instances of StepFilter.
*/
protected class StepFilterContentProvider implements IStructuredContentProvider { |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | private CheckboxTableViewer fViewer;
private List fFilters;
public StepFilterContentProvider(CheckboxTableViewer viewer) {
fViewer = viewer;
List active = JDIDebugModel.getActiveStepFilters();
List inactive = JDIDebugModel.getInactiveStepFilters();
populateFilters(active, inactive);
}
public void setDefaults() {
fViewer.remove(fFilters.toArray());
List active = JDIDebugModel.getDefaultActiveStepFilters();
List inactive = JDIDebugModel.getDefaultInactiveStepFilters();
populateFilters(active, inactive);
fFilterSyntheticButton.setSelection(JDIDebugModel.getDefaultFilterSynthetic());
fFilterStaticButton.setSelection(JDIDebugModel.getDefaultFilterStatic()); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | fFilterConstructorButton.setSelection(JDIDebugModel.getDefaultFilterConstructor());
boolean useStepFilters = JDIDebugModel.getDefaultUseStepFilters();
fUseFiltersCheckbox.setSelection(useStepFilters);
toggleStepFilterWidgetsEnabled(useStepFilters);
}
protected void populateFilters(List activeList, List inactiveList) {
fFilters = new ArrayList(activeList.size() + inactiveList.size());
populateList(activeList, true);
populateList(inactiveList, false);
}
protected void populateList(List list, boolean checked) {
Iterator iterator = list.iterator();
while (iterator.hasNext()) {
String name = (String)iterator.next();
addFilter(name, checked);
}
}
public StepFilter addFilter(String name, boolean checked) {
StepFilter filter = new StepFilter(name, checked);
if (!fFilters.contains(filter)) {
fFilters.add(filter);
fViewer.add(filter);
fViewer.setChecked(filter, checked);
}
return filter;
} |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | public void saveFilters() {
JDIDebugModel.setUseStepFilters(fUseFiltersCheckbox.getSelection());
JDIDebugModel.setFilterSynthetic(fFilterSyntheticButton.getSelection());
JDIDebugModel.setFilterStatic(fFilterStaticButton.getSelection());
JDIDebugModel.setFilterConstructor(fFilterConstructorButton.getSelection());
List active = new ArrayList(fFilters.size());
List inactive = new ArrayList(fFilters.size());
Iterator iterator = fFilters.iterator();
while (iterator.hasNext()) {
StepFilter filter = (StepFilter)iterator.next();
String name = filter.getName();
if (filter.isChecked()) {
active.add(name);
} else {
inactive.add(name);
}
}
JDIDebugModel.setActiveStepFilters(active);
JDIDebugModel.setInactiveStepFilters(inactive);
}
public void removeFilters(Object[] filters) {
for (int i = 0; i < filters.length; i++) {
StepFilter filter = (StepFilter)filters[i];
fFilters.remove(filter);
}
fViewer.remove(filters);
} |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | public void toggleFilter(StepFilter filter) {
boolean newState = !filter.isChecked();
filter.setChecked(newState);
fViewer.setChecked(filter, newState);
}
/*
* @see IStructuredContentProvider#getElements(Object)
*/
public Object[] getElements(Object inputElement) {
return fFilters.toArray();
}
/*
* @see IContentProvider#inputChanged(Viewer, Object, Object)
*/
public void inputChanged(Viewer viewer, Object oldInput, Object newInput) {
}
/*
* @see IContentProvider#dispose()
*/
public void dispose() {
}
}
/**
* Support for editing entries in filter table.
*/
protected class CellModifier implements ICellModifier { |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | public CellModifier() {
}
/*
* @see ICellModifier#canModify(Object, String)
*/
public boolean canModify(Object element, String property) {
return isNameProperty(property);
}
/*
* @see ICellModifier#getValue(Object, String)
*/
public Object getValue(Object element, String property) {
if (isNameProperty(property)) {
StepFilter filter = (StepFilter)element;
return filter.getName(); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | }
return null;
}
/*
* @see ICellModifier#modify(Object, String, Object)
*/
public void modify(Object element, String property, Object value) {
if (value != null) {
if (isNameProperty(property) && element instanceof TableItem) {
String stringValue = (String) value;
TableItem tableItem = (TableItem)element;
StepFilter filter = (StepFilter)tableItem.getData();
filter.setName(stringValue);
tableItem.setText(stringValue);
}
}
}
private boolean isNameProperty(String property) {
return property.equals(TABLE_COLUMN_PROPERTIES[FILTERNAME_PROP]);
}
};
/**
* Label provider for StepFilter model objects
*/
protected class StepFilterLabelProvider extends LabelProvider implements ITableLabelProvider {
/*
* @see ITableLabelProvider#getColumnText(Object, int) |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | */
public String getColumnText(Object object, int column) {
if (column == 0) {
return ((StepFilter)object).getName();
}
return "";
}
/*
* @see ILabelProvider#getText(Object)
*/
public String getText(Object element) {
return ((StepFilter)element).getName();
}
/*
* @see ITableLabelProvider#getColumnImage(Object, int)
*/
public Image getColumnImage(Object object, int column) {
String name = ((StepFilter)object).getName();
if (name.endsWith(".*")) {
return IMG_PKG;
} else {
return IMG_CUNIT;
}
}
}
public JavaDebugPreferencePage() {
super();
setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | }
/**
* Set the default preferences for this page.
*/
public static void initDefaults(IPreferenceStore store) {
store.setDefault(SHOW_HEX, false);
store.setDefault(SHOW_CHARS, false);
store.setDefault(SHOW_UNSIGNED, false);
}
/**
* @see PreferencePage#createContents(Composite)
*/
protected Control createContents(Composite parent) {
WorkbenchHelp.setHelp(getControl(), new DialogPageContextComputer(this, IJavaHelpContextIds.JAVA_BASE_PREFERENCE_PAGE));
Composite composite = new Composite(parent, SWT.NULL);
GridLayout layout = new GridLayout();
layout.numColumns = 1;
composite.setLayout(layout);
GridData data = new GridData();
data.verticalAlignment = GridData.FILL;
data.horizontalAlignment = GridData.FILL;
composite.setLayoutData(data);
createPrimitiveDisplayPreferences(composite);
createSpace(composite); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | createStepFilterPreferences(composite);
setValues();
return composite;
}
/**
* Create the primitive display preferences composite widget
*/
private void createPrimitiveDisplayPreferences(Composite parent) {
Composite comp= createLabelledComposite(parent, 1, "Primitive type display options");
fHexButton= createCheckButton(comp, "Display &hexadecimal values (byte, short, char, int, long)");
fCharButton= createCheckButton(comp, "Display ASCII &character values (byte, short, int, long)");
fUnsignedButton= createCheckButton(comp, "Display &unsigned values (byte)");
}
/**
* Create a group to contain the step filter related widgetry
*/
private void createStepFilterPreferences(Composite parent) {
Composite comp = createLabelledComposite(parent, 1, "Step filters");
Composite container = new Composite(comp, SWT.NONE);
GridLayout layout = new GridLayout();
layout.numColumns = 2;
layout.marginHeight = 0;
layout.marginWidth = 0;
container.setLayout(layout); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | fUseFiltersCheckbox = new Button(container, SWT.CHECK);
fUseFiltersCheckbox.setText("Use &step filters");
fUseFiltersCheckbox.setToolTipText("Toggle whether step filters are used at all");
GridData gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING);
gd.horizontalSpan = 2;
fUseFiltersCheckbox.setLayoutData(gd);
fUseFiltersCheckbox.addSelectionListener(new SelectionListener() {
public void widgetSelected(SelectionEvent se) {
toggleStepFilterWidgetsEnabled(fUseFiltersCheckbox.getSelection());
}
public void widgetDefaultSelected(SelectionEvent se) {
}
});
fFilterViewer = new CheckboxTableViewer(container, SWT.BORDER | SWT.MULTI | SWT.FULL_SELECTION);
fFilterTable = fFilterViewer.getTable();
fTableEditor = new TableEditor(fFilterTable);
fFilterViewer.setLabelProvider(new StepFilterLabelProvider());
fFilterViewer.setSorter(new WorkbenchViewerSorter());
fStepFilterContentProvider = new StepFilterContentProvider(fFilterViewer);
fFilterViewer.setContentProvider(fStepFilterContentProvider);
fFilterViewer.setInput(JDIDebugModel.getAllStepFilters());
gd = new GridData(GridData.FILL_BOTH | GridData.GRAB_HORIZONTAL | GridData.GRAB_VERTICAL);
gd.heightHint = 150;
gd.widthHint = 300;
fFilterViewer.getTable().setLayoutData(gd);
fFilterViewer.addCheckStateListener(new ICheckStateListener() { |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | public void checkStateChanged(CheckStateChangedEvent event) {
StepFilter filter = (StepFilter)event.getElement();
fStepFilterContentProvider.toggleFilter(filter);
}
});
fFilterViewer.addSelectionChangedListener(new ISelectionChangedListener() {
public void selectionChanged(SelectionChangedEvent event) {
ISelection selection = event.getSelection();
if (selection.isEmpty()) {
fRemoveFilterButton.setEnabled(false);
} else {
fRemoveFilterButton.setEnabled(true);
}
}
});
Composite buttonContainer = new Composite(container, SWT.NONE);
gd = new GridData(GridData.FILL_VERTICAL);
buttonContainer.setLayoutData(gd);
GridLayout buttonLayout = new GridLayout();
buttonLayout.numColumns = 1;
buttonLayout.marginHeight = 0;
buttonLayout.marginWidth = 0;
buttonContainer.setLayout(buttonLayout);
fAddFilterButton = new Button(buttonContainer, SWT.PUSH);
fAddFilterButton.setText("Add &Filter");
fAddFilterButton.setToolTipText("Key in the name of a new step filter"); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING);
fAddFilterButton.setLayoutData(gd);
fAddFilterButton.addSelectionListener(new SelectionListener() {
public void widgetSelected(SelectionEvent se) {
addActiveFilter();
}
public void widgetDefaultSelected(SelectionEvent se) {
}
});
fAddTypeButton = new Button(buttonContainer, SWT.PUSH);
fAddTypeButton.setText("Add &Type...");
fAddTypeButton.setToolTipText("Choose a java type and add it to step filters");
gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING);
fAddTypeButton.setLayoutData(gd);
fAddTypeButton.addSelectionListener(new SelectionListener() {
public void widgetSelected(SelectionEvent se) {
addType();
}
public void widgetDefaultSelected(SelectionEvent se) {
}
});
fAddPackageButton = new Button(buttonContainer, SWT.PUSH);
fAddPackageButton.setText("Add &Package...");
fAddPackageButton.setToolTipText("Choose a package and add it to step filters");
gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING);
fAddPackageButton.setLayoutData(gd); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | fAddPackageButton.addSelectionListener(new SelectionListener() {
public void widgetSelected(SelectionEvent se) {
addPackage();
}
public void widgetDefaultSelected(SelectionEvent se) {
}
});
fRemoveFilterButton = new Button(buttonContainer, SWT.PUSH);
fRemoveFilterButton.setText("&Remove");
fRemoveFilterButton.setToolTipText("Remove all selected step filters");
gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING);
fRemoveFilterButton.setLayoutData(gd);
fRemoveFilterButton.addSelectionListener(new SelectionListener() {
public void widgetSelected(SelectionEvent se) {
removeFilters();
}
public void widgetDefaultSelected(SelectionEvent se) {
}
});
fRemoveFilterButton.setEnabled(false);
fFilterSyntheticButton = new Button(container, SWT.CHECK);
fFilterSyntheticButton.setText("Filter s&ynthetic methods (requires VM support)");
gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING);
gd.horizontalSpan = 2;
fFilterSyntheticButton.setLayoutData(gd); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | fFilterStaticButton = new Button(container, SWT.CHECK);
fFilterStaticButton.setText("Filter static &initializers");
gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING);
gd.horizontalSpan = 2;
fFilterStaticButton.setLayoutData(gd);
fFilterConstructorButton = new Button(container, SWT.CHECK);
fFilterConstructorButton.setText("Filter co&nstructors");
gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING);
gd.horizontalSpan = 2;
fFilterConstructorButton.setLayoutData(gd);
fFilterSyntheticButton.setSelection(JDIDebugModel.getFilterSynthetic());
fFilterStaticButton.setSelection(JDIDebugModel.getFilterStatic());
fFilterConstructorButton.setSelection(JDIDebugModel.getFilterConstructor());
boolean enabled = JDIDebugModel.useStepFilters();
fUseFiltersCheckbox.setSelection(enabled);
toggleStepFilterWidgetsEnabled(enabled);
}
private void toggleStepFilterWidgetsEnabled(boolean enabled) {
fFilterViewer.getTable().setEnabled(enabled);
fAddPackageButton.setEnabled(enabled);
fAddTypeButton.setEnabled(enabled);
fAddFilterButton.setEnabled(enabled);
fFilterSyntheticButton.setEnabled(enabled);
fFilterStaticButton.setEnabled(enabled);
fFilterConstructorButton.setEnabled(enabled); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | if (!enabled) {
fRemoveFilterButton.setEnabled(enabled);
} else if (!fFilterViewer.getSelection().isEmpty()) {
fRemoveFilterButton.setEnabled(true);
}
}
/**
* Create a new filter in the table (with the default 'new filter' value),
* then open up an in-place editor on it.
*/
private void addActiveFilter() {
fNewStepFilter = fStepFilterContentProvider.addFilter(DEFAULT_NEW_FILTER_TEXT, true);
fNewTableItem = fFilterTable.getItem(0);
editFilter();
}
private void editFilter() {
if (fEditorText != null) {
validateChangeAndCleanup();
}
fEditorText = new Text(fFilterTable, SWT.BORDER | SWT.SINGLE);
GridData gd = new GridData(GridData.FILL_BOTH);
fEditorText.setLayoutData(gd);
fTableEditor.horizontalAlignment = SWT.LEFT; |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | fTableEditor.grabHorizontal = true;
fTableEditor.setEditor(fEditorText, fNewTableItem, 0);
fEditorText.setText(fNewStepFilter.getName());
fEditorText.selectAll();
setEditorListeners(fEditorText);
fEditorText.setFocus();
}
private void setEditorListeners(Text text) {
text.addKeyListener(new KeyAdapter() {
public void keyReleased(KeyEvent event) {
if (event.character == SWT.CR) {
validateChangeAndCleanup();
} else if (event.character == SWT.ESC) {
removeNewFilter();
cleanupEditor();
}
}
});
text.addFocusListener(new FocusAdapter() {
public void focusLost(FocusEvent event) {
validateChangeAndCleanup();
}
}); |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | text.addListener(SWT.Traverse, new Listener() {
public void handleEvent(Event event) {
event.doit = false;
}
});
}
private void validateChangeAndCleanup() {
String trimmedValue = fEditorText.getText().trim();
if (trimmedValue.length() < 1) {
removeNewFilter();
}
else if (!validateEditorInput(trimmedValue)) {
getShell().getDisplay().beep();
return;
} else {
fNewTableItem.setText(trimmedValue);
fNewStepFilter.setName(trimmedValue);
}
cleanupEditor();
}
/**
* Cleanup all widgetry & resources used by the in-place editing
*/
private void cleanupEditor() { |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | if (fEditorText != null) {
fEditorText.dispose();
fEditorText = null;
fNewStepFilter = null;
fNewTableItem = null;
fTableEditor.setEditor(null, null, 0);
}
}
private void removeNewFilter() {
fStepFilterContentProvider.removeFilters(new Object[] {fNewStepFilter});
}
/**
* A valid step filter is simply one that is not empty (all spaces),
* and has no embedded spaces. Beyond this, a string cannot be
* validated as corresponding to an existing type or package (and
* this is probably not even desirable).
*/
private boolean validateEditorInput(String trimmedValue) {
int embeddedSpace = trimmedValue.indexOf(' ');
if (embeddedSpace != -1) {
return false;
}
return true;
}
private void addType() {
Shell shell= JavaPlugin.getActiveWorkbenchShell();
SelectionDialog dialog= null; |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | try {
dialog= JavaUI.createTypeDialog(shell, new ProgressMonitorDialog(shell),
SearchEngine.createWorkspaceScope(), IJavaElementSearchConstants.CONSIDER_TYPES, false);
} catch (JavaModelException jme) {
String title= "Add type to step filters";
String message= "Could not open type selection dialog for step filters";
ExceptionHandler.handle(jme, title, message);
return;
}
dialog.setTitle("Add type to step filters");
dialog.setMessage("Select a type to filter when stepping");
if (dialog.open() == IDialogConstants.CANCEL_ID) {
return;
}
Object[] types= dialog.getResult();
if (types != null && types.length > 0) {
IType type = (IType)types[0];
fStepFilterContentProvider.addFilter(type.getFullyQualifiedName(), true);
}
}
private void addPackage() {
Shell shell= JavaPlugin.getActiveWorkbenchShell();
SelectionDialog dialog = null;
try {
dialog = createAllPackagesDialog(shell);
} catch (JavaModelException jme) {
String title= "Add package to step filters"; |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | String message= "Could not open package selection dialog for step filters";
ExceptionHandler.handle(jme, title, message);
return;
}
dialog.setTitle("Add package to step filters");
dialog.setMessage("Select a package to filter when stepping");
if (dialog.open() == IDialogConstants.CANCEL_ID) {
return;
}
Object[] packages= dialog.getResult();
if (packages != null && packages.length > 0) {
IJavaElement pkg = (IJavaElement)packages[0];
String filter = pkg.getElementName();
if (filter.length() < 1) {
filter = "(default package)";
} else {
filter += ".*";
}
fStepFilterContentProvider.addFilter(filter, true);
}
}
private void removeFilters() {
IStructuredSelection selection = (IStructuredSelection)fFilterViewer.getSelection();
fStepFilterContentProvider.removeFilters(selection.toArray());
}
/**
* Ignore package fragments that contain only non-java resources, and make sure |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | * that each fragment is added to the list only once.
*/
private SelectionDialog createAllPackagesDialog(Shell shell) throws JavaModelException{
IWorkspaceRoot wsroot= JavaPlugin.getWorkspace().getRoot();
IJavaModel model= JavaCore.create(wsroot);
IJavaProject[] projects= model.getJavaProjects();
Set packageNameSet= new HashSet();
List packageList = new ArrayList();
for (int i = 0; i < projects.length; i++) {
IPackageFragment[] pkgs= projects[i].getPackageFragments();
for (int j = 0; j < pkgs.length; j++) {
IPackageFragment pkg = pkgs[j];
if (!pkg.hasChildren() && (pkg.getNonJavaResources().length > 0)) {
continue;
}
if (packageNameSet.add(pkg.getElementName())) {
packageList.add(pkg);
}
}
}
int flags= JavaElementLabelProvider.SHOW_DEFAULT;
ElementListSelectionDialog dialog= new ElementListSelectionDialog(shell, new JavaElementLabelProvider(flags));
dialog.setIgnoreCase(false);
dialog.setElements(packageList.toArray());
return dialog;
}
/**
* @see IWorkbenchPreferencePage#init(IWorkbench)
*/ |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | public void init(IWorkbench workbench) {
}
/**
* @see PreferencePage#performOk()
* Also, notifies interested listeners
*/
public boolean performOk() {
storeValues();
getPreferenceStore().firePropertyChangeEvent(IPreferencesConstants.VARIABLE_RENDERING, new Boolean(true), new Boolean(false));
fStepFilterContentProvider.saveFilters();
return true;
}
/**
* Sets the default preferences
*/
protected void performDefaults() {
setDefaultValues();
super.performDefaults();
}
private void setDefaultValues() {
IPreferenceStore store = getPreferenceStore();
fHexButton.setSelection(store.getDefaultBoolean(SHOW_HEX));
fCharButton.setSelection(store.getDefaultBoolean(SHOW_CHARS));
fUnsignedButton.setSelection(store.getDefaultBoolean(SHOW_UNSIGNED));
fStepFilterContentProvider.setDefaults();
} |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | /**
* Creates a button with the given label and sets the default
* configuration data.
*/
private Button createCheckButton(Composite parent, String label) {
Button button= new Button(parent, SWT.CHECK | SWT.LEFT);
button.setText(label);
button.addListener(SWT.Selection, this);
GridData data = new GridData();
button.setLayoutData(data);
return button;
}
/**
* Creates composite control and sets the default layout data.
*
* @param parent the parent of the new composite
* @param numColumns the number of columns for the new composite
* @param labelText the text label of the new composite
* @return the newly-created composite
*/
private Composite createLabelledComposite(Composite parent, int numColumns, String labelText) {
Composite comp = new Composite(parent, SWT.NONE);
GridLayout layout = new GridLayout();
layout.numColumns = numColumns; |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | comp.setLayout(layout);
GridData gd= new GridData();
gd.verticalAlignment = GridData.FILL;
gd.horizontalAlignment = GridData.FILL;
comp.setLayoutData(gd);
Label label = new Label(comp, SWT.NONE);
label.setText(labelText);
gd = new GridData();
gd.horizontalSpan = numColumns;
label.setLayoutData(gd);
return comp;
}
/**
* Create a vertical space to separate groups of controls.
*/
private void createSpace(Composite parent) {
Label vfiller = new Label(parent, SWT.LEFT);
GridData gridData = new GridData();
gridData.horizontalAlignment = GridData.BEGINNING;
gridData.grabExcessHorizontalSpace = false;
gridData.verticalAlignment = GridData.CENTER;
gridData.grabExcessVerticalSpace = false;
vfiller.setLayoutData(gridData);
}
/**
* @see Listener#handleEvent(Event) |
5,587 | Bug 5587 Step Over jumps to caller | Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; } | verified fixed | a1fa1cd | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-08T17:14:34Z" | "2001-11-06T18:06:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java | */
public void handleEvent(Event event) {
}
/**
* Set the values of the component widgets based on the
* values in the preference store
*/
private void setValues() {
IPreferenceStore store = getPreferenceStore();
fHexButton.setSelection(store.getBoolean(SHOW_HEX));
fCharButton.setSelection(store.getBoolean(SHOW_CHARS));
fUnsignedButton.setSelection(store.getBoolean(SHOW_UNSIGNED));
}
/**
* Store the preference values based on the state of the
* component widgets
*/
private void storeValues() {
IPreferenceStore store = getPreferenceStore();
store.setValue(SHOW_HEX, fHexButton.getSelection());
store.setValue(SHOW_CHARS, fCharButton.getSelection());
store.setValue(SHOW_UNSIGNED, fUnsignedButton.getSelection());
}
} |
4,103 | Bug 4103 Should have shortcuts for new file and folder (1GIF4F6) | Another vote for adding File and Folder to the new menu in the Java perspective. NOTES: | verified fixed | 1022fe5 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-10T17:11:57Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaPerspectiveFactory.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui;
import org.eclipse.ui.IFolderLayout;
import org.eclipse.ui.IPageLayout;
import org.eclipse.ui.IPerspectiveFactory;
import org.eclipse.search.ui.SearchUI;
import org.eclipse.debug.ui.IDebugUIConstants;
import org.eclipse.jdt.ui.JavaUI;
public class JavaPerspectiveFactory implements IPerspectiveFactory {
/**
* Constructs a new Default layout engine.
*/
public JavaPerspectiveFactory() {
super();
}
public void createInitialLayout(IPageLayout layout) {
String editorArea = layout.getEditorArea();
IFolderLayout folder= layout.createFolder("left", IPageLayout.LEFT, (float)0.25, editorArea);
folder.addView(JavaUI.ID_PACKAGES);
folder.addView(JavaUI.ID_TYPE_HIERARCHY);
folder.addPlaceholder(IPageLayout.ID_RES_NAV);
IFolderLayout outputfolder= layout.createFolder("bottom", IPageLayout.BOTTOM, (float)0.75, editorArea); |
4,103 | Bug 4103 Should have shortcuts for new file and folder (1GIF4F6) | Another vote for adding File and Folder to the new menu in the Java perspective. NOTES: | verified fixed | 1022fe5 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-10T17:11:57Z" | "2001-10-11T03:13:20Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaPerspectiveFactory.java | outputfolder.addView(IPageLayout.ID_TASK_LIST);
outputfolder.addView(SearchUI.SEARCH_RESULT_VIEW_ID);
outputfolder.addView(IDebugUIConstants.ID_CONSOLE_VIEW);
layout.addView(IPageLayout.ID_OUTLINE, IPageLayout.RIGHT, (float)0.75, editorArea);
layout.addActionSet(IDebugUIConstants.DEBUG_ACTION_SET);
layout.addActionSet(JavaUI.ID_ACTION_SET);
layout.addActionSet(IUIConstants.ID_REFACTORING_ACTION_SET);
layout.addShowViewShortcut(JavaUI.ID_PACKAGES);
layout.addShowViewShortcut(JavaUI.ID_TYPE_HIERARCHY);
layout.addShowViewShortcut(SearchUI.SEARCH_RESULT_VIEW_ID);
layout.addShowViewShortcut(IDebugUIConstants.ID_PROCESS_VIEW);
layout.addShowViewShortcut(IDebugUIConstants.ID_CONSOLE_VIEW);
layout.addShowViewShortcut(IPageLayout.ID_OUTLINE);
layout.addShowViewShortcut(IPageLayout.ID_TASK_LIST);
layout.addShowViewShortcut(IPageLayout.ID_RES_NAV);
layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewPackageCreationWizard");
layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewClassCreationWizard");
layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewInterfaceCreationWizard");
layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewSnippetCreationWizard");
}
} |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | /*
* (c) Copyright IBM Corp. 2000, 2001.
* All Rights Reserved.
*/
package org.eclipse.jdt.internal.ui.packageview;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import org.eclipse.core.resources.IContainer; |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | import org.eclipse.core.resources.IFile;
import org.eclipse.core.resources.IResource;
import org.eclipse.core.resources.IWorkspace;
import org.eclipse.core.runtime.IAdaptable;
import org.eclipse.core.runtime.IPath;
import org.eclipse.jdt.core.IClassFile;
import org.eclipse.jdt.core.ICompilationUnit;
import org.eclipse.jdt.core.IJavaElement;
import org.eclipse.jdt.core.IJavaModel;
import org.eclipse.jdt.core.IMember;
import org.eclipse.jdt.core.IOpenable;
import org.eclipse.jdt.core.ISourceReference;
import org.eclipse.jdt.core.IType;
import org.eclipse.jdt.core.IWorkingCopy;
import org.eclipse.jdt.core.JavaCore;
import org.eclipse.jdt.core.JavaModelException;
import org.eclipse.jdt.internal.ui.IJavaHelpContextIds;
import org.eclipse.jdt.internal.ui.JavaPlugin;
import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup;
import org.eclipse.jdt.internal.ui.compare.JavaAddElementFromHistory;
import org.eclipse.jdt.internal.ui.compare.JavaReplaceWithEditionAction;
import org.eclipse.jdt.internal.ui.dnd.DelegatingDragAdapter;
import org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter;
import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer;
import org.eclipse.jdt.internal.ui.dnd.TransferDragSourceListener;
import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener;
import org.eclipse.jdt.internal.ui.javaeditor.IClassFileEditorInput;
import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility;
import org.eclipse.jdt.internal.ui.javaeditor.JarEntryEditorInput;
import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | import org.eclipse.jdt.internal.ui.IPreferencesConstants;
import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringAction;
import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringGroup;
import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider;
import org.eclipse.jdt.internal.ui.reorg.DeleteAction;
import org.eclipse.jdt.internal.ui.reorg.ReorgGroup;
import org.eclipse.jdt.internal.ui.search.JavaSearchGroup;
import org.eclipse.jdt.internal.ui.util.JavaModelUtil;
import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil;
import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter;
import org.eclipse.jdt.internal.ui.viewsupport.MarkerErrorTickProvider;
import org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer;
import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater;
import org.eclipse.jdt.internal.ui.wizards.NewGroup;
import org.eclipse.jdt.ui.IContextMenuConstants;
import org.eclipse.jdt.ui.IPackagesViewPart;
import org.eclipse.jdt.ui.JavaElementContentProvider;
import org.eclipse.jdt.ui.JavaElementLabelProvider;
import org.eclipse.jdt.ui.JavaUI;
import org.eclipse.jface.action.Action;
import org.eclipse.jface.action.IMenuListener;
import org.eclipse.jface.action.IMenuManager;
import org.eclipse.jface.action.IStatusLineManager;
import org.eclipse.jface.action.IToolBarManager;
import org.eclipse.jface.action.MenuManager;
import org.eclipse.jface.action.Separator;
import org.eclipse.jface.preference.IPreferenceStore;
import org.eclipse.jface.util.IPropertyChangeListener;
import org.eclipse.jface.util.PropertyChangeEvent;
import org.eclipse.jface.viewers.DecoratingLabelProvider; |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | import org.eclipse.jface.viewers.DoubleClickEvent;
import org.eclipse.jface.viewers.IDoubleClickListener;
import org.eclipse.jface.viewers.ILabelDecorator;
import org.eclipse.jface.viewers.ILabelProvider;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.jface.viewers.ISelectionChangedListener;
import org.eclipse.jface.viewers.ISelectionProvider;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.jface.viewers.ITreeViewerListener;
import org.eclipse.jface.viewers.SelectionChangedEvent;
import org.eclipse.jface.viewers.StructuredSelection;
import org.eclipse.jface.viewers.TreeExpansionEvent;
import org.eclipse.jface.viewers.TreeViewer;
import org.eclipse.search.ui.IWorkingSet;
import org.eclipse.search.ui.SearchUI;
import org.eclipse.swt.SWT;
import org.eclipse.swt.dnd.DND;
import org.eclipse.swt.dnd.DragSource;
import org.eclipse.swt.dnd.FileTransfer;
import org.eclipse.swt.dnd.Transfer;
import org.eclipse.swt.events.KeyAdapter;
import org.eclipse.swt.events.KeyEvent;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Menu;
import org.eclipse.swt.widgets.ScrollBar;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.swt.widgets.Tree;
import org.eclipse.ui.IActionBars;
import org.eclipse.ui.IEditorInput; |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | import org.eclipse.ui.IEditorPart;
import org.eclipse.ui.IFileEditorInput;
import org.eclipse.ui.IMemento;
import org.eclipse.ui.IPartListener;
import org.eclipse.ui.IViewPart;
import org.eclipse.ui.IViewSite;
import org.eclipse.ui.IWorkbenchActionConstants;
import org.eclipse.ui.IWorkbenchPage;
import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.PartInitException;
import org.eclipse.ui.actions.OpenPerspectiveMenu;
import org.eclipse.ui.actions.OpenWithMenu;
import org.eclipse.ui.actions.RefreshAction;
import org.eclipse.ui.dialogs.PropertyDialogAction;
import org.eclipse.ui.help.ViewContextComputer;
import org.eclipse.ui.help.WorkbenchHelp;
import org.eclipse.ui.part.ISetSelectionTarget;
import org.eclipse.ui.part.ViewPart;
import org.eclipse.ui.views.internal.framelist.BackAction;
import org.eclipse.ui.views.internal.framelist.ForwardAction;
import org.eclipse.ui.views.internal.framelist.FrameList;
import org.eclipse.ui.views.internal.framelist.GoIntoAction;
import org.eclipse.ui.views.internal.framelist.UpAction;
/**
* The ViewPart for the ProjectExplorer. It listens to part activation events.
* When selection linking with the editor is enabled the view selection tracks
* the active editor page. Similarly when a resource is selected in the packages
* view the corresponding editor is activated.
*/
public class PackageExplorerPart extends ViewPart implements ISetSelectionTarget, IMenuListener, IPackagesViewPart, IPropertyChangeListener { |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | public final static String VIEW_ID= JavaUI.ID_PACKAGES;
static final String TAG_SELECTION= "selection";
static final String TAG_EXPANDED= "expanded";
static final String TAG_ELEMENT= "element";
static final String TAG_PATH= "path";
static final String TAG_VERTICAL_POSITION= "verticalPosition";
static final String TAG_HORIZONTAL_POSITION= "horizontalPosition";
static final String TAG_FILTERS = "filters";
static final String TAG_FILTER = "filter";
static final String TAG_SHOWLIBRARIES = "showLibraries";
static final String TAG_SHOWBINARIES = "showBinaries";
static final String TAG_WORKINGSET = "workingset";
private JavaElementPatternFilter fPatternFilter= new JavaElementPatternFilter();
private LibraryFilter fLibraryFilter= new LibraryFilter();
private BinaryProjectFilter fBinaryFilter= new BinaryProjectFilter();
private WorkingSetFilter fWorkingSetFilter= new WorkingSetFilter();
private ProblemTreeViewer fViewer;
private PackagesFrameSource fFrameSource;
private FrameList fFrameList;
private ContextMenuGroup[] fStandardGroups; |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | private Menu fContextMenu;
private OpenResourceAction fOpenCUAction;
private Action fOpenToAction;
private Action fShowTypeHierarchyAction;
private Action fShowNavigatorAction;
private Action fPropertyDialogAction;
private RefactoringAction fDeleteAction;
private RefreshAction fRefreshAction;
private BackAction fBackAction;
private ForwardAction fForwardAction;
private GoIntoAction fZoomInAction;
private UpAction fUpAction;
private GotoTypeAction fGotoTypeAction;
private GotoPackageAction fGotoPackageAction;
private AddBookmarkAction fAddBookmarkAction;
private FilterSelectionAction fFilterAction;
private ShowLibrariesAction fShowLibrariesAction;
private ShowBinariesAction fShowBinariesAction;
private FilterWorkingSetAction fFilterWorkingSetAction;
private RemoveWorkingSetFilterAction fRemoveWorkingSetAction;
private IMemento fMemento;
private ISelectionChangedListener fSelectionListener;
private IPartListener fPartListener= new IPartListener() {
public void partActivated(IWorkbenchPart part) {
if (part instanceof IEditorPart)
editorActivated((IEditorPart) part);
}
public void partBroughtToTop(IWorkbenchPart part) { |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | }
public void partClosed(IWorkbenchPart part) {
}
public void partDeactivated(IWorkbenchPart part) {
}
public void partOpened(IWorkbenchPart part) {
}
};
private ITreeViewerListener fExpansionListener= new ITreeViewerListener() {
public void treeCollapsed(TreeExpansionEvent event) {
}
public void treeExpanded(TreeExpansionEvent event) {
Object element= event.getElement();
if (element instanceof ICompilationUnit ||
element instanceof IClassFile)
expandMainType(element);
}
};
public PackageExplorerPart() {
}
/* (non-Javadoc)
* Method declared on IViewPart.
*/
public void init(IViewSite site, IMemento memento) throws PartInitException {
super.init(site, memento);
fMemento= memento;
} |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | /**
* Initializes the default preferences
*/
public static void initDefaults(IPreferenceStore store) {
store.setDefault(TAG_SHOWLIBRARIES, true);
store.setDefault(TAG_SHOWBINARIES, true);
}
/**
* Returns the package explorer part of the active perspective. If
* there isn't any package explorer part <code>null</code> is returned.
*/
public static PackageExplorerPart getFromActivePerspective() {
IViewPart view= JavaPlugin.getActivePage().findView(VIEW_ID);
if (view instanceof PackageExplorerPart)
return (PackageExplorerPart)view;
return null;
}
/**
* Makes the package explorer part visible in the active perspective. If there
* isn't a package explorer part registered <code>null</code> is returned.
* Otherwise the opened view part is returned.
*/
public static PackageExplorerPart openInActivePerspective() {
try {
return (PackageExplorerPart)JavaPlugin.getActivePage().showView(VIEW_ID);
} catch(PartInitException pe) {
return null;
} |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | }
public void dispose() {
if (fViewer != null)
JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fViewer);
if (fContextMenu != null && !fContextMenu.isDisposed())
fContextMenu.dispose();
getSite().getPage().removePartListener(fPartListener);
JavaPlugin.getDefault().getPreferenceStore().removePropertyChangeListener(this);
if (fViewer != null)
fViewer.removeTreeListener(fExpansionListener);
super.dispose();
}
/**
* Implementation of IWorkbenchPart.createPartControl(Composite)
*/
public void createPartControl(Composite parent) {
fViewer= new ProblemTreeViewer(parent, SWT.MULTI | SWT.H_SCROLL | SWT.V_SCROLL);
boolean showCUChildren= JavaBasePreferencePage.showCompilationUnitChildren();
fViewer.setContentProvider(new JavaElementContentProvider(showCUChildren, false));
JavaPlugin.getDefault().getProblemMarkerManager().addListener(fViewer);
JavaPlugin.getDefault().getPreferenceStore().addPropertyChangeListener(this);
JavaElementLabelProvider labelProvider= new JavaElementLabelProvider(getLabelProviderFlags());
labelProvider.setErrorTickManager(new MarkerErrorTickProvider());
fViewer.setLabelProvider(new DecoratingLabelProvider(labelProvider, null));
fViewer.setSorter(new JavaElementSorter());
fViewer.addFilter(new EmptyInnerPackageFilter()); |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | fViewer.setUseHashlookup(true);
fViewer.addFilter(fPatternFilter);
fViewer.addFilter(fLibraryFilter);
fViewer.addFilter(fWorkingSetFilter);
if(fMemento != null)
restoreFilters();
else
initFilterFromPreferences();
fViewer.setInput(findInputElement());
initDragAndDrop();
initFrameList();
initKeyListener();
updateTitle();
MenuManager menuMgr= new MenuManager("#PopupMenu");
menuMgr.setRemoveAllWhenShown(true);
menuMgr.addMenuListener(this);
fContextMenu= menuMgr.createContextMenu(fViewer.getTree());
fViewer.getTree().setMenu(fContextMenu);
getSite().registerContextMenu(menuMgr, fViewer);
makeActions();
fSelectionListener= new ISelectionChangedListener() {
public void selectionChanged(SelectionChangedEvent event) {
handleSelectionChanged(event); |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | }
};
fViewer.addSelectionChangedListener(fSelectionListener);
fViewer.addDoubleClickListener(new IDoubleClickListener() {
public void doubleClick(DoubleClickEvent event) {
handleDoubleClick(event);
}
});
fViewer.getControl().addKeyListener(new KeyAdapter() {
public void keyPressed(KeyEvent e) {
handleKeyPressed(e);
}
});
getSite().setSelectionProvider(fViewer);
getSite().getPage().addPartListener(fPartListener);
IStatusLineManager slManager= getViewSite().getActionBars().getStatusLineManager();
fViewer.addSelectionChangedListener(new StatusBarUpdater(slManager));
fViewer.addTreeListener(fExpansionListener);
if (fMemento != null)
restoreState(fMemento);
fMemento= null;
WorkbenchHelp.setHelp(fViewer.getControl(), new ViewContextComputer(this, IJavaHelpContextIds.PACKAGE_VIEW));
fillActionBars();
}
private void fillActionBars() { |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | IActionBars actionBars= getViewSite().getActionBars();
IToolBarManager toolBar= actionBars.getToolBarManager();
toolBar.add(fBackAction);
toolBar.add(fForwardAction);
toolBar.add(fUpAction);
actionBars.updateActionBars();
IMenuManager menu= actionBars.getMenuManager();
menu.add(fFilterAction);
menu.add(fShowLibrariesAction);
menu.add(fFilterWorkingSetAction);
menu.add(fRemoveWorkingSetAction);
menu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS));
menu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS+"-end"));
}
private Object findInputElement() {
Object input= getSite().getPage().getInput();
if (input instanceof IWorkspace) {
return JavaCore.create(((IWorkspace)input).getRoot());
} else if (input instanceof IContainer) {
return JavaCore.create((IContainer)input);
}
return JavaCore.create(JavaPlugin.getWorkspace().getRoot());
} |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | /**
* Answer the property defined by key.
*/
public Object getAdapter(Class key) {
if (key.equals(ISelectionProvider.class))
return fViewer;
return super.getAdapter(key);
}
/**
* Returns the tool tip text for the given element.
*/
String getToolTipText(Object element) {
String result;
if (!(element instanceof IResource)) {
result= ((ILabelProvider) getViewer().getLabelProvider()).getText(element);
} else {
IPath path= ((IResource) element).getFullPath();
if (path.isRoot()) {
result= PackagesMessages.getString("PackageExplorer.title");
} else {
result= path.makeRelative().toString();
}
}
IWorkingSet ws= fWorkingSetFilter.getWorkingSet();
if (ws == null)
return result;
String wsstr= "Working Set: "+ws.getName();
if (result.length() == 0)
return wsstr; |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | return result + " - " + wsstr;
}
public String getTitleToolTip() {
if (fViewer == null)
return super.getTitleToolTip();
return getToolTipText(fViewer.getInput());
}
/**
* @see IWorkbenchPart#setFocus()
*/
public void setFocus() {
fViewer.getTree().setFocus();
}
/**
* Sets the working set to be used for filtering this part
*/
public void setWorkingSet(IWorkingSet ws) {
fWorkingSetFilter.setWorkingSet(ws);
firePropertyChange(IWorkbenchPart.PROP_TITLE);
fFilterWorkingSetAction.setChecked(ws != null);
fRemoveWorkingSetAction.setEnabled(ws != null);
}
/**
* Returns the shell to use for opening dialogs.
* Used in this class, and in the actions.
*/
private Shell getShell() { |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | return fViewer.getTree().getShell();
}
/**
* Returns the selection provider.
*/
private ISelectionProvider getSelectionProvider() {
return fViewer;
}
/**
* Returns the current selection.
*/
private ISelection getSelection() {
return fViewer.getSelection();
}
/**
* Called when the context menu is about to open.
* Override to add your own context dependent menu contributions.
*/
public void menuAboutToShow(IMenuManager menu) {
JavaPlugin.createStandardGroups(menu);
IStructuredSelection selection= (IStructuredSelection) fViewer.getSelection();
boolean selectionHasElements= !selection.isEmpty();
Object element= selection.getFirstElement();
if (selection.size() == 1 && fViewer.isExpandable(element))
menu.appendToGroup(IContextMenuConstants.GROUP_GOTO, fZoomInAction); |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | addGotoMenu(menu);
fOpenCUAction.update();
if (fOpenCUAction.isEnabled())
menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, fOpenCUAction);
addOpenWithMenu(menu, selection);
addOpenToMenu(menu, selection);
addRefactoring(menu);
if (selection.size() == 1) {
menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new JavaReplaceWithEditionAction(fViewer));
menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new JavaAddElementFromHistory(null, fViewer));
}
ContextMenuGroup.add(menu, fStandardGroups, fViewer);
if (fAddBookmarkAction.canOperateOnSelection())
menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, fAddBookmarkAction);
menu.appendToGroup(IContextMenuConstants.GROUP_BUILD, fRefreshAction);
fRefreshAction.selectionChanged(selection);
if (selectionHasElements) {
menu.appendToGroup(IContextMenuConstants.GROUP_PROPERTIES, fPropertyDialogAction);
}
}
void addGotoMenu(IMenuManager menu) {
MenuManager gotoMenu= new MenuManager(PackagesMessages.getString("PackageExplorer.gotoTitle"));
menu.appendToGroup(IContextMenuConstants.GROUP_GOTO, gotoMenu);
gotoMenu.add(fBackAction); |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | gotoMenu.add(fForwardAction);
gotoMenu.add(fUpAction);
gotoMenu.add(fGotoTypeAction);
gotoMenu.add(fGotoPackageAction);
}
private void makeActions() {
ISelectionProvider provider= getSelectionProvider();
fOpenCUAction= new OpenResourceAction(provider);
fPropertyDialogAction= new PropertyDialogAction(getShell(), provider);
fShowNavigatorAction= new ShowInNavigatorAction(provider);
fAddBookmarkAction= new AddBookmarkAction(provider);
fStandardGroups= new ContextMenuGroup[] {
new NewGroup(),
new BuildGroup(),
new ReorgGroup(),
new JavaSearchGroup()
};
fDeleteAction= new DeleteAction(StructuredSelectionProvider.createFrom(provider));
fRefreshAction= new RefreshAction(getShell());
fFilterAction = new FilterSelectionAction(getShell(), this, PackagesMessages.getString("PackageExplorer.filters"));
fShowLibrariesAction = new ShowLibrariesAction(this, PackagesMessages.getString("PackageExplorer.referencedLibs"));
fShowBinariesAction = new ShowBinariesAction(getShell(), this, PackagesMessages.getString("PackageExplorer.binaryProjects"));
fFilterWorkingSetAction = new FilterWorkingSetAction(getShell(), this, "Filter Working Set...");
fRemoveWorkingSetAction = new RemoveWorkingSetFilterAction(getShell(), this, "Remove Working Set Filter");
fBackAction= new BackAction(fFrameList);
fForwardAction= new ForwardAction(fFrameList); |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | fZoomInAction= new GoIntoAction(fFrameList);
fUpAction= new UpAction(fFrameList);
fGotoTypeAction= new GotoTypeAction(this);
fGotoPackageAction= new GotoPackageAction(this);
IActionBars actionService= getViewSite().getActionBars();
actionService.setGlobalActionHandler(IWorkbenchActionConstants.DELETE, fDeleteAction);
}
private void addRefactoring(IMenuManager menu){
MenuManager refactoring= new MenuManager(PackagesMessages.getString("PackageExplorer.refactoringTitle"));
ContextMenuGroup.add(refactoring, new ContextMenuGroup[] { new RefactoringGroup() }, fViewer);
if (!refactoring.isEmpty())
menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, refactoring);
}
private void addOpenToMenu(IMenuManager menu, IStructuredSelection selection) {
if (selection.size() != 1)
return;
IAdaptable element= (IAdaptable) selection.getFirstElement();
IResource resource= (IResource)element.getAdapter(IResource.class);
if ((resource instanceof IContainer)) {
MenuManager submenu = new MenuManager(PackagesMessages.getString("PackageExplorer.openPerspective"));
submenu.add(new OpenPerspectiveMenu(getSite().getWorkbenchWindow(), resource));
menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu);
}
OpenTypeHierarchyUtil.addToMenu(getSite().getWorkbenchWindow(), menu, element);
}
private void addOpenWithMenu(IMenuManager menu, IStructuredSelection selection) { |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | if (selection.size() != 1)
return;
IAdaptable element= (IAdaptable)selection.getFirstElement();
Object resource= element.getAdapter(IResource.class);
if (!(resource instanceof IFile))
return;
MenuManager submenu= new MenuManager(PackagesMessages.getString("PackageExplorer.openWith"));
submenu.add(new OpenWithMenu(getSite().getPage(), (IFile) resource));
menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu);
}
private boolean isSelectionOfType(ISelection s, Class clazz, boolean considerUnderlyingResource) {
if (! (s instanceof IStructuredSelection) || s.isEmpty())
return false;
IStructuredSelection selection= (IStructuredSelection)s;
Iterator iter= selection.iterator();
while (iter.hasNext()) {
Object o= iter.next();
if (clazz.isInstance(o))
return true;
if (considerUnderlyingResource) {
if (! (o instanceof IJavaElement))
return false;
IJavaElement element= (IJavaElement)o;
Object resource= element.getAdapter(IResource.class); |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | if (! clazz.isInstance(resource))
return false;
}
}
return true;
}
private void initDragAndDrop() {
int ops= DND.DROP_COPY | DND.DROP_MOVE;
final LocalSelectionTransfer lt= LocalSelectionTransfer.getInstance();
Transfer[] transfers= new Transfer[] {lt, FileTransfer.getInstance()};
TransferDropTargetListener[] dropListeners= new TransferDropTargetListener[] {
new SelectionTransferDropAdapter(fViewer),
new FileTransferDropAdapter(fViewer)
};
fViewer.addDropSupport(ops, transfers, new DelegatingDropAdapter(dropListeners));
Control control= fViewer.getControl();
TransferDragSourceListener[] dragListeners= new TransferDragSourceListener[] {
new SelectionTransferDragAdapter(fViewer),
new FileTransferDragAdapter(fViewer)
};
DragSource source= new DragSource(control, ops);
source.addDragListener(new DelegatingDragAdapter(dragListeners)); |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | }
/**
* Handles key events in viewer.
*/
void handleKeyPressed(KeyEvent event) {
if (event.character == SWT.DEL && event.stateMask == 0){
fDeleteAction.update();
if (fDeleteAction.isEnabled())
fDeleteAction.run();
}
}
/**
* Handles double clicks in viewer.
* Opens editor if file double-clicked.
*/
private void handleDoubleClick(DoubleClickEvent event) {
IStructuredSelection s= (IStructuredSelection) event.getSelection();
Object element= s.getFirstElement();
if (EditorUtility.isOpenInEditor(element) == null) {
if (fOpenCUAction.isEnabled()) {
fOpenCUAction.run();
return;
}
}
if (fViewer.isExpandable(element)) {
if (JavaBasePreferencePage.doubleClockGoesInto()) { |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | if (element instanceof IOpenable &&
!(element instanceof ICompilationUnit) &&
!(element instanceof IClassFile)) {
fZoomInAction.run();
}
} else {
fViewer.setExpandedState(element, !fViewer.getExpandedState(element));
expandMainType(element);
}
}
}
/**
* Handles selection changed in viewer.
* Updates global actions.
* Links to editor (if option enabled)
*/
private void handleSelectionChanged(SelectionChangedEvent event) {
IStructuredSelection sel= (IStructuredSelection) event.getSelection();
fZoomInAction.update();
linkToEditor(sel);
}
public void selectReveal(ISelection selection) {
ISelection javaSelection= convertSelection(selection);
fViewer.setSelection(javaSelection, true);
}
private ISelection convertSelection(ISelection s) {
List converted= new ArrayList();
if (s instanceof StructuredSelection) {
Object[] elements= ((StructuredSelection)s).toArray(); |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | for (int i= 0; i < elements.length; i++) {
Object e= elements[i];
if (e instanceof IJavaElement)
converted.add(e);
else if (e instanceof IResource) {
IJavaElement element= JavaCore.create((IResource)e);
if (element != null)
converted.add(element);
else
converted.add(e);
}
}
}
return new StructuredSelection(converted.toArray());
}
public void selectAndReveal(Object element) {
selectReveal(new StructuredSelection(element));
}
/**
* Returns whether the preference to link selection to active editor is enabled.
*/
boolean isLinkingEnabled() {
return JavaBasePreferencePage.linkPackageSelectionToEditor();
}
/**
* Links to editor (if option enabled)
*/
private void linkToEditor(IStructuredSelection selection) { |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | Object obj= selection.getFirstElement();
Object element= null;
if (selection.size() == 1) {
if (obj instanceof IJavaElement) {
IJavaElement cu= JavaModelUtil.findElementOfKind((IJavaElement)obj, IJavaElement.COMPILATION_UNIT);
if (cu != null)
element= getResourceFor(cu);
if (element == null)
element= JavaModelUtil.findElementOfKind((IJavaElement)obj, IJavaElement.CLASS_FILE);
}
else if (obj instanceof IFile)
element= obj;
if (element == null)
return;
IWorkbenchPage page= getSite().getPage();
IEditorPart editorArray[]= page.getEditors();
for (int i= 0; i < editorArray.length; ++i) {
IEditorPart editor= editorArray[i];
Object input= getElementOfInput(editor.getEditorInput());
if (input != null && input.equals(element)) {
page.bringToTop(editor);
if (obj instanceof IJavaElement)
EditorUtility.revealInEditor(editor, (IJavaElement) obj);
return;
}
} |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | }
}
private IResource getResourceFor(Object element) {
if (element instanceof IJavaElement) {
if (element instanceof IWorkingCopy) {
IWorkingCopy wc= (IWorkingCopy)element;
IJavaElement original= wc.getOriginalElement();
if (original != null)
element= original;
}
try {
element= ((IJavaElement)element).getUnderlyingResource();
} catch (JavaModelException e) {
return null;
}
}
if (!(element instanceof IResource) || ((IResource)element).isPhantom()) {
return null;
}
return (IResource)element;
}
public void saveState(IMemento memento) {
if (fViewer == null) {
if (fMemento != null)
memento.putMemento(fMemento);
return;
}
saveExpansionState(memento); |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | saveSelectionState(memento);
saveScrollState(memento, fViewer.getTree());
savePatternFilterState(memento);
saveFilterState(memento);
saveWorkingSetState(memento);
}
protected void saveFilterState(IMemento memento) {
boolean showLibraries= getLibraryFilter().getShowLibraries();
String show= "true";
if (!showLibraries)
show= "false";
memento.putString(TAG_SHOWLIBRARIES, show);
boolean showBinaries= getBinaryFilter().getShowBinaries();
String showBinString= "true";
if (!showBinaries)
showBinString= "false";
memento.putString(TAG_SHOWBINARIES, showBinString);
}
protected void savePatternFilterState(IMemento memento) {
String filters[] = getPatternFilter().getPatterns();
if(filters.length > 0) {
IMemento filtersMem = memento.createChild(TAG_FILTERS);
for (int i = 0; i < filters.length; i++){
IMemento child = filtersMem.createChild(TAG_FILTER);
child.putString(TAG_ELEMENT,filters[i]);
}
}
} |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | protected void saveScrollState(IMemento memento, Tree tree) {
ScrollBar bar= tree.getVerticalBar();
int position= bar != null ? bar.getSelection() : 0;
memento.putString(TAG_VERTICAL_POSITION, String.valueOf(position));
bar= tree.getHorizontalBar();
position= bar != null ? bar.getSelection() : 0;
memento.putString(TAG_HORIZONTAL_POSITION, String.valueOf(position));
}
protected void saveSelectionState(IMemento memento) {
Object elements[]= ((IStructuredSelection) fViewer.getSelection()).toArray();
if (elements.length > 0) {
IMemento selectionMem= memento.createChild(TAG_SELECTION);
for (int i= 0; i < elements.length; i++) {
IMemento elementMem= selectionMem.createChild(TAG_ELEMENT);
Object o= elements[i];
if (o instanceof IJavaElement)
elementMem.putString(TAG_PATH, ((IJavaElement) elements[i]).getHandleIdentifier());
}
}
}
protected void saveExpansionState(IMemento memento) {
Object expandedElements[]= fViewer.getExpandedElements();
if (expandedElements.length > 0) {
IMemento expandedMem= memento.createChild(TAG_EXPANDED);
for (int i= 0; i < expandedElements.length; i++) {
IMemento elementMem= expandedMem.createChild(TAG_ELEMENT);
Object o= expandedElements[i]; |
5,774 | Bug 5774 Unpredicatable behaviour on double click in packages view | from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ; | resolved fixed | d13ebe7 | JDT | https://github.com/eclipse-jdt/eclipse.jdt.ui | eclipse-jdt/eclipse.jdt.ui | java | null | null | null | "2001-11-11T14:10:11Z" | "2001-11-11T14:46:40Z" | org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java | if (o instanceof IJavaElement)
elementMem.putString(TAG_PATH, ((IJavaElement) expandedElements[i]).getHandleIdentifier());
}
}
}
protected void saveWorkingSetState(IMemento memento) {
IWorkingSet ws= getWorkingSetFilter().getWorkingSet();
if (ws != null) {
memento.putString(TAG_WORKINGSET, ws.getName());
}
}
void restoreState(IMemento memento) {
restoreExpansionState(memento);
restoreSelectionState(memento);
restoreScrollState(memento, fViewer.getTree());
}
protected void restoreScrollState(IMemento memento, Tree tree) {
ScrollBar bar= tree.getVerticalBar();
if (bar != null) {
try {
String posStr= memento.getString(TAG_VERTICAL_POSITION);
int position;
position= new Integer(posStr).intValue();
bar.setSelection(position);
} catch (NumberFormatException e) {
}
}
bar= tree.getHorizontalBar();
if (bar != null) { |