Datasets:

bug-localization

/

apache_bugs

like 0

Follow

BLAZE 1

Bug 423257 LTW - java.lang.VerifyError: Bad return type with generics and local variables

resolved fixed

dd88d21

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjState.java", "tests/bugs175/pr423257/AspectX.java", "tests/bugs175/pr423257/Test.java", "tests/src/org/aspectj/systemtest/AllTests17.java", "tests/src/org/aspectj/systemtest/ajc175/Ajc175Tests.java", "tests/src/org/aspectj/systemtest/ajc175/AllTestsAspectJ175.java", "tests/src/org/aspectj/systemtest/incremental/tools/MultiProjectIncrementalTests.java", "weaver/src/org/aspectj/weaver/bcel/asm/StackMapAdder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 420210 Support additional message insert keys in declare error/warning

It would be good to be able to insert the enclosing class name or enclosing member for a joinpoint.

resolved fixed

9319e34

["org.aspectj.matcher/src/org/aspectj/weaver/Checker.java", "tests/bugs174/extra_inserts/Code.java", "tests/src/org/aspectj/systemtest/ajc174/Ajc174Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 419279 ajc option to change -Xlint level per-message without Xlintfile

The -Xlintfile option is not a great fit for controlling message across multiple build projects, specifically in my case from the pluginManagement section of a maven parent pom. The problem is that you need a local file to configure the per-message output levels (ignore/warning/error) when you really want to specify it in the build script or in a shared file. As an alternative to -Xlintfile, it would be handy to be able to change an Xlint warning level per message using command line options. For example: ajc -Xlint:adviceDidNotMatch=ignore would override the XlintDefault.properties file for the adviceDidNotMatch message. With Regards Rob

resolved fixed

b2cd5fa

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildConfig.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.matcher/src/org/aspectj/weaver/Lint.java", "testing/newsrc/org/aspectj/testing/CompileSpec.java", "tests/bugs174/pr419279/Code.java", "tests/src/org/aspectj/systemtest/ajc174/Ajc174Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 415266 LTW not working when JMX is enabled

When I enable JMX remote management on a JVM along with AspectJ load-time weaving (LTW), our Aspect doesn't appear to get woven in. This are the JVM arguments: -Dvisualvm.display.name=JdbcTimingAspectTest -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.port=1024 -javaagent:/jars/aspectjweaver.jar -Dorg.aspectj.weaver.loadtime.configuration=com/trgr/cobalt/infrastructure/instrumentation/aspects/timing/jdbc/jdbcmonitor.xml Note that if I don't enable JMX remote management (by remove the -Dcom.sun.management.jmxremote.* JVM arguments), the Aspect works fine.

resolved fixed

9e992d6

["loadtime/src/org/aspectj/weaver/loadtime/Aj.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 418129 Can't introduce annotation onto introduced method from trait-patterned aspect

resolved fixed

2393bef

["tests/bugs174/pr418129/Target.java", "tests/bugs174/pr418129/Target2.java", "tests/bugs174/pr418129/Target3.java", "tests/bugs174/pr418129/Target4.java", "tests/src/org/aspectj/systemtest/ajc174/Ajc174Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 368046 configure a set of classloader for which weavers should not be created in an LTW scenario

Prototyped and tested for JspClassLoaders (see the thread 'aspectj and jsp load' on the mailing list). That was done through a system property but it would be easier via aop.xml. However, this would be the first time we have an aop.xml setting that affects global operation of loadtime weaving. When any classloader actually got far enough to load the aop.xmls it would discover this setting and from that point on it would be set. In our JspClassLoader case this would mean that either some non-JspClassLoader is run early enough to discover this setting and turn it off for all JspClassLoaders or the first JspClassLoader will discover the setting and turn it off for all other JspClassLoaders. I think we can live with that mode of operation.

resolved fixed

0c0adc5

["loadtime/src/org/aspectj/weaver/loadtime/Aj.java", "loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java", "loadtime/src/org/aspectj/weaver/loadtime/Options.java", "tests/bugs174/pr368046/Azpect.java", "tests/bugs174/pr368046/Code.java", "tests/src/org/aspectj/systemtest/ajc174/Ajc174Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 413378 A constructor added by ITD cannot invoke the method of its super class

AspectJ Development Tools 2.2.0.e37x-RELEASE-20120704-0900 It seems *super.someMethod()* can not be correctly resolved in the constructor added by ITD It can be compiled with no problem, but* at runtime, exception is raised.* The class which I'll add a new constructor to: public class Child extends Parent{ public String mParent = "John"; public Child(String parent) { this.mParent = parent; } public String getParent() { return this.mParent; } } As we can see, *Child * extends *Parent* class Parent has a method getAge() public class Parent { private String mName = "John"; private int mAge = 50; public int getAge(){ return mAge; } } If I add a new constructor for the *Child * in my aspect. public aspect MyTest { public Child.new(String parent, int age) { this(parent); System.out.println("Get Age:" + super.getAge()); System.out.println("Child Name:" + this.mParent); } } The above aspect code will trigger an exception. Exception in thread "main" java.lang.NoSuchMethodError: com.test.Child.ajc$superDispatch$com_test_Child$getAge()I at MyTest.ajc$postInterConstructor$MyTest$com_test_Child(MyTest.aj:13) at com.test.Child.<init>(Child.java:1) at MainProgram.main(MainProgram.java:14) Is this a limitation of AspectJ? Is this the only way to resolve this issue? I also attach the src & compiled binary files

resolved fixed

302c14e

["tests/bugs174/pr413378/Code.java", "tests/src/org/aspectj/systemtest/AllTests17.java", "tests/src/org/aspectj/systemtest/ajc174/Ajc174Tests.java", "tests/src/org/aspectj/systemtest/ajc174/AllTestsAspectJ174.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 407017 Stack trace being printed, but want to mute it

In org.aspectj.ajdt.internal.core.builder.AjState.getDelegate(ReferenceType), there is a call to printStackTrace(). On the AJDT build server, this exception is being printed and causing some noise. Can you replace that call with a call to the IMessageHandler for the build?

resolved fixed

e6cb508

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjState.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 408721 java.util.ConcurrentModificationException when multiple threads enter the weaver

I am using AspectJ 1.7.1. Occasionally I see the following exception, which I believe is related to multiple threads initializing some internal state. java.util.ConcurrentModificationException: null at java.util.ArrayList$Itr.checkForComodification(Unknown Source) ~[na:1.7.0_11] at java.util.ArrayList$Itr.next(Unknown Source) ~[na:1.7.0_11] at org.aspectj.weaver.ReferenceType.findDerivativeType(ReferenceType.java:1122) ~[aspectjweaver.jar:1.7.1] at org.aspectj.weaver.TypeFactory.createParameterizedType(TypeFactory.java:44) ~[aspectjweaver.jar:1.7.1] at org.aspectj.weaver.ResolvedType.parameterize(ResolvedType.java:2479) ~[aspectjweaver.jar:1.7.1] at org.aspectj.weaver.ReferenceType.getDeclaredInterfaces(ReferenceType.java:673) ~[aspectjweaver.jar:1.7.1] at org.aspectj.weaver.ResolvedType.getDirectSupertypes(ResolvedType.java:82) ~[aspectjweaver.jar:1.7.1] at org.aspectj.weaver.patterns.TypePattern.matchesSubtypes(TypePattern.java:178) ~[aspectjweaver.jar:1.7.1] at org.aspectj.weaver.patterns.ExactTypePattern.matchesSubtypes(ExactTypePattern.java:74) ~[aspectjweaver.jar:1.7.1] at org.aspectj.weaver.patterns.TypePattern.matchesStatically(TypePattern.java:130) ~[aspectjweaver.jar:1.7.1] at org.aspectj.weaver.patterns.KindedPointcut.fastMatch(KindedPointcut.java:130) ~[aspectjweaver.jar:1.7.1] at org.aspectj.weaver.internal.tools.PointcutExpressionImpl.couldMatchJoinPointsInType(PointcutExpressionImpl.java:84) ~[aspectjweaver.jar:1.7.1] at org.springframework.aop.aspectj.AspectJExpressionPointcut.matches(AspectJExpressionPointcut.java:250) ~[spring-aop.jar:3.2.1.RELEASE] at org.springframework.aop.support.AopUtils.canApply(AopUtils.java:208) ~[spring-aop.jar:3.2.1.RELEASE] at org.springframework.aop.support.AopUtils.canApply(AopUtils.java:262) ~[spring-aop.jar:3.2.1.RELEASE] at org.springframework.aop.support.AopUtils.findAdvisorsThatCanApply(AopUtils.java:294) ~[spring-aop.jar:3.2.1.RELEASE] at org.springframework.aop.framework.autoproxy.AbstractAdvisorAutoProxyCreator.findAdvisorsThatCanApply(AbstractAdvisorAutoProxyCreator.java:118) ~[spring-aop.jar:3.2.1.RELEASE]

resolved fixed

3f6e166

["org.aspectj.matcher/src/org/aspectj/weaver/ReferenceType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 404600 Unhandled RuntimeException

I'm getting an unhandled RuntimeException from STS 3.2.0.RELEASE: java.lang.RuntimeException at org.aspectj.asm.AsmManager.sameType(AsmManager.java:897) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:711) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1033) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:514) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.queueForWeavin ... ndation-domain/src\/main\/java<com.scispike.foundation.domain.trait.persistence*PersistableAspect.aj%com.scispike.foundation.domain.trait.persistence) Andy Clement, this can be reproduced in our private foundation repo's dev branch at commit d879446f2bfd83b51bf711d2931f4b28ce8c1901. After clicking ok on the exception dialog, there is an error marker on the package statement with text: Internal compiler error: java.lang.RuntimeException: Exception whilst walking up from target com.scispike.foundation.domain.trait.persistence kind=(package declaration) hid=(=foundation-domain/src\/main\/java<com.scispike.foundation.domain.trait.persistence*PersistableAspect.aj%com.scispike.foundation.domain.trait.persistence) at org.aspectj.asm.AsmManager.sameType(AsmManager.java:897) If I do a Project\Clean..., the exception is not reproduced and everything compiles ok. Next edit repros the exception.

resolved fixed

ff0859d

["weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 404594 Assertion failed at ResolvedType.java:614

resolved fixed

4e34477

["org.aspectj.matcher/src/org/aspectj/weaver/ResolvedType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 318878 Pertarget aspect instantiation is not thread-safe

The way in which pertarget aspects compiled with ajc check if a given target already has an aspect is not thread safe. When two different threads trigger an advice on a target object for the first time at the same time, sometimes the aspect for that target gets created twice. The following code demonstrates the problem: The following pertarget aspect will add itself to a (synchronized) set in another class in it's constructor. aspect Pertarget pertarget(execution(void foo())) { public Pertarget() { Main.aspects.add(this); // Add this instance to the set in Main } before(): execution(void foo()) {} // Empty advice to trigger creation } This class creates 10000 target objects and has two separate threads call a method (that causes the aspect to be instantiated) on each object. The aspects add themselves to the "aspects" set and this set's size is printed when all threads have finished. import java.util.Collections; import java.util.IdentityHashMap; import java.util.Set; public class Main { public static Set aspects = Collections.synchronizedSet( Collections.newSetFromMap(new IdentityHashMap())); public static void main(String[] args) throws InterruptedException { for (int i = 0; i < 10000; ++i) { final Main m = new Main(); // Create a new target for the aspect Runnable r = new Runnable() { public void run() { m.foo(); } // This will trigger the advice }; Thread t1 = new Thread(r); Thread t2 = new Thread(r); t1.start(); t2.start(); t1.join(); t2.join(); } System.out.println(aspects.size()); // Should be 10000 } private void foo() {} } When compiled with ajc and run, the main method prints values over 10000 (something like 10030-10060 typically), which means that some target objects get multiple aspect instances. In my own application I sometimes also saw some threads accessing partially built aspect instances. This was quite rare however and I wasn't able to make a test case for it. The ajc version (the current stable) used was: AspectJ Compiler 1.6.8 (1.6.8 - Built: Friday Jan 8, 2010 at 21:53:37 GMT) - Eclipse Compiler 0.785_R33x, 3.3 The sun vm version was: Java(TM) SE Runtime Environment (build 1.6.0_20-b02) Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode) I investigated the source of this problem: the ajc compiler generates the following (decompiled) method into the aspect class: public static void ajc$perObjectBind(Object obj) { if((obj instanceof ajcMightHaveAspect) && ((ajcMightHaveAspect)obj).perObjectGet() == null) ((ajcMightHaveAspect)obj).perObjectSet(new Pertarget()); } , which obviously is not thread safe.

resolved fixed

be5a530

["org.aspectj.matcher/src/org/aspectj/weaver/AjcMemberMaker.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 391384 WildAnnotationTypePattern.java:231

OK, I get that this is not supported (and what I *want* here is matching on the existence of the supplied header *among* the headers in the String[]). A feature request might be in order, but a syntax for specifying how you want to match the array would be needed.... The bug that I'm reporting is that trying to *save* this program gets an error that pops up a dialog. This should just become another error marker. It might the compiler that has to change what it throws, but in the end it's the Eclipse IDE that ends up breaking from a user standpoint. (RequestMapping.headers() is of type String[]). public aspect Fail { pointcut testable(): execution(public * @RequestMapping(headers="x-test=test") com.example..*(..)); } java.lang.RuntimeException at org.aspectj.weaver.patterns.WildAnnotationTypePattern.resolveAnnotationValues(WildAnnotationTypePattern.java:231) at org.aspectj.weaver.patterns.WildAnnotationTypePattern.resolveBindings(WildAnnotationTypePattern.java:325) at org.aspectj.weaver.patterns.WildTypePattern.resolveBindings(WildTypePattern.java:657) at org.aspectj.weaver.patterns.SignaturePattern.resolveBindings(SignaturePattern.java:81) at org.a ... n(Worker.java:53) Compile error: RuntimeException thrown: Compiler limitation: annotation value support not implemented for type java.lang.String[]

resolved fixed

edb41e3

["org.aspectj.matcher/src/org/aspectj/weaver/WeaverMessages.java", "org.aspectj.matcher/src/org/aspectj/weaver/patterns/WildAnnotationTypePattern.java", "tests/bugs172/pr391384/Code.java", "tests/src/org/aspectj/systemtest/ajc172/Ajc172Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 394535 Java throws OutOfMemory in call to Class.getGenericSuperclass() on woven class

resolved fixed

46f9079

["org.aspectj.matcher/src/org/aspectj/weaver/TypeVariable.java", "tests/bugs172/pr394535/Bug.java", "tests/bugs172/pr394535/Bug2.java", "tests/src/org/aspectj/systemtest/ajc172/Ajc172Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 399590 Bad generics signature generated

resolved fixed

4af4b1e

["org.aspectj.matcher/src/org/aspectj/weaver/BoundedReferenceType.java", "tests/bugs172/pr399590/Cage.java", "tests/bugs172/pr399590/Cage2.java", "tests/bugs172/pr399590/five/Cage.java", "tests/bugs172/pr399590/five/Cage2.java", "tests/bugs172/pr399590/four/Cage.java", "tests/bugs172/pr399590/four/Cage2.java", "tests/bugs172/pr399590/three/Cage.java", "tests/bugs172/pr399590/three/Cage2.java", "tests/bugs172/pr399590/two/Cage.java", "tests/bugs172/pr399590/two/Cage2.java", "tests/src/org/aspectj/systemtest/ajc172/Ajc172Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 399408 NPE in ExactAnnotationTypePattern.matches

[ERROR] java.lang.NullPointerException [ERROR] at org.aspectj.weaver.patterns.ExactAnnotationTypePattern.matches(ExactAnnotationTypePattern.java:137) [ERROR] at org.aspectj.weaver.patterns.ExactAnnotationTypePattern.matches(ExactAnnotationTypePattern.java:96) [ERROR] at org.aspectj.weaver.patterns.AnyWithAnnotationTypePattern.matchesExactly(AnyWithAnnotationTypePattern.java:55) [ERROR] at org.aspectj.weaver.patterns.TypePattern.matchesStatically(TypePattern.java:132) [ERROR] at org.aspectj.weaver.patterns.DeclareParents.match(DeclareParents.java:63) [ERROR] at org.aspectj.weaver.patterns.DeclareParents.findMatchingNewParents(DeclareParents.java:358) [ERROR] at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.doDeclareParents(AjLookupEnvironment.java:885) [ERROR] at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.weaveInterTypeDeclarations(AjLookupEnvironment.java:766) [ERROR] at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.weaveIntertypes(AjLookupEnvironment.java:424) [ERROR] at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.weaveIntertypes(AjLookupEnvironment.java:410) [ERROR] at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.completeTypeBindings(AjLookupEnvironment.java:261)

resolved fixed

d524403

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseSourceType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 398588 Using aspect 'requires' clause causes all aspects with 'requires' clauses not be loaded regardless

The usage of the 'requires' clause causes all aspects that have have 'requires' clauses not to be loaded regardless of whether the specified required class exists or not. Here is the scenario and why it happens: Let's assume we have a bunch of aspects (A1, A2, A3, etc.) - all with 'requires' clauses and all referencing classes that can be satisfied. ClassLoaderWeavingAdaptor#registerAspects goes over the aspects in a Definition one by one. It reaches aspect A1 and detects that it has a 'requires' clause, and so it invokes BcelWorld#addAspectRequires. This causes the aspect A1 and its required class to be registered in an internal 'aspectRequiredTypes' map. Then the code calls BcelWeaver#addLibraryAspect with A1 as the argument, which in turn calls addOrReplaceAspect which invokes 'hasUnsatisfiedDependency'. The 'hasUnsatisfiedDependency' has been written to run only ONCE - i.e., it checks if it has already run, and if so then it does nothing. Otherwise, it removes from the 'aspectRequiredTypes' map all the types that can be resolved, thus leaving only those that cannot be resolved. In other words, it assumes that after having run (once !!!) any remaining type must be unsatified. Thus, when it is invoked with A1, being the 1st time, it resolves the required type by A1 and leaves the 'aspectRequiredTypes' map empty - but also marks that no further running is required. When the ClassLoaderWeavingAdaptor#registerAspects loop reaches A2, it call BcelWorld#addAspectRequires since A2 also declares a 'requires' clause. This causes A2 and its referenced class to be mapped in the 'aspectRequiredTypes' map. However, when BcelWeaver#addLibraryAspect is called with A2 and the code reaches 'hasUnsatisfiedDependency' - the code assumes that it has already run (which it has - with A1), so it does not check if indeed A2's referenced class can be satisfied (which we assume it can). In other words, all subsequent aspects (A2, A3, etc.) are declared as having unsatisified dependencies - which they don't. The (quick) bugfix seems rather simple: every time BcelWorld#addAspectRequires method is called, it should mark 'aspectRequiredTypesProcessed' as FALSE, in order to force a re-evaluation in case 'hasUnsatisfiedDependency' is called.

resolved fixed

96ebaae

["tests/bugs172/pr398588/Anno.java", "tests/bugs172/pr398588/Anno2.java", "tests/bugs172/pr398588/AspectA.java", "tests/bugs172/pr398588/AspectB.java", "tests/bugs172/pr398588/AspectC.java", "tests/bugs172/pr398588/AspectD.java", "tests/bugs172/pr398588/Blah.java", "tests/bugs172/pr398588/Code.java", "tests/bugs172/pr398588/Code2.java", "tests/src/org/aspectj/systemtest/ajc172/Ajc172Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 395221 weird error about unbound formals when mixing generics with annotation style

From the mailing list: I have following problem with following Aspect: @Aspect public class CounterAspect extends AbstractMoskitoAspect { @Around(value = "execution(* *(..)) && (@annotation(method))") public Object countMethod(ProceedingJoinPoint pjp, Count method) throws Throwable { return count(pjp, method.producerId(), method.subsystem(), method.category()); } @Around(value = "execution(* *(..)) && (@annotation(method))") public Object countByParameter(ProceedingJoinPoint pjp, CountByParameter method) throws Throwable { return countByParameter(pjp, method.producerId(), method.subsystem(), method.category()); } @Around(value = "execution(* *.*(..)) && (@within(clazz))") public Object countClass(ProceedingJoinPoint pjp, Count clazz) throws Throwable { return count(pjp, clazz.producerId(), clazz.subsystem(), clazz.category()); } private Object countByParameter(ProceedingJoinPoint pjp, String aProducerId, String aSubsystem, String aCategory) throws Throwable { .... It works. However, since I have two similar aspects that differ only in using some internal classes, I made my super class using generics: public class AbstractMoskitoAspect<S extends IStats> { @Aspect public class CounterAspect extends AbstractMoskitoAspect<CounterStats> { this breaks the build instantly with the very unhelpful error message: [ERROR] Failed to execute goal org.codehaus.mojo:aspectj-maven-plugin:1.4:compile (default) on project moskito-aop: Compiler errors: [ERROR] error at @Around(value = "execution(* *(..)) && (@annotation(method))") [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [ERROR] /Users/another/projects/moskito/moskito-aop/java/net/anotheria/moskito/aop/aspect/CounterAspect.java:24:0::0 the parameter pjp is not bound in [all branches of] pointcut [ERROR] error at @Around(value = "execution(* *(..)) && (@annotation(method))") [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [ERROR] /Users/another/projects/moskito/moskito-aop/java/net/anotheria/moskito/aop/aspect/CounterAspect.java:29:0::0 the parameter pjp is not bound in [all branches of] pointcut [ERROR] error at @Around(value = "execution(* *.*(..)) && (@within(clazz))") [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [ERROR] /Users/another/projects/moskito/moskito-aop/java/net/anotheria/moskito/aop/aspect/CounterAspect.java:34:0::0 the parameter pjp is not bound in [all branches of] pointcut what am i doing wrong here?

resolved fixed

3e5af0f

["org.aspectj.matcher/src/org/aspectj/weaver/patterns/AndPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 394234 Invalid StackMapTable generated in Java 7

When compiling for Java 7, AspectJ can compute an invalid StackMapTable. The verifier will throw a ClassNotFoundException when the generated class is loaded. Example: class Parent<T> {} class ChildA<T> extends Parent<T> {} class ChildB<T> extends Parent<T> {} public Object methodWithBadStackMapTable(boolean value) { return value ? new ChildA<String>() : new ChildB<String>(); } javap shows the computed StackMapTable to be: StackMapTable: number_of_entries = 2 frame_type = 15 /* same */ frame_type = 71 /* same_locals_1_stack_item */ stack = [ class "Parent<T>" ] when it should be: StackMapTable: number_of_entries = 2 frame_type = 15 /* same */ frame_type = 71 /* same_locals_1_stack_item */ stack = [ class Parent ]

resolved fixed

fc55431

["weaver/src/org/aspectj/weaver/bcel/asm/StackMapAdder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 391123 Added support for more cache backing(s)

closed fixed

df1823b

["build/src/org/aspectj/internal/tools/ant/taskdefs/Checklics.java", "util/src/org/aspectj/util/LangUtil.java", "weaver/src/org/aspectj/weaver/tools/cache/AbstractIndexedFileCacheBacking.java", "weaver/src/org/aspectj/weaver/tools/cache/AsynchronousFileCacheBacking.java", "weaver/src/org/aspectj/weaver/tools/cache/DefaultFileCacheBacking.java", "weaver/src/org/aspectj/weaver/tools/cache/FlatFileCacheBacking.java", "weaver/src/org/aspectj/weaver/tools/cache/ZippedFileCacheBacking.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/AbstractCacheBackingTestSupport.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/AsynchronousFileCacheBackingTestSupport.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/CacheTests.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/DefaultCacheKeyResolverTest.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/DefaultFileCacheBackingTest.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/FlatFileCacheBackingTest.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/SimpleClassCacheTest.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/WeavedClassCacheTest.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/ZippedFileCacheBackingTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 389967 Weaved aspects mechanism does not take into account modified classes

The current caching mechanism assumes that if the same class is encountered then its cached weaved version can be used. However, the mechanism uses only the (fully qualified) class name to identify the class and does not take into account the fact that the class bytes may have changed (e.g., the user re-compiled and re-deployed some changes to the same class).

resolved fixed

9a3cc2b

["loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java", "loadtime/src/org/aspectj/weaver/loadtime/WeavingURLClassLoader.java", "org.aspectj.matcher/src/org/aspectj/weaver/tools/GeneratedClassHandler.java", "util/src/org/aspectj/util/LangUtil.java", "weaver/src/org/aspectj/weaver/tools/WeavingAdaptor.java", "weaver/src/org/aspectj/weaver/tools/cache/CacheBacking.java", "weaver/src/org/aspectj/weaver/tools/cache/CacheStatistics.java", "weaver/src/org/aspectj/weaver/tools/cache/CachedClassEntry.java", "weaver/src/org/aspectj/weaver/tools/cache/CachedClassReference.java", "weaver/src/org/aspectj/weaver/tools/cache/DefaultCacheFactory.java", "weaver/src/org/aspectj/weaver/tools/cache/DefaultCacheKeyResolver.java", "weaver/src/org/aspectj/weaver/tools/cache/DefaultFileCacheBacking.java", "weaver/src/org/aspectj/weaver/tools/cache/GeneratedCachedClassHandler.java", "weaver/src/org/aspectj/weaver/tools/cache/WeavedClassCache.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/DefaultFileCacheBackingTest.java", "weaver/testsrc/org/aspectj/weaver/tools/cache/WeavedClassCacheTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 389456 NPE in EclipseTypeMunger.mungeNewMethod()

resolved fixed

b8ebdc3

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 389752 declare parents & @type not matching on annotation properties of enum types

NOTE: real project private git repo demonstrating bug has been shared with Andy Clement privately. I'm reporting bug as Andy requested with as much info as I feel I can. I have a case where 'declare parents' and 'declare @type' instructions are not being applied because their type patterns, which use annotations whose properties are of enumerated types, are not matching. Below find the relevant artifacts and their shapes. The lines in the aspect PersistableJpaAspect that are not matching as they should are the 'declare parents' and 'declare @type'. If I change the annotation properties to be of type String and change the type patterns to use string literals (see "matches" comments in annotation: StoreType.JPA => "JPA" and IdType.LONG => "LONG"), the matching works properly. enums: ====== public enum StoreType { MONGO, JDO, JPA; } ===== public enum IdType { LONG, STRING; } annotation: =========== public @interface Persistable { StoreType in() default StoreType.MONGO; // doesn't match // matches: String in() default "MONGO"; IdType id() default IdType.STRING; // doesn't match // matches: String id() default "STRING"; } aspect: ======= public abstract privileged aspect PersistableAspect { public interface I extends ....trait.interfaces.persistence.Persistable { long version(); void version(long version); } public interface L extends I { Long idLong(); void idLong(Long id); } public interface S extends I { String idString(); void idString(String id); } declare @type : I+ : @Configurable; // ... } ===== public privileged aspect PersistableJpaAspect extends PersistableAspect { public interface JL extends L { } public interface JS extends S { } declare parents : (@Persistable(id = IdType.LONG, in = StoreType.JPA) *) implements JL; declare parents : (@Persistable(id = IdType.STRING, in = StoreType.JPA) *) implements JS; declare @type : @Persistable(in="JPA") JL+ : @Entity; declare @type : @Persistable(in="JPA") JS+ : @Entity; // ... }

resolved fixed

0d69bd3

["org.aspectj.matcher/src/org/aspectj/weaver/EnumAnnotationValue.java", "org.aspectj.matcher/src/org/aspectj/weaver/StandardAnnotation.java", "org.aspectj.matcher/src/org/aspectj/weaver/patterns/WildAnnotationTypePattern.java", "tests/bugs172/pr389752/Code.java", "tests/bugs172/pr389752/Code2.java", "tests/bugs172/pr389752/Code3.java", "tests/src/org/aspectj/systemtest/ajc172/Ajc172Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 389750 Inconsistent classfile encountered: The undefined type parameter xxx is referenced from within yyy

With the declare parents pattern below, I'm getting this **runtime** error (compiler completes ok): Inconsistent classfile encountered: The undefined type parameter ID is referenced from within PersistableAspect If I remove the generics part of the interface declaration, the error goes away. Here's the pattern: interface: ========== package example.trait; // imports... public interface Persistable<ID extends Serializable> { Object getOid(); ID getId(); String getIdString(); long getVersion(); } annotation: =========== package example.anno; // imports... @Target(TYPE) @Retention(RUNTIME) @Trait public @interface Persistable { String in() default "MONGO"; StoreType inAsEnum() default StoreType.MONGO; String id() default "STRING"; IdType idAsEnum() default IdType.STRING; } aspect: ======= package example.aspect; // imports... public privileged aspect PersistableAspect { public interface I<ID extends Serializable> extends example.trait.Persistable<ID> { } public interface L extends I<Long> { } public interface S extends I<String> { } declare parents : (@Persistable(id="LONG") *) implements L; declare parents : (@Persistable(id="STRING") *) implements S; // remaining code is ITDs introducing vars & methods... }

resolved fixed

b9c7a19

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AstUtil.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeMethodDeclaration.java", "tests/bugs172/pr389750/Clazz.java", "tests/bugs172/pr389750/Clazz2.java", "tests/bugs172/pr389750/Clazz3.java", "tests/bugs172/pr389750/Clazz4.java", "tests/src/org/aspectj/systemtest/AllTests17.java", "tests/src/org/aspectj/systemtest/ajc172/Ajc172Tests.java", "tests/src/org/aspectj/systemtest/ajc172/AllTestsAspectJ172.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 388971 Double Synthetic attributes on some around advice members

Some of the support members in aspects were getting Synthetic attributes added twice (once when compiled, once when used as an aspect library). Some JVMs appear to flag this as a verify error. The fix is simply to check before adding to make sure the attribute isn't added twice.

resolved fixed

c2ff74f

["weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 384401 NPE when no pointcut in afterthrowing annotation style advice

From the mailing list: import org.aspectj.lang.JoinPoint; import org.aspectj.lang.annotation.AfterThrowing; import org.aspectj.lang.annotation.Aspect; @Aspect public class X { // @AfterThrowing(pointcut="execution(* *(..))",throwing = "e") @AfterThrowing(throwing = "e") public void bizLoggerWithException(JoinPoint thisJoinPoint,Throwable e) { // .....// do some stuff } } class BizLoggable {}

resolved fixed

55ebaa1

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/ValidateAtAspectJAnnotationsVisitor.java", "tests/bugs171/pr384401/X.java", "tests/src/org/aspectj/systemtest/ajc171/Ajc171Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 387444 Softening exception in try-with-resources

resolved fixed

76d695f

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/bugs171/pr387444/Code.java", "tests/bugs171/pr387444/Code2.java", "tests/src/org/aspectj/systemtest/ajc171/Ajc171Tests.java", "tests/src/org/aspectj/systemtest/ajc171/Ajc171Tests_need17jre.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 387718 RuntimeException when trying to compile broken code

java.lang.RuntimeException at org.aspectj.weaver.NameMangler.makeVisibilityName(NameMangler.java:297) at org.aspectj.weaver.NameMangler.interMethod(NameMangler.java:242) at org.aspectj.weaver.AjcMemberMaker.interMethod(AjcMemberMaker.java:538) at org.aspectj.ajdt.internal.compiler.problem.AjProblemReporter.methodMustOverride(AjProblemReporter.java:385) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(M ... dJob.java:241) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) Compile error: RuntimeException thrown: protected inter-types not allowed

resolved fixed

cbb6f5a

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 386049 Error "must implement abstract inter-type declaration" even though build is fine

verified fixed

7c6e936

["org.aspectj.matcher/src/org/aspectj/weaver/ResolvedType.java", "tests/bugs171/pr386049/de/scrum_master/galileo/filter/BasicFilter.java", "tests/bugs171/pr386049/de/scrum_master/galileo/filter/JsoupFilter.java", "tests/bugs171/pr387568/Code.java", "tests/src/org/aspectj/systemtest/ajc171/Ajc171Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 384398 Type Mismatch error when using inner classes contained in generic types within ITDs

Please see attached example project. I get the following (strange) compiler error: Type mismatch: cannot convert from A<T>.InnerA<> to A.InnerA BAspect.aj /AspectJInnerclassInGenericTypeBug/src/de/example line 12

resolved fixed

bf949d3

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "tests/bugs171/pr384398/A.java", "tests/bugs171/pr384398/B.java", "tests/bugs171/pr384398_2/A.java", "tests/bugs171/pr384398_2/B.java", "tests/src/org/aspectj/systemtest/AllTests17.java", "tests/src/org/aspectj/systemtest/ajc171/Ajc171Tests.java", "tests/src/org/aspectj/systemtest/ajc171/AllTestsAspectJ171.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 384189 make ajcore file creation optional

Although cores are useful, there may be situations where you are working around whatever they are reporting and are perhaps unable to pick up a later version of AJ that includes the fix. In these situations it might be helpful to make the creation of cores optional, through a sys prop.

resolved fixed

5d0e186

["org.aspectj.matcher/src/org/aspectj/weaver/Dump.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 382189 NPE in BcelTypeMunger.createBridgeMethod

Build Identifier: Since I updated to version AspectJ Development Tools 2.2.0.e37x-20120529-0900 I get during compile: java.lang.NullPointerException at org.aspectj.weaver.bcel.BcelTypeMunger.createBridgeMethod(BcelTypeMunger.java:1325) at org.aspectj.weaver.bcel.BcelTypeMunger.createAnyBridgeMethodsForCovariance(BcelTypeMunger.java:1272) at org.aspectj.weaver.bcel.BcelTypeMunger.mungeNewMethod(BcelTypeMunger.java:971) at org.aspectj.weaver.bcel.BcelTypeMunger.munge(BcelTypeMunger.java:108) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeave ... ) Before, I had AspectJ Development Tools 2.2.0.e37x-20120507-1400 and the same project compiled without that exception. Reproducible: Always

resolved fixed

a748303

["org.aspectj.matcher/src/org/aspectj/weaver/ResolvedType.java", "tests/bugs170/pr382189/covbug/A.java", "tests/bugs170/pr382189/covbug/B.java", "tests/bugs170/pr382189/covbug/SuperA.java", "tests/bugs170/pr382189/covbug/SuperB.java", "tests/bugs170/pr382189/covbug/cc/covbug/A.java", "tests/bugs170/pr382189/covbug/cc/covbug/B.java", "tests/bugs170/pr382189/covbug/cc/covbug/SuperA.java", "tests/bugs170/pr382189/covbug/cc/covbug/SuperB.java", "tests/bugs170/pr382189/covbug/pj/Foo.java", "tests/bugs170/pr382189/one/A.java", "tests/bugs170/pr382189/one/B.java", "tests/bugs170/pr382189/one/SuperA.java", "tests/bugs170/pr382189/one/SuperB.java", "tests/bugs170/pr382189/three/A.java", "tests/bugs170/pr382189/three/B.java", "tests/bugs170/pr382189/three/SuperA.java", "tests/bugs170/pr382189/three/SuperB.java", "tests/bugs170/pr382189/two/A.java", "tests/bugs170/pr382189/two/B.java", "tests/bugs170/pr382189/two/SuperA.java", "tests/bugs170/pr382189/two/SuperB.java", "tests/bugs170/pr382435/one/bug/A.java", "tests/bugs170/pr382435/two/bug/A.java", "tests/src/org/aspectj/systemtest/ajc170/Ajc170Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 382723 An package-level abstract generic privileged aspect, which extends an abstract generic aspect, gives a IlligalStateException on a method call in around advice

Build Identifier: AJDT Version: 2.1.3.e37x-20110628-1900 / AspectJ version: 1.6.12.20110613132200 / eclipse.buildId=M20120208-0800 around advice targetting a generic constructor call in a package visability generic privileged abstract apsect, which extends a abstract generic aspect gives a compiler error when in this around advice a method call is made to a method defined in the aspect, superaspect or abstract defined methods. This only affects around advice and only when the aspect is package-visible and privileged. Workaround: either make the aspect public or remove privileged. Compiler output: Compile error: IllegalStateException thrown: Use generic type, not parameterized type StackTrace: java.lang.IllegalStateException: Use generic type, not parameterized type at org.aspectj.weaver.ResolvedTypeMunger.<init>(ResolvedTypeMunger.java:72) at org.aspectj.weaver.PrivilegedAccessMunger.<init>(PrivilegedAccessMunger.java:31) at org.aspectj.weaver.CrosscuttingMembers.addPrivilegedAccesses(CrosscuttingMembers.java:232) at org.aspectj.weaver.ResolvedType.collectCrosscuttingMembers(ResolvedType.java:756) at org.aspectj.weaver.CrosscuttingMembersSet.addOrReplaceAspect(CrosscuttingMembersSet.java:89) at org.aspectj.weaver.CrosscuttingMembersSet.addOrReplaceAspect(CrosscuttingMembersSet.java:69) at org.aspectj.weaver.bcel.BcelWeaver.prepareForWeave(BcelWeaver.java:512) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.ensureWeaverInitialized(AjPipeliningCompilerAdapter.java:529) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:509) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.queueForWeaving(AjPipeliningCompilerAdapter.java:447) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.afterProcessing(AjPipeliningCompilerAdapter.java:432) at org.aspectj.ajdt.internal.compiler.CompilerAdapter.ajc$after$org_aspectj_ajdt_internal_compiler_CompilerAdapter$5$6b855184(CompilerAdapter.aj:98) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:652) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:392) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:1021) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:305) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.incrementalBuild(AjBuildManager.java:185) at org.aspectj.ajde.core.internal.AjdeCoreBuildManager.performBuild(AjdeCoreBuildManager.java:127) at org.aspectj.ajde.core.AjCompiler.build(AjCompiler.java:91) at org.eclipse.ajdt.core.builder.AJBuilder.build(AJBuilder.java:257) at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:728) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:199) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:239) at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:292) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:295) at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:351) at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:374) at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:143) at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:241) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) Session data: eclipse.buildId=M20120208-0800 java.version=1.6.0_22 java.vendor=Sun Microsystems Inc. BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=nl_NL Command-line arguments: -data C:\workspace\ -os win32 -ws win32 -arch x86_64 Reproducible: Always Steps to Reproduce: 1. In a empty AspectJ project create the file Foo.java: import java.util.LinkedList; public class Foo { public LinkedList bar() { new LinkedList(); return null; } } 2. Create the file FooAspect.aj containing: import java.util.AbstractList; import java.util.List; abstract aspect FooAspectParent<T extends List> { protected int getNumber(int k) { return -1*k; } } abstract privileged aspect FooAspect<T extends AbstractList> extends FooAspectParent<T> { pointcut pc(): call(T.new()); T around():pc() { //getNumber(1); //<-- method call to superAspect fails //method(); // <-- method call to abstract local defined method fails //localMethod(); //<-- method call to local private method fails Math.random(); //<-- works hashCode(); //<-- works return null; } private void localMethod(){} protected abstract T method(); } 3. Uncomment one or more of the three commentted functions calls in the around advice and the compiler will reproduce the error. (note: this example with List which is a generic object is just for illustration of hierachy, this problem occured on production code when doing the same with non-generic, but hierachal objects. This way was the easiest to issolate and reproduce the bug the fastest.)

resolved fixed

ba9d43c

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AccessForInlineVisitor.java", "tests/bugs170/pr382723/Foo.java", "tests/bugs170/pr382723/FooAspect.java", "tests/bugs170/pr382723/FooAspect2.java", "tests/bugs170/pr382723/FooAspect3.java", "tests/src/org/aspectj/systemtest/ajc170/Ajc170Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 376990 iajc does not support source compliance level 1.7

Build Identifier: Version: 3.7.2 Build id: M20120208-0800 I am using AspectJ 1.7.0.M1. I changed the examples build.xml to use a source compliance level of 1.7 and verbose=true as follows: <iajc destdir="${classes.dir}" verbose="true" source="1.7" argfiles="${list}" When I run this using 'ant bean' I get the following line: [iajc] ignored: -source 1.7 at E:\aspectj1.7\doc\examples\build.xml:136: I have tried running the compiler 'ajc' directly specifying -source 1.7 and that works. I am trying to use this on a large development project that uses AspectJ and has been migrated over to Java 7. The project uses ant to do builds so it is critical that iajc support 1.7. The project can't be built if any Java 7 features are used in the source files which defeats the whole purpose of moving to Java 7. Reproducible: Always Steps to Reproduce: 1.Change the examples build.xml to use a source compliance level of 1.7 and verbose=true as follows: <iajc destdir="${classes.dir}" verbose="true" source="1.7" argfiles="${list}" 2.Run using 'ant bean' I get the following line: [iajc] ignored: -source 1.7 at E:\aspectj1.7\doc\examples\build.xml:136:

resolved fixed

89c178f

["taskdefs/src/org/aspectj/tools/ant/taskdefs/AjcTask.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 376351 attribute problems with Java 7 compilation

From the mailing list, this goes wrong: ***R.java*** public class R{ public static void main(String[] args) {System.out.println(new R().getClass().getName());} } ***R1.java*** public class R1 extends R {} ***RAj.aj*** public aspect RAj { private ThreadLocal<Object> inAspect = new ThreadLocal<Object>(); pointcut createR() : execution(R.new()); Object around() : createR() { System.out.println("aspect:" + inAspect.get() + ":" + this); if (inAspect.get() != null) { return proceed(); } else { inAspect.set(this); return new R1(); } } } compile command: /cygdrive/c/Program\ Files/Java/aspectj-1.6.12/bin/ajc.bat -source 1.7 -outxml -outjar araj.jar -classpath "aspectjrt.jar;." RAj.aj run: /cygdrive/c/Program\ Files/Java/aspectj-1.6.12/bin/aj5.bat -classpath ".;./araj.jar" R errors: Apr 06, 2012 1:37:40 PM org.aspectj.weaver.tools.Jdk14Trace error SEVERE: register definition failed java.lang.RuntimeException: Problem processing attributes in RAj at org.aspectj.weaver.bcel.BcelObjectType.ensureAspectJAttributesUnpacked(BcelObjectType.java:385)

resolved fixed

be063b8

["tests/bugs170/pr376351/R.java", "tests/bugs170/pr376351/R1.java", "tests/bugs170/pr376351/RAj.java", "tests/src/org/aspectj/systemtest/ajc170/Ajc170Tests.java", "weaver/src/org/aspectj/weaver/bcel/asm/StackMapAdder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 376139 AspectJ throws Nullpointer after its IDE plugin update

Build Identifier: Version: Indigo Service Release 2 Build id: 20120216-1857 java.lang.NullPointerException at org.aspectj.org.eclipse.jdt.internal.compiler.ast.SwitchStatement.analyseCode(SwitchStatement.java:118) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.analyseCode(MethodDeclaration.java:104) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.internalAnalyseCode(TypeDeclaration.java:730) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.analyseC ... oBuildJob.run(AutoBuildJob.java:241) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) Compile error: NullPointerException thrown: null Reproducible: Always Steps to Reproduce: 1. After updating the eclipse plugin

resolved fixed

62fca9a

["tests/bugs170/pr376139/Code.java", "tests/src/org/aspectj/systemtest/ajc170/Ajc170Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 374964 Performance - improve pointcut expensiveness calculation

Build Identifier: 1.6.12 I'm able to reduce the AspectJ LTW startup overhead on the app I'm working on, from 95 seconds down to 47 seconds, just by switching the "expensiveness" of THIS_OR_TARGET and CALL in PointcutEvaluationExpenseComparator. It seems to make sense to me that THIS_OR_TARGET is more expensive since it requires type matching (under profiler ExactTypePattern.matchesInstanceof() is what shows up as very expensive), whereas CALL can evaluate very quickly in most cases since it just fails to match on method name. I'm not sure if this is specific to my particular usage, but cutting 50% of the LTW startup is a very nice improvement. If you think this change doesn't make sense for everyone, I can work on a patch that makes this configurable somehow. Thanks. Reproducible: Always

resolved fixed

f85631f

["org.aspectj.matcher/src/org/aspectj/weaver/patterns/PointcutEvaluationExpenseComparator.java", "tests/src/org/aspectj/systemtest/ajc170/Ajc170Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 374745 Performance regression in 1.6.12

resolved fixed

549d227

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "org.aspectj.matcher/src/org/aspectj/weaver/ReferenceType.java", "org.aspectj.matcher/src/org/aspectj/weaver/ResolvedType.java", "org.aspectj.matcher/src/org/aspectj/weaver/TypeFactory.java", "org.aspectj.matcher/src/org/aspectj/weaver/TypeVariableReferenceType.java", "org.aspectj.matcher/src/org/aspectj/weaver/UnresolvedType.java", "org.aspectj.matcher/src/org/aspectj/weaver/UnresolvedTypeVariableReferenceType.java", "org.aspectj.matcher/src/org/aspectj/weaver/World.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 373195 Memory leak in CompilationAndWeavingContext leading to PermGen OOME

Build Identifier: 1.6.11 The static contextMap in CompilationAndWeavingContext keeps strong references to Thread instances (which in turn strongly reference their contextClassLoader which prevents all kinds of stuff from unloading). In my particular use case I am running unit tests, each in their own WeavingURLClassLoader, but these ClassLoaders are never released, and running several unit tests at once leads to PermGen OutOfMemoryError. Using -XX:+HeapDumpOnOutOfMemory and analyzing the resulting heap dump in Eclipse Memory Analyzer points to CompilationAndWeavingContext.contextMap. I am able to work around this issue by executing the following at the end of each unit test to clear out this contextMap: CompilationAndWeavingContext.setMultiThreaded(false); CompilationAndWeavingContext.reset(); CompilationAndWeavingContext.setMultiThreaded(true); I am also able to resolve this issue (more satisfactorily) by patching CompilationAndWeavingContext and changing contextMap into a ThreadLocal. Reproducible: Always

resolved fixed

6defb4e

["bridge/src/org/aspectj/bridge/context/CompilationAndWeavingContext.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 371998 org.aspectj.weaver.BCException compiling @DeclareParents with value using "||"

Build Identifier: 20110916-0149 Using: import org.aspectj.lang.annotation.Aspect; import org.aspectj.lang.annotation.DeclareParents; @Aspect public class AspectTest { private interface X {} private static class XImpl {} @DeclareParents(value="java.lang.Runnable || java.util.concurrent.Callable", defaultImpl=XImpl.class) private X xImpl; } Throws: org.aspectj.weaver.BCException at org.aspectj.weaver.patterns.ExactTypePattern.resolveBindings(ExactTypePattern.java:312) at org.aspectj.weaver.patterns.OrTypePattern.resolveBindings(OrTypePattern.java:121) at org.aspectj.weaver.bcel.AtAjAttributes.handleDeclareParentsAnnotation(AtAjAttributes.java:746) at org.aspectj.weaver.bcel.AtAjAttributes.readAj5ClassAttributes(AtAjAttributes.java:384) at org.aspectj.weaver.bcel.BcelObjectType.ens ... \Program Files\Java\jre6\lib\ext\sunjce_provider.jar;C:\Users\xxx\software\eclipse-j2ee\\plugins/org.eclipse.equinox.launcher_1.2.0.v20110502.jar; Current workaround is to use multiple DeclareParents annotations on different variables. Reproducible: Always Steps to Reproduce: 1. Create new class given the code in the details. 2. Save and compile in Eclipse.

resolved fixed

f37c56e

["tests/bugs170/pr371998/AspectTest.java", "tests/src/org/aspectj/systemtest/ajc170/Ajc170Tests.java", "weaver/src/org/aspectj/weaver/bcel/AtAjAttributes.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 371684 type construction for signature makes mistakes with wildcards

If you have a type with multiple type params, like this: Foo<?,T> the signature is: LFoo<*TT;>; and the handling of * is not working in TypeFactory. If that signature is passed in it will actually build: Foo<?> having lost the second type parameter, this breaks code later that has expectations on the number of params. (e.g. ArrayIndexOutOfBoundsException when building parameterization map)

resolved fixed

89756cd

["org.aspectj.matcher/src/org/aspectj/weaver/TypeFactory.java", "tests/src/org/aspectj/systemtest/ajc170/Ajc170Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 362956 neo4j NPE

java.lang.NullPointerException at org.aspectj.weaver.patterns.ExactAnnotationTypePattern.matches(ExactAnnotationTypePattern.java:128) at org.aspectj.weaver.patterns.ExactAnnotationTypePattern.matches(ExactAnnotationTypePattern.java:96) at org.aspectj.weaver.patterns.AndAnnotationTypePattern.matches(AndAnnotationTypePattern.java:42) at org.aspectj.weaver.patterns.AnyWithAnnotationTypePattern.matchesExactly(AnyWithAnnotationTypePattern.java:55) at org.aspectj.weaver.patterns.TypePattern.matchesStatically(TypePattern.java:132) at org.aspectj.weaver.patterns.TypePattern.matches(TypePattern.java:146) at org.aspectj.weaver.patterns.SignaturePattern.couldEverMatch(SignaturePattern.java:999) at org.aspectj.weaver.patterns.DeclareAnnotation.couldEverMatch(DeclareAnnotation.java:483) at org.aspectj.weaver.bcel.BcelClassWeaver.getMatchingSubset(BcelClassWeaver.java:1065) at org.aspectj.weaver.bcel.BcelClassWeaver.weaveDeclareAtField(BcelClassWeaver.java:1301) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:445) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:100) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1687) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump(BcelWeaver.java:1631) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(BcelWeaver.java:1394) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1180) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:514) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.queueForWeaving(AjPipeliningCompilerAdapter.java:447) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.afterProcessing(AjPipeliningCompilerAdapter.java:432) at org.aspectj.ajdt.internal.compiler.CompilerAdapter.ajc$after$org_aspectj_ajdt_internal_compiler_CompilerAdapter$5$6b855184(CompilerAdapter.aj:98) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:652) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:392) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:1021) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:268) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:181) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:112) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:60) at org.aspectj.tools.ajc.Main.run(Main.java:371)

resolved fixed

942da06

["org.aspectj.matcher/src/org/aspectj/weaver/ReferenceType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 359332 NPE in AjBuildManager.java:528 after non-Java/AJ file was renamed

Build Identifier: Upon using Eclipse's "Rename Resource" dialog to rename my project's "src/main/resources/META-INF/spring/email.properties" file to "scheduler.properties" in the same directory, Eclipse displayed the "AspectJ Internal Compiler Error" dialog with this stack trace: java.io.FileNotFoundException at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.<init>(FileInputStream.java:120) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.copyResourcesFromFile(AjBuildManager.java:528) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.copyResourcesToDestination(AjBuildManager.java:466) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:363) ... e error: FileNotFoundException thrown: /Users/aswan/projects/foo/src/main/resources/META-INF/spring/email.properties (No such file or directory) Reproducible: Couldn't Reproduce Steps to Reproduce: N/A

resolved fixed

14a6eac

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 354947 Nullpointer-Exception while parsing definition file (aop.xml) in DocumentParser

Build Identifier: 20100617-1415 With an activated NullpointerException-Breakpoint i recently stumpled upon a thrown NPE in the DocumentParser.parse()-method (Line 106): public static Definition parse(final URL url) throws Exception { InputStream in = null; try { if (CACHE && parsedFiles.containsKey(url.toString())) { return parsedFiles.get(url.toString()); } Definition def=null; if(LIGHTPARSER){ def = SimpleAOPParser.parse(url); }else{ def = saxParsing(url); } if (CACHE && def.getAspectClassNames().size() > 0) { parsedFiles.put(url.toString(), def); } return def; } finally { try { in.close(); } catch (Throwable t) { } } } ... The parsing of the configuration file works fine, merely the InputStream seems not to be used anymore. Reproducible: Always

resolved fixed

e71e287

["weaver/src/org/aspectj/weaver/loadtime/definition/DocumentParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 353457 NPE when saving an aspect - Aspectj Internal Compiler Error

resolved fixed

0f506ab

["org.aspectj.matcher/src/org/aspectj/weaver/ShadowMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 354022 constructor inlining can fail for some groovy built code

The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but because it is in the bytecode it trips up the AspectJ code which inlines this() calls before weaving - since it gets into an infinite loop. For now, just keep track of ctors making the recursive call and so don't get trapped in the infinite loop.

resolved fixed

6ae463a

["weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 340806 Race condition in JavaLangTypeToResolvedTypeConverter (potentially exposed through Spring AOP)

resolved fixed

167b801

["weaver5/java5-src/org/aspectj/weaver/reflect/JavaLangTypeToResolvedTypeConverter.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 353349 NPE in deleteNewAndDup

java.lang.NullPointerException at org.aspectj.weaver.bcel.BcelShadow.deleteNewAndDup(BcelShadow.java:179) at org.aspectj.weaver.bcel.BcelShadow.prepareForMungers(BcelShadow.java:303) at org.aspectj.weaver.Shadow.implement(Shadow.java:543) at org.aspectj.weaver.bcel.BcelClassWeaver.implement(BcelClassWeaver.java:3147) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:490) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:100) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1687) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump(BcelWeaver.java:1631) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(BcelWeaver.java:1394) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1180) at org.aspectj.weaver.tools.WeavingAdaptor.getWovenBytes(WeavingAdaptor.java:467) at org.aspectj.weaver.tools.WeavingAdaptor.weaveClass(WeavingAdaptor.java:318) at org.aspectj.weaver.loadtime.Aj.preProcess(Aj.java:96)

resolved fixed

e8ef5bf

["weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 353100 Need to demote "warning ignoring duplicate definition" from warning to debug

Build Identifier: 1.6.11 This kind of problem can occur for complex class loader hierarchies, and since it is not really a problem, we should make it debug level message so as not to write log messages un-necessarily. Reproducible: Always Steps to Reproduce: 1. Create an application that has some weaved class loaders hierarchy - recommend some URLClassLoader derived ones 2. Add the same(!) JAR with only an aop.xml file to more than one loader along the hierarchy 3. Make the loader the default context thread loader and start running some code.

resolved fixed

c6fb752

["loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 352389 overweaving can attribute duplicate attributes, one of which will not deserialize correctly

When overweaving it is possible that a class will get a second WeaverState attribute. This second one will not be valid (it hasn't been correctly configured). This isn't normally a problem because the next thing that happens is that the class is defined to the VM. But if *another* weave step occurs, the malformed attribute will cause that weave to fail with this kind of message: bad WeaverState.Kind: -115 The solution is to avoid adding the duplicate when overweaving.

resolved fixed

8553b30

["weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 350855 overweaving misbehaving when subclassing WeavingURLClassLoader

Raised by the Spring Insight team, they observed that in a system where they are using a special classloader (subclassing weaving url classloader) they see it fail to weave an aspect if overweaving is on.

resolved fixed

2302e94

["weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 349764 Repeated output of ASPECTJ: aspectj.overweaving=true: overweaving switched ON

Build Identifier: 1.6.11 The message is repeated every time a new class loader is being use to load weaving configuration (using -Dorg.aspectj.tracing.factory=default). Since this value is a system (!) property there is no need to display its value more than once (or even check it more than once - it could be lazily initialized and cached...) Reproducible: Always Steps to Reproduce: 1. use -Dorg.aspectj.tracing.factory=default -Daspectj.overweaving=true properties 2. place some JAR that contains aop.xml with some aspects and weaving options where it can be loaded/visible from several class loaders 3. runt the application and check the STDOUT output

resolved fixed

bb2aea4

["org.aspectj.matcher/src/org/aspectj/weaver/World.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 349636 AspectJ reports "abort trouble" while instrumenting a class on startup

Build Identifier: 20110218-0911 java.lang.NullPointerException at org.aspectj.weaver.bcel.Utility.appendConversion(Utility.java:272) at org.aspectj.weaver.bcel.BcelVar.appendConvertableArrayLoad(BcelVar.java:81) at org.aspectj.weaver.bcel.BcelVar.createConvertableArrayLoad(BcelVar.java:101) at org.aspectj.weaver.bcel.BcelShadow.makeClosureClassAndReturnConstructor(BcelShadow.java:3066) at org.aspectj.weaver.bcel.BcelShadow.weaveAroundClosure(BcelShadow.java:2830) at org.aspectj.weaver.bcel.BcelAdvice.implementOn(BcelAdvice.java:342) at org.aspectj.weaver.Shadow.implementMungers(Shadow.java:630) at org.aspectj.weaver.Shadow.implement(Shadow.java:544) at org.aspectj.weaver.bcel.BcelClassWeaver.implement(BcelClassWeaver.java:3147) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:490) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:100) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1687) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump(BcelWeaver.java:1631) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(BcelWeaver.java:1394) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1180) at org.aspectj.weaver.tools.WeavingAdaptor.getWovenBytes(WeavingAdaptor.java:467) at org.aspectj.weaver.tools.WeavingAdaptor.weaveClass(WeavingAdaptor.java:318) at org.eclipse.equinox.weaving.aspectj.loadtime.OSGiWeavingAdaptor.weaveClass(Unknown Source) at org.eclipse.equinox.weaving.aspectj.AspectJWeavingService.preProcess(Unknown Source) at org.eclipse.equinox.weaving.adaptors.WeavingAdaptor.weaveClass(Unknown Source) at org.eclipse.equinox.weaving.hooks.WeavingHook.processClass(Unknown Source) at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.defineClass(ClasspathManager.java:575) at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findClassImpl(ClasspathManager.java:550) at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClassImpl(ClasspathManager.java:481) at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass_LockClassLoader(ClasspathManager.java:469) at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass(ClasspathManager.java:449) at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.findLocalClass(DefaultClassLoader.java:216) at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:393) at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:469) at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:422) at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:410) at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:107) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) at org.eclipse.osgi.internal.loader.BundleLoader.loadClass(BundleLoader.java:338) at org.eclipse.osgi.framework.internal.core.BundleHost.loadClass(BundleHost.java:232) at org.eclipse.osgi.framework.internal.core.AbstractBundle.loadClass(AbstractBundle.java:1197) at org.springframework.osgi.util.BundleDelegatingClassLoader.findClass(BundleDelegatingClassLoader.java:99) at org.springframework.osgi.util.BundleDelegatingClassLoader.loadClass(BundleDelegatingClassLoader.java:157) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) at org.springframework.util.ClassUtils.forName(ClassUtils.java:257) at org.springframework.beans.factory.support.AbstractBeanDefinition.resolveBeanClass(AbstractBeanDefinition.java:408) at org.springframework.beans.factory.support.AbstractBeanFactory.doResolveBeanClass(AbstractBeanFactory.java:1271) at org.springframework.beans.factory.support.AbstractBeanFactory.resolveBeanClass(AbstractBeanFactory.java:1242) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.predictBeanType(AbstractAutowireCapableBeanFactory.java:576) at org.springframework.beans.factory.support.AbstractBeanFactory.isFactoryBean(AbstractBeanFactory.java:1319) at org.springframework.beans.factory.support.DefaultListableBeanFactory.getBeanNamesForType(DefaultListableBeanFactory.java:315) at org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext.invokeBeanFactoryPostProcessors(AbstractDelegatedExecutionApplicationContext.java:391) at org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext.invokeBeanFactoryPostProcessors(AbstractDelegatedExecutionApplicationContext.java:364) at org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext$3.run(AbstractDelegatedExecutionApplicationContext.java:256) at org.springframework.osgi.util.internal.PrivilegedUtils.executeWithCustomTCCL(PrivilegedUtils.java:87) at org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext.startRefresh(AbstractDelegatedExecutionApplicationContext.java:222) at org.springframework.osgi.extender.internal.dependencies.startup.DependencyWaiterApplicationContextExecutor.stageOne(DependencyWaiterApplicationContextExecutor.java:225) at org.springframework.osgi.extender.internal.dependencies.startup.DependencyWaiterApplicationContextExecutor.refresh(DependencyWaiterApplicationContextExecutor.java:178) at org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext.refresh(AbstractDelegatedExecutionApplicationContext.java:159) at org.springframework.osgi.extender.internal.activator.LifecycleManager$1.run(LifecycleManager.java:223) at java.lang.Thread.run(Thread.java:662) Reproducible: Sometimes

resolved fixed

f7b1193

["weaver/src/org/aspectj/weaver/bcel/Utility.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 348979 world type map fixed/expendable problems

Discovered whilst working with Steve Ash on a build of a few projects that was consuming more than 2Gigs of heap. To recover memory Steve activated type demotion. This didn't appear to help much. This was due to Steve's projects using aspectpath. The aspectpath scanning to discover aspects was inadvertently making any types discovered on the aspectpath permanent types (not expendable) and they'd never be demoted/evicted. The types were all being made permanent in case they were an aspect but never being demoted if it turns out they were not. In a Roo petclinic I added spel as a dependency (on the aspectpath) and parsed a simple expression (just to further exaggerate the problem). This was leaving 213 types in the fixed area of the typemap. By correctly scanning aspectpath and demoting non-aspects this was reduced to 90.

resolved fixed

2edb246

["tests/multiIncremental/PR278496_10/base/com/Asp.java", "tests/multiIncremental/PR278496_10/base/com/Foo.java", "tests/multiIncremental/PR278496_11/base/com/Foo.java", "tests/multiIncremental/PR278496_11_a/base/com/Asp.java", "tests/multiIncremental/PR278496_11_a/base/com/Dibble.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 348488 "register definition failed" with NullPointerException

resolved fixed

95e70d2

["weaver/src/org/aspectj/weaver/bcel/AtAjAttributes.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 327134 Cant suppress raw types warning in a pointcut

Build Identifier: I20100608-0911 Generic type used in a pointcut and bound to target() or this() must omit actual type name and thus causes 'raw type must be parametrized' compiler warning. @SuppressAJWarning or @SuppressWarning annotations does not turn it off Reproducible: Always Steps to Reproduce: Code snippets: pointcut IVOListUpdate(IVOList list): && target(list) && call(void updateList(*)); public interface IVOList<T extends IValueObject> extends List<T>, Externalizable, Serializable { void updateList(List<T> newList); } public interface IValueObject extends Comparable<IValueObject>, Serializable { }

resolved fixed

199299c

["tests/bugs1612/pr327134/Code.java", "tests/src/org/aspectj/systemtest/ajc1612/Ajc1612Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 339974 NPE when accessing static class inside of an ITIT

This code: public class City { private String name; private Country country; } And separate file: public aspect TrafficCalculator { public static class City.TrafficCalculator { Function<City, Time> EXTREME = createExtremeTraffic(); Function<City, Time> BASIC = createBasicTraffic(); } private static Function<City, Time> createExtremeTraffic() { return null; } private static Function<City, Time> createBasicTraffic() { return null; } public static class Time { } } Try full build and the following exception: java.lang.NullPointerException at org.aspectj.ajdt.internal.compiler.ast.IntertypeMemberClassDeclaration.resolveOnType(IntertypeMemberClassDeclaration.java:238) at org.aspectj.ajdt.internal.compiler.ast.IntertypeMemberClassDeclaration.build(IntertypeMemberClassDeclaration.java:246) at org.aspectj.ajdt.internal.compiler.ast.AspectDeclaration.processIntertypeMemberTypes(AspectDeclaration.java:1039) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.processInterTypeMemberTypes(AjLookupEnvironment.java:523) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.completeTypeBindings(AjLookupEnvironment.java:197) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.internalBeginToCompile(Compiler.java:616) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:357) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:371) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:1021) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:305) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.incrementalBuild(AjBuildManager.java:185) at org.aspectj.ajde.core.internal.AjdeCoreBuildManager.performBuild(AjdeCoreBuildManager.java:127) at org.aspectj.ajde.core.AjCompiler.build(AjCompiler.java:91) at org.eclipse.ajdt.core.builder.AJBuilder.build(AJBuilder.java:257) at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:629) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:172) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:203) at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:255) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:258) at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:311) at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:343) at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:144) at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:242) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

resolved fixed

249f832

["tests/bugs1612/pr339974/City.java", "tests/bugs1612/pr339974/TrafficCalculator.java", "tests/bugs1612/pr342605/Code.java", "tests/src/org/aspectj/systemtest/ajc1612/Ajc1612Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 341446 java.lang.UnsupportedClassVersionError when running Java 1.5

resolved fixed

293a075

["org.aspectj.matcher/testdata/AnnotatedClass.java", "org.aspectj.matcher/testdata/MethodLevelAnnotation.java", "org.aspectj.matcher/testdata/SomeAnnotation.java", "org.aspectj.matcher/testsrc/org/aspectj/matcher/tools/CommonAdvancedPointcutExpressionTests.java", "org.aspectj.matcher/testsrc/testdata/AnnotatedClass.java", "org.aspectj.matcher/testsrc/testdata/MethodLevelAnnotation.java", "org.aspectj.matcher/testsrc/testdata/SomeAnnotation.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 340323 NPE when weaving java.lang.Object at org.aspectj.weaver.bcel.BcelTypeMunger.createAnyBridgeMethodsForCovariance(BcelTypeMunger.java:1251)

resolved fixed

a8e6797

["weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 339300 problem weaving anonymous inner (member owned) classes in scala library

Reported by Ramnivas. Due to the use of numerous $ chars in scala classnames, some of the AspectJ handling of inner classes breaks down. It should be possible to correctly use the available class attributes rather than mess around with attributes. A while back one use did contribute a change to enable scala weaving which tried to use the InnerClasses attribute before falling back on string chopping. However we have now hit another case. In the scenario we are dealing with the class scala.Predef$$anon$3 in the scala library (a 2.9.0-SNAPSHOT version). What we normally do here is in that type we discover the InnerClass attribute and refer to the outerclass index it holds. Unfortunately, due to it being an anonymous inner inside a method, the index is 0. So we fail to process the attribute and with string chopping come up with a stupid guessed name for the outer. The solution is to use the EnclosingMethod attribute in these situations. The EnclosingMethod attribute is an optional attribute. A class must have an EnclosingMethod attribute if and only if it is a local class or an anonymous class. A class may have no more than one EnclosingMethod attribute. The EnclosingMethod attribute includes a pointer to the containing outerclass (that had the method in which encloses this inner type).

resolved fixed

945402f

["weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 336997 IllegalStateException for generic ITD usage

java.lang.IllegalStateException: Can't answer binding questions prior to resolving at org.aspectj.weaver.TypeVariable.canBeBoundTo(TypeVariable.java:175) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:496) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:399) at org.aspectj.weaver.ResolvedType.checkLegalOverride(ResolvedType.java:1999) at org.aspectj.weaver.ResolvedType.clashesWithExistingMember(ResolvedType.java:1843) at org.aspectj.weaver.ResolvedType.addInterTypeMunger(ResolvedType.java:1699) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.weaveInterTypeDeclarations(AjLookupEnvironment.java:795) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.weaveInterTypeDeclarations(AjLookupEnvironment.java:652) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.createBinaryTypeFrom(AjLookupEnvironment.java:1398) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.createBinaryTypeFrom(LookupEnvironment.java:599) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.accept(Compiler.java:276) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:113) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.UnresolvedReferenceBinding.resolve(UnresolvedReferenceBinding.java:49) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.BinaryTypeBinding.resolveType(BinaryTypeBinding.java:99) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.getType(LookupEnvironment.java:971) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.lookupBinding(EclipseFactory.java:749) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.makeTypeBinding1(EclipseFactory.java:743) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.makeTypeBinding(EclipseFactory.java:605) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.addParent(AjLookupEnvironment.java:1314) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.doDeclareParents(AjLookupEnvironment.java:902) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.weaveInterTypeDeclarations(AjLookupEnvironment.java:730) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.weaveIntertypes(AjLookupEnvironment.java:418) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.completeTypeBindings(AjLookupEnvironment.java:255) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.internalBeginToCompile(Compiler.java:616) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:357) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:371) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:1021) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:268) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:181) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:112) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:60) at org.aspectj.tools.ajc.Main.run(Main.java:371) at org.aspectj.tools.ajc.Main.runMain(Main.java:248) at org.codehaus.mojo.aspectj.AbstractAjcCompiler.execute(AbstractAjcCompiler.java:360) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138) at org.apache.maven.cli.MavenCli.main(MavenCli.java:362) at org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375)

resolved fixed

80785bf

["org.aspectj.matcher/src/org/aspectj/weaver/TypeVariable.java", "org.aspectj.matcher/src/org/aspectj/weaver/TypeVariableReferenceType.java", "org.aspectj.matcher/src/org/aspectj/weaver/World.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 282379 [plan] spaces in file names causes AspectJ weaver to fail

The WeavingAdaptor requires the aspect path to be composed by URLs. The URL of a file is encoded, for example if it contains spaces they will be represented with %20. It then converts these file:// urls to simple string paths, and then tries to access files pointed by those paths. This is done inside the FileUtil.makeClasspath(URL[]) . This method uses URL.getPath() to obtain the path. But this method does not decode the string, it returns it as it is in the URL. When later this string is used to create a new File instance, that file contains an invalid path, and the weaver fails as follows : Caused by: org.aspectj.bridge.AbortException: bad aspect library: '/home/sym/path%20with%20space/aspect-library.jar' at org.aspectj.weaver.tools.WeavingAdaptor$WeavingAdaptorMessageHolder.handleMessage(WeavingAdaptor.java:624) at org.aspectj.bridge.MessageUtil.error(MessageUtil.java:80) at org.aspectj.weaver.tools.WeavingAdaptor.error(WeavingAdaptor.java:504) at org.aspectj.weaver.tools.WeavingAdaptor.addAspectLibrary(WeavingAdaptor.java:472) at org.aspectj.weaver.tools.WeavingAdaptor.registerAspectLibraries(WeavingAdaptor.java:447) at org.aspectj.weaver.tools.WeavingAdaptor.init(WeavingAdaptor.java:177) at org.aspectj.weaver.tools.WeavingAdaptor.<init>(WeavingAdaptor.java:112) This issue is quite important, because on older windows "Documents and Settings" is an unfortunately common path, for example Maven stores there its repository. Multiple solutions are possible for this simple bug, in order of impact : - Decode the string obtained by URL.getPath() using URLEncoder.decode() - Use Files instead of Strings and let Java handle the URL, using the File(URI) constructor - Don't assume that aspect libraries are files, and hence that urls are file url, and use URLConnection to fetch aspect library contents.

resolved fixed

5648105

["util/src/org/aspectj/util/FileUtil.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 324804 NullPointerException at AspectJElementHierarchy.java:677

Build Identifier: 20100617-1415 After removing a "throws" clause from the constructor of a class and then saving I got the following error: java.lang.NullPointerException at org.aspectj.asm.internal.AspectJElementHierarchy.getCanonicalFilePath(AspectJElementHierarchy.java:677) at org.aspectj.asm.internal.AspectJElementHierarchy.updateHandleMap(AspectJElementHierarchy.java:641) at org.aspectj.asm.AsmManager.removeStructureModelForFiles(AsmManager.java:572) at org.aspectj.asm.AsmManager.processDelta(AsmManager.java:604) at org.aspectj.ajdt.internal.core.builder.AjBuildManager ... oBuildJob.run(AutoBuildJob.java:242) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) Compile error: NullPointerException thrown: null Reproducible: Didn't try

resolved fixed

6249672

["asm/src/org/aspectj/asm/internal/AspectJElementHierarchy.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 324190 NullPointerException in AjBuildManager.findOutputDirsForAspects when compiling AspectJ project generated with Maven

Build Identifier: 20100617-1415 When I compile my AspectJ project, I get an AspectJ Internal Compiler Error. The stack trace is : java.lang.NullPointerException at org.aspectj.ajdt.internal.core.builder.AjBuildManager.findOutputDirsForAspects(AjBuildManager.java:725) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.writeOutxmlFile(AjBuildManager.java:652) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:367) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:181) at org.aspectj.a ... on$1.run(GlobalBuildAction.java:179) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) I digged a bit and looked into the classes. It would seem that AjState.getAspectNamesToFileNameMap() can return null in AjBuildManager.findOutputDirsForAspects. It is taken in account when AjBuildConfig.getCompilationResultDestinationManager() returns null or a list with one element, but not when it returns a list with several elements. Reproducible: Always Steps to Reproduce: Always happen in my configuration, but I didn't try to make it happen again in another workspace. Here are the steps I followed. 1. Generate a AspectJ project with Maven using the pom.xml I'll join 2. Create an aspect with a few pointcuts and a few advices 3. Compile (not with maven, the Eclipse compilation)

resolved fixed

03c43f5

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 318899 NPE with @args matching Argument by Type

resolved fixed

2a8d684

["org.aspectj.matcher/src/org/aspectj/weaver/reflect/ShadowMatchImpl.java", "org.aspectj.matcher/testsrc/org/aspectj/weaver/patterns/ThisOrTargetTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 324135 ArrayIndexOutOfBoundsException at AjState.java:1767

Build Identifier: 20100617-1415 Using AspectJ version: 1.6.10.20100817163700 I hit the blow exception after saving a edited java file. java.lang.ArrayIndexOutOfBoundsException at org.aspectj.ajdt.internal.core.builder.AjState.hasStructuralChanges(AjState.java:1767) at org.aspectj.ajdt.internal.core.builder.AjState.recordClassFile(AjState.java:1510) at org.aspectj.ajdt.internal.core.builder.AjState.noteResult(AjState.java:1322) at org.aspectj.ajdt.internal.core.builder.AjBuildManager$3.acceptResult(AjBuildManager.java:1049) at org.aspectj.ajdt.internal.compiler.AjPipeli ... b.run(AutoBuildJob.java:242) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) Compile error: ArrayIndexOutOfBoundsException thrown: 14 Reproducible: Didn't try

resolved fixed

88fab6a

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjState.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 320468 ModifiersPattern.getModifierFlag() is not thread safe

Build Identifier: org.aspectj.weaver_1.6.0.20080423100000.jar ModifiersPattern.getModifierFlag() is a non-synchronized static method using the static Map modifierFlags. This can lead to a ConcurrentModificationException when this code is executed in a multi-threaded environment. A stack trace showing the erroneous behavior is appended at the end of this bug report. In our case multithreading is introduced by using Spring DM. This leads to many application contexts being initialized in parallel. Each of them can contain pointcut expression, which are processed in independent threads. Spring AOP enters the "AspectJ world" calling PointcutParser.parsePointcutExpression(). Since there is no guarantee that a ConcurrentModificationException is thrown it is also possible that concurrent read/write accesses to the modifierFlags map are not recognized and incorrect values are used. org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'sessionFactoryProxy': Post-processing of the FactoryBean's object failed; nested exception is java.util.ConcurrentModificationException: concurrent access to HashMap attempted by Thread[SpringOsgiExtenderThread-43,5,spring-osgi-extender[6dee6dee]-threads] at org.springframework.beans.factory.support.FactoryBeanRegistrySupport$1.run(FactoryBeanRegistrySupport.java:142) at java.security.AccessController.doPrivileged(AccessController.java:219) at org.springframework.beans.factory.support.FactoryBeanRegistrySupport.doGetObjectFromFactoryBean(FactoryBeanRegistrySupport.java:116) at org.springframework.beans.factory.support.FactoryBeanRegistrySupport.getObjectFromFactoryBean(FactoryBeanRegistrySupport.java:91) at org.springframework.beans.factory.support.AbstractBeanFactory.getObjectForBeanInstance(AbstractBeanFactory.java:1288) at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:217) at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:185) at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:164) at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:425) at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:728) at org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext.access$1600(AbstractDelegatedExecutionApplicationContext.java:69) at org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext$4.run(AbstractDelegatedExecutionApplicationContext.java:355) at org.springframework.osgi.util.internal.PrivilegedUtils.executeWithCustomTCCL(PrivilegedUtils.java:85) at org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext.completeRefresh(AbstractDelegatedExecutionApplicationContext.java:320) at org.springframework.osgi.extender.internal.dependencies.startup.DependencyWaiterApplicationContextExecutor$CompleteRefreshTask.run(DependencyWaiterApplicationContextExecutor.java:136) at java.lang.Thread.run(Thread.java:811) Caused by: java.util.ConcurrentModificationException: concurrent access to HashMap attempted by Thread[SpringOsgiExtenderThread-43,5,spring-osgi-extender[6dee6dee]-threads] at java.util.HashMap.onEntry(HashMap.java:214) at java.util.HashMap.transfer(HashMap.java:686) at java.util.HashMap.resize(HashMap.java:676) at java.util.HashMap.addEntry(HashMap.java:1049) at java.util.HashMap.put(HashMap.java:561) at org.aspectj.weaver.patterns.ModifiersPattern.getModifierFlag(ModifiersPattern.java:87) at org.aspectj.weaver.patterns.PatternParser.parseModifiersPattern(PatternParser.java:1169) at org.aspectj.weaver.patterns.PatternParser.parseMethodOrConstructorSignaturePattern(PatternParser.java:1248) at org.aspectj.weaver.patterns.PatternParser.parseKindedPointcut(PatternParser.java:603) at org.aspectj.weaver.patterns.PatternParser.parseSinglePointcut(PatternParser.java:317) at org.aspectj.weaver.patterns.PatternParser.parseAtomicPointcut(PatternParser.java:295) at org.aspectj.weaver.patterns.PatternParser.parsePointcut(PatternParser.java:256) at org.aspectj.weaver.tools.PointcutParser.resolvePointcutExpression(PointcutParser.java:328) at org.aspectj.weaver.tools.PointcutParser.parsePointcutExpression(PointcutParser.java:309) at org.springframework.aop.aspectj.AspectJExpressionPointcut.buildPointcutExpression(AspectJExpressionPointcut.java:206) at org.springframework.aop.aspectj.AspectJExpressionPointcut.checkReadyToMatch(AspectJExpressionPointcut.java:193) at org.springframework.aop.aspectj.AspectJExpressionPointcut.getClassFilter(AspectJExpressionPointcut.java:174) at org.springframework.aop.support.AopUtils.canApply(AopUtils.java:195) at org.springframework.aop.support.AopUtils.canApply(AopUtils.java:250) at org.springframework.aop.support.AopUtils.findAdvisorsThatCanApply(AopUtils.java:284) at org.springframework.aop.framework.autoproxy.AbstractAdvisorAutoProxyCreator.findAdvisorsThatCanApply(AbstractAdvisorAutoProxyCreator.java:113) at org.springframework.aop.framework.autoproxy.AbstractAdvisorAutoProxyCreator.findEligibleAdvisors(AbstractAdvisorAutoProxyCreator.java:85) at org.springframework.aop.framework.autoproxy.AbstractAdvisorAutoProxyCreator.getAdvicesAndAdvisorsForBean(AbstractAdvisorAutoProxyCreator.java:66) at org.springframework.aop.framework.autoproxy.AbstractAutoProxyCreator.wrapIfNecessary(AbstractAutoProxyCreator.java:362) at org.springframework.aop.framework.autoproxy.AbstractAutoProxyCreator.postProcessAfterInitialization(AbstractAutoProxyCreator.java:325) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsAfterInitialization(AbstractAutowireCapableBeanFactory.java:361) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.postProcessObjectFromFactoryBean(AbstractAutowireCapableBeanFactory.java:1429) at org.springframework.beans.factory.support.FactoryBeanRegistrySupport$1.run(FactoryBeanRegistrySupport.java:139) ... 15 more Reproducible: Sometimes

resolved fixed

e0e1330

["org.aspectj.matcher/src/org/aspectj/weaver/patterns/ModifiersPattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 323634 NPE parameterizing perclause

java.lang.NullPointerException at org.aspectj.weaver.ReferenceType.getPerClause(ReferenceType.java:823) at org.aspectj.weaver.patterns.PerFromSuper.lookupConcretePerClause(PerFromSuper.java:82) at org.aspectj.weaver.patterns.PerFromSuper.concretize(PerFromSuper.java:61) at org.aspectj.weaver.CrosscuttingMembers.setPerClause(CrosscuttingMembers.java:512) at org.aspectj.weaver.ResolvedType.collectCrosscuttingMembers(ResolvedType.java:748) ... oBuildJob.run(AutoBuildJob.java:242) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

resolved fixed

ce16a06

["org.aspectj.matcher/src/org/aspectj/weaver/ReferenceType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 323417 Sometimes StackOverflow is got while weaving

Build Identifier: 1.6.10 While weaving LifeRay 6.0.5 over tomcat 6.0.26 sometimes the next exceptions appear: java.lang.StackOverflowError at java.lang.String.indexOf(String.java:1521) at org.aspectj.weaver.TypeFactory.createTypeFromSignature(TypeFactory.java:199) at org.aspectj.weaver.UnresolvedType.forSignature(UnresolvedType.java:375) at org.aspectj.weaver.UnresolvedType.getRawType(UnresolvedType.java:533) at org.aspectj.weaver.ResolvedType.getRawType(ResolvedType.java:2400) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:430) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:399) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:430) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:399) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:430) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:399) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:430) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:399) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:430) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:399) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:430) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:399) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:430) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:399) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:430) at org.aspectj.weaver.ReferenceType.isAssignableFrom(ReferenceType.java:399) ... Reproducible: Sometimes

resolved fixed

f631ad6

["org.aspectj.matcher/src/org/aspectj/weaver/World.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 322039 Fully qualified ITD has incorrect handle identifier

In the following aspect: public aspect Aspect { public void q2.ThisClass.something2() {} } In aspectJ, the ITD has the following handle identifier (notice that the ITD name is not fully qualified): =AspectJ Project/src2<p*Aspect.aj'Aspect)ThisClass.something2 However, it should be (with fully qualified name): =AspectJ Project/src2<p*Aspect.aj'Aspect)q2.ThisClass.something2 This means that fully qualified ITDs cannot be navigated to or searched. I'm a little surprised that this doesn't work because I thought I had tests for it...

resolved fixed

6b35ea4

["tests/multiIncremental/pr322039/base/src/p/Azpect.java", "tests/multiIncremental/pr322039/base/src/q2/Code.java", "tests/src/org/aspectj/systemtest/incremental/tools/MultiProjectIncrementalTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 322832 early field resolution leading to problems for ITDs when declare parents in use

I have a type that is being used where a generic is being expected. That generic specifies an upper bound. The type only obeys the upper bound once a declare parents has applied to it. I have an intertype declaration (a field). When the ITD is applied we do some work to see if it clashes with existing fields. This causes existing fields to be resolved. If this resolution triggers a bounds check for the declare parents affected type before the declare parents has applied, a problem will be raised. Basically if the target of the declare is processed before the intertype then we are ok, but that is luck based. We should do the declare parents first (and declare annotation) and then do intertype declarations (since they may trigger this extra resolution).

resolved fixed

16adee6

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 321641 No way to exclude Proxool classes although excluded from AOP. Causing Veryfy error.

Build Identifier: 20100218-1602 For aspectJ 1.6.7 the setup works, however exactly the same setup but changing the aspectJ version to 1.6.8 or 1.6.9 derive to the same error: a piece of code excluded from the aop.xml is woven causing a Verify Error. We are using Proxool, proxy setup which in fact uses CGLIB to create a EnhancerProxy class. In order to avoid VerifyError exceptions the Proxool classes are excluded from aop.xml exactly in the same way the CGLIB workarround is commented in the aspectJ FAQ: <exclude within="*..*Proxool*"/> This is the error we got when we upgrade our 1.6.7 aspejctweaver.jar to 1.6.8. The same is got when using 1.6.9: jvm 3 | 2010/08/03 16:42:53 | java.lang.VerifyError: (class: oracle/jdbc/internal/OracleConnection$$EnhancerByProxool$$7f6320a8, method: getTdoCState signature: (Ljava/lang/String;Ljava/lang/String;)J) Inconsistent stack height 1 != 0 jvm 3 | 2010/08/03 16:42:53 | at java.lang.Class.getDeclaredMethods0(Native Method) jvm 3 | 2010/08/03 16:42:53 | at java.lang.Class.privateGetDeclaredMethods(Class.java:2427) jvm 3 | 2010/08/03 16:42:53 | at java.lang.Class.getDeclaredMethod(Class.java:1935) jvm 3 | 2010/08/03 16:42:53 | at org.logicalcobwebs.cglib.proxy.Enhancer.getCallbacksSetter(Enhancer.java:627) jvm 3 | 2010/08/03 16:42:53 | at org.logicalcobwebs.cglib.proxy.Enhancer.setCallbacksHelper(Enhancer.java:615) jvm 3 | 2010/08/03 16:42:53 | at org.logicalcobwebs.cglib.proxy.Enhancer.setThreadCallbacks(Enhancer.java:609) jvm 3 | 2010/08/03 16:42:53 | at org.logicalcobwebs.cglib.proxy.Enhancer.createUsingReflection(Enhancer.java:631) jvm 3 | 2010/08/03 16:42:53 | at org.logicalcobwebs.cglib.proxy.Enhancer.firstInstance(Enhancer.java:538) jvm 3 | 2010/08/03 16:42:53 | at org.logicalcobwebs.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:225) jvm 3 | 2010/08/03 16:42:53 | at org.logicalcobwebs.cglib.proxy.Enhancer.createHelper(Enhancer.java:377) jvm 3 | 2010/08/03 16:42:53 | at org.logicalcobwebs.cglib.proxy.Enhancer.create(Enhancer.java:285) .... As far as the Verify Error is got while deploying one of the applications that run on the serve we are no able to use the new versions of aspectJ because the application is not properly started up. Thank you very much in advance, Best regards. Reproducible: Always Steps to Reproduce: 1.Exclude Proxool classes from aop.xml using aspectj 1.6.7. It works 2.Upgrade to 1.6.8: it does not work. 3.Upgrade to 1.6.9: it does not work.

resolved fixed

85fd25d

["loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java", "loadtime/testsrc/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptorTest.java", "loadtime/testsrc/testdata/MessageService$$EnhancerByCGLIB$$6dd4e683.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 318397 Caching in EclipseSourceType is too aggressive

In fixing a recent Roo related issue (where annotations are resolved too early, before declare parents are done) a cache was introduced into EclipseSourceType (see ensureAnnotationTypesResolved()). The cache needs to be cleared if the set of annotation declarations changes - this can occur even after parsing because declare annotation can change them.

resolved fixed

fe049ea

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseSourceType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 317743 import handling and type lookup issues

Raised by Peter Melnikov on the mailing list. Two problems: 1) the binding scope being used for annotation style aspects accumulates lots of duplicate import prefixes in the SimpleScope object. 2) SimpleScope.lookupType tries the prefixes even if the type is already fully qualified. The combination of these issues causes a terrible mess. Lots of class lookup failures. Since the type cannot be 'partially qualified' it is silly to use the prefixes if the type is fully qualified.

resolved fixed

767bb85

["org.aspectj.matcher/src/org/aspectj/weaver/BindingScope.java", "org.aspectj.matcher/src/org/aspectj/weaver/patterns/IScope.java", "org.aspectj.matcher/src/org/aspectj/weaver/patterns/SimpleScope.java", "org.aspectj.matcher/src/org/aspectj/weaver/patterns/WildTypePattern.java", "org.aspectj.matcher/testsrc/org/aspectj/weaver/patterns/PatternsTests.java", "org.aspectj.matcher/testsrc/org/aspectj/weaver/patterns/SimpleScopeTests.java", "org.aspectj.matcher/testsrc/org/aspectj/weaver/patterns/TypePatternTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 317139 NullPointerException during weaving

resolved fixed

92a52a2

["weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 314766 NPE when using aop.xml for compile time config

Reported on the list: java.lang.NullPointerException at org.aspectj.weaver.bcel.BcelWorld.isAspectIncluded(BcelWorld.java:942) at org.aspectj.weaver.ShadowMunger.match(ShadowMunger.java:80) at org.aspectj.weaver.Advice.match(Advice.java:106) at org.aspectj.weaver.bcel.BcelAdvice.match(BcelAdvice.java:149) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:3108) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:2562)

resolved fixed

0e5ecd3

["org.aspectj.matcher/src/org/aspectj/weaver/Advice.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 314130 [plan] [ltw] [hcr] LTW, Reweaving and Hot Code Replace changes reflected every two saves of files

resolved fixed

cf0ee0c

["weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java", "weaver/src/org/aspectj/weaver/tools/WeavingAdaptor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 314365 pointcut rewriter can have issues for large hashcode values

AJDT uses a pointcut like this: (persingleton(org.eclipse.ajdt.internal.ui.ras.UIFFDC) && ((handler(java.lang.Throwable+) && args(arg1)) && ((within(org.eclipse.ajdt..*) && (!within(org.eclipse.ajdt.internal.ui.lazystart..*) && (!within(org.eclipse.ajdt.internal.ui.dialogs.OpenTypeSelectionDialog2) && !(within(org.eclipse.ajdt.internal.ui.editor.AspectJBreakpointRulerAction) && handler(org.eclipse.jface.text.BadLocationException))))) && (!(within(org.eclipse.ajdt.core.ras.FFDC+) || handler(org.eclipse.core.runtime.OperationCanceledException)) && !this(java.lang.Object))))) After the pointcut rewriter has chewed on it, it is reduced to a normal form. This is meant to be a stable form such that further rewrites of it would not change it. This turned out not to be the case. The hashcodes for some of the components were quite large and manifested as negative integers. The arithmetic in the comparator for the elements would have a problem and give unhelpful responses. For example, if the elements were C,B,A it might rewrite them to A,B,C but on a subsequent rewrite it would realise that C was less than A, giving B,C,A. Whether it went wrong was dependent on the order in which the elements were collected by the rewriter. This is now fixed. It impacts incremental compilation sometimes as two pointcuts that should be identical look different because one has been through the rewritter more times than the other...

resolved fixed

1e28b92

["org.aspectj.matcher/src/org/aspectj/weaver/patterns/PointcutEvaluationExpenseComparator.java", "org.aspectj.matcher/testsrc/org/aspectj/weaver/patterns/PointcutRewriterTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 311910 AspectJ internal Compiler Error

Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.

resolved fixed

3be69a2

["weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 310144 java.lang.RuntimeException at AsmManager.java:1143

Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse

resolved fixed

728ecb8

["asm/src/org/aspectj/asm/AsmManager.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 310704 Bug in ProgramElement.getCorrespondingType()

Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'

resolved fixed

a502da8

["asm/src/org/aspectj/asm/internal/ProgramElement.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 309402 Changes to Main.java

In order to get the AJDT ant integration working, we need a small change to Main.java. We need to be able to pass in a custom org.aspectj.bridge.ICommand object. Currently, the ICommand object is created via reflection. Here is my suggestion: 1. augment the ICommand local variable to being a field 2. add a setter for this field 3. change this: ICommand command = ReflectionFactory.makeCommand(commandName, holder); to this: if (command != null) command = ReflectionFactory.makeCommand(commandName, holder);

verified fixed

b21eb05

["org.aspectj.ajdt.core/src/org/aspectj/tools/ajc/Main.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 308386 NPE when hasfield evaluating with annotations and there is an unresolved import

hasfield/hasmethod can cause early matching - before the weaving process kicks in properly. For a 'normal' compile error, like an unresolvable import, the error is put out before the weaving process kicks off. However hasfield/hasmethod happening early causes an NPE to occur before the error is put out. A guard for the NPE (which occurs in EclipseResolvedMember.getAnnotationTypes()) addresses this problem and allows the real error to come out.

resolved fixed

94d0a4e

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseResolvedMember.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 291206 Allow declare error & declare warning to support type expressions

resolved fixed

9241e2e

["tests/bugs169/pr291206/One.java", "tests/bugs169/pr291206/Three.java", "tests/bugs169/pr291206/Two.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 308093 incremental build problem when mixing up ITDs and declare parents

reported by Rod Johnson. He had a sophisticated aspect doing a mix of ITDs and declare parents. On doing an incremental build he was receiving errors that looked like the declare parents hadn't applied on the secondary build. What was actually happening is that when a class file was brought in as a BinaryTypeBinding, the existing World representation wasn't being cleaned up properly. Without the cleanup the declare parents thought it was still in effect, but it was not. With proper cleanup the declare parents applies on the secondary build and all is well. Change is in AjLookupEnviroment.weaveInterTypeDeclarations where the onType.clearInterTypeMungers() must be paired with an onType.ensureConsistent() call.

resolved fixed

4b43dc6

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 305788 Exception was thrown when I saved a file in Eclipse

Build Identifier: SpringSource STS 2.3.1 java.util.ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) at java.util.HashMap$KeyIterator.next(HashMap.java:828) at org.aspectj.asm.internal.AspectJElementHierarchy.updateHandleMap(AspectJElementHierarchy.java:594) at org.aspectj.asm.AsmManager.removeStructureModelForFiles(AsmManager.java:564) at org.aspectj.asm.AsmManager.processDelta(AsmManager.java:639) at org.aspectj.ajdt.internal.core ... un(AutoBuildJob.java:238) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55) Compile error: ConcurrentModificationException thrown: null Reproducible: Always Steps to Reproduce: 1.Generate an abstract class using Spring roo 2. Edit that file within Eclipse/STS to add JPA annotations 3.Click on the save icon to save the file - Exceptions box pops up

resolved fixed

749078d

["asm/src/org/aspectj/asm/internal/AspectJElementHierarchy.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 298786 suspected problem with handling of multiple aop.xml files

resolved fixed

a968890

["loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 297013 Unclosed stream in AjAttribute

resolved fixed

28fb861

["org.aspectj.matcher/src/org/aspectj/weaver/AjAttribute.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 120375 Support Load-Time Weaving and HotSwap

resolved fixed

19355dd

["loadtime5/java5-src/org/aspectj/weaver/loadtime/ClassPreProcessorAgentAdapter.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 293457 NPE on multiple declare @methods

resolved fixed

dc53b77

["tests/bugs167/pr293457/org/springmodules/cache/annotations/Cacheable.java", "tests/src/org/aspectj/systemtest/ajc167/Ajc167Tests.java", "tests/src/org/aspectj/systemtest/ajc167/IntertypeTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 293351 RuntimeException weaving roo app with advice based on execution pointcut

java.lang.RuntimeException at org.aspectj.weaver.ResolvedType.getAnnotations(ResolvedType.java:718) at org.aspectj.weaver.AbstractAnnotationAJ.retrieveAnnotationOnAnnotation(AbstractAnnotationAJ.java:123) at org.aspectj.weaver.AbstractAnnotationAJ.ensureAtTargetInitialized(AbstractAnnotationAJ.java:85) at org.aspectj.weaver.AbstractAnnotationAJ.specifiesTarget(AbstractAnnotationAJ.java:115) at org.aspectj.weaver.bcel.BcelWeaver.verifyTa ... .eclipse.core.internal.jobs.Worker.run(Worker.java:55) Compile error: RuntimeException thrown: ResolvedType.getAnnotations() should never be called

resolved fixed

a23c7e4

["org.aspectj.matcher/src/org/aspectj/weaver/MissingResolvedTypeWithKnownSignature.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 279298 AspectJ LTW with Cobertura

resolved fixed

35a9649

["weaver/src/org/aspectj/weaver/bcel/AtAjAttributes.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 289818 Unclosed stream in org.aspectj.weaver.bcel.ExtensibleURLClassLoader

resolved fixed

4d200d1

["weaver/src/org/aspectj/weaver/bcel/ExtensibleURLClassLoader.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 289816 Potentially unclosed stream in org.aspectj.weaver.bcel.BcelWorld

resolved fixed

67ffda8

["weaver/src/org/aspectj/weaver/bcel/BcelWorld.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 288198 LangUtils JVM version detection cannot handle Java 7

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-GB; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 Build Identifier: 1.6.4 The JVM detection in LangUtils is currently unable to handle Java7, whilst this is naturally an unreleased version of the JVM, the fix is trivial. Reproducible: Always Steps to Reproduce: Attempt to use the LangUtils java version support on java7

resolved fixed

b29f839

["util/src/org/aspectj/util/LangUtil.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 288505 failure to close inputstream

resolved fixed

3d3d03b

["org.aspectj.matcher/src/org/aspectj/weaver/Lint.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 287315 NPE using declare @type

reported by Ramnivas: java.lang.NullPointerException at org.aspectj.weaver.bcel.BcelObjectType.hasAnnotation(BcelObjectType.java:558) at org.aspectj.weaver.ReferenceType.hasAnnotation(ReferenceType.java:161) at org.aspectj.weaver.patterns.ExactAnnotationTypePattern.matches(ExactAnnotationTypePattern.java:101) at org.aspectj.weaver.patterns.ExactAnnotationTypePattern.matches(ExactAnnotationTypePattern.java:94) at org.aspectj.weaver.patterns.AnyWithAnnotationTypePattern.matchesExactly(TypePattern.java:513) at org.aspectj.weaver.patterns.TypePattern.matchesStatically(TypePattern.java:129) at org.aspectj.weaver.patterns.DeclareAnnotation.matches(DeclareAnnotation.java:269) at org.aspectj.weaver.bcel.BcelWeaver.applyDeclareAtType(BcelWeaver.java:1590)

resolved fixed

b664969

["weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 285172 Sometimes when load-time weaving there will be two ReferenceType objects for the same type

Seen by Ramnivas. A pointcut uses an exact type name for an annotation execution(* (@Controller *..*).*(..)) Resolving this pointcut causes us to construct a ReferenceType for 'Controller'. Then we attempt to populate it by loading the class implementation. This recurses back into the weaver as Controller is loaded and an attempt is made to weave it. This takes a second route through the weaver to build a referencetype again and this second referencetype is cached in the world. When we unwind, we continue building the original referencetype and are left with one in the cache and the one resolved for the pointcut. Due to the use of == for comparison, we fail to match on join points later because they will use the ReferenceType from the cache.

resolved fixed

dd7d879

["org.aspectj.matcher/src/org/aspectj/weaver/World.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 280783 JavaDocRunner fails on System.setSecurityManager in Netbeans

resolved fixed

59d5c3b

["ajdoc/src/org/aspectj/tools/ajdoc/JavadocRunner.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 279120 NPE determining annotation target kind during weaving

reported on the list: Hi, I am using aspectj LTW (aspectjweaver-1.6.1) for weaving an aspect available in another jar within my web application code. While building the jar which contains the aspect, using maven, I have JUnits which run without any problems using LTW. My aspect code looks as below @Around("execution (@com.arisglobal.aglite.annotations.OperationTrail public * *(..)) && this(executor)") public Object auditOperation(ProceedingJoinPoint thisJoinPoint, Object executor) { ... ... aspect code ... } However when I deploy the application in tomcat (with javaagent:aspectjweaver-1.6.1.jar option), I get a NPE which I have pasted below. Jun 4, 2009 12:06:18 PM org.aspectj.weaver.tools.Jdk14Trace error SEVERE: com/arisglobal/aglite/services/actiontrail/ActionTrailAspect java.lang.NullPointerException at org.aspectj.weaver.bcel.BcelObjectType.getAnnotationTargetKinds(BcelO bjectType.java:612) at org.aspectj.weaver.ReferenceType.getAnnotationTargetKinds(ReferenceTy pe.java:265) at org.aspectj.weaver.patterns.SignaturePattern.checkForIncorrectTargetK ind(SignaturePattern.java:112) at org.aspectj.weaver.patterns.SignaturePattern.checkForIncorrectTargetK ind(SignaturePattern.java:94) at org.aspectj.weaver.patterns.SignaturePattern.resolveBindings(Signatur ePattern.java:87) at org.aspectj.weaver.patterns.KindedPointcut.resolveBindings(KindedPoin tcut.java:262) at org.aspectj.weaver.patterns.AndPointcut.resolveBindings(AndPointcut.j ava:75) at org.aspectj.weaver.patterns.Pointcut.resolve(Pointcut.java:196) at org.aspectj.weaver.bcel.AtAjAttributes.handleAroundAnnotation(AtAjAtt ributes.java:1308) at org.aspectj.weaver.bcel.AtAjAttributes.readAj5MethodAttributes(AtAjAt tributes.java:403) at org.aspectj.weaver.bcel.BcelMethod.unpackAjAttributes(BcelMethod.java :189) at org.aspectj.weaver.bcel.BcelMethod.<init>(BcelMethod.java:96) at org.aspectj.weaver.bcel.BcelObjectType.getDeclaredMethods(BcelObjectT ype.java:264) at org.aspectj.weaver.bcel.LazyClassGen.<init>(LazyClassGen.java:303) at org.aspectj.weaver.bcel.BcelObjectType.getLazyClassGen(BcelObjectType .java:524) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1728) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump(BcelWeaver.java:1 696) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(BcelWeaver.java:145 8) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1244) at org.aspectj.weaver.tools.WeavingAdaptor.getWovenBytes(WeavingAdaptor. java:423) at org.aspectj.weaver.tools.WeavingAdaptor.weaveClass(WeavingAdaptor.jav a:286) at org.aspectj.weaver.loadtime.Aj.preProcess(Aj.java:95) at org.aspectj.weaver.loadtime.ClassPreProcessorAgentAdapter.transform(C lassPreProcessorAgentAdapter.java:52) at sun.instrument.TransformerManager.transform(TransformerManager.java:1 22) at sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java :155) at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:620) I also tried using aspectjweaver-1.6.4 version however got the same error.

resolved fixed

3417cbe

["weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java