url
stringlengths
63
64
repository_url
stringclasses
1 value
labels_url
stringlengths
77
78
comments_url
stringlengths
72
73
events_url
stringlengths
70
71
html_url
stringlengths
51
54
id
int64
1.73B
2.09B
node_id
stringlengths
18
19
number
int64
5.23k
16.2k
title
stringlengths
1
385
user
dict
labels
list
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
list
milestone
null
comments
int64
0
56
created_at
timestamp[s]
updated_at
timestamp[s]
closed_at
timestamp[s]
author_association
stringclasses
3 values
active_lock_reason
null
body
stringlengths
1
55.4k
reactions
dict
timeline_url
stringlengths
72
73
performed_via_github_app
null
state_reason
stringclasses
3 values
draft
bool
2 classes
pull_request
dict
https://api.github.com/repos/langchain-ai/langchain/issues/14453
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14453/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14453/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14453/events
https://github.com/langchain-ai/langchain/pull/14453
2,033,031,303
PR_kwDOIPDwls5hi0QE
14,453
docs: add missing imports for local_llms
{ "login": "Yelinz", "id": 30687616, "node_id": "MDQ6VXNlcjMwNjg3NjE2", "avatar_url": "https://avatars.githubusercontent.com/u/30687616?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Yelinz", "html_url": "https://github.com/Yelinz", "followers_url": "https://api.github.com/users/Yelinz/followers", "following_url": "https://api.github.com/users/Yelinz/following{/other_user}", "gists_url": "https://api.github.com/users/Yelinz/gists{/gist_id}", "starred_url": "https://api.github.com/users/Yelinz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Yelinz/subscriptions", "organizations_url": "https://api.github.com/users/Yelinz/orgs", "repos_url": "https://api.github.com/users/Yelinz/repos", "events_url": "https://api.github.com/users/Yelinz/events{/privacy}", "received_events_url": "https://api.github.com/users/Yelinz/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
{ "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false }
[ { "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false } ]
null
2
2023-12-08T17:10:55
2023-12-09T08:54:58
2023-12-09T01:23:30
CONTRIBUTOR
null
<!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** a description of the change, - **Issue:** the issue # it fixes (if applicable), - **Dependencies:** any dependencies required for this change, - **Tag maintainer:** for a quicker response, tag the relevant maintainer (see below), - **Twitter handle:** we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out! Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. --> Keeping it consistent with everywhere else in the docs and adding the missing imports to be able to copy paste and run the code example.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14453/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14453/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14453", "html_url": "https://github.com/langchain-ai/langchain/pull/14453", "diff_url": "https://github.com/langchain-ai/langchain/pull/14453.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14453.patch", "merged_at": "2023-12-09T01:23:30" }
https://api.github.com/repos/langchain-ai/langchain/issues/14452
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14452/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14452/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14452/events
https://github.com/langchain-ai/langchain/pull/14452
2,032,894,138
PR_kwDOIPDwls5hiWF0
14,452
Andrewreed
{ "login": "A-Roucher", "id": 69208727, "node_id": "MDQ6VXNlcjY5MjA4NzI3", "avatar_url": "https://avatars.githubusercontent.com/u/69208727?v=4", "gravatar_id": "", "url": "https://api.github.com/users/A-Roucher", "html_url": "https://github.com/A-Roucher", "followers_url": "https://api.github.com/users/A-Roucher/followers", "following_url": "https://api.github.com/users/A-Roucher/following{/other_user}", "gists_url": "https://api.github.com/users/A-Roucher/gists{/gist_id}", "starred_url": "https://api.github.com/users/A-Roucher/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/A-Roucher/subscriptions", "organizations_url": "https://api.github.com/users/A-Roucher/orgs", "repos_url": "https://api.github.com/users/A-Roucher/repos", "events_url": "https://api.github.com/users/A-Roucher/events{/privacy}", "received_events_url": "https://api.github.com/users/A-Roucher/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700863, "node_id": "LA_kwDOIPDwls8AAAABUpidvw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:enhancement", "name": "auto:enhancement", "color": "C2E0C6", "default": false, "description": "A large net-new component, integration, or chain. Use sparingly. The largest features" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714130, "node_id": "LA_kwDOIPDwls8AAAABc3-rkg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XL", "name": "size:XL", "color": "D4C5F9", "default": false, "description": "This PR changes 500-999 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-08T15:45:57
2023-12-08T15:49:46
2023-12-08T15:46:37
CONTRIBUTOR
null
<!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** a description of the change, - **Issue:** the issue # it fixes (if applicable), - **Dependencies:** any dependencies required for this change, - **Tag maintainer:** for a quicker response, tag the relevant maintainer (see below), - **Twitter handle:** we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out! Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14452/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14452/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14452", "html_url": "https://github.com/langchain-ai/langchain/pull/14452", "diff_url": "https://github.com/langchain-ai/langchain/pull/14452.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14452.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14451
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14451/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14451/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14451/events
https://github.com/langchain-ai/langchain/pull/14451
2,032,887,874
PR_kwDOIPDwls5hiUt8
14,451
Corrected the argument alias from 'base_store' to 'docstore'
{ "login": "xkra", "id": 22492738, "node_id": "MDQ6VXNlcjIyNDkyNzM4", "avatar_url": "https://avatars.githubusercontent.com/u/22492738?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xkra", "html_url": "https://github.com/xkra", "followers_url": "https://api.github.com/users/xkra/followers", "following_url": "https://api.github.com/users/xkra/following{/other_user}", "gists_url": "https://api.github.com/users/xkra/gists{/gist_id}", "starred_url": "https://api.github.com/users/xkra/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xkra/subscriptions", "organizations_url": "https://api.github.com/users/xkra/orgs", "repos_url": "https://api.github.com/users/xkra/repos", "events_url": "https://api.github.com/users/xkra/events{/privacy}", "received_events_url": "https://api.github.com/users/xkra/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
2
2023-12-08T15:42:07
2023-12-08T23:58:55
2023-12-08T23:58:55
CONTRIBUTOR
null
- **Description:** The sample code in the documentation about MultiVectorRetriever throws an error. The reason is an incorrect reference to an argument alias (`base_store` instead of `docstore`) The definition of the MultiVectorRetriever class shows that the correct argument alias is `docstore`. This fixes the error.,
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14451/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14451", "html_url": "https://github.com/langchain-ai/langchain/pull/14451", "diff_url": "https://github.com/langchain-ai/langchain/pull/14451.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14451.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14450
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14450/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14450/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14450/events
https://github.com/langchain-ai/langchain/issues/14450
2,032,847,275
I_kwDOIPDwls55Ksmr
14,450
Web Scraping with ChatOllama gives SSL: WRONG_VERSION_NUMBER
{ "login": "AndreaBrg", "id": 11504277, "node_id": "MDQ6VXNlcjExNTA0Mjc3", "avatar_url": "https://avatars.githubusercontent.com/u/11504277?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AndreaBrg", "html_url": "https://github.com/AndreaBrg", "followers_url": "https://api.github.com/users/AndreaBrg/followers", "following_url": "https://api.github.com/users/AndreaBrg/following{/other_user}", "gists_url": "https://api.github.com/users/AndreaBrg/gists{/gist_id}", "starred_url": "https://api.github.com/users/AndreaBrg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AndreaBrg/subscriptions", "organizations_url": "https://api.github.com/users/AndreaBrg/orgs", "repos_url": "https://api.github.com/users/AndreaBrg/repos", "events_url": "https://api.github.com/users/AndreaBrg/events{/privacy}", "received_events_url": "https://api.github.com/users/AndreaBrg/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
4
2023-12-08T15:19:32
2023-12-23T13:51:51
null
NONE
null
### Issue you'd like to raise. Hi, I'm trying to implement the [web scraping tutorial ](https://python.langchain.com/docs/use_cases/web_scraping#llm-with-function-calling) using ChatOllama instead of ChatOpenAI. This is what I'm trying to do: ``` import pprint from langchain.chains import create_extraction_chain from langchain.document_loaders import AsyncChromiumLoader from langchain.document_transformers import BeautifulSoupTransformer from langchain.text_splitter import RecursiveCharacterTextSplitter from langchain.chat_models import ChatOllama def extract(content: str, schema: dict, llm): return create_extraction_chain(schema=schema, llm=llm).run(content) def scrape_with_playwright(urls, schema, llm): loader = AsyncChromiumLoader(urls) docs = loader.load() bs_transformer = BeautifulSoupTransformer() docs_transformed = bs_transformer.transform_documents( docs, tags_to_extract=["span"] ) print("Extracting content with LLM") # Grab the first 1000 tokens of the site splitter = RecursiveCharacterTextSplitter.from_tiktoken_encoder( chunk_size=1000, chunk_overlap=0 ) splits = splitter.split_documents(docs_transformed) # Process the first split extracted_content = extract(schema=schema, content=splits[0].page_content, llm=llm) return extracted_content if __name__ == '__main__': llm = ChatOllama(base_url="https://localhost:11434", model="llama2") schema = { "properties": { "news_article_title": {"type": "string"}, "news_article_summary": {"type": "string"}, }, "required": ["news_article_title", "news_article_summary"], } urls = ["https://www.wsj.com"] extracted_content = scrape_with_playwright(urls, schema=schema, llm=llm) pprint.pprint(extracted_content) ``` Instead of the results shown I get this error: `requests.exceptions.SSLError: HTTPSConnectionPool(host='localhost', port=11434): Max retries exceeded with url: /api/generate/ (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1006)')))` when the `extract` function is called. Could anyone please help me understand what I'm doing wrong? Thanks! ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14450/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14450/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14446
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14446/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14446/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14446/events
https://github.com/langchain-ai/langchain/pull/14446
2,032,687,823
PR_kwDOIPDwls5hhoeK
14,446
Fix: redundant casting to SecretStr API keys
{ "login": "rancomp", "id": 23070692, "node_id": "MDQ6VXNlcjIzMDcwNjky", "avatar_url": "https://avatars.githubusercontent.com/u/23070692?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rancomp", "html_url": "https://github.com/rancomp", "followers_url": "https://api.github.com/users/rancomp/followers", "following_url": "https://api.github.com/users/rancomp/following{/other_user}", "gists_url": "https://api.github.com/users/rancomp/gists{/gist_id}", "starred_url": "https://api.github.com/users/rancomp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rancomp/subscriptions", "organizations_url": "https://api.github.com/users/rancomp/orgs", "repos_url": "https://api.github.com/users/rancomp/repos", "events_url": "https://api.github.com/users/rancomp/events{/privacy}", "received_events_url": "https://api.github.com/users/rancomp/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
open
false
{ "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false }
[ { "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false } ]
null
7
2023-12-08T13:47:43
2024-01-08T09:01:15
null
CONTRIBUTOR
null
- **Description:** This PR serves as standardization of the masking and testing. - Some API keys were not really masked when stored in the `values` dict. They should be masked and cast back to string only during the `POST` request. I fixed 1 occurance of this. - Some tests were not covering this flaw because they were repeating the back-and-forth pattern of casting to `SecretStr` and invoking `.get_secret_value()` immediately. This pattern is confusing, and in order to clear this out I added an `extract_secret_str : SecretStr | Str | None -> str` method. - The code-base was filled with `secretstr, secret_str, secret_string` names. I replaced all of them with `secretstr`. - **Issue:** fixes https://github.com/langchain-ai/langchain/issues/14445, related https://github.com/langchain-ai/langchain/issues/12165 - **Dependencies:** None - **Tag maintainer:** @eyurtsev @hwchase17
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14446/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14446/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14446", "html_url": "https://github.com/langchain-ai/langchain/pull/14446", "diff_url": "https://github.com/langchain-ai/langchain/pull/14446.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14446.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14445
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14445/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14445/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14445/events
https://github.com/langchain-ai/langchain/issues/14445
2,032,683,865
I_kwDOIPDwls55KEtZ
14,445
Issue: Flawed implementations of SecretStr for API keys
{ "login": "rancomp", "id": 23070692, "node_id": "MDQ6VXNlcjIzMDcwNjky", "avatar_url": "https://avatars.githubusercontent.com/u/23070692?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rancomp", "html_url": "https://github.com/rancomp", "followers_url": "https://api.github.com/users/rancomp/followers", "following_url": "https://api.github.com/users/rancomp/following{/other_user}", "gists_url": "https://api.github.com/users/rancomp/gists{/gist_id}", "starred_url": "https://api.github.com/users/rancomp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rancomp/subscriptions", "organizations_url": "https://api.github.com/users/rancomp/orgs", "repos_url": "https://api.github.com/users/rancomp/repos", "events_url": "https://api.github.com/users/rancomp/events{/privacy}", "received_events_url": "https://api.github.com/users/rancomp/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-08T13:45:01
2023-12-08T15:46:00
null
CONTRIBUTOR
null
During the recent initiative to secure API keys with `SecretStr` (https://github.com/langchain-ai/langchain/issues/12165), some implementations and their corresponding tests were implemented with some flaws. More specifically, they were not really masking the API key. For instsance, in `libs/langchain/langchain/chat_models/javelin_ai_gateway.py` we have: ``` @property def _default_params(self) -> Dict[str, Any]: params: Dict[str, Any] = { "gateway_uri": self.gateway_uri, "javelin_api_key": cast(SecretStr, self.javelin_api_key).get_secret_value(), "route": self.route, **(self.params.dict() if self.params else {}), } return params ``` In the above snippet, `self.javelin_api_key` is cast to `SecretStr`, and then immediately `.get_secret_value()` is invoked, essentially retrieving the original string. Note that Javelin chat lacks unit tests. This could be used to handle the case where the API key is `None`, but then it might appear like there's no masking and it's preferable to address the `None` case directly. It's worth noting that this pattern is repeated in tests, such as in `libs/langchain/tests/integration_tests/chat_models/test_baiduqianfan.py`: ``` def test_uses_actual_secret_value_from_secret_str() -> None: """Test that actual secret is retrieved using `.get_secret_value()`.""" chat = QianfanChatEndpoint( qianfan_ak="test-api-key", qianfan_sk="test-secret-key", ) assert cast(SecretStr, chat.qianfan_ak).get_secret_value() == "test-api-key" assert cast(SecretStr, chat.qianfan_sk).get_secret_value() == "test-secret-key" ``` The point of the test would be to assert that the API key is indeed a secret, and not just cast it back and forth. Let me point out that the test suite for baiduqianfan chat does indeed catch whether the API key is indeed masked with a `SecretStr` by capturing the stdout. @eyurtsev @hwchase17 ### Suggestion: PR to fix the issues
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14445/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14445/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14444
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14444/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14444/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14444/events
https://github.com/langchain-ai/langchain/pull/14444
2,032,617,829
PR_kwDOIPDwls5hhZA6
14,444
Update with new VertexAIModelGarden output format
{ "login": "shikanime", "id": 22115108, "node_id": "MDQ6VXNlcjIyMTE1MTA4", "avatar_url": "https://avatars.githubusercontent.com/u/22115108?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shikanime", "html_url": "https://github.com/shikanime", "followers_url": "https://api.github.com/users/shikanime/followers", "following_url": "https://api.github.com/users/shikanime/following{/other_user}", "gists_url": "https://api.github.com/users/shikanime/gists{/gist_id}", "starred_url": "https://api.github.com/users/shikanime/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shikanime/subscriptions", "organizations_url": "https://api.github.com/users/shikanime/orgs", "repos_url": "https://api.github.com/users/shikanime/repos", "events_url": "https://api.github.com/users/shikanime/events{/privacy}", "received_events_url": "https://api.github.com/users/shikanime/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714119, "node_id": "LA_kwDOIPDwls8AAAABc3-rhw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:M", "name": "size:M", "color": "C5DEF5", "default": false, "description": "This PR changes 30-99 lines, ignoring generated files." } ]
open
false
{ "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false }
[ { "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false } ]
null
2
2023-12-08T13:01:13
2024-01-03T00:40:53
null
NONE
null
On December 1st, the Google Cloud Vertex AI Model Garden models runtime received an update in the form of `Prompt:\n\t{prompt}\nOutput:\n\t{prompt}` and now streams tokens throughout the second level list. This change will break the current behavior of your applications if adequate fixes are not applied. We are promoting these changes based on our experiences with LLaMA, Falcon, Mistral, and additional models that are distributed directly by Vertex AI Model Garden. Probably fixes #13370 #10012
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14444/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14444/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14444", "html_url": "https://github.com/langchain-ai/langchain/pull/14444", "diff_url": "https://github.com/langchain-ai/langchain/pull/14444.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14444.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14443
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14443/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14443/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14443/events
https://github.com/langchain-ai/langchain/issues/14443
2,032,599,462
I_kwDOIPDwls55JwGm
14,443
Unexpected end of JSON
{ "login": "andyjessop", "id": 1304307, "node_id": "MDQ6VXNlcjEzMDQzMDc=", "avatar_url": "https://avatars.githubusercontent.com/u/1304307?v=4", "gravatar_id": "", "url": "https://api.github.com/users/andyjessop", "html_url": "https://github.com/andyjessop", "followers_url": "https://api.github.com/users/andyjessop/followers", "following_url": "https://api.github.com/users/andyjessop/following{/other_user}", "gists_url": "https://api.github.com/users/andyjessop/gists{/gist_id}", "starred_url": "https://api.github.com/users/andyjessop/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/andyjessop/subscriptions", "organizations_url": "https://api.github.com/users/andyjessop/orgs", "repos_url": "https://api.github.com/users/andyjessop/repos", "events_url": "https://api.github.com/users/andyjessop/events{/privacy}", "received_events_url": "https://api.github.com/users/andyjessop/received_events", "type": "User", "site_admin": false }
[ { "id": 5541141061, "node_id": "LA_kwDOIPDwls8AAAABSkcaRQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20embeddings", "name": "area: embeddings", "color": "C5DEF5", "default": false, "description": "Related to text embedding models module" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 5932474361, "node_id": "LA_kwDOIPDwls8AAAABYZpf-Q", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20pinecone", "name": "integration: pinecone", "color": "BC53BE", "default": false, "description": "Related to Pinecone vector store integration" } ]
open
false
null
[]
null
1
2023-12-08T12:47:37
2023-12-08T12:57:10
null
NONE
null
### System Info npm version: "^0.0.203" MacOS Bun version: 1.0.15+b3bdf22eb ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [X] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [X] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [X] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction The following code will cause this error: ``` import { Pinecone } from '@pinecone-database/pinecone'; import { VectorDBQAChain } from 'langchain/chains'; import { OpenAIEmbeddings } from 'langchain/embeddings/openai'; import { OpenAI } from 'langchain/llms/openai'; import { PineconeStore } from 'langchain/vectorstores/pinecone'; const pinecone = new Pinecone(); const indexKey = process.env.PINECONE_INDEX_KEY; if (!indexKey) { throw new Error('PINECONE_INDEX_KEY is not set.'); } const pineconeIndex = pinecone.Index(indexKey); export async function queryDocuments(query: string, returnSourceDocuments = false) { const vectorStore = await PineconeStore.fromExistingIndex( new OpenAIEmbeddings({ modelName: 'text-embedding-ada-002', }), { pineconeIndex, }, ); const model = new OpenAI({ modelName: 'gpt-4-1106-preview', }); const chain = VectorDBQAChain.fromLLM(model, vectorStore, { k: 5, returnSourceDocuments, }); return await chain.call({ query }); } ``` The embeddings have been created and confirmed to exist in the Pinecone console, e.g.: <img width="1240" alt="Screenshot 2023-12-08 at 13 46 24" src="https://github.com/langchain-ai/langchain/assets/1304307/66c23c7e-916a-461d-b8f6-28a7fa460300"> ### Expected behavior I would expect it to query the vector DB and correctly prompt GPT-4 with the results. But instead, I get the following error: ``` ? Enter your query what is the third wave of dam Creating query for "what is the third wave of dam"... 499 | var _a; 500 | return __generator(this, function (_b) { 501 | switch (_b.label) { 502 | case 0: 503 | _a = this.transformer; 504 | return [4 /*yield*/, this.raw.json()]; ^ SyntaxError: Unexpected end of JSON input at /Users/andy/dev/runestone/node_modules/@pinecone-database/pinecone/dist/pinecone-generated-ts-fetch/runtime.js:504:46 at step (/Users/andy/dev/runestone/node_modules/@pinecone-database/pinecone/dist/pinecone-generated-ts-fetch/runtime.js:72:18) at /Users/andy/dev/runestone/node_modules/@pinecone-database/pinecone/dist/pinecone-generated-ts-fetch/runtime.js:53:53 at /Users/andy/dev/runestone/node_modules/@pinecone-database/pinecone/dist/pinecone-generated-ts-fetch/runtime.js:47:9 at new Promise (:1:21) at /Users/andy/dev/runestone/node_modules/@pinecone-database/pinecone/dist/pinecone-generated-ts-fetch/runtime.js:43:12 at /Users/andy/dev/runestone/node_modules/@pinecone-database/pinecone/dist/pinecone-generated-ts-fetch/runtime.js:498:16 at /Users/andy/dev/runestone/node_modules/@pinecone-database/pinecone/dist/pinecone-generated-ts-fetch/apis/VectorOperationsApi.js:405:46 at step (/Users/andy/dev/runestone/node_modules/@pinecone-database/pinecone/dist/pinecone-generated-ts-fetch/apis/VectorOperationsApi.js:84:18) ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14443/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14443/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14442
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14442/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14442/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14442/events
https://github.com/langchain-ai/langchain/issues/14442
2,032,443,629
I_kwDOIPDwls55JKDt
14,442
Issue: Opensearch manually assigned shards and replicas while using vector_db.add_text(page_contents,metatas)
{ "login": "akash97715", "id": 34799343, "node_id": "MDQ6VXNlcjM0Nzk5MzQz", "avatar_url": "https://avatars.githubusercontent.com/u/34799343?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akash97715", "html_url": "https://github.com/akash97715", "followers_url": "https://api.github.com/users/akash97715/followers", "following_url": "https://api.github.com/users/akash97715/following{/other_user}", "gists_url": "https://api.github.com/users/akash97715/gists{/gist_id}", "starred_url": "https://api.github.com/users/akash97715/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akash97715/subscriptions", "organizations_url": "https://api.github.com/users/akash97715/orgs", "repos_url": "https://api.github.com/users/akash97715/repos", "events_url": "https://api.github.com/users/akash97715/events{/privacy}", "received_events_url": "https://api.github.com/users/akash97715/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 6077048506, "node_id": "LA_kwDOIPDwls8AAAABajhmug", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20elasticsearch", "name": "integration: elasticsearch", "color": "DAB5EC", "default": false, "description": "Related to elastic/elasticsearch integrations" } ]
open
false
null
[]
null
1
2023-12-08T11:02:46
2023-12-08T11:10:23
null
NONE
null
### Issue you'd like to raise. Hello Team, We are using opensearch vectordb to store the embeddings, then we are using these embeddings to retrieve the similar document during conversastnal retrieval. while checking the settings of the index created by vector_db.add_text(page_content,metadatas). i have seen the number_of_replicas as 5 and shards as 1(this is the default behaviour of vector_db.add_text(page_content,metadats) **I want to pass as number_of_replicas as 1** and shards as 1 whenever the index is created on opensearch. Can you please help me with this, how can i custom pass this replicas value. Also i am adding code for better understanding below In the below code if u see the **langchain vector_db.add_text() in Line 109** creating a index with 5 shards by default. i just want to pass this parameter manually lets say 1 shard. Can u please help me out here. Please let me know if you want any more info to understand my issue. ![langchain_num_shard](https://github.com/langchain-ai/langchain/assets/34799343/453e20f7-15c3-4aa5-a862-398696037b0f) ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14442/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14442/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14441
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14441/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14441/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14441/events
https://github.com/langchain-ai/langchain/issues/14441
2,032,387,502
I_kwDOIPDwls55I8Wu
14,441
Issue: How Can I use Prompt Template?
{ "login": "deepak-habilelabs", "id": 137885024, "node_id": "U_kgDOCDf1YA", "avatar_url": "https://avatars.githubusercontent.com/u/137885024?v=4", "gravatar_id": "", "url": "https://api.github.com/users/deepak-habilelabs", "html_url": "https://github.com/deepak-habilelabs", "followers_url": "https://api.github.com/users/deepak-habilelabs/followers", "following_url": "https://api.github.com/users/deepak-habilelabs/following{/other_user}", "gists_url": "https://api.github.com/users/deepak-habilelabs/gists{/gist_id}", "starred_url": "https://api.github.com/users/deepak-habilelabs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/deepak-habilelabs/subscriptions", "organizations_url": "https://api.github.com/users/deepak-habilelabs/orgs", "repos_url": "https://api.github.com/users/deepak-habilelabs/repos", "events_url": "https://api.github.com/users/deepak-habilelabs/events{/privacy}", "received_events_url": "https://api.github.com/users/deepak-habilelabs/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-08T10:24:07
2023-12-08T10:35:09
null
NONE
null
### Issue you'd like to raise. #prompt template How Can I use Prompt Template in my code below? def chat_langchain(new_project_qa, query, not_uuid): check = query.lower() user_experience_inst = UserExperience.objects.get(not_uuid=not_uuid) # query="If the context is related to hi/hello with or without incorrect spelling then reply Hi! How can I assist you today?,else Search the entire context and provide formal and accurate answer for this query - {}. Explain the relevant information with important points, if necessary.If you don't find answer then give relavant answer else reply with text 'Sorry, I can't find the related information' ".format(check) if check not in ['hi','hello','hey','hui','hiiii','hii','hiii','heyyy'] and not user_experience_inst.custom_prompt: query = "Search the entire context and provide formal and accurate answer for this query - {}. Explain the relevant information with important points, if necessary.If you don't find answer then reply with text 'Sorry, I can't find the related information' otherwise give relavant answer".format(check) elif check not in ['hi','hello','hey','hui','hiiii','hii','hiii','heyyy'] and user_experience_inst.custom_prompt: query = f"{user_experience_inst.custom_prompt} {check}.If you don't find answer then reply with text 'Sorry, I can't find the related information'" else: query="Search the entire context and provide formal and accurate answer for this query - {}. Explain the relevant information with important points, if necessary.".format(check) result = new_project_qa(query) relevant_document = result['source_documents'] if relevant_document: source = relevant_document[0].metadata.get('source', '') # Check if the file extension is ".pdf" file_extension = os.path.splitext(source)[1] if file_extension.lower() == ".pdf": source = os.path.basename(source) # Retrieve the UserExperience instance using the provided not_uuid user_experience_inst = UserExperience.objects.get(not_uuid=not_uuid) bot_ending = user_experience_inst.bot_ending_msg if user_experience_inst.bot_ending_msg is not None else "" # Create the list_json dictionary if bot_ending != '': list_json = { 'bot_message': result['result'] + '\n\n' + str(bot_ending), "citation": source } else: list_json = { 'bot_message': result['result'] + str(bot_ending), "citation": source } else: # Handle the case when relevant_document is empty list_json = { 'bot_message': result['result'], 'citation': '' } # Return the list_json dictionary return list_json ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14441/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14441/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14440
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14440/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14440/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14440/events
https://github.com/langchain-ai/langchain/issues/14440
2,032,367,290
I_kwDOIPDwls55I3a6
14,440
custom_table_info along with sql_db_schema while using create_sql_agent
{ "login": "Mohankumar311", "id": 115910074, "node_id": "U_kgDOBuilug", "avatar_url": "https://avatars.githubusercontent.com/u/115910074?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Mohankumar311", "html_url": "https://github.com/Mohankumar311", "followers_url": "https://api.github.com/users/Mohankumar311/followers", "following_url": "https://api.github.com/users/Mohankumar311/following{/other_user}", "gists_url": "https://api.github.com/users/Mohankumar311/gists{/gist_id}", "starred_url": "https://api.github.com/users/Mohankumar311/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Mohankumar311/subscriptions", "organizations_url": "https://api.github.com/users/Mohankumar311/orgs", "repos_url": "https://api.github.com/users/Mohankumar311/repos", "events_url": "https://api.github.com/users/Mohankumar311/events{/privacy}", "received_events_url": "https://api.github.com/users/Mohankumar311/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-08T10:10:16
2023-12-08T11:46:22
null
NONE
null
### Feature request When utilizing custom_table_info in the sqldatabase instance while employing the create_sql_agent function, it appears that there is an issue where it disregards the sql_db_schema. Currently, it only utilizes either the custom_table_info or the sql_db_schema. This poses a challenge, especially when crucial information, such as identifying which ID column corresponds to other tables, cannot be specified in the custom table info. There is a need for an option to use both the custom table information and the sql_db_schema table_info={'invoice':" the customer_id in invoice table is referenced to customers table's company_id",} db=SQLDatabase(engine=dbengine,include_tables=["invoice","customer"],custom_table_info=table_info) Invoking: `sql_db_schema` with `customer, invoice` CREATE TABLE customer ( id SERIAL NOT NULL, key VARCHAR NOT NULL, company_id VARCHAR NOT NULL, company_name VARCHAR NOT NULL, ) /* 1 rows from customer table: id key company_id company_name 670 CUST-0ab15 17 Aim Inc */ the customer_id in invoice table is referenced to customers table's company_id, It doesnt have the schema of invoice table so generating wrong sql queries ### Motivation I need both custom_table_info and sql_db_schema to work, as some kinda metadata is needed to specify that is specific to my use cases. ### Your contribution NO
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14440/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14440/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14439
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14439/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14439/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14439/events
https://github.com/langchain-ai/langchain/pull/14439
2,032,340,256
PR_kwDOIPDwls5hgdD7
14,439
Support `score_threshold` in SupabaseVectorStore similarity search
{ "login": "codehound42", "id": 41467365, "node_id": "MDQ6VXNlcjQxNDY3MzY1", "avatar_url": "https://avatars.githubusercontent.com/u/41467365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/codehound42", "html_url": "https://github.com/codehound42", "followers_url": "https://api.github.com/users/codehound42/followers", "following_url": "https://api.github.com/users/codehound42/following{/other_user}", "gists_url": "https://api.github.com/users/codehound42/gists{/gist_id}", "starred_url": "https://api.github.com/users/codehound42/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/codehound42/subscriptions", "organizations_url": "https://api.github.com/users/codehound42/orgs", "repos_url": "https://api.github.com/users/codehound42/repos", "events_url": "https://api.github.com/users/codehound42/events{/privacy}", "received_events_url": "https://api.github.com/users/codehound42/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 6232714108, "node_id": "LA_kwDOIPDwls8AAAABc3-rfA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:S", "name": "size:S", "color": "BFDADC", "default": false, "description": "This PR changes 10-29 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-08T09:52:59
2024-01-03T00:47:06
2024-01-03T00:47:05
CONTRIBUTOR
null
Description: Add support for setting the `score_threshold` for similarity search in SupabaseVectoreStore. This pull request addresses issue #14438
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14439/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14439/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14439", "html_url": "https://github.com/langchain-ai/langchain/pull/14439", "diff_url": "https://github.com/langchain-ai/langchain/pull/14439.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14439.patch", "merged_at": "2024-01-03T00:47:05" }
https://api.github.com/repos/langchain-ai/langchain/issues/14438
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14438/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14438/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14438/events
https://github.com/langchain-ai/langchain/issues/14438
2,032,332,864
I_kwDOIPDwls55IvBA
14,438
DOC: `SupabaseVectorStore` support for similarity `score_threshold` filtering in `as_retriever`
{ "login": "codehound42", "id": 41467365, "node_id": "MDQ6VXNlcjQxNDY3MzY1", "avatar_url": "https://avatars.githubusercontent.com/u/41467365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/codehound42", "html_url": "https://github.com/codehound42", "followers_url": "https://api.github.com/users/codehound42/followers", "following_url": "https://api.github.com/users/codehound42/following{/other_user}", "gists_url": "https://api.github.com/users/codehound42/gists{/gist_id}", "starred_url": "https://api.github.com/users/codehound42/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/codehound42/subscriptions", "organizations_url": "https://api.github.com/users/codehound42/orgs", "repos_url": "https://api.github.com/users/codehound42/repos", "events_url": "https://api.github.com/users/codehound42/events{/privacy}", "received_events_url": "https://api.github.com/users/codehound42/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" } ]
open
false
null
[]
null
2
2023-12-08T09:48:57
2023-12-08T09:54:40
null
CONTRIBUTOR
null
### Issue with current documentation: The supabase vectorstore does not support setting the `score_threshold` in `as_retriever` despite being showcased as an option in the vectorestore superclass docstring example. https://github.com/langchain-ai/langchain/blob/a05230a4ba4dee591d3810440ce65e16860956ae/libs/langchain/langchain/vectorstores/supabase.py#L218 https://github.com/langchain-ai/langchain/blob/a05230a4ba4dee591d3810440ce65e16860956ae/libs/core/langchain_core/vectorstores.py#L596 ### Idea or request for content: The VectoreStore superclass of SupabaseVectoreStore contains logic in `similarity_search_by_vector_with_relevance_scores` that could be used in the SupabaseVectorStore subclass to support the `score_threshold` parameter.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14438/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14438/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14437
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14437/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14437/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14437/events
https://github.com/langchain-ai/langchain/issues/14437
2,032,270,431
I_kwDOIPDwls55Ifxf
14,437
DoctranTextTranslator Is Not Working
{ "login": "ryang420", "id": 9249372, "node_id": "MDQ6VXNlcjkyNDkzNzI=", "avatar_url": "https://avatars.githubusercontent.com/u/9249372?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ryang420", "html_url": "https://github.com/ryang420", "followers_url": "https://api.github.com/users/ryang420/followers", "following_url": "https://api.github.com/users/ryang420/following{/other_user}", "gists_url": "https://api.github.com/users/ryang420/gists{/gist_id}", "starred_url": "https://api.github.com/users/ryang420/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ryang420/subscriptions", "organizations_url": "https://api.github.com/users/ryang420/orgs", "repos_url": "https://api.github.com/users/ryang420/repos", "events_url": "https://api.github.com/users/ryang420/events{/privacy}", "received_events_url": "https://api.github.com/users/ryang420/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-08T09:10:36
2023-12-08T09:18:34
null
NONE
null
### System Info Python 3.11 Langchain 0.0.348 ### Who can help? _No response_ ### Information - [x] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [x] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction I am trying DoctranTextTranslator of langchain. However, I got an error message after running below code. Error: doctran_docs[i] = await doc.translate(language=self.language).execute() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: object Document can't be used in 'await' expression ``` from langchain.document_transformers import DoctranTextTranslator from langchain.schema import Document from dotenv import load_dotenv import asyncio load_dotenv() sample_text = """[Generated with ChatGPT] Confidential Document - For Internal Use Only Date: July 1, 2023 Subject: Updates and Discussions on Various Topics Dear Team, I hope this email finds you well. In this document, I would like to provide you with some important updates and discuss various topics that require our attention. Please treat the information contained herein as highly confidential. Security and Privacy Measures As part of our ongoing commitment to ensure the security and privacy of our customers' data, we have implemented robust measures across all our systems. We would like to commend John Doe (email: john.doe@example.com) from the IT department for his diligent work in enhancing our network security. Moving forward, we kindly remind everyone to strictly adhere to our data protection policies and guidelines. Additionally, if you come across any potential security risks or incidents, please report them immediately to our dedicated team at security@example.com. HR Updates and Employee Benefits Recently, we welcomed several new team members who have made significant contributions to their respective departments. I would like to recognize Jane Smith (SSN: 049-45-5928) for her outstanding performance in customer service. Jane has consistently received positive feedback from our clients. Furthermore, please remember that the open enrollment period for our employee benefits program is fast approaching. Should you have any questions or require assistance, please contact our HR representative, Michael Johnson (phone: 418-492-3850, email: michael.johnson@example.com). Marketing Initiatives and Campaigns Our marketing team has been actively working on developing new strategies to increase brand awareness and drive customer engagement. We would like to thank Sarah Thompson (phone: 415-555-1234) for her exceptional efforts in managing our social media platforms. Sarah has successfully increased our follower base by 20% in the past month alone. Moreover, please mark your calendars for the upcoming product launch event on July 15th. We encourage all team members to attend and support this exciting milestone for our company. Research and Development Projects In our pursuit of innovation, our research and development department has been working tirelessly on various projects. I would like to acknowledge the exceptional work of David Rodriguez (email: david.rodriguez@example.com) in his role as project lead. David's contributions to the development of our cutting-edge technology have been instrumental. Furthermore, we would like to remind everyone to share their ideas and suggestions for potential new projects during our monthly R&D brainstorming session, scheduled for July 10th. Please treat the information in this document with utmost confidentiality and ensure that it is not shared with unauthorized individuals. If you have any questions or concerns regarding the topics discussed, please do not hesitate to reach out to me directly. Thank you for your attention, and let's continue to work together to achieve our goals. Best regards, Jason Fan Cofounder & CEO Psychic jason@psychic.dev """ documents = [Document(page_content=sample_text)] qa_translator = DoctranTextTranslator(language="spanish", openai_api_model="gpt-3.5-turbo") async def atransform_documents(docs): return await qa_translator.atransform_documents(docs) translated_document = asyncio.run(atransform_documents(documents)) print(translated_document[0].page_content) ``` ### Expected behavior It should return the translated text.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14437/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14437/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14436
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14436/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14436/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14436/events
https://github.com/langchain-ai/langchain/issues/14436
2,032,269,106
I_kwDOIPDwls55Ifcy
14,436
import error in elasticsearch memory module: Module cannot be used as a type
{ "login": "shubham1138", "id": 50394157, "node_id": "MDQ6VXNlcjUwMzk0MTU3", "avatar_url": "https://avatars.githubusercontent.com/u/50394157?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shubham1138", "html_url": "https://github.com/shubham1138", "followers_url": "https://api.github.com/users/shubham1138/followers", "following_url": "https://api.github.com/users/shubham1138/following{/other_user}", "gists_url": "https://api.github.com/users/shubham1138/gists{/gist_id}", "starred_url": "https://api.github.com/users/shubham1138/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shubham1138/subscriptions", "organizations_url": "https://api.github.com/users/shubham1138/orgs", "repos_url": "https://api.github.com/users/shubham1138/repos", "events_url": "https://api.github.com/users/shubham1138/events{/privacy}", "received_events_url": "https://api.github.com/users/shubham1138/received_events", "type": "User", "site_admin": false }
[ { "id": 4899126096, "node_id": "LA_kwDOIPDwls8AAAABJAK7UA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20memory", "name": "area: memory", "color": "BFDADC", "default": false, "description": "Related to memory module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 6077048506, "node_id": "LA_kwDOIPDwls8AAAABajhmug", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20elasticsearch", "name": "integration: elasticsearch", "color": "DAB5EC", "default": false, "description": "Related to elastic/elasticsearch integrations" } ]
open
false
null
[]
null
1
2023-12-08T09:09:41
2023-12-08T09:17:37
null
NONE
null
### System Info langchain version: 0.0.348 for the type hint for es_connection variable in class ElasticsearchChatMessageHistory, module is used as a type @hwchase17 @eyurtsev ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [X] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction import json import logging from time import time from typing import TYPE_CHECKING, Any, Dict, List, Optional from langchain_core.chat_history import BaseChatMessageHistory from langchain_core.messages import ( BaseMessage, message_to_dict, messages_from_dict, ) if TYPE_CHECKING: from elasticsearch import Elasticsearch logger = logging.getLogger(__name__) class ElasticsearchChatMessageHistory(BaseChatMessageHistory): """Chat message history that stores history in Elasticsearch. Args: es_url: URL of the Elasticsearch instance to connect to. es_cloud_id: Cloud ID of the Elasticsearch instance to connect to. es_user: Username to use when connecting to Elasticsearch. es_password: Password to use when connecting to Elasticsearch. es_api_key: API key to use when connecting to Elasticsearch. es_connection: Optional pre-existing Elasticsearch connection. index: Name of the index to use. session_id:Arbitrary key that is used to store the messages of a single chat session. """ def __init__( self, index: str, session_id: str, *, es_connection: Optional["**Elasticsearch**"] = None, es_url: Optional[str] = None, es_cloud_id: Optional[str] = None, es_user: Optional[str] = None, es_api_key: Optional[str] = None, es_password: Optional[str] = None, ): self.index: str = index self.session_id: str = session_id ### Expected behavior import of module elasticsearch is not done properly
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14436/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14436/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14435
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14435/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14435/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14435/events
https://github.com/langchain-ai/langchain/pull/14435
2,032,189,698
PR_kwDOIPDwls5hf77O
14,435
Improvement: Allow passing parameters to the underlying es_client. Closes: #14403
{ "login": "169", "id": 10000925, "node_id": "MDQ6VXNlcjEwMDAwOTI1", "avatar_url": "https://avatars.githubusercontent.com/u/10000925?v=4", "gravatar_id": "", "url": "https://api.github.com/users/169", "html_url": "https://github.com/169", "followers_url": "https://api.github.com/users/169/followers", "following_url": "https://api.github.com/users/169/following{/other_user}", "gists_url": "https://api.github.com/users/169/gists{/gist_id}", "starred_url": "https://api.github.com/users/169/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/169/subscriptions", "organizations_url": "https://api.github.com/users/169/orgs", "repos_url": "https://api.github.com/users/169/repos", "events_url": "https://api.github.com/users/169/events{/privacy}", "received_events_url": "https://api.github.com/users/169/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 6077048506, "node_id": "LA_kwDOIPDwls8AAAABajhmug", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20elasticsearch", "name": "integration: elasticsearch", "color": "DAB5EC", "default": false, "description": "Related to elastic/elasticsearch integrations" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
3
2023-12-08T08:28:17
2024-01-03T00:48:18
2024-01-03T00:48:18
CONTRIBUTOR
null
### Description In https://github.com/langchain-ai/langchain/issues/14403, the user mentioned that he hopes not to verify ssl and needs to pass more parameters I found that the `Elasticsearch` class [has very many parameters](https://github.com/elastic/elasticsearch-py/blob/98f2af2134dfc3f2b2054b87a4056e2508b9b8db/elasticsearch/_sync/client/__init__.py#L131-L191 ): <img width="1097" alt="Screenshot 2023-12-08 at 4 24 39 PM" src="https://github.com/langchain-ai/langchain/assets/10000925/f2201554-b41a-4388-a8e8-c14a2d0466d4"> In order to adapt to more situations, I want to add the kwargs parameter so that users can enter more `Elasticsearch` parameters. Like [redis](https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/vectorstores/redis/base.py#L253), [tair](https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/vectorstores/tair.py#L32), [myscale](https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/vectorstores/myscale.py#L112) and so on.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14435/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14435/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14435", "html_url": "https://github.com/langchain-ai/langchain/pull/14435", "diff_url": "https://github.com/langchain-ai/langchain/pull/14435.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14435.patch", "merged_at": "2024-01-03T00:48:18" }
https://api.github.com/repos/langchain-ai/langchain/issues/14434
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14434/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14434/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14434/events
https://github.com/langchain-ai/langchain/issues/14434
2,032,157,152
I_kwDOIPDwls55IEHg
14,434
StructuredChatAgent did not provide the correct action input.
{ "login": "Casper-Mars", "id": 50834595, "node_id": "MDQ6VXNlcjUwODM0NTk1", "avatar_url": "https://avatars.githubusercontent.com/u/50834595?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Casper-Mars", "html_url": "https://github.com/Casper-Mars", "followers_url": "https://api.github.com/users/Casper-Mars/followers", "following_url": "https://api.github.com/users/Casper-Mars/following{/other_user}", "gists_url": "https://api.github.com/users/Casper-Mars/gists{/gist_id}", "starred_url": "https://api.github.com/users/Casper-Mars/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Casper-Mars/subscriptions", "organizations_url": "https://api.github.com/users/Casper-Mars/orgs", "repos_url": "https://api.github.com/users/Casper-Mars/repos", "events_url": "https://api.github.com/users/Casper-Mars/events{/privacy}", "received_events_url": "https://api.github.com/users/Casper-Mars/received_events", "type": "User", "site_admin": false }
[ { "id": 4899412369, "node_id": "LA_kwDOIPDwls8AAAABJAcZkQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20agent", "name": "area: agent", "color": "BFD4F2", "default": false, "description": "Related to agents module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" } ]
closed
false
null
[]
null
3
2023-12-08T08:15:05
2023-12-08T10:27:18
2023-12-08T10:27:18
NONE
null
### System Info langchain version:0.0.311 os:macOS 11.6 python: 3.11 ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [X] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction This is code sample of using agent: ``` sys_p = self.create_sys_prompt() tools = [ ProgrammerAgent(self.env), DefaultAgent(), ] agent_obj = StructuredChatAgent.from_llm_and_tools( llm=self.env.llm, tools=tools, prefix=sys_p + PREFIX, verbose=True, ) agent = AgentExecutor.from_agent_and_tools( agent=agent_obj, tools=tools, verbose=True, ) task = f""" Here is the requirement: ```Markdown {requirement} ``` Please Implement the requirement. """ return agent.run(task) ``` this is the code of ProgrammerAgent tool: ``` from typing import Any, Type from langchain.tools import BaseTool from pydantic import Field, BaseModel from enviroment import Environment class ProgramRequirementSchema(BaseModel): task: str = Field(description="Coding task") task_context: str = Field(description="Contextual background information for the task.") project_path: str = Field(description="Project path") class ProgrammerAgent(BaseTool): name: str = "programmer_agent" description: str = """ programmer agent is a agent that write code for a given coding task. """ args_schema: Type[ProgramRequirementSchema] = ProgramRequirementSchema env: Environment = Field(default=None) def __init__(self, env: Environment): super().__init__() self.env = env def _run(self, task: str, task_context: str, project_path: str) -> Any: result = "success" return result ``` And this is the wrong action: ``` Action: ```json { "action": "programmer_agent", "action_input": { "task": { "title": "Implement the requirement", "description": "1. Update the `grpc.proto` file. 2. Design the database and write the create SQL. 3. Implement the database operation interface. 4. Implement the grpc interface." }, "task_context": { "title": "Context", "description": "The project is built with golang, and the database used is relational database. The grpc interface is defined in `grpc.proto`." }, "project_path": "golang.52tt.com/services/tt-rev/offering-room" } } ``` ### Expected behavior the value of action_input should be : ```json { "action": "programmer_agent", "action_input": { "task": "1. Update the `grpc.proto` file. 2. Design the database and write the create SQL. 3. Implement the database operation interface. 4. Implement the grpc interface.", "task_context": "The project is built with golang, and the database used is relational database. The grpc interface is defined in `grpc.proto`.", "project_path": "golang.52tt.com/services/tt-rev/offering-room" } } ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14434/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14434/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14433
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14433/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14433/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14433/events
https://github.com/langchain-ai/langchain/pull/14433
2,032,106,242
PR_kwDOIPDwls5hfpUb
14,433
Add option to preserve headers in MarkdownHeaderTextSplitter
{ "login": "finnless", "id": 6785029, "node_id": "MDQ6VXNlcjY3ODUwMjk=", "avatar_url": "https://avatars.githubusercontent.com/u/6785029?v=4", "gravatar_id": "", "url": "https://api.github.com/users/finnless", "html_url": "https://github.com/finnless", "followers_url": "https://api.github.com/users/finnless/followers", "following_url": "https://api.github.com/users/finnless/following{/other_user}", "gists_url": "https://api.github.com/users/finnless/gists{/gist_id}", "starred_url": "https://api.github.com/users/finnless/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/finnless/subscriptions", "organizations_url": "https://api.github.com/users/finnless/orgs", "repos_url": "https://api.github.com/users/finnless/repos", "events_url": "https://api.github.com/users/finnless/events{/privacy}", "received_events_url": "https://api.github.com/users/finnless/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-08T07:42:55
2024-01-03T06:34:52
2024-01-03T06:34:52
CONTRIBUTOR
null
- **Description:** `MarkdownHeaderTextSplitter` currently strips header lines from chunked content. Many applications require these header lines are preserved. This adds an optional parameter to preserve those headers in the chunked content. - **Issue:** #2836 (relevant) - **Dependencies:** - - **Tag maintainer:** @baskaryan - **Twitter handle:** @finnless Unit tests and new examples in notebook included. cc @rlancemartin
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14433/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14433", "html_url": "https://github.com/langchain-ai/langchain/pull/14433", "diff_url": "https://github.com/langchain-ai/langchain/pull/14433.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14433.patch", "merged_at": "2024-01-03T06:34:52" }
https://api.github.com/repos/langchain-ai/langchain/issues/14432
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14432/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14432/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14432/events
https://github.com/langchain-ai/langchain/pull/14432
2,032,095,439
PR_kwDOIPDwls5hfnDf
14,432
Improvement: Correct type annotation for azure_ad_token_provider Closed: #14402
{ "login": "169", "id": 10000925, "node_id": "MDQ6VXNlcjEwMDAwOTI1", "avatar_url": "https://avatars.githubusercontent.com/u/10000925?v=4", "gravatar_id": "", "url": "https://api.github.com/users/169", "html_url": "https://github.com/169", "followers_url": "https://api.github.com/users/169/followers", "following_url": "https://api.github.com/users/169/following{/other_user}", "gists_url": "https://api.github.com/users/169/gists{/gist_id}", "starred_url": "https://api.github.com/users/169/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/169/subscriptions", "organizations_url": "https://api.github.com/users/169/orgs", "repos_url": "https://api.github.com/users/169/repos", "events_url": "https://api.github.com/users/169/events{/privacy}", "received_events_url": "https://api.github.com/users/169/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541141061, "node_id": "LA_kwDOIPDwls8AAAABSkcaRQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20embeddings", "name": "area: embeddings", "color": "C5DEF5", "default": false, "description": "Related to text embedding models module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
{ "login": "eyurtsev", "id": 3205522, "node_id": "MDQ6VXNlcjMyMDU1MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/3205522?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eyurtsev", "html_url": "https://github.com/eyurtsev", "followers_url": "https://api.github.com/users/eyurtsev/followers", "following_url": "https://api.github.com/users/eyurtsev/following{/other_user}", "gists_url": "https://api.github.com/users/eyurtsev/gists{/gist_id}", "starred_url": "https://api.github.com/users/eyurtsev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eyurtsev/subscriptions", "organizations_url": "https://api.github.com/users/eyurtsev/orgs", "repos_url": "https://api.github.com/users/eyurtsev/repos", "events_url": "https://api.github.com/users/eyurtsev/events{/privacy}", "received_events_url": "https://api.github.com/users/eyurtsev/received_events", "type": "User", "site_admin": false }
[ { "login": "eyurtsev", "id": 3205522, "node_id": "MDQ6VXNlcjMyMDU1MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/3205522?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eyurtsev", "html_url": "https://github.com/eyurtsev", "followers_url": "https://api.github.com/users/eyurtsev/followers", "following_url": "https://api.github.com/users/eyurtsev/following{/other_user}", "gists_url": "https://api.github.com/users/eyurtsev/gists{/gist_id}", "starred_url": "https://api.github.com/users/eyurtsev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eyurtsev/subscriptions", "organizations_url": "https://api.github.com/users/eyurtsev/orgs", "repos_url": "https://api.github.com/users/eyurtsev/repos", "events_url": "https://api.github.com/users/eyurtsev/events{/privacy}", "received_events_url": "https://api.github.com/users/eyurtsev/received_events", "type": "User", "site_admin": false } ]
null
3
2023-12-08T07:35:47
2023-12-13T22:37:40
2023-12-13T22:37:39
CONTRIBUTOR
null
Description Fix https://github.com/langchain-ai/langchain/issues/14402, Similar changes: https://github.com/langchain-ai/langchain/pull/14166 Twitter handle [lin_bob57617](https://twitter.com/lin_bob57617)
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14432/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14432/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14432", "html_url": "https://github.com/langchain-ai/langchain/pull/14432", "diff_url": "https://github.com/langchain-ai/langchain/pull/14432.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14432.patch", "merged_at": "2023-12-13T22:37:39" }
https://api.github.com/repos/langchain-ai/langchain/issues/14431
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14431/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14431/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14431/events
https://github.com/langchain-ai/langchain/issues/14431
2,032,065,241
I_kwDOIPDwls55HtrZ
14,431
Bug: ImportError for ElasticsearchStore
{ "login": "brandonkzw", "id": 3462248, "node_id": "MDQ6VXNlcjM0NjIyNDg=", "avatar_url": "https://avatars.githubusercontent.com/u/3462248?v=4", "gravatar_id": "", "url": "https://api.github.com/users/brandonkzw", "html_url": "https://github.com/brandonkzw", "followers_url": "https://api.github.com/users/brandonkzw/followers", "following_url": "https://api.github.com/users/brandonkzw/following{/other_user}", "gists_url": "https://api.github.com/users/brandonkzw/gists{/gist_id}", "starred_url": "https://api.github.com/users/brandonkzw/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/brandonkzw/subscriptions", "organizations_url": "https://api.github.com/users/brandonkzw/orgs", "repos_url": "https://api.github.com/users/brandonkzw/repos", "events_url": "https://api.github.com/users/brandonkzw/events{/privacy}", "received_events_url": "https://api.github.com/users/brandonkzw/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 6077048506, "node_id": "LA_kwDOIPDwls8AAAABajhmug", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20elasticsearch", "name": "integration: elasticsearch", "color": "DAB5EC", "default": false, "description": "Related to elastic/elasticsearch integrations" } ]
closed
false
null
[]
null
3
2023-12-08T07:14:10
2023-12-08T15:16:20
2023-12-08T15:16:20
NONE
null
### System Info Langchain Version: 0.0.346 Python: 3.11.4 ### Who can help? @eyurtsev ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [X] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ```python from langchain.vectorstores import ElasticsearchStore ``` Results in ``` File "C:\Users\XXX\Desktop\Projects\XXX\api\controllers\Vector.py", line 5, in <module> from langchain.vectorstores import ElasticsearchStore ImportError: cannot import name 'ElasticsearchStore' from 'langchain.vectorstores' ``` or ```python from langchain.vectorstores.elasticsearch import ElasticsearchStore ``` Results in ``` File "C:\Users\XXX\Desktop\Projects\XXX\api\controllers\Vector.py", line 5, in <module> from langchain.vectorstores.elasticsearch import ElasticsearchStore ModuleNotFoundError: No module named 'langchain.vectorstores.elasticsearch' ``` ### Expected behavior I am upgrading from `langchain==0.0.279` to `langchain==0.0.346` and this is the issue that arised. Expected behavior would be import successfully, new langchain version does not seems to be backward compatible for `ElasticsearchStore`
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14431/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14431/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14430
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14430/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14430/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14430/events
https://github.com/langchain-ai/langchain/pull/14430
2,031,974,974
PR_kwDOIPDwls5hfMqr
14,430
fix imports from core
{ "login": "hwchase17", "id": 11986836, "node_id": "MDQ6VXNlcjExOTg2ODM2", "avatar_url": "https://avatars.githubusercontent.com/u/11986836?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hwchase17", "html_url": "https://github.com/hwchase17", "followers_url": "https://api.github.com/users/hwchase17/followers", "following_url": "https://api.github.com/users/hwchase17/following{/other_user}", "gists_url": "https://api.github.com/users/hwchase17/gists{/gist_id}", "starred_url": "https://api.github.com/users/hwchase17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hwchase17/subscriptions", "organizations_url": "https://api.github.com/users/hwchase17/orgs", "repos_url": "https://api.github.com/users/hwchase17/repos", "events_url": "https://api.github.com/users/hwchase17/events{/privacy}", "received_events_url": "https://api.github.com/users/hwchase17/received_events", "type": "User", "site_admin": false }
[ { "id": 4899412369, "node_id": "LA_kwDOIPDwls8AAAABJAcZkQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20agent", "name": "area: agent", "color": "BFD4F2", "default": false, "description": "Related to agents module" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-08T05:55:03
2023-12-08T17:33:36
2023-12-08T17:33:35
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14430/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14430/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14430", "html_url": "https://github.com/langchain-ai/langchain/pull/14430", "diff_url": "https://github.com/langchain-ai/langchain/pull/14430.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14430.patch", "merged_at": "2023-12-08T17:33:35" }
https://api.github.com/repos/langchain-ai/langchain/issues/14429
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14429/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14429/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14429/events
https://github.com/langchain-ai/langchain/issues/14429
2,031,914,421
I_kwDOIPDwls55HI21
14,429
Retrieval Inability to Filter Based on Metadata in Milvius Database
{ "login": "NishantKumarJ", "id": 67734928, "node_id": "MDQ6VXNlcjY3NzM0OTI4", "avatar_url": "https://avatars.githubusercontent.com/u/67734928?v=4", "gravatar_id": "", "url": "https://api.github.com/users/NishantKumarJ", "html_url": "https://github.com/NishantKumarJ", "followers_url": "https://api.github.com/users/NishantKumarJ/followers", "following_url": "https://api.github.com/users/NishantKumarJ/following{/other_user}", "gists_url": "https://api.github.com/users/NishantKumarJ/gists{/gist_id}", "starred_url": "https://api.github.com/users/NishantKumarJ/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NishantKumarJ/subscriptions", "organizations_url": "https://api.github.com/users/NishantKumarJ/orgs", "repos_url": "https://api.github.com/users/NishantKumarJ/repos", "events_url": "https://api.github.com/users/NishantKumarJ/events{/privacy}", "received_events_url": "https://api.github.com/users/NishantKumarJ/received_events", "type": "User", "site_admin": false }
[ { "id": 4899412369, "node_id": "LA_kwDOIPDwls8AAAABJAcZkQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20agent", "name": "area: agent", "color": "BFD4F2", "default": false, "description": "Related to agents module" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" } ]
open
false
null
[]
null
2
2023-12-08T04:37:35
2023-12-08T04:54:29
null
NONE
null
### System Info Python ==3.11.3 pymilvus== 2.3.1 langchain==0.0.327 openai==0.28.1 ### Who can help? _No response_ ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [X] Vector Stores / Retrievers - [ ] Memory - [X] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction Description: The issue encountered revolves around the inability of the retrieval process to filter data based on metadata, specifically focusing on the 'file_name' object in the metadata. The context pertains to utilizing Milvius as the database for the vector store. Details: Metadata Structure: The metadata comprises a list of dictionaries, where each dictionary holds key-value pairs containing metadata information. The 'file_name' attribute is utilized for filtration purposes. Example Metadata List: [{'page_number': '4', 'file_name': 'Apple_history.pdf', 'source_path': '.../Apple_history.pdf'}, ...] Applied Options and Observations: Attempted a approach by directly using a 'filter_query' with the 'file_name'. filter_query = {"filter": {"file_name": 'samsung.pdf'}, "k": self.top} retriever = vectorstore.as_retriever(search_kwargs=filter_query) # Retrieval of top k results result = retriever.get_relevant_documents(agent_query) Similar observations were made where the retrieval fetched data unrelated to the specified 'samsung.pdf' filename. ### Expected behavior The anticipated functionality was to filter the retrieval process based on the 'file_name' metadata attribute. In scenarios where there are no chunks associated with the specified 'file_name', the retrieval should ideally return no data.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14429/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14429/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14428
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14428/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14428/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14428/events
https://github.com/langchain-ai/langchain/pull/14428
2,031,901,487
PR_kwDOIPDwls5he84P
14,428
Fix scheduled testing
{ "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714119, "node_id": "LA_kwDOIPDwls8AAAABc3-rhw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:M", "name": "size:M", "color": "C5DEF5", "default": false, "description": "This PR changes 30-99 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-08T04:19:10
2023-12-08T18:23:03
2023-12-08T18:23:02
COLLABORATOR
null
- integration tests in pyproject - integration test fixes
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14428/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14428/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14428", "html_url": "https://github.com/langchain-ai/langchain/pull/14428", "diff_url": "https://github.com/langchain-ai/langchain/pull/14428.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14428.patch", "merged_at": "2023-12-08T18:23:02" }
https://api.github.com/repos/langchain-ai/langchain/issues/14427
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14427/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14427/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14427/events
https://github.com/langchain-ai/langchain/pull/14427
2,031,897,790
PR_kwDOIPDwls5he8FA
14,427
Simplify ensemble retriever
{ "login": "Ayenem", "id": 50707385, "node_id": "MDQ6VXNlcjUwNzA3Mzg1", "avatar_url": "https://avatars.githubusercontent.com/u/50707385?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Ayenem", "html_url": "https://github.com/Ayenem", "followers_url": "https://api.github.com/users/Ayenem/followers", "following_url": "https://api.github.com/users/Ayenem/following{/other_user}", "gists_url": "https://api.github.com/users/Ayenem/gists{/gist_id}", "starred_url": "https://api.github.com/users/Ayenem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ayenem/subscriptions", "organizations_url": "https://api.github.com/users/Ayenem/orgs", "repos_url": "https://api.github.com/users/Ayenem/repos", "events_url": "https://api.github.com/users/Ayenem/events{/privacy}", "received_events_url": "https://api.github.com/users/Ayenem/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714119, "node_id": "LA_kwDOIPDwls8AAAABc3-rhw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:M", "name": "size:M", "color": "C5DEF5", "default": false, "description": "This PR changes 30-99 lines, ignoring generated files." } ]
open
false
null
[]
null
1
2023-12-08T04:13:54
2024-01-03T14:55:29
null
NONE
null
- **Description:** code simplification to improve readability and remove unnecessary memory allocations. - **Tag maintainer**: @baskaryan, @eyurtsev, @hwchase17.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14427/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14427/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14427", "html_url": "https://github.com/langchain-ai/langchain/pull/14427", "diff_url": "https://github.com/langchain-ai/langchain/pull/14427.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14427.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14426
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14426/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14426/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14426/events
https://github.com/langchain-ai/langchain/pull/14426
2,031,885,325
PR_kwDOIPDwls5he5aw
14,426
docs `networkx`update
{ "login": "leo-gan", "id": 2256422, "node_id": "MDQ6VXNlcjIyNTY0MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/2256422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/leo-gan", "html_url": "https://github.com/leo-gan", "followers_url": "https://api.github.com/users/leo-gan/followers", "following_url": "https://api.github.com/users/leo-gan/following{/other_user}", "gists_url": "https://api.github.com/users/leo-gan/gists{/gist_id}", "starred_url": "https://api.github.com/users/leo-gan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leo-gan/subscriptions", "organizations_url": "https://api.github.com/users/leo-gan/orgs", "repos_url": "https://api.github.com/users/leo-gan/repos", "events_url": "https://api.github.com/users/leo-gan/events{/privacy}", "received_events_url": "https://api.github.com/users/leo-gan/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 6232714108, "node_id": "LA_kwDOIPDwls8AAAABc3-rfA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:S", "name": "size:S", "color": "BFDADC", "default": false, "description": "This PR changes 10-29 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-08T03:56:11
2023-12-08T21:59:04
2023-12-08T21:39:50
COLLABORATOR
null
Added setting up instruction, package description and link
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14426/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14426/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14426", "html_url": "https://github.com/langchain-ai/langchain/pull/14426", "diff_url": "https://github.com/langchain-ai/langchain/pull/14426.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14426.patch", "merged_at": "2023-12-08T21:39:50" }
https://api.github.com/repos/langchain-ai/langchain/issues/14425
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14425/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14425/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14425/events
https://github.com/langchain-ai/langchain/pull/14425
2,031,860,325
PR_kwDOIPDwls5he0I8
14,425
Update mongodb_atlas docs for GA
{ "login": "baf509", "id": 3084212, "node_id": "MDQ6VXNlcjMwODQyMTI=", "avatar_url": "https://avatars.githubusercontent.com/u/3084212?v=4", "gravatar_id": "", "url": "https://api.github.com/users/baf509", "html_url": "https://github.com/baf509", "followers_url": "https://api.github.com/users/baf509/followers", "following_url": "https://api.github.com/users/baf509/following{/other_user}", "gists_url": "https://api.github.com/users/baf509/gists{/gist_id}", "starred_url": "https://api.github.com/users/baf509/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/baf509/subscriptions", "organizations_url": "https://api.github.com/users/baf509/orgs", "repos_url": "https://api.github.com/users/baf509/repos", "events_url": "https://api.github.com/users/baf509/events{/privacy}", "received_events_url": "https://api.github.com/users/baf509/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 6232714119, "node_id": "LA_kwDOIPDwls8AAAABc3-rhw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:M", "name": "size:M", "color": "C5DEF5", "default": false, "description": "This PR changes 30-99 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-08T03:18:10
2023-12-08T21:23:01
2023-12-08T21:23:01
CONTRIBUTOR
null
Updated the MongoDB Atlas Vector Search docs to indicate the service is Generally Available, updated the example to use the new index definition, and added an example that uses metadata pre-filtering for semantic search
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14425/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14425/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14425", "html_url": "https://github.com/langchain-ai/langchain/pull/14425", "diff_url": "https://github.com/langchain-ai/langchain/pull/14425.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14425.patch", "merged_at": "2023-12-08T21:23:01" }
https://api.github.com/repos/langchain-ai/langchain/issues/14424
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14424/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14424/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14424/events
https://github.com/langchain-ai/langchain/pull/14424
2,031,827,302
PR_kwDOIPDwls5hetIi
14,424
GITLAB_URL should take default https://gitlab.com instead of error
{ "login": "manjunathshiva", "id": 35326118, "node_id": "MDQ6VXNlcjM1MzI2MTE4", "avatar_url": "https://avatars.githubusercontent.com/u/35326118?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manjunathshiva", "html_url": "https://github.com/manjunathshiva", "followers_url": "https://api.github.com/users/manjunathshiva/followers", "following_url": "https://api.github.com/users/manjunathshiva/following{/other_user}", "gists_url": "https://api.github.com/users/manjunathshiva/gists{/gist_id}", "starred_url": "https://api.github.com/users/manjunathshiva/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manjunathshiva/subscriptions", "organizations_url": "https://api.github.com/users/manjunathshiva/orgs", "repos_url": "https://api.github.com/users/manjunathshiva/repos", "events_url": "https://api.github.com/users/manjunathshiva/events{/privacy}", "received_events_url": "https://api.github.com/users/manjunathshiva/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
2
2023-12-08T02:30:24
2023-12-13T03:26:04
2023-12-13T03:22:03
CONTRIBUTOR
null
The fix #14221 has broken default gitlab url which is forcing the users to specify GITLAB_URL for default one. With this fix if GITLAB_URL is not set, the default gitlab url will be taken. <!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** Add a Default URL with https://gitlab.com instead of None - **Issue:** The fix #14221 has broken default gitlab url which is forcing the users to specify GITLAB_URL - **Dependencies:** None - **Tag maintainer:** @hwchase17 - **Twitter handle:** @manjunath_shiva Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14424/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14424/timeline
null
null
true
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14424", "html_url": "https://github.com/langchain-ai/langchain/pull/14424", "diff_url": "https://github.com/langchain-ai/langchain/pull/14424.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14424.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14423
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14423/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14423/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14423/events
https://github.com/langchain-ai/langchain/pull/14423
2,031,803,443
PR_kwDOIPDwls5heoCj
14,423
feat: patch chroma.similarity_search_with_score to return vector id
{ "login": "timothycarambat", "id": 16845892, "node_id": "MDQ6VXNlcjE2ODQ1ODky", "avatar_url": "https://avatars.githubusercontent.com/u/16845892?v=4", "gravatar_id": "", "url": "https://api.github.com/users/timothycarambat", "html_url": "https://github.com/timothycarambat", "followers_url": "https://api.github.com/users/timothycarambat/followers", "following_url": "https://api.github.com/users/timothycarambat/following{/other_user}", "gists_url": "https://api.github.com/users/timothycarambat/gists{/gist_id}", "starred_url": "https://api.github.com/users/timothycarambat/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/timothycarambat/subscriptions", "organizations_url": "https://api.github.com/users/timothycarambat/orgs", "repos_url": "https://api.github.com/users/timothycarambat/repos", "events_url": "https://api.github.com/users/timothycarambat/events{/privacy}", "received_events_url": "https://api.github.com/users/timothycarambat/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5924999838, "node_id": "LA_kwDOIPDwls8AAAABYShSng", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20chroma", "name": "integration: chroma", "color": "B78AF8", "default": false, "description": "Related to ChromaDB" }, { "id": 6232714108, "node_id": "LA_kwDOIPDwls8AAAABc3-rfA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:S", "name": "size:S", "color": "BFDADC", "default": false, "description": "This PR changes 10-29 lines, ignoring generated files." } ]
open
false
null
[]
null
1
2023-12-08T01:56:13
2024-01-03T01:04:23
null
NONE
null
**Description:** In chroma, return the vector_ids for associated vectors when using the `similarity_search_with_score` and `similarity_search_by_vector_with_relevance_scores` so that turning around to manage the vector (update/delete) is instantly available. Right now, there is no easy way to get similarity and get the associated vector id for the results. Given the id on creation can be created in-library or _optionally_ set by the user we should greedily return the id so the user can always manage their vectors easily. **Issue:** #11592, **Dependencies:** N/A **Tag maintainer:** N/A, **Twitter handle:** @mintplexlabs
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14423/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14423/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14423", "html_url": "https://github.com/langchain-ai/langchain/pull/14423", "diff_url": "https://github.com/langchain-ai/langchain/pull/14423.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14423.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14422
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14422/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14422/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14422/events
https://github.com/langchain-ai/langchain/pull/14422
2,031,760,369
PR_kwDOIPDwls5hefCc
14,422
manual mapping
{ "login": "hwchase17", "id": 11986836, "node_id": "MDQ6VXNlcjExOTg2ODM2", "avatar_url": "https://avatars.githubusercontent.com/u/11986836?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hwchase17", "html_url": "https://github.com/hwchase17", "followers_url": "https://api.github.com/users/hwchase17/followers", "following_url": "https://api.github.com/users/hwchase17/following{/other_user}", "gists_url": "https://api.github.com/users/hwchase17/gists{/gist_id}", "starred_url": "https://api.github.com/users/hwchase17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hwchase17/subscriptions", "organizations_url": "https://api.github.com/users/hwchase17/orgs", "repos_url": "https://api.github.com/users/hwchase17/repos", "events_url": "https://api.github.com/users/hwchase17/events{/privacy}", "received_events_url": "https://api.github.com/users/hwchase17/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 6232714130, "node_id": "LA_kwDOIPDwls8AAAABc3-rkg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XL", "name": "size:XL", "color": "D4C5F9", "default": false, "description": "This PR changes 500-999 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-08T01:09:57
2023-12-09T00:29:34
2023-12-09T00:29:34
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14422/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14422/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14422", "html_url": "https://github.com/langchain-ai/langchain/pull/14422", "diff_url": "https://github.com/langchain-ai/langchain/pull/14422.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14422.patch", "merged_at": "2023-12-09T00:29:33" }
https://api.github.com/repos/langchain-ai/langchain/issues/14420
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14420/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14420/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14420/events
https://github.com/langchain-ai/langchain/pull/14420
2,031,667,512
PR_kwDOIPDwls5heMDE
14,420
feat: masking api key for litellm
{ "login": "xavier-xia-99", "id": 86207636, "node_id": "MDQ6VXNlcjg2MjA3NjM2", "avatar_url": "https://avatars.githubusercontent.com/u/86207636?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xavier-xia-99", "html_url": "https://github.com/xavier-xia-99", "followers_url": "https://api.github.com/users/xavier-xia-99/followers", "following_url": "https://api.github.com/users/xavier-xia-99/following{/other_user}", "gists_url": "https://api.github.com/users/xavier-xia-99/gists{/gist_id}", "starred_url": "https://api.github.com/users/xavier-xia-99/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xavier-xia-99/subscriptions", "organizations_url": "https://api.github.com/users/xavier-xia-99/orgs", "repos_url": "https://api.github.com/users/xavier-xia-99/repos", "events_url": "https://api.github.com/users/xavier-xia-99/events{/privacy}", "received_events_url": "https://api.github.com/users/xavier-xia-99/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
open
false
null
[]
null
1
2023-12-07T23:11:28
2023-12-07T23:11:40
null
NONE
null
Description: Masking API key for LiteLLM Chat Model to protect user secrets. Issue: https://github.com/langchain-ai/langchain/issues/12165 Dependencies: Litellm and LangChain Tag maintainer: @eyurtsev `make test` skips current unit_test and we are unable to install the dependency `litellm` due to a conflict with `tiktoken` See #14419
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14420/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14420/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14420", "html_url": "https://github.com/langchain-ai/langchain/pull/14420", "diff_url": "https://github.com/langchain-ai/langchain/pull/14420.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14420.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14419
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14419/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14419/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14419/events
https://github.com/langchain-ai/langchain/issues/14419
2,031,666,536
I_kwDOIPDwls55GMVo
14,419
Dependency Conflict between litellm and tiktoken
{ "login": "PeterNotFound114", "id": 98713019, "node_id": "U_kgDOBeI9uw", "avatar_url": "https://avatars.githubusercontent.com/u/98713019?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PeterNotFound114", "html_url": "https://github.com/PeterNotFound114", "followers_url": "https://api.github.com/users/PeterNotFound114/followers", "following_url": "https://api.github.com/users/PeterNotFound114/following{/other_user}", "gists_url": "https://api.github.com/users/PeterNotFound114/gists{/gist_id}", "starred_url": "https://api.github.com/users/PeterNotFound114/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PeterNotFound114/subscriptions", "organizations_url": "https://api.github.com/users/PeterNotFound114/orgs", "repos_url": "https://api.github.com/users/PeterNotFound114/repos", "events_url": "https://api.github.com/users/PeterNotFound114/events{/privacy}", "received_events_url": "https://api.github.com/users/PeterNotFound114/received_events", "type": "User", "site_admin": false }
[ { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-07T23:10:21
2023-12-07T23:17:09
null
NONE
null
### System Info Langchain Version: 0.0.348 Output from `poetry env info` **Virtualenv** Python: 3.9.12 Implementation: CPython Path: /Users/peternf/Desktop/langchain/libs/langchain/.venv Executable: /Users/peternf/Desktop/langchain/libs/langchain/.venv/bin/python Valid: True **System** Platform: darwin OS: posix Python: 3.9.12 Path: /Users/peternf/opt/miniconda3 Executable: /Users/peternf/opt/miniconda3/bin/python3.9 ### Who can help? @eyurtsev ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [X] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ### Reason to Install litellm @xavier-xia-99 and I are collaborating on finishing the tasks of #12165 for _libs/langchain/langchain/chat_models/litellm.py_. We have finished the implementation and is adding unit tests to verify our logic when we discovered that we need to include litellm for the unit tests, or `make test` will just skip our newly added unit tests. Yet as we try to add the optional dependency litellm according to the instructions provided in langchain/.github/CONTRIBUTING.md, it shows the following dependency conflict. Hence, we will appreciate any help in addressing this conflict or running the CI. Thank you! ### Steps to Reproduce the Behavior 1. Run `poetry add --optional litellm` 2. Error Message: <img width="720" alt="Screenshot 2023-12-07 at 5 50 43 PM" src="https://github.com/langchain-ai/langchain/assets/98713019/3e0d5730-2134-4e11-b901-fbda927bc796"> ### Expected behavior Output of litellm downloads in progress and successful installation of relevant packages.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14419/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14419/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14418
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14418/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14418/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14418/events
https://github.com/langchain-ai/langchain/pull/14418
2,031,656,503
PR_kwDOIPDwls5heJpq
14,418
experimental[patch]: Release 0.0.45
{ "login": "baskaryan", "id": 22008038, "node_id": "MDQ6VXNlcjIyMDA4MDM4", "avatar_url": "https://avatars.githubusercontent.com/u/22008038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/baskaryan", "html_url": "https://github.com/baskaryan", "followers_url": "https://api.github.com/users/baskaryan/followers", "following_url": "https://api.github.com/users/baskaryan/following{/other_user}", "gists_url": "https://api.github.com/users/baskaryan/gists{/gist_id}", "starred_url": "https://api.github.com/users/baskaryan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/baskaryan/subscriptions", "organizations_url": "https://api.github.com/users/baskaryan/orgs", "repos_url": "https://api.github.com/users/baskaryan/repos", "events_url": "https://api.github.com/users/baskaryan/events{/privacy}", "received_events_url": "https://api.github.com/users/baskaryan/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T22:58:40
2023-12-07T23:01:41
2023-12-07T23:01:39
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14418/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14418/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14418", "html_url": "https://github.com/langchain-ai/langchain/pull/14418", "diff_url": "https://github.com/langchain-ai/langchain/pull/14418.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14418.patch", "merged_at": "2023-12-07T23:01:39" }
https://api.github.com/repos/langchain-ai/langchain/issues/14417
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14417/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14417/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14417/events
https://github.com/langchain-ai/langchain/pull/14417
2,031,646,028
PR_kwDOIPDwls5heHVq
14,417
langchain[patch]: Release 0.0.348
{ "login": "baskaryan", "id": 22008038, "node_id": "MDQ6VXNlcjIyMDA4MDM4", "avatar_url": "https://avatars.githubusercontent.com/u/22008038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/baskaryan", "html_url": "https://github.com/baskaryan", "followers_url": "https://api.github.com/users/baskaryan/followers", "following_url": "https://api.github.com/users/baskaryan/following{/other_user}", "gists_url": "https://api.github.com/users/baskaryan/gists{/gist_id}", "starred_url": "https://api.github.com/users/baskaryan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/baskaryan/subscriptions", "organizations_url": "https://api.github.com/users/baskaryan/orgs", "repos_url": "https://api.github.com/users/baskaryan/repos", "events_url": "https://api.github.com/users/baskaryan/events{/privacy}", "received_events_url": "https://api.github.com/users/baskaryan/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T22:46:38
2023-12-07T22:52:44
2023-12-07T22:52:43
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14417/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14417/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14417", "html_url": "https://github.com/langchain-ai/langchain/pull/14417", "diff_url": "https://github.com/langchain-ai/langchain/pull/14417.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14417.patch", "merged_at": "2023-12-07T22:52:43" }
https://api.github.com/repos/langchain-ai/langchain/issues/14416
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14416/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14416/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14416/events
https://github.com/langchain-ai/langchain/pull/14416
2,031,639,122
PR_kwDOIPDwls5heF0d
14,416
docs `promptlayer` pages update
{ "login": "leo-gan", "id": 2256422, "node_id": "MDQ6VXNlcjIyNTY0MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/2256422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/leo-gan", "html_url": "https://github.com/leo-gan", "followers_url": "https://api.github.com/users/leo-gan/followers", "following_url": "https://api.github.com/users/leo-gan/following{/other_user}", "gists_url": "https://api.github.com/users/leo-gan/gists{/gist_id}", "starred_url": "https://api.github.com/users/leo-gan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leo-gan/subscriptions", "organizations_url": "https://api.github.com/users/leo-gan/orgs", "repos_url": "https://api.github.com/users/leo-gan/repos", "events_url": "https://api.github.com/users/leo-gan/events{/privacy}", "received_events_url": "https://api.github.com/users/leo-gan/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714119, "node_id": "LA_kwDOIPDwls8AAAABc3-rhw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:M", "name": "size:M", "color": "C5DEF5", "default": false, "description": "This PR changes 30-99 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T22:39:18
2023-12-08T00:38:38
2023-12-07T23:48:10
COLLABORATOR
null
Updated provider page by adding LLM and ChatLLM references; removed a content that is duplicate text from the LLM referenced page. Updated the collback page
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14416/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14416/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14416", "html_url": "https://github.com/langchain-ai/langchain/pull/14416", "diff_url": "https://github.com/langchain-ai/langchain/pull/14416.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14416.patch", "merged_at": "2023-12-07T23:48:10" }
https://api.github.com/repos/langchain-ai/langchain/issues/14415
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14415/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14415/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14415/events
https://github.com/langchain-ai/langchain/pull/14415
2,031,633,057
PR_kwDOIPDwls5heEgl
14,415
core[patch]: Release 0.0.12
{ "login": "baskaryan", "id": 22008038, "node_id": "MDQ6VXNlcjIyMDA4MDM4", "avatar_url": "https://avatars.githubusercontent.com/u/22008038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/baskaryan", "html_url": "https://github.com/baskaryan", "followers_url": "https://api.github.com/users/baskaryan/followers", "following_url": "https://api.github.com/users/baskaryan/following{/other_user}", "gists_url": "https://api.github.com/users/baskaryan/gists{/gist_id}", "starred_url": "https://api.github.com/users/baskaryan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/baskaryan/subscriptions", "organizations_url": "https://api.github.com/users/baskaryan/orgs", "repos_url": "https://api.github.com/users/baskaryan/repos", "events_url": "https://api.github.com/users/baskaryan/events{/privacy}", "received_events_url": "https://api.github.com/users/baskaryan/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T22:32:46
2023-12-07T22:37:01
2023-12-07T22:37:00
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14415/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14415/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14415", "html_url": "https://github.com/langchain-ai/langchain/pull/14415", "diff_url": "https://github.com/langchain-ai/langchain/pull/14415.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14415.patch", "merged_at": "2023-12-07T22:37:00" }
https://api.github.com/repos/langchain-ai/langchain/issues/14414
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14414/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14414/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14414/events
https://github.com/langchain-ai/langchain/pull/14414
2,031,572,756
PR_kwDOIPDwls5hd3QW
14,414
core[patch], langchain[patch], experimental[patch]: import CI
{ "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T21:41:13
2023-12-08T19:28:56
2023-12-08T19:28:55
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14414/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14414/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14414", "html_url": "https://github.com/langchain-ai/langchain/pull/14414", "diff_url": "https://github.com/langchain-ai/langchain/pull/14414.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14414.patch", "merged_at": "2023-12-08T19:28:55" }
https://api.github.com/repos/langchain-ai/langchain/issues/14413
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14413/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14413/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14413/events
https://github.com/langchain-ai/langchain/pull/14413
2,031,528,491
PR_kwDOIPDwls5hdtmI
14,413
Update prompts.py
{ "login": "Sebas102507", "id": 52805660, "node_id": "MDQ6VXNlcjUyODA1NjYw", "avatar_url": "https://avatars.githubusercontent.com/u/52805660?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Sebas102507", "html_url": "https://github.com/Sebas102507", "followers_url": "https://api.github.com/users/Sebas102507/followers", "following_url": "https://api.github.com/users/Sebas102507/following{/other_user}", "gists_url": "https://api.github.com/users/Sebas102507/gists{/gist_id}", "starred_url": "https://api.github.com/users/Sebas102507/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Sebas102507/subscriptions", "organizations_url": "https://api.github.com/users/Sebas102507/orgs", "repos_url": "https://api.github.com/users/Sebas102507/repos", "events_url": "https://api.github.com/users/Sebas102507/events{/privacy}", "received_events_url": "https://api.github.com/users/Sebas102507/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714144, "node_id": "LA_kwDOIPDwls8AAAABc3-roA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XXL", "name": "size:XXL", "color": "5319E7", "default": false, "description": "This PR changes 1000+ lines, ignoring generated files." } ]
closed
false
null
[]
null
2
2023-12-07T21:03:51
2024-01-03T01:05:25
2024-01-03T01:05:24
NONE
null
<!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** a description of the change, - **Issue:** the issue # it fixes (if applicable), - **Dependencies:** any dependencies required for this change, - **Tag maintainer:** for a quicker response, tag the relevant maintainer (see below), - **Twitter handle:** we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out! Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14413/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14413/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14413", "html_url": "https://github.com/langchain-ai/langchain/pull/14413", "diff_url": "https://github.com/langchain-ai/langchain/pull/14413.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14413.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14412
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14412/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14412/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14412/events
https://github.com/langchain-ai/langchain/issues/14412
2,031,444,278
I_kwDOIPDwls55FWE2
14,412
Issue: <Zilliz and Milvus metadata field and memory seperation>
{ "login": "Ahmed14z", "id": 93006780, "node_id": "U_kgDOBYsrvA", "avatar_url": "https://avatars.githubusercontent.com/u/93006780?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Ahmed14z", "html_url": "https://github.com/Ahmed14z", "followers_url": "https://api.github.com/users/Ahmed14z/followers", "following_url": "https://api.github.com/users/Ahmed14z/following{/other_user}", "gists_url": "https://api.github.com/users/Ahmed14z/gists{/gist_id}", "starred_url": "https://api.github.com/users/Ahmed14z/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ahmed14z/subscriptions", "organizations_url": "https://api.github.com/users/Ahmed14z/orgs", "repos_url": "https://api.github.com/users/Ahmed14z/repos", "events_url": "https://api.github.com/users/Ahmed14z/events{/privacy}", "received_events_url": "https://api.github.com/users/Ahmed14z/received_events", "type": "User", "site_admin": false }
[ { "id": 4899126096, "node_id": "LA_kwDOIPDwls8AAAABJAK7UA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20memory", "name": "area: memory", "color": "BFDADC", "default": false, "description": "Related to memory module" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" } ]
open
false
null
[]
null
1
2023-12-07T20:08:44
2023-12-07T20:15:19
null
NONE
null
### Issue you'd like to raise. im trying to create a metadata to separate user id fields vectors, I searched a lot and couldn't find anything , im using zilliz vector store , I tried using the userid as memory key but it's not possible , any ideas ? Im using the docs is automatically saved and retrieved from the saved collection on zilliz , so I can't edit the docs too , im just trying to add meta fields when user chats and when retrieved for context. ``` vectordb = Milvus.from_documents( {} , embeddings, connection_args={ "uri": ZILLIZ_CLOUD_URI, "token": ZILLIZ_CLOUD_API_KEY, # API key, for serverless clusters which can be used as replacements for user and password "secure": True, }, ) # vectordb. retriever = Milvus.as_retriever(vectordb,search_kwargs= {"k":15 , 'user_id': "a3"} ) # here we use userid with "a" for retreiving memory # print(retriever) memory= VectorStoreRetrieverMemory(retriever=retriever , memory_key="history" , metadata={"user_id": "a3"} ) chain = ConversationChain(llm=self.llm, memory=memory, verbose=True,prompt = PROMPT , metadata={"user_id": "a3"}) res = chain.predict(input=input_text) # with chain_recorder as recording: # llm_response = chain(input_text) return res ``` ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14412/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14412/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14410
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14410/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14410/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14410/events
https://github.com/langchain-ai/langchain/pull/14410
2,031,383,753
PR_kwDOIPDwls5hdNxN
14,410
'on_llm_new_token' was never awaited: resolved
{ "login": "triyam", "id": 55938092, "node_id": "MDQ6VXNlcjU1OTM4MDky", "avatar_url": "https://avatars.githubusercontent.com/u/55938092?v=4", "gravatar_id": "", "url": "https://api.github.com/users/triyam", "html_url": "https://github.com/triyam", "followers_url": "https://api.github.com/users/triyam/followers", "following_url": "https://api.github.com/users/triyam/following{/other_user}", "gists_url": "https://api.github.com/users/triyam/gists{/gist_id}", "starred_url": "https://api.github.com/users/triyam/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/triyam/subscriptions", "organizations_url": "https://api.github.com/users/triyam/orgs", "repos_url": "https://api.github.com/users/triyam/repos", "events_url": "https://api.github.com/users/triyam/events{/privacy}", "received_events_url": "https://api.github.com/users/triyam/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
3
2023-12-07T19:23:36
2023-12-08T13:36:15
2023-12-07T19:51:52
NONE
null
Issue #14399 - **Description:** Added async to `on_llm_new_token` function in `CallbackManagerForLLMRun` class in `manager.py` file present in `libs/core/langchain_core`, - **Issue:** It fixed the RuntimeWarning: coroutine 'AsyncCallbackManagerForLLMRun.on_llm_new_token' was never awaited ChatGPT', - **Twitter handle:** https://twitter.com/Triyambaka58284 It is passing the `make format`, `make lint` and `make test` to check this locally. Kindly reviews my PR @baskaryan, @eyurtsev, @hwchase17.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14410/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14410/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14410", "html_url": "https://github.com/langchain-ai/langchain/pull/14410", "diff_url": "https://github.com/langchain-ai/langchain/pull/14410.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14410.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14409
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14409/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14409/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14409/events
https://github.com/langchain-ai/langchain/issues/14409
2,031,382,949
I_kwDOIPDwls55FHGl
14,409
FAISS db.delete() says `ids` is required even when it is Optional
{ "login": "anjanvb", "id": 84933469, "node_id": "MDQ6VXNlcjg0OTMzNDY5", "avatar_url": "https://avatars.githubusercontent.com/u/84933469?v=4", "gravatar_id": "", "url": "https://api.github.com/users/anjanvb", "html_url": "https://github.com/anjanvb", "followers_url": "https://api.github.com/users/anjanvb/followers", "following_url": "https://api.github.com/users/anjanvb/following{/other_user}", "gists_url": "https://api.github.com/users/anjanvb/gists{/gist_id}", "starred_url": "https://api.github.com/users/anjanvb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anjanvb/subscriptions", "organizations_url": "https://api.github.com/users/anjanvb/orgs", "repos_url": "https://api.github.com/users/anjanvb/repos", "events_url": "https://api.github.com/users/anjanvb/events{/privacy}", "received_events_url": "https://api.github.com/users/anjanvb/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" } ]
open
false
null
[]
null
1
2023-12-07T19:22:56
2023-12-07T19:28:46
null
CONTRIBUTOR
null
### System Info LangChain version : Latest ```python def delete(self, ids: Optional[List[str]] = None, **kwargs: Any) -> Optional[bool]: ``` [This check](https://github.com/langchain-ai/langchain/blob/54040b00a4a05e81964a1a7f7edbf0b830d4395c/libs/langchain/langchain/vectorstores/faiss.py#L798) causes the issue. ### Who can help? @eyurtsev ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [X] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ```python db = FAISS.from_documents(text_pages, embeddings) db.delete() ``` Error ``` --------------------------------------------------------------------------- ValueError Traceback (most recent call last) Cell In[51], line 1 ----> 1 db.delete() File /opt/conda/lib/python3.10/site-packages/langchain/vectorstores/faiss.py:799, in FAISS.delete(self, ids, **kwargs) 789 """Delete by ID. These are the IDs in the vectorstore. 790 791 Args: (...) 796 False otherwise, None if not implemented. 797 """ 798 if ids is None: --> 799 raise ValueError("No ids provided to delete.") 800 missing_ids = set(ids).difference(self.index_to_docstore_id.values()) 801 if missing_ids: ValueError: No ids provided to delete. ``` ### Expected behavior The index should be deleted without needing to pass an index `id`.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14409/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14409/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14408
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14408/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14408/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14408/events
https://github.com/langchain-ai/langchain/pull/14408
2,031,365,825
PR_kwDOIPDwls5hdJ2A
14,408
Vectara summarization
{ "login": "ofermend", "id": 1823547, "node_id": "MDQ6VXNlcjE4MjM1NDc=", "avatar_url": "https://avatars.githubusercontent.com/u/1823547?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ofermend", "html_url": "https://github.com/ofermend", "followers_url": "https://api.github.com/users/ofermend/followers", "following_url": "https://api.github.com/users/ofermend/following{/other_user}", "gists_url": "https://api.github.com/users/ofermend/gists{/gist_id}", "starred_url": "https://api.github.com/users/ofermend/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ofermend/subscriptions", "organizations_url": "https://api.github.com/users/ofermend/orgs", "repos_url": "https://api.github.com/users/ofermend/repos", "events_url": "https://api.github.com/users/ofermend/events{/privacy}", "received_events_url": "https://api.github.com/users/ofermend/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700863, "node_id": "LA_kwDOIPDwls8AAAABUpidvw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:enhancement", "name": "auto:enhancement", "color": "C2E0C6", "default": false, "description": "A large net-new component, integration, or chain. Use sparingly. The largest features" }, { "id": 6232714144, "node_id": "LA_kwDOIPDwls8AAAABc3-roA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XXL", "name": "size:XXL", "color": "5319E7", "default": false, "description": "This PR changes 1000+ lines, ignoring generated files." } ]
closed
false
null
[]
null
15
2023-12-07T19:09:58
2023-12-20T19:45:40
2023-12-20T19:45:39
CONTRIBUTOR
null
- **Description:** Adding Summarization to Vectara, to reflect it provides not only vector-store type functionality but also can return a summary. Also added: * MMR capability (in the Vectara platform side) * Updated templates * Updated documentation and IPYNB examples - **Tag maintainer:** @baskaryan - **Twitter handle:** @ofermend
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14408/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14408/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14408", "html_url": "https://github.com/langchain-ai/langchain/pull/14408", "diff_url": "https://github.com/langchain-ai/langchain/pull/14408.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14408.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14407
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14407/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14407/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14407/events
https://github.com/langchain-ai/langchain/pull/14407
2,031,313,484
PR_kwDOIPDwls5hc-lQ
14,407
core dependencies update
{ "login": "leo-gan", "id": 2256422, "node_id": "MDQ6VXNlcjIyNTY0MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/2256422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/leo-gan", "html_url": "https://github.com/leo-gan", "followers_url": "https://api.github.com/users/leo-gan/followers", "following_url": "https://api.github.com/users/leo-gan/following{/other_user}", "gists_url": "https://api.github.com/users/leo-gan/gists{/gist_id}", "starred_url": "https://api.github.com/users/leo-gan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leo-gan/subscriptions", "organizations_url": "https://api.github.com/users/leo-gan/orgs", "repos_url": "https://api.github.com/users/leo-gan/repos", "events_url": "https://api.github.com/users/leo-gan/events{/privacy}", "received_events_url": "https://api.github.com/users/leo-gan/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
3
2023-12-07T18:31:18
2023-12-07T21:28:11
2023-12-07T20:09:29
COLLABORATOR
null
Updated `pyproject.toml` with missed dependencies. Several dependencies are missed in the `pyproject.toml`. They are explicitly imported in code. I listed the files and code lines below. Those packages are still presented in the `poetry.lock`. So, those missed dependencies do not break anything. This update is for consistency. Every explicitly imported package should be presented in the dependency configuration. Note: `poetry.lock` is updated because `anyio` version here (=>4.0 - from poetry.lock) conflicts with `langchain` version (<4.0) > langchain_core/language_models/llms.py: > langchain_core/prompts/base.py: > langchain_core/prompts/loading.py: > import yaml > > langchain_core/output_parsers/base.py: > from typing_extensions import get_args > > langchain_core/runnables/base.py: > from typing_extensions import Literal, get_args > > langchain_core/runnables/config.py: > langchain_core/runnables/router.py: > from typing_extensions import TypedDict > > langchain_core/utils/iter.py: > from typing_extensions import Literal > > langchain_core/tracers/langchain_v1.py: > langchain_core/utils/loading.py: > import requests > > langchain_core/utils/utils.py: > from requests import HTTPError, Response > > langchain_core/tracers/log_stream.py: > from anyio import create_memory_object_stream > > langchain_core/utils/utils.py: > from packaging.version import parse
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14407/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14407/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14407", "html_url": "https://github.com/langchain-ai/langchain/pull/14407", "diff_url": "https://github.com/langchain-ai/langchain/pull/14407.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14407.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14406
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14406/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14406/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14406/events
https://github.com/langchain-ai/langchain/pull/14406
2,031,196,134
PR_kwDOIPDwls5hckaS
14,406
feat(llms): support more tasks in HuggingFaceHub LLM and remove deprecated dep
{ "login": "mspronesti", "id": 44113430, "node_id": "MDQ6VXNlcjQ0MTEzNDMw", "avatar_url": "https://avatars.githubusercontent.com/u/44113430?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mspronesti", "html_url": "https://github.com/mspronesti", "followers_url": "https://api.github.com/users/mspronesti/followers", "following_url": "https://api.github.com/users/mspronesti/following{/other_user}", "gists_url": "https://api.github.com/users/mspronesti/gists{/gist_id}", "starred_url": "https://api.github.com/users/mspronesti/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mspronesti/subscriptions", "organizations_url": "https://api.github.com/users/mspronesti/orgs", "repos_url": "https://api.github.com/users/mspronesti/repos", "events_url": "https://api.github.com/users/mspronesti/events{/privacy}", "received_events_url": "https://api.github.com/users/mspronesti/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714119, "node_id": "LA_kwDOIPDwls8AAAABc3-rhw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:M", "name": "size:M", "color": "C5DEF5", "default": false, "description": "This PR changes 30-99 lines, ignoring generated files." } ]
open
false
null
[]
null
4
2023-12-07T17:22:11
2024-01-17T19:10:51
null
CONTRIBUTOR
null
- **Description:** this PR upgrades the `HuggingFaceHub` LLM: * support more tasks (`translation` and `conversational`) * replaced the deprecated `InferenceApi` with `InferenceClient` * adjusted the overall logic to use the "recommended" model for each task when no model is provided, and vice-versa. - **Tag mainter(s)**: @baskaryan @hwchase17
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14406/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14406/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14406", "html_url": "https://github.com/langchain-ai/langchain/pull/14406", "diff_url": "https://github.com/langchain-ai/langchain/pull/14406.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14406.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14405
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14405/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14405/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14405/events
https://github.com/langchain-ai/langchain/pull/14405
2,031,054,488
PR_kwDOIPDwls5hcFOq
14,405
update LanguageModelInput from List to Sequence
{ "login": "alan910127", "id": 70696274, "node_id": "MDQ6VXNlcjcwNjk2Mjc0", "avatar_url": "https://avatars.githubusercontent.com/u/70696274?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alan910127", "html_url": "https://github.com/alan910127", "followers_url": "https://api.github.com/users/alan910127/followers", "following_url": "https://api.github.com/users/alan910127/following{/other_user}", "gists_url": "https://api.github.com/users/alan910127/gists{/gist_id}", "starred_url": "https://api.github.com/users/alan910127/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alan910127/subscriptions", "organizations_url": "https://api.github.com/users/alan910127/orgs", "repos_url": "https://api.github.com/users/alan910127/repos", "events_url": "https://api.github.com/users/alan910127/events{/privacy}", "received_events_url": "https://api.github.com/users/alan910127/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T15:55:33
2024-01-03T02:49:02
2024-01-03T02:49:01
CONTRIBUTOR
null
<!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** a description of the change, - **Issue:** the issue # it fixes (if applicable), - **Dependencies:** any dependencies required for this change, - **Tag maintainer:** for a quicker response, tag the relevant maintainer (see below), - **Twitter handle:** we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out! Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. --> - **Description:** Update (one of the branches of) the type alias `LanguageModelInput` from `List[BaseMessage]` to `Sequence[BaseMessage]` to disable the error from Pylance's type checker (see below). - **Issue:** N/A. - **Dependencies:** No changes. - **Tag maintainer:** @baskaryan @eyurtsev - **Twitter handle:** @alan_0127 --- - **The error:** ![image](https://github.com/langchain-ai/langchain/assets/70696274/dfbe53ac-fc6c-4051-8e93-f27287909fc5)
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14405/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14405/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14405", "html_url": "https://github.com/langchain-ai/langchain/pull/14405", "diff_url": "https://github.com/langchain-ai/langchain/pull/14405.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14405.patch", "merged_at": "2024-01-03T02:49:01" }
https://api.github.com/repos/langchain-ai/langchain/issues/14404
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14404/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14404/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14404/events
https://github.com/langchain-ai/langchain/issues/14404
2,031,053,527
I_kwDOIPDwls55D2rX
14,404
db_chain_sql_out.return_sql
{ "login": "Nageshyr", "id": 20627783, "node_id": "MDQ6VXNlcjIwNjI3Nzgz", "avatar_url": "https://avatars.githubusercontent.com/u/20627783?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Nageshyr", "html_url": "https://github.com/Nageshyr", "followers_url": "https://api.github.com/users/Nageshyr/followers", "following_url": "https://api.github.com/users/Nageshyr/following{/other_user}", "gists_url": "https://api.github.com/users/Nageshyr/gists{/gist_id}", "starred_url": "https://api.github.com/users/Nageshyr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Nageshyr/subscriptions", "organizations_url": "https://api.github.com/users/Nageshyr/orgs", "repos_url": "https://api.github.com/users/Nageshyr/repos", "events_url": "https://api.github.com/users/Nageshyr/events{/privacy}", "received_events_url": "https://api.github.com/users/Nageshyr/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
4
2023-12-07T15:55:01
2023-12-08T19:51:48
null
NONE
null
### System Info from langchain.llms import GooglePalm from sqlalchemy import create_engine from langchain.utilities import SQLDatabase from langchain.llms import GooglePalm from langchain_experimental.sql import SQLDatabaseChain ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction st.write(db_chain_sql_out.return_sql) is returning bool value "True" Instead of the model generated actual SQL Statement - I am using Google Palm - is this the normal output? ### Expected behavior Expecting model generated SQL
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14404/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14404/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14403
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14403/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14403/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14403/events
https://github.com/langchain-ai/langchain/issues/14403
2,031,037,974
I_kwDOIPDwls55Dy4W
14,403
Issue: ElasticsearchStore with ssl_verify = {'verify_certs':False} does not work
{ "login": "Civel-1", "id": 28729460, "node_id": "MDQ6VXNlcjI4NzI5NDYw", "avatar_url": "https://avatars.githubusercontent.com/u/28729460?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Civel-1", "html_url": "https://github.com/Civel-1", "followers_url": "https://api.github.com/users/Civel-1/followers", "following_url": "https://api.github.com/users/Civel-1/following{/other_user}", "gists_url": "https://api.github.com/users/Civel-1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Civel-1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Civel-1/subscriptions", "organizations_url": "https://api.github.com/users/Civel-1/orgs", "repos_url": "https://api.github.com/users/Civel-1/repos", "events_url": "https://api.github.com/users/Civel-1/events{/privacy}", "received_events_url": "https://api.github.com/users/Civel-1/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 6077048506, "node_id": "LA_kwDOIPDwls8AAAABajhmug", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20elasticsearch", "name": "integration: elasticsearch", "color": "DAB5EC", "default": false, "description": "Related to elastic/elasticsearch integrations" } ]
closed
false
null
[]
null
4
2023-12-07T15:46:15
2024-01-16T08:10:14
2024-01-03T00:48:21
NONE
null
### Issue you'd like to raise. I am using langchain 0.0.316 an trying to create a ElasticsearchStore to do some similarity_search However, whenever I try to create it (using from_documents or not) I get the following error : `raise ValueError("check_hostname requires server_hostname")` This is a SSL error, and I suspect it to be the problem as I cannot use SSL. Somewhere else in the project, I cannot with Python to Elastic using verify_certs = False and everything works perfectly. Thus I tried to create ElasticsearchStore with the following arguments : ``` db = ElasticsearchStore(texts, es_url='...', index_name = '...', embedding, ssl_verify = {'verify_certs'=False'}) ``` But I still have the error and nothing has changed. How can I make langchain to initialize Elastic without checking for ssl certificates ? ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14403/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14403/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14402
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14402/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14402/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14402/events
https://github.com/langchain-ai/langchain/issues/14402
2,031,016,359
I_kwDOIPDwls55Dtmn
14,402
AzureOpenAIEmbeddings cannot authenticate with azure_ad_token_provider
{ "login": "proschowsky", "id": 106142807, "node_id": "U_kgDOBlOcVw", "avatar_url": "https://avatars.githubusercontent.com/u/106142807?v=4", "gravatar_id": "", "url": "https://api.github.com/users/proschowsky", "html_url": "https://github.com/proschowsky", "followers_url": "https://api.github.com/users/proschowsky/followers", "following_url": "https://api.github.com/users/proschowsky/following{/other_user}", "gists_url": "https://api.github.com/users/proschowsky/gists{/gist_id}", "starred_url": "https://api.github.com/users/proschowsky/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/proschowsky/subscriptions", "organizations_url": "https://api.github.com/users/proschowsky/orgs", "repos_url": "https://api.github.com/users/proschowsky/repos", "events_url": "https://api.github.com/users/proschowsky/events{/privacy}", "received_events_url": "https://api.github.com/users/proschowsky/received_events", "type": "User", "site_admin": false }
[ { "id": 5541141061, "node_id": "LA_kwDOIPDwls8AAAABSkcaRQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20embeddings", "name": "area: embeddings", "color": "C5DEF5", "default": false, "description": "Related to text embedding models module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" } ]
closed
false
null
[]
null
9
2023-12-07T15:35:19
2023-12-19T09:29:58
2023-12-13T22:37:40
NONE
null
### System Info Langchain: 0.0.346 OpenAI: 1.3.7 ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [X] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction Simple script to authenticate to Azure with RBAC ``` from langchain.embeddings import AzureOpenAIEmbeddings from azure.identity import DefaultAzureCredential, get_bearer_token_provider token_provider = get_bearer_token_provider(DefaultAzureCredential(), "https://cognitiveservices.azure.com/.default") embeddings = AzureOpenAIEmbeddings(azure_endpoint='xxxxxxx', azure_ad_token_provider=token_provider) ``` ### Expected behavior Should authenticate, but is seems like the `azure_ad_token_provider` is not added to the values dict langchain/embeddings/azure_openai.py line 80-86 ``` values["azure_endpoint"] = values["azure_endpoint"] or os.getenv( "AZURE_OPENAI_ENDPOINT" ) values["azure_ad_token"] = values["azure_ad_token"] or os.getenv( "AZURE_OPENAI_AD_TOKEN" ) ``` Other parameters are added to values, but not `azure_ad_token_provider`
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14402/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14402/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14401
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14401/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14401/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14401/events
https://github.com/langchain-ai/langchain/issues/14401
2,030,975,852
I_kwDOIPDwls55Djts
14,401
Issue: <Trouble with langchain Library: Error in LLMChain Validation>
{ "login": "GRPUI", "id": 57088395, "node_id": "MDQ6VXNlcjU3MDg4Mzk1", "avatar_url": "https://avatars.githubusercontent.com/u/57088395?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GRPUI", "html_url": "https://github.com/GRPUI", "followers_url": "https://api.github.com/users/GRPUI/followers", "following_url": "https://api.github.com/users/GRPUI/following{/other_user}", "gists_url": "https://api.github.com/users/GRPUI/gists{/gist_id}", "starred_url": "https://api.github.com/users/GRPUI/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GRPUI/subscriptions", "organizations_url": "https://api.github.com/users/GRPUI/orgs", "repos_url": "https://api.github.com/users/GRPUI/repos", "events_url": "https://api.github.com/users/GRPUI/events{/privacy}", "received_events_url": "https://api.github.com/users/GRPUI/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-07T15:17:37
2023-12-07T15:26:47
null
NONE
null
### Issue you'd like to raise. Hello community, I'm currently working on a project that involves using the langchain library for natural language processing. I'm encountering an issue with the LLMChain class, and I'm hoping someone can help me troubleshoot. I've initialized a Hugging Face pipeline and constructed a prompt using PromptTemplate. However, when I attempt to load a QA chain using the load_qa_chain function, I get a ValidationError related to the Runnable type. The error suggests that an instance of Runnable is expected, but it seems there's a mismatch. Here's a simplified version of my code: ``` from langchain.prompts import PromptTemplate from langchain import load_qa_chain from transformers import HuggingFacePipeline hf = HuggingFacePipeline.from_model_id( model_id="ai-forever/rugpt3large_based_on_gpt2", task="text-generation", pipeline_kwargs={"max_new_tokens": 10}, ) prompt = """Question: {question} Answer: {text}""" # The next line is where the error occurs chain = load_qa_chain(hf(prompt=prompt), chain_type="stuff") ``` ``` ValidationError: 2 validation errors for LLMChain llm instance of Runnable expected (type=type_error.arbitrary_type; expected_arbitrary_type=Runnable) llm instance of Runnable expected (type=type_error.arbitrary_type; expected_arbitrary_type=Runnable) ``` I have checked the documentation and versions of the libraries, but I'm still having trouble understanding and resolving the issue. Could someone please provide guidance on what might be causing this ValidationError and how I can address it? Thank you in advance for your help! ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14401/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14401/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14400
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14400/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14400/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14400/events
https://github.com/langchain-ai/langchain/issues/14400
2,030,832,959
I_kwDOIPDwls55DA0_
14,400
value error when using huggingfacehub API
{ "login": "MegalaRamu", "id": 64842084, "node_id": "MDQ6VXNlcjY0ODQyMDg0", "avatar_url": "https://avatars.githubusercontent.com/u/64842084?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MegalaRamu", "html_url": "https://github.com/MegalaRamu", "followers_url": "https://api.github.com/users/MegalaRamu/followers", "following_url": "https://api.github.com/users/MegalaRamu/following{/other_user}", "gists_url": "https://api.github.com/users/MegalaRamu/gists{/gist_id}", "starred_url": "https://api.github.com/users/MegalaRamu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MegalaRamu/subscriptions", "organizations_url": "https://api.github.com/users/MegalaRamu/orgs", "repos_url": "https://api.github.com/users/MegalaRamu/repos", "events_url": "https://api.github.com/users/MegalaRamu/events{/privacy}", "received_events_url": "https://api.github.com/users/MegalaRamu/received_events", "type": "User", "site_admin": false }
[ { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
10
2023-12-07T14:05:46
2023-12-11T10:32:26
null
NONE
null
### System Info Hi Team, Am trying to connect to SQL/CSV using the HuggingFaceHUb and I get value error. This value error occurs even when I use the same example as given in https://python.langchain.com/docs/use_cases/qa_structured/sql except that instead of openAI am using huggingfaceHub ### Who can help? _No response_ ### Information - [X] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [X] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [X] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction st.title("SQL DB with Langchain") #entering input through streamlit into the app for querying input_text = st.text_input("enter the text for search") #input_period = st.text_input("enter the period for which you need summarization") #connecting to hugging face API os.environ["HUGGINGFACEHUB_API_TOKEN"] = huggingface_write_key #SQL db = SQLDatabase.from_uri("sqlite:///Chinook.db") repo_id = "google/flan-t5-xxl" llm = HuggingFaceHub( repo_id=repo_id, model_kwargs={"temperature": 0.2} ) db_chain = SQLDatabaseChain.from_llm(llm, db, verbose=True) if input_text: st.write(db_chain.run(input_text)) ### Expected behavior Expected to give output for the query thats run
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14400/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14400/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14399
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14399/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14399/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14399/events
https://github.com/langchain-ai/langchain/issues/14399
2,030,821,733
I_kwDOIPDwls55C-Fl
14,399
Issue:python3.10/site-packages/langchain/llms/bedrock.py:315: RuntimeWarning: coroutine 'AsyncCallbackManagerForLLMRun.on_llm_new_token' was never awaited
{ "login": "vmunagal", "id": 111293648, "node_id": "U_kgDOBqI00A", "avatar_url": "https://avatars.githubusercontent.com/u/111293648?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vmunagal", "html_url": "https://github.com/vmunagal", "followers_url": "https://api.github.com/users/vmunagal/followers", "following_url": "https://api.github.com/users/vmunagal/following{/other_user}", "gists_url": "https://api.github.com/users/vmunagal/gists{/gist_id}", "starred_url": "https://api.github.com/users/vmunagal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vmunagal/subscriptions", "organizations_url": "https://api.github.com/users/vmunagal/orgs", "repos_url": "https://api.github.com/users/vmunagal/repos", "events_url": "https://api.github.com/users/vmunagal/events{/privacy}", "received_events_url": "https://api.github.com/users/vmunagal/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
closed
false
null
[]
null
4
2023-12-07T13:59:30
2023-12-08T02:24:40
2023-12-07T19:59:26
NONE
null
### Issue you'd like to raise. python3.10/site-packages/langchain/llms/bedrock.py:315: RuntimeWarning: coroutine 'AsyncCallbackManagerForLLMRun.on_llm_new_token' was never awaited ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14399/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14399/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14398
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14398/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14398/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14398/events
https://github.com/langchain-ai/langchain/pull/14398
2,030,819,165
PR_kwDOIPDwls5hbQ9Y
14,398
Fix Bedrock broad error catching
{ "login": "JuR-0", "id": 94719392, "node_id": "U_kgDOBaVNoA", "avatar_url": "https://avatars.githubusercontent.com/u/94719392?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JuR-0", "html_url": "https://github.com/JuR-0", "followers_url": "https://api.github.com/users/JuR-0/followers", "following_url": "https://api.github.com/users/JuR-0/following{/other_user}", "gists_url": "https://api.github.com/users/JuR-0/gists{/gist_id}", "starred_url": "https://api.github.com/users/JuR-0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JuR-0/subscriptions", "organizations_url": "https://api.github.com/users/JuR-0/orgs", "repos_url": "https://api.github.com/users/JuR-0/repos", "events_url": "https://api.github.com/users/JuR-0/events{/privacy}", "received_events_url": "https://api.github.com/users/JuR-0/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T13:58:09
2024-01-03T01:25:49
2024-01-03T01:25:49
CONTRIBUTOR
null
Fixes #14347 <!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** Added the traceback of the previous error to keep the initial error type, - **Issue:** #14347 , - **Dependencies:** None, - **Tag maintainer:** Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14398/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14398/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14398", "html_url": "https://github.com/langchain-ai/langchain/pull/14398", "diff_url": "https://github.com/langchain-ai/langchain/pull/14398.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14398.patch", "merged_at": "2024-01-03T01:25:49" }
https://api.github.com/repos/langchain-ai/langchain/issues/14397
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14397/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14397/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14397/events
https://github.com/langchain-ai/langchain/issues/14397
2,030,814,970
I_kwDOIPDwls55C8b6
14,397
TypeError: DDGS.text() got an unexpected keyword argument 'max_results' AND HTTPError:
{ "login": "VERISBABY", "id": 95742474, "node_id": "U_kgDOBbTqCg", "avatar_url": "https://avatars.githubusercontent.com/u/95742474?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VERISBABY", "html_url": "https://github.com/VERISBABY", "followers_url": "https://api.github.com/users/VERISBABY/followers", "following_url": "https://api.github.com/users/VERISBABY/following{/other_user}", "gists_url": "https://api.github.com/users/VERISBABY/gists{/gist_id}", "starred_url": "https://api.github.com/users/VERISBABY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VERISBABY/subscriptions", "organizations_url": "https://api.github.com/users/VERISBABY/orgs", "repos_url": "https://api.github.com/users/VERISBABY/repos", "events_url": "https://api.github.com/users/VERISBABY/events{/privacy}", "received_events_url": "https://api.github.com/users/VERISBABY/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
closed
false
null
[]
null
1
2023-12-07T13:55:48
2023-12-07T14:38:09
2023-12-07T14:38:09
NONE
null
### System Info langchain: 0.0.346 python: 3.11.7 ### Who can help? _No response_ ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [X] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction Error when run: ``` from langchain.tools import DuckDuckGoSearchRun search = DuckDuckGoSearchRun() search.run("Obama's first name?") ``` ### Expected behavior I got this error when run: ``` --------------------------------------------------------------------------- TypeError Traceback (most recent call last) [c:\Users\thenh\OneDrive\M](file:///C:/Users/thenh/OneDrive/M)áy tính\demo\test.ipynb Cell 13 line 4 ..... File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain_core\tools.py:337, in BaseTool.run(self, tool_input, verbose, start_color, color, callbacks, tags, metadata, run_name, **kwargs) [334](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:334) try: [335](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:335) tool_args, tool_kwargs = self._to_args_and_kwargs(parsed_input) [336](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:336) observation = ( --> [337](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:337) self._run(*tool_args, run_manager=run_manager, **tool_kwargs) [338](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:338) if new_arg_supported [339](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:339) else self._run(*tool_args, **tool_kwargs) [340](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:340) ) [341](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:341) except ToolException as e: [342](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:342) if not self.handle_tool_error: File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain\tools\ddg_search\tool.py:37, in DuckDuckGoSearchRun._run(self, query, run_manager) [31](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:31) def _run( [32](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:32) self, [33](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:33) query: str, [34](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:34) run_manager: Optional[CallbackManagerForToolRun] = None, [35](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:35) ) -> str: [36](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:36) """Use the tool.""" ---> [37](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:37) return self.api_wrapper.run(query) File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain\utilities\duckduckgo_search.py:81, in DuckDuckGoSearchAPIWrapper.run(self, query) [79](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:79) """Run query through DuckDuckGo and return concatenated results.""" [80](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:80) if self.source == "text": ---> [81](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:81) results = self._ddgs_text(query) [82](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:82) elif self.source == "news": [83](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:83) results = self._ddgs_news(query) File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain\utilities\duckduckgo_search.py:48, in DuckDuckGoSearchAPIWrapper._ddgs_text(self, query, max_results) [45](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:45) from duckduckgo_search import DDGS [47](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:47) with DDGS() as ddgs: ---> [48](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:48) ddgs_gen = ddgs.text( [49](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:49) query, [50](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:50) region=self.region, [51](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:51) safesearch=self.safesearch, [52](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:52) timelimit=self.time, [53](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:53) max_results=max_results or self.max_results, [54](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:54) backend=self.backend, [55](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:55) ) [56](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:56) if ddgs_gen: [57](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:57) return [r for r in ddgs_gen] TypeError: DDGS.text() got an unexpected keyword argument 'max_results' ``` After remove _`max_results=max_results or self.max_results`_, i still got another error: ``` --------------------------------------------------------------------------- HTTPError Traceback (most recent call last) [c:\Users\thenh\OneDrive\M](file:///C:/Users/thenh/OneDrive/M)áy tính\demo\test.ipynb Cell 13 line 4 [1](vscode-notebook-cell:/c%3A/Users/thenh/OneDrive/M%C3%A1y%20t%C3%ADnh/demo/test.ipynb#X15sZmlsZQ%3D%3D?line=0) from langchain.tools import DuckDuckGoSearchRun [2](vscode-notebook-cell:/c%3A/Users/thenh/OneDrive/M%C3%A1y%20t%C3%ADnh/demo/test.ipynb#X15sZmlsZQ%3D%3D?line=1) search = DuckDuckGoSearchRun() ----> [4](vscode-notebook-cell:/c%3A/Users/thenh/OneDrive/M%C3%A1y%20t%C3%ADnh/demo/test.ipynb#X15sZmlsZQ%3D%3D?line=3) search.run("who is newjeans") File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain_core\tools.py:365, in BaseTool.run(self, tool_input, verbose, start_color, color, callbacks, tags, metadata, run_name, **kwargs) [363](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:363) except (Exception, KeyboardInterrupt) as e: [364](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:364) run_manager.on_tool_error(e) --> [365](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:365) raise e [366](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:366) else: [367](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:367) run_manager.on_tool_end( [368](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:368) str(observation), color=color, name=self.name, **kwargs [369](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:369) ) File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain_core\tools.py:337, in BaseTool.run(self, tool_input, verbose, start_color, color, callbacks, tags, metadata, run_name, **kwargs) [334](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:334) try: [335](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:335) tool_args, tool_kwargs = self._to_args_and_kwargs(parsed_input) [336](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:336) observation = ( --> [337](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:337) self._run(*tool_args, run_manager=run_manager, **tool_kwargs) [338](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:338) if new_arg_supported [339](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:339) else self._run(*tool_args, **tool_kwargs) [340](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:340) ) [341](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:341) except ToolException as e: [342](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain_core/tools.py:342) if not self.handle_tool_error: File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain\tools\ddg_search\tool.py:37, in DuckDuckGoSearchRun._run(self, query, run_manager) [31](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:31) def _run( [32](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:32) self, [33](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:33) query: str, [34](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:34) run_manager: Optional[CallbackManagerForToolRun] = None, [35](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:35) ) -> str: [36](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:36) """Use the tool.""" ---> [37](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/tools/ddg_search/tool.py:37) return self.api_wrapper.run(query) File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain\utilities\duckduckgo_search.py:81, in DuckDuckGoSearchAPIWrapper.run(self, query) [79](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:79) """Run query through DuckDuckGo and return concatenated results.""" [80](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:80) if self.source == "text": ---> [81](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:81) results = self._ddgs_text(query) [82](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:82) elif self.source == "news": [83](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:83) results = self._ddgs_news(query) File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain\utilities\duckduckgo_search.py:57, in DuckDuckGoSearchAPIWrapper._ddgs_text(self, query, max_results) [48](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:48) ddgs_gen = ddgs.text( [49](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:49) query, [50](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:50) region=self.region, (...) [54](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:54) backend=self.backend, [55](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:55) ) [56](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:56) if ddgs_gen: ---> [57](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:57) return [r for r in ddgs_gen] [58](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:58) return [] File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\langchain\utilities\duckduckgo_search.py:57, in <listcomp>(.0) [48](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:48) ddgs_gen = ddgs.text( [49](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:49) query, [50](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:50) region=self.region, (...) [54](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:54) backend=self.backend, [55](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:55) ) [56](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:56) if ddgs_gen: ---> [57](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:57) return [r for r in ddgs_gen] [58](file:///C:/Program%20Files/Python311/Lib/site-packages/langchain/utilities/duckduckgo_search.py:58) return [] File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\duckduckgo_search\duckduckgo_search.py:150, in DDGS.text(self, keywords, region, safesearch, timelimit, backend) [134](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:134) """DuckDuckGo text search generator. Query params: https://duckduckgo.com/params [135](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:135) [136](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:136) Args: (...) [147](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:147) [148](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:148) """ [149](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:149) if backend == "api": --> [150](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:150) yield from self._text_api(keywords, region, safesearch, timelimit) [151](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:151) elif backend == "html": [152](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:152) yield from self._text_html(keywords, region, safesearch, timelimit) File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\duckduckgo_search\duckduckgo_search.py:203, in DDGS._text_api(self, keywords, region, safesearch, timelimit) [201](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:201) for s in ("0", "20", "70", "120"): [202](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:202) payload["s"] = s --> [203](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:203) resp = self._get_url( [204](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:204) "GET", "https://links.duckduckgo.com/d.js", params=payload [205](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:205) ) [206](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:206) if resp is None: [207](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:207) break File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\duckduckgo_search\duckduckgo_search.py:89, in DDGS._get_url(self, method, url, **kwargs) [87](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:87) logger.warning(f"_get_url() {url} {type(ex).__name__} {ex}") [88](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:88) if i >= 2 or "418" in str(ex): ---> [89](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:89) raise ex [90](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:90) sleep(3) [91](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:91) return None File [c:\Program](file:///C:/Program) Files\Python311\Lib\site-packages\duckduckgo_search\duckduckgo_search.py:82, in DDGS._get_url(self, method, url, **kwargs) [78](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:78) resp = self._client.request( [79](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:79) method, url, follow_redirects=True, **kwargs [80](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:80) ) [81](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:81) if self._is_500_in_url(str(resp.url)) or resp.status_code == 202: ---> [82](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:82) raise httpx._exceptions.HTTPError("") [83](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:83) resp.raise_for_status() [84](file:///C:/Program%20Files/Python311/Lib/site-packages/duckduckgo_search/duckduckgo_search.py:84) if resp.status_code == 200: HTTPError: ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14397/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14397/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14396
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14396/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14396/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14396/events
https://github.com/langchain-ai/langchain/issues/14396
2,030,741,752
I_kwDOIPDwls55Cqj4
14,396
Issue: How to delete particular space embeddings for a confluence projects
{ "login": "deepak-habilelabs", "id": 137885024, "node_id": "U_kgDOCDf1YA", "avatar_url": "https://avatars.githubusercontent.com/u/137885024?v=4", "gravatar_id": "", "url": "https://api.github.com/users/deepak-habilelabs", "html_url": "https://github.com/deepak-habilelabs", "followers_url": "https://api.github.com/users/deepak-habilelabs/followers", "following_url": "https://api.github.com/users/deepak-habilelabs/following{/other_user}", "gists_url": "https://api.github.com/users/deepak-habilelabs/gists{/gist_id}", "starred_url": "https://api.github.com/users/deepak-habilelabs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/deepak-habilelabs/subscriptions", "organizations_url": "https://api.github.com/users/deepak-habilelabs/orgs", "repos_url": "https://api.github.com/users/deepak-habilelabs/repos", "events_url": "https://api.github.com/users/deepak-habilelabs/events{/privacy}", "received_events_url": "https://api.github.com/users/deepak-habilelabs/received_events", "type": "User", "site_admin": false }
[ { "id": 5541141061, "node_id": "LA_kwDOIPDwls8AAAABSkcaRQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20embeddings", "name": "area: embeddings", "color": "C5DEF5", "default": false, "description": "Related to text embedding models module" }, { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" }, { "id": 5924999838, "node_id": "LA_kwDOIPDwls8AAAABYShSng", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20chroma", "name": "integration: chroma", "color": "B78AF8", "default": false, "description": "Related to ChromaDB" } ]
open
false
null
[]
null
1
2023-12-07T13:14:35
2023-12-07T13:21:11
null
NONE
null
### Issue you'd like to raise. def delete_confluence_embeddings(file_path, persist_directory,not_uuid): chroma_db = chromadb.PersistentClient(path=persist_directory) collection = chroma_db.get_or_create_collection(name="langchain") project_instance = ProjectName.objects.get(not_uuid=not_uuid) confluence_data = json.loads(project_instance.media).get('confluence', []) confluence_url = project_instance.url username = project_instance.confluence_username api_key = base64.b64decode(project_instance.api_key).decode('utf-8') space_keys = [space_data['space_key'] for space_data in project_instance.space_key] documents = [] loader = ConfluenceLoader( url=confluence_url, username=username, api_key=api_key ) for space_key in space_keys: documents.extend(loader.load(space_key=space_key, limit=100)) page_info = [] for document in documents: page_id = document.metadata.get('id') page_title = document.metadata.get('title') formatted_title = page_title.replace(' ', '+') page_info.append({"id": page_id, "title": formatted_title}) # print(f"Page ID: {page_id}, Page Title: {formatted_title}") for entry in page_info: entry_file_path = f"{file_path}/pages/{entry['id']}" ids = collection.get(where={"source": entry_file_path})['ids'] collection.delete(where={"source": entry_file_path}, ids=ids) for entry in page_info: entry_file_path = f"{file_path}/pages/{entry['id']}/{entry['title']}" ids = collection.get(where={"source": entry_file_path})['ids'] collection.delete(where={"source": entry_file_path}, ids=ids) chroma_db.delete_collection(name="langchain") print("Delete successfully") how can i delete for particular space. file path is url/spaces/space_key/ ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14396/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14396/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14395
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14395/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14395/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14395/events
https://github.com/langchain-ai/langchain/issues/14395
2,030,731,840
I_kwDOIPDwls55CoJA
14,395
Retrieval QA chain does not work
{ "login": "VpkPrasanna", "id": 30804112, "node_id": "MDQ6VXNlcjMwODA0MTEy", "avatar_url": "https://avatars.githubusercontent.com/u/30804112?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VpkPrasanna", "html_url": "https://github.com/VpkPrasanna", "followers_url": "https://api.github.com/users/VpkPrasanna/followers", "following_url": "https://api.github.com/users/VpkPrasanna/following{/other_user}", "gists_url": "https://api.github.com/users/VpkPrasanna/gists{/gist_id}", "starred_url": "https://api.github.com/users/VpkPrasanna/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VpkPrasanna/subscriptions", "organizations_url": "https://api.github.com/users/VpkPrasanna/orgs", "repos_url": "https://api.github.com/users/VpkPrasanna/repos", "events_url": "https://api.github.com/users/VpkPrasanna/events{/privacy}", "received_events_url": "https://api.github.com/users/VpkPrasanna/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-07T13:08:45
2023-12-07T13:20:39
null
CONTRIBUTOR
null
### System Info when i am using Retrieval QA with custom prompt on official llama2 model it gives back an empty result even though retriever has worked but LLM failed to give back the response but if i directly pass the query to chain without any prompt it works as expected ## Versions Python - 3.10 Langchain - 0.0.306 @hwchase17 and @agola11 please take a loot at this issue ### Who can help? _No response_ ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [X] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction `qa_chain = RetrievalQA.from_chain_type( llm=llm, chain_type="stuff", retriever=final_retriever, chain_type_kwargs={"prompt": prompt_template}, return_source_documents=True )` if i initialize the chain like this it is failing without ### Expected behavior `qa_chain = RetrievalQA.from_chain_type( llm=llm, chain_type="stuff", retriever=final_retriever, return_source_documents=True )` if i initialize the chain like this it is working as expected
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14395/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14395/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14394
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14394/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14394/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14394/events
https://github.com/langchain-ai/langchain/issues/14394
2,030,689,372
I_kwDOIPDwls55Cdxc
14,394
AttributeError: module 'openai' has no attribute 'error'
{ "login": "andysingal", "id": 20493493, "node_id": "MDQ6VXNlcjIwNDkzNDkz", "avatar_url": "https://avatars.githubusercontent.com/u/20493493?v=4", "gravatar_id": "", "url": "https://api.github.com/users/andysingal", "html_url": "https://github.com/andysingal", "followers_url": "https://api.github.com/users/andysingal/followers", "following_url": "https://api.github.com/users/andysingal/following{/other_user}", "gists_url": "https://api.github.com/users/andysingal/gists{/gist_id}", "starred_url": "https://api.github.com/users/andysingal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/andysingal/subscriptions", "organizations_url": "https://api.github.com/users/andysingal/orgs", "repos_url": "https://api.github.com/users/andysingal/repos", "events_url": "https://api.github.com/users/andysingal/events{/privacy}", "received_events_url": "https://api.github.com/users/andysingal/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-07T12:47:28
2023-12-07T12:57:58
null
NONE
null
### System Info Google colab ### Who can help? @agola ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ``` !pip install lmql==0.0.6.6 langchain==0.0.316 openai==0.28.1 -q import lmql import aiohttp import os os.environ["OPENAI_API_KEY"] = "" from langchain import LLMChain, PromptTemplate from langchain.chat_models import ChatOpenAI from langchain.prompts.chat import ( ChatPromptTemplate, SystemMessagePromptTemplate, AIMessagePromptTemplate, HumanMessagePromptTemplate, ) from langchain.llms import OpenAI # Setup the LM to be used by langchain llm = OpenAI(temperature=0.9) human_message_prompt = HumanMessagePromptTemplate( prompt=PromptTemplate( template="What is a good name for a company that makes {product}?", input_variables=["product"], ) ) chat_prompt_template = ChatPromptTemplate.from_messages([human_message_prompt]) chat = ChatOpenAI(temperature=0.9) chain = LLMChain(llm=chat, prompt=chat_prompt_template) # Run the chain chain.run("colorful socks") ``` gives error: ``` --------------------------------------------------------------------------- AttributeError Traceback (most recent call last) [<ipython-input-17-c7d901a7e281>](https://localhost:8080/#) in <cell line: 25>() 23 24 # Run the chain ---> 25 chain.run("colorful socks") 11 frames [/usr/local/lib/python3.10/dist-packages/langchain/chat_models/openai.py](https://localhost:8080/#) in _create_retry_decorator(self) 300 301 def _combine_llm_outputs(self, llm_outputs: List[Optional[dict]]) -> dict: --> 302 overall_token_usage: dict = {} 303 for output in llm_outputs: 304 if output is None: AttributeError: module 'openai' has no attribute 'error' ``` ### Expected behavior show results
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14394/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14394/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14393
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14393/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14393/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14393/events
https://github.com/langchain-ai/langchain/pull/14393
2,030,538,533
PR_kwDOIPDwls5haSqu
14,393
add api_base to _client_params
{ "login": "DavidLMS", "id": 17435126, "node_id": "MDQ6VXNlcjE3NDM1MTI2", "avatar_url": "https://avatars.githubusercontent.com/u/17435126?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DavidLMS", "html_url": "https://github.com/DavidLMS", "followers_url": "https://api.github.com/users/DavidLMS/followers", "following_url": "https://api.github.com/users/DavidLMS/following{/other_user}", "gists_url": "https://api.github.com/users/DavidLMS/gists{/gist_id}", "starred_url": "https://api.github.com/users/DavidLMS/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DavidLMS/subscriptions", "organizations_url": "https://api.github.com/users/DavidLMS/orgs", "repos_url": "https://api.github.com/users/DavidLMS/repos", "events_url": "https://api.github.com/users/DavidLMS/events{/privacy}", "received_events_url": "https://api.github.com/users/DavidLMS/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
2
2023-12-07T11:19:16
2023-12-13T07:49:21
2023-12-13T07:49:21
CONTRIBUTOR
null
- **Description:** This PR adds `api_base` to `_client_params` in the `chat_model` of LiteLLM to ensure it's included in API calls. Previously, `api_base` was set on the client but was not included in the parameters passed to the completion function. This change ensures that `api_base` is correctly passed to all API calls. - **Issue:** #14338 - **Tag maintainer:** @hwchase17 @agola11 - **Twitter handle:** @LMS_David_RS
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14393/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14393/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14393", "html_url": "https://github.com/langchain-ai/langchain/pull/14393", "diff_url": "https://github.com/langchain-ai/langchain/pull/14393.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14393.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14392
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14392/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14392/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14392/events
https://github.com/langchain-ai/langchain/issues/14392
2,030,447,654
I_kwDOIPDwls55Biwm
14,392
Issue: <how does langchain's routerchain work with conversationbuffermemory>
{ "login": "akhilajallavaram", "id": 110890651, "node_id": "U_kgDOBpwOmw", "avatar_url": "https://avatars.githubusercontent.com/u/110890651?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akhilajallavaram", "html_url": "https://github.com/akhilajallavaram", "followers_url": "https://api.github.com/users/akhilajallavaram/followers", "following_url": "https://api.github.com/users/akhilajallavaram/following{/other_user}", "gists_url": "https://api.github.com/users/akhilajallavaram/gists{/gist_id}", "starred_url": "https://api.github.com/users/akhilajallavaram/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akhilajallavaram/subscriptions", "organizations_url": "https://api.github.com/users/akhilajallavaram/orgs", "repos_url": "https://api.github.com/users/akhilajallavaram/repos", "events_url": "https://api.github.com/users/akhilajallavaram/events{/privacy}", "received_events_url": "https://api.github.com/users/akhilajallavaram/received_events", "type": "User", "site_admin": false }
[ { "id": 4899126096, "node_id": "LA_kwDOIPDwls8AAAABJAK7UA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20memory", "name": "area: memory", "color": "BFDADC", "default": false, "description": "Related to memory module" }, { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
13
2023-12-07T10:39:13
2023-12-08T11:29:49
null
NONE
null
### Issue you'd like to raise. How does conversationbuffermemory works with routerchain for suppose if I wanted to create a chat application I need memory to store the conversations how does that thing work with routerchain? I'm currently using the same implementation that has shown in the documentation please respond as soon as possible thank you:)) ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14392/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14392/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14390
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14390/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14390/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14390/events
https://github.com/langchain-ai/langchain/pull/14390
2,030,351,509
PR_kwDOIPDwls5hZoe_
14,390
Rollback multiple keys in Qdrant
{ "login": "kacperlukawski", "id": 2649301, "node_id": "MDQ6VXNlcjI2NDkzMDE=", "avatar_url": "https://avatars.githubusercontent.com/u/2649301?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kacperlukawski", "html_url": "https://github.com/kacperlukawski", "followers_url": "https://api.github.com/users/kacperlukawski/followers", "following_url": "https://api.github.com/users/kacperlukawski/following{/other_user}", "gists_url": "https://api.github.com/users/kacperlukawski/gists{/gist_id}", "starred_url": "https://api.github.com/users/kacperlukawski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kacperlukawski/subscriptions", "organizations_url": "https://api.github.com/users/kacperlukawski/orgs", "repos_url": "https://api.github.com/users/kacperlukawski/repos", "events_url": "https://api.github.com/users/kacperlukawski/events{/privacy}", "received_events_url": "https://api.github.com/users/kacperlukawski/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
2
2023-12-07T09:57:10
2023-12-08T10:25:35
2023-12-07T19:13:19
CONTRIBUTOR
null
This reverts commit 38813d7090294c0c96d4963a2a230db4fef5e37e. This is a temporary fix, as I don't see a clear way on how to use multiple keys with `Qdrant.from_texts`. Context: #14378
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14390/reactions", "total_count": 3, "+1": 3, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14390/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14390", "html_url": "https://github.com/langchain-ai/langchain/pull/14390", "diff_url": "https://github.com/langchain-ai/langchain/pull/14390.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14390.patch", "merged_at": "2023-12-07T19:13:19" }
https://api.github.com/repos/langchain-ai/langchain/issues/14389
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14389/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14389/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14389/events
https://github.com/langchain-ai/langchain/pull/14389
2,030,320,306
PR_kwDOIPDwls5hZhX9
14,389
Azure DocumentIntelligenceLoader/Parser support update with latest SDK
{ "login": "zifeiq", "id": 7711036, "node_id": "MDQ6VXNlcjc3MTEwMzY=", "avatar_url": "https://avatars.githubusercontent.com/u/7711036?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zifeiq", "html_url": "https://github.com/zifeiq", "followers_url": "https://api.github.com/users/zifeiq/followers", "following_url": "https://api.github.com/users/zifeiq/following{/other_user}", "gists_url": "https://api.github.com/users/zifeiq/gists{/gist_id}", "starred_url": "https://api.github.com/users/zifeiq/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zifeiq/subscriptions", "organizations_url": "https://api.github.com/users/zifeiq/orgs", "repos_url": "https://api.github.com/users/zifeiq/repos", "events_url": "https://api.github.com/users/zifeiq/events{/privacy}", "received_events_url": "https://api.github.com/users/zifeiq/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700863, "node_id": "LA_kwDOIPDwls8AAAABUpidvw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:enhancement", "name": "auto:enhancement", "color": "C2E0C6", "default": false, "description": "A large net-new component, integration, or chain. Use sparingly. The largest features" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
{ "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false }
[ { "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false } ]
null
9
2023-12-07T09:45:05
2023-12-22T00:40:28
2023-12-22T00:40:27
CONTRIBUTOR
null
- **Description:** Add DocumentIntelligenceLoader & DocumentIntelligenceParser implementation using the latest Azure Document Intelligence SDK with markdown support. The core logic resides in DocumentIntelligenceParser and DocumentIntelligenceLoader is a mere wrapper of the parser. The parser will takes api_endpoint and api_key and creates DocumentIntelligenceClient for the user. 4 parsing modes are supported: 1. Markdown (default) 2. Single 3. Page 4. Object UT and notebook are also updated accordingly. - **Dependencies:** Azure Document Intelligence SDK: azure-ai-documentintelligence [azure-sdk-for-python/sdk/documentintelligence/azure-ai-documentintelligence at 7c42462ac662522a6fd21b17d2a20f4cd40d0356 · Azure/azure-sdk-for-python (github.com)](https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-python%2Ftree%2F7c42462ac662522a6fd21b17d2a20f4cd40d0356%2Fsdk%2Fdocumentintelligence%2Fazure-ai-documentintelligence&data=05%7C01%7CZifei.Qian%40microsoft.com%7C298225aa3e31468a863108dbf07374ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638368150928704292%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oE0Sl4HERnMKdbkV9KgBV46Z2xytcQAShdTWf7ZNl%2Bs%3D&reserved=0).
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14389/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14389/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14389", "html_url": "https://github.com/langchain-ai/langchain/pull/14389", "diff_url": "https://github.com/langchain-ai/langchain/pull/14389.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14389.patch", "merged_at": "2023-12-22T00:40:27" }
https://api.github.com/repos/langchain-ai/langchain/issues/14388
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14388/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14388/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14388/events
https://github.com/langchain-ai/langchain/pull/14388
2,030,282,574
PR_kwDOIPDwls5hZY1U
14,388
infra: Fix test filesystem paths incompatible with windows
{ "login": "rancomp", "id": 23070692, "node_id": "MDQ6VXNlcjIzMDcwNjky", "avatar_url": "https://avatars.githubusercontent.com/u/23070692?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rancomp", "html_url": "https://github.com/rancomp", "followers_url": "https://api.github.com/users/rancomp/followers", "following_url": "https://api.github.com/users/rancomp/following{/other_user}", "gists_url": "https://api.github.com/users/rancomp/gists{/gist_id}", "starred_url": "https://api.github.com/users/rancomp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rancomp/subscriptions", "organizations_url": "https://api.github.com/users/rancomp/orgs", "repos_url": "https://api.github.com/users/rancomp/repos", "events_url": "https://api.github.com/users/rancomp/events{/privacy}", "received_events_url": "https://api.github.com/users/rancomp/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 6232714108, "node_id": "LA_kwDOIPDwls8AAAABc3-rfA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:S", "name": "size:S", "color": "BFDADC", "default": false, "description": "This PR changes 10-29 lines, ignoring generated files." } ]
closed
false
null
[]
null
3
2023-12-07T09:29:16
2023-12-21T21:45:42
2023-12-21T21:45:42
CONTRIBUTOR
null
- **Description:** This PR fixes test failures on Windows caused by path handling differences and unescaped special characters in regex. The failing tests are: ``` FAILED tests/unit_tests/storage/test_filesystem.py::test_yield_keys - AssertionError: assert ['key1', 'subdir\\key2'] == ['key1', 'subdir/key2'] FAILED tests/unit_tests/test_imports.py::test_importable_all - ModuleNotFoundError: No module named 'langchain_community.langchain_community\\adapters' FAILED tests/unit_tests/tools/file_management/test_utils.py::test_get_validated_relative_path_errs_on_absolute - re.error: incomplete escape \U at position 53 FAILED tests/unit_tests/tools/file_management/test_utils.py::test_get_validated_relative_path_errs_on_parent_dir - re.error: incomplete escape \U at position 69 FAILED tests/unit_tests/tools/file_management/test_utils.py::test_get_validated_relative_path_errs_for_symlink_outside_root - re.error: incomplete escape \U at position 64 ``` - **Issue:** fixes https://github.com/langchain-ai/langchain/issues/11775 (partially) - **Dependencies:** none
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14388/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14388/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14388", "html_url": "https://github.com/langchain-ai/langchain/pull/14388", "diff_url": "https://github.com/langchain-ai/langchain/pull/14388.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14388.patch", "merged_at": "2023-12-21T21:45:42" }
https://api.github.com/repos/langchain-ai/langchain/issues/14387
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14387/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14387/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14387/events
https://github.com/langchain-ai/langchain/issues/14387
2,030,232,645
I_kwDOIPDwls55AuRF
14,387
OutputFixingParser does not work with PydanticOutputParser
{ "login": "ccasadei", "id": 16083297, "node_id": "MDQ6VXNlcjE2MDgzMjk3", "avatar_url": "https://avatars.githubusercontent.com/u/16083297?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ccasadei", "html_url": "https://github.com/ccasadei", "followers_url": "https://api.github.com/users/ccasadei/followers", "following_url": "https://api.github.com/users/ccasadei/following{/other_user}", "gists_url": "https://api.github.com/users/ccasadei/gists{/gist_id}", "starred_url": "https://api.github.com/users/ccasadei/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ccasadei/subscriptions", "organizations_url": "https://api.github.com/users/ccasadei/orgs", "repos_url": "https://api.github.com/users/ccasadei/repos", "events_url": "https://api.github.com/users/ccasadei/events{/privacy}", "received_events_url": "https://api.github.com/users/ccasadei/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
2
2023-12-07T09:01:20
2023-12-07T09:29:53
null
NONE
null
### System Info langchain v 0.0.344 pydantic v 2.5.2 pydantic_code v 2.14.5 python v 3.10.13 ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [X] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction I noticed that the **OutputFixingParser** class does not work when applied to a **PydanticOutputParser** class. Something has probably changed in **Pydantic**. Doing step-by-step debugging, I saw that in **PydanticOutputParser**, at line 32 (see below)... ![code](https://github.com/langchain-ai/langchain/assets/16083297/b59a8d15-2e21-41e3-baf4-180904d1f3ec) ...the exception caught is indeed a **ValidationError**, but _it is not the same_ **ValidationError**... The **ValidationError** expected from that `try..except` block is of this type. ![valerr01](https://github.com/langchain-ai/langchain/assets/16083297/17ea8ec2-4b5f-4820-8f95-3481d687cfba) While the **ValidationError** raised is of this other type. ![valerr02](https://github.com/langchain-ai/langchain/assets/16083297/d2ef0fa4-0fba-4234-a6a8-b65c1fd4ac76) ### Expected behavior I therefore imagine that the **LangChain** code needs to be updated to also handle the new exception (since the old one belongs to a "**v1**" package).
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14387/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14387/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14386
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14386/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14386/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14386/events
https://github.com/langchain-ai/langchain/pull/14386
2,030,176,155
PR_kwDOIPDwls5hZBPE
14,386
Fix `llms.Mlflow` example
{ "login": "harupy", "id": 17039389, "node_id": "MDQ6VXNlcjE3MDM5Mzg5", "avatar_url": "https://avatars.githubusercontent.com/u/17039389?v=4", "gravatar_id": "", "url": "https://api.github.com/users/harupy", "html_url": "https://github.com/harupy", "followers_url": "https://api.github.com/users/harupy/followers", "following_url": "https://api.github.com/users/harupy/following{/other_user}", "gists_url": "https://api.github.com/users/harupy/gists{/gist_id}", "starred_url": "https://api.github.com/users/harupy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/harupy/subscriptions", "organizations_url": "https://api.github.com/users/harupy/orgs", "repos_url": "https://api.github.com/users/harupy/repos", "events_url": "https://api.github.com/users/harupy/events{/privacy}", "received_events_url": "https://api.github.com/users/harupy/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T08:35:28
2024-01-03T06:35:14
2024-01-03T06:35:14
CONTRIBUTOR
null
<!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** a description of the change, - **Issue:** the issue # it fixes (if applicable), - **Dependencies:** any dependencies required for this change, - **Tag maintainer:** for a quicker response, tag the relevant maintainer (see below), - **Twitter handle:** we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out! Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. --> The example code for `llms.Mlflow` is outdated.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14386/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14386/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14386", "html_url": "https://github.com/langchain-ai/langchain/pull/14386", "diff_url": "https://github.com/langchain-ai/langchain/pull/14386.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14386.patch", "merged_at": "2024-01-03T06:35:13" }
https://api.github.com/repos/langchain-ai/langchain/issues/14385
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14385/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14385/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14385/events
https://github.com/langchain-ai/langchain/pull/14385
2,030,171,357
PR_kwDOIPDwls5hZAMC
14,385
Remove unused `Params`
{ "login": "harupy", "id": 17039389, "node_id": "MDQ6VXNlcjE3MDM5Mzg5", "avatar_url": "https://avatars.githubusercontent.com/u/17039389?v=4", "gravatar_id": "", "url": "https://api.github.com/users/harupy", "html_url": "https://github.com/harupy", "followers_url": "https://api.github.com/users/harupy/followers", "following_url": "https://api.github.com/users/harupy/following{/other_user}", "gists_url": "https://api.github.com/users/harupy/gists{/gist_id}", "starred_url": "https://api.github.com/users/harupy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/harupy/subscriptions", "organizations_url": "https://api.github.com/users/harupy/orgs", "repos_url": "https://api.github.com/users/harupy/repos", "events_url": "https://api.github.com/users/harupy/events{/privacy}", "received_events_url": "https://api.github.com/users/harupy/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714108, "node_id": "LA_kwDOIPDwls8AAAABc3-rfA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:S", "name": "size:S", "color": "BFDADC", "default": false, "description": "This PR changes 10-29 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T08:32:05
2024-01-03T06:45:18
2024-01-03T06:45:18
CONTRIBUTOR
null
<!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** a description of the change, - **Issue:** the issue # it fixes (if applicable), - **Dependencies:** any dependencies required for this change, - **Tag maintainer:** for a quicker response, tag the relevant maintainer (see below), - **Twitter handle:** we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out! Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. --> Removes unused `Params` in `libs/langchain/langchain/llms/mlflow.py`.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14385/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14385/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14385", "html_url": "https://github.com/langchain-ai/langchain/pull/14385", "diff_url": "https://github.com/langchain-ai/langchain/pull/14385.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14385.patch", "merged_at": "2024-01-03T06:45:18" }
https://api.github.com/repos/langchain-ai/langchain/issues/14384
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14384/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14384/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14384/events
https://github.com/langchain-ai/langchain/pull/14384
2,030,159,717
PR_kwDOIPDwls5hY9lm
14,384
Update minimax.py
{ "login": "ethynic", "id": 5636106, "node_id": "MDQ6VXNlcjU2MzYxMDY=", "avatar_url": "https://avatars.githubusercontent.com/u/5636106?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ethynic", "html_url": "https://github.com/ethynic", "followers_url": "https://api.github.com/users/ethynic/followers", "following_url": "https://api.github.com/users/ethynic/following{/other_user}", "gists_url": "https://api.github.com/users/ethynic/gists{/gist_id}", "starred_url": "https://api.github.com/users/ethynic/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ethynic/subscriptions", "organizations_url": "https://api.github.com/users/ethynic/orgs", "repos_url": "https://api.github.com/users/ethynic/repos", "events_url": "https://api.github.com/users/ethynic/events{/privacy}", "received_events_url": "https://api.github.com/users/ethynic/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
open
false
null
[]
null
1
2023-12-07T08:26:07
2024-01-03T06:38:00
null
NONE
null
MiniMaxChat class _generate method shoud return a ChatResult object not str <!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** a description of the change, - **Issue:** the issue # it fixes (if applicable), - **Dependencies:** any dependencies required for this change, - **Tag maintainer:** for a quicker response, tag the relevant maintainer (see below), - **Twitter handle:** we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out! Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14384/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14384/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14384", "html_url": "https://github.com/langchain-ai/langchain/pull/14384", "diff_url": "https://github.com/langchain-ai/langchain/pull/14384.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14384.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14383
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14383/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14383/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14383/events
https://github.com/langchain-ai/langchain/issues/14383
2,030,135,709
I_kwDOIPDwls55AWmd
14,383
index with redis as vector store cannot delete documents
{ "login": "edwardzjl", "id": 7287580, "node_id": "MDQ6VXNlcjcyODc1ODA=", "avatar_url": "https://avatars.githubusercontent.com/u/7287580?v=4", "gravatar_id": "", "url": "https://api.github.com/users/edwardzjl", "html_url": "https://github.com/edwardzjl", "followers_url": "https://api.github.com/users/edwardzjl/followers", "following_url": "https://api.github.com/users/edwardzjl/following{/other_user}", "gists_url": "https://api.github.com/users/edwardzjl/gists{/gist_id}", "starred_url": "https://api.github.com/users/edwardzjl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/edwardzjl/subscriptions", "organizations_url": "https://api.github.com/users/edwardzjl/orgs", "repos_url": "https://api.github.com/users/edwardzjl/repos", "events_url": "https://api.github.com/users/edwardzjl/events{/privacy}", "received_events_url": "https://api.github.com/users/edwardzjl/received_events", "type": "User", "site_admin": false }
[ { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5955630415, "node_id": "LA_kwDOIPDwls8AAAABYvu1Tw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20redis", "name": "integration: redis", "color": "F9D0C4", "default": false, "description": "Any integration that uses Redis" } ]
open
false
null
[]
null
1
2023-12-07T08:09:30
2023-12-07T08:11:51
null
CONTRIBUTOR
null
### System Info langchain==0.0.346 python==3.11.6 ### Who can help? @eyurtsev ### Information - [ ] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [X] Document Loaders - [X] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction Hi there! I'm currently exploring the index feature in Langchain to load documents into the vector store upon my app startup. However, I've encountered an issue where the index doesn't delete old documents when utilizing Redis as the vector store. After some investigation, I discovered that the `delete` function in `langchain.vectorstores.redis.base.Redis` is a static method, which poses a limitation—it cannot access instance variables, including the essential `key_prefix`. Without the `key_prefix`, Redis is unable to delete documents correctly. This leads me to question why the `delete` method of the Redis vector store is static. I've noticed that other vector stores, such as Pinecone, do not have a static `delete` function and seem to handle this differently. ### Expected behavior index with Redis as vector store should delete documents correctly.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14383/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14383/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14382
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14382/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14382/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14382/events
https://github.com/langchain-ai/langchain/issues/14382
2,030,036,527
I_kwDOIPDwls54_-Yv
14,382
Allow ChatAnthropic to receive Raw prompt or don't deprecate llms.Anthropic
{ "login": "dosuken123", "id": 4432788, "node_id": "MDQ6VXNlcjQ0MzI3ODg=", "avatar_url": "https://avatars.githubusercontent.com/u/4432788?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dosuken123", "html_url": "https://github.com/dosuken123", "followers_url": "https://api.github.com/users/dosuken123/followers", "following_url": "https://api.github.com/users/dosuken123/following{/other_user}", "gists_url": "https://api.github.com/users/dosuken123/gists{/gist_id}", "starred_url": "https://api.github.com/users/dosuken123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dosuken123/subscriptions", "organizations_url": "https://api.github.com/users/dosuken123/orgs", "repos_url": "https://api.github.com/users/dosuken123/repos", "events_url": "https://api.github.com/users/dosuken123/events{/privacy}", "received_events_url": "https://api.github.com/users/dosuken123/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
2
2023-12-07T06:57:30
2023-12-07T08:12:30
null
CONTRIBUTOR
null
### Feature request GitLab is currently trying to adopt LangChain in https://gitlab.com/gitlab-org/modelops/applied-ml/code-suggestions/ai-assist/-/merge_requests/475 for Anthropic usage. It's just simply passing a raw prompt to the Anthropic client, however, LangChain seems not supporting it because: - `langchain.chat_models.ChatAnthropic` class can't take a raw prompt. It expects [`List[BaseMessage]`](https://github.com/dosuken123/langchain/blob/master/libs/langchain/langchain/chat_models/anthropic.py#L45C5-L45C41) and constructs the new messages. - `langchain.llms.Anthropic` class was deprecated by @hwchase17 in https://github.com/langchain-ai/langchain/commit/52d95ec47dbb06a1bcc3f0ff30cadc50135351db. We don't want to use a deprecated class. It sounds like we should add an option to `ChatAnthropic` to allow raw prompt, or recover `langchain.llms.Anthropic` from deprecated state. ### Motivation Increasing the adoption of LangChain in GitLab ### Your contribution I can contribute to this issue as LangChain contributor.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14382/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14382/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14381
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14381/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14381/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14381/events
https://github.com/langchain-ai/langchain/issues/14381
2,030,022,877
I_kwDOIPDwls54_7Dd
14,381
How can we integrate tools with custom prompt?
{ "login": "hussamsayeed", "id": 46478199, "node_id": "MDQ6VXNlcjQ2NDc4MTk5", "avatar_url": "https://avatars.githubusercontent.com/u/46478199?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hussamsayeed", "html_url": "https://github.com/hussamsayeed", "followers_url": "https://api.github.com/users/hussamsayeed/followers", "following_url": "https://api.github.com/users/hussamsayeed/following{/other_user}", "gists_url": "https://api.github.com/users/hussamsayeed/gists{/gist_id}", "starred_url": "https://api.github.com/users/hussamsayeed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hussamsayeed/subscriptions", "organizations_url": "https://api.github.com/users/hussamsayeed/orgs", "repos_url": "https://api.github.com/users/hussamsayeed/repos", "events_url": "https://api.github.com/users/hussamsayeed/events{/privacy}", "received_events_url": "https://api.github.com/users/hussamsayeed/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-07T06:45:10
2023-12-07T06:52:11
null
NONE
null
### Issue you'd like to raise. I am using ConversationChain with a custom prompt, and now I am looking to integrate tools into it. How can we do that? ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14381/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14381/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14380
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14380/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14380/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14380/events
https://github.com/langchain-ai/langchain/issues/14380
2,029,974,064
I_kwDOIPDwls54_vIw
14,380
Issue: How to remove citation from langchain results
{ "login": "jnm-jai", "id": 119486058, "node_id": "U_kgDOBx82ag", "avatar_url": "https://avatars.githubusercontent.com/u/119486058?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jnm-jai", "html_url": "https://github.com/jnm-jai", "followers_url": "https://api.github.com/users/jnm-jai/followers", "following_url": "https://api.github.com/users/jnm-jai/following{/other_user}", "gists_url": "https://api.github.com/users/jnm-jai/gists{/gist_id}", "starred_url": "https://api.github.com/users/jnm-jai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jnm-jai/subscriptions", "organizations_url": "https://api.github.com/users/jnm-jai/orgs", "repos_url": "https://api.github.com/users/jnm-jai/repos", "events_url": "https://api.github.com/users/jnm-jai/events{/privacy}", "received_events_url": "https://api.github.com/users/jnm-jai/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" } ]
open
false
null
[]
null
1
2023-12-07T06:03:28
2023-12-07T06:12:01
null
NONE
null
### Issue you'd like to raise. How to remove citation from langchain results and can we get the image out of it? ### Suggestion: How to remove citation from langchain results and can we get the image out of it?
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14380/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14380/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14379
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14379/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14379/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14379/events
https://github.com/langchain-ai/langchain/issues/14379
2,029,945,805
I_kwDOIPDwls54_oPN
14,379
create_sql_agent Suffix error
{ "login": "rajesh-b-rao", "id": 67594699, "node_id": "MDQ6VXNlcjY3NTk0Njk5", "avatar_url": "https://avatars.githubusercontent.com/u/67594699?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rajesh-b-rao", "html_url": "https://github.com/rajesh-b-rao", "followers_url": "https://api.github.com/users/rajesh-b-rao/followers", "following_url": "https://api.github.com/users/rajesh-b-rao/following{/other_user}", "gists_url": "https://api.github.com/users/rajesh-b-rao/gists{/gist_id}", "starred_url": "https://api.github.com/users/rajesh-b-rao/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rajesh-b-rao/subscriptions", "organizations_url": "https://api.github.com/users/rajesh-b-rao/orgs", "repos_url": "https://api.github.com/users/rajesh-b-rao/repos", "events_url": "https://api.github.com/users/rajesh-b-rao/events{/privacy}", "received_events_url": "https://api.github.com/users/rajesh-b-rao/received_events", "type": "User", "site_admin": false }
[ { "id": 4899412369, "node_id": "LA_kwDOIPDwls8AAAABJAcZkQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20agent", "name": "area: agent", "color": "BFD4F2", "default": false, "description": "Related to agents module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
2
2023-12-07T05:39:25
2023-12-22T13:19:39
null
NONE
null
### System Info Langchain version = 0.0.344 Python version = 3.11.5 @agola11 @hwchase17 ### Who can help? @hwchase17 @agola11 ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [X] Agents / Agent Executors - [X] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction Here is my code and it is giving me below error for create_sql_agent whe i use suffix variable. A single string input was passed in, but this chain expects multiple inputs (set()). When a chain expects multiple inputs, please call it by passing in a dictionary, eg `chain({'foo': 1, 'bar': 2}) agent_inputs = { 'prefix': MSSQL_AGENT_PREFIX, 'format_instructions': MSSQL_AGENT_FORMAT_INSTRUCTIONS, 'suffix': MSSQL_AGENT_SUFFIX, 'llm': llm, 'toolkit': toolkit, 'top_k': 30, 'early_stopping_method': 'generate', 'handle_parsing_errors': True, 'input_variables': ['question'] } agent_executor_sql = create_sql_agent(**agent_inputs) i also used suffix': [MSSQL_AGENT_SUFFIX], and suffix': str(MSSQL_AGENT_SUFFIX). Yet the error persist. Kindly help. ### Expected behavior It should take suffix and work.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14379/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14379/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14378
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14378/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14378/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14378/events
https://github.com/langchain-ai/langchain/issues/14378
2,029,922,881
I_kwDOIPDwls54_ipB
14,378
Issue with Qdrant: TypeError: unhashable type: 'list'
{ "login": "jeremi", "id": 9537, "node_id": "MDQ6VXNlcjk1Mzc=", "avatar_url": "https://avatars.githubusercontent.com/u/9537?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jeremi", "html_url": "https://github.com/jeremi", "followers_url": "https://api.github.com/users/jeremi/followers", "following_url": "https://api.github.com/users/jeremi/following{/other_user}", "gists_url": "https://api.github.com/users/jeremi/gists{/gist_id}", "starred_url": "https://api.github.com/users/jeremi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jeremi/subscriptions", "organizations_url": "https://api.github.com/users/jeremi/orgs", "repos_url": "https://api.github.com/users/jeremi/repos", "events_url": "https://api.github.com/users/jeremi/events{/privacy}", "received_events_url": "https://api.github.com/users/jeremi/received_events", "type": "User", "site_admin": false }
[ { "id": 5541141061, "node_id": "LA_kwDOIPDwls8AAAABSkcaRQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20embeddings", "name": "area: embeddings", "color": "C5DEF5", "default": false, "description": "Related to text embedding models module" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" } ]
closed
false
null
[]
null
8
2023-12-07T05:17:40
2023-12-07T19:19:13
2023-12-07T19:19:13
NONE
null
### System Info langchain==0.0.347 langchain-core==0.0.11 ### Who can help? @JeanBaptiste-dlb @hwchase17 @kacperlukawski ### Information - [X] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [X] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction The code I'm trying is based from: https://python.langchain.com/docs/integrations/vectorstores/qdrant ``` import os directory_path = 'data/' from langchain.document_loaders import TextLoader from langchain.embeddings.openai import OpenAIEmbeddings from langchain.text_splitter import CharacterTextSplitter from langchain.vectorstores import Qdrant from langchain.embeddings import OpenAIEmbeddings embeddings = OpenAIEmbeddings(openai_api_key="sk-XXX") loader = TextLoader(os.path.join(directory_path, "concept-note.md")) documents = loader.load() text_splitter = CharacterTextSplitter(chunk_size=1000, chunk_overlap=0) docs = text_splitter.split_documents(documents) qdrant = Qdrant.from_documents( docs, embeddings, location=":memory:", # Local mode with in-memory storage only collection_name="my_documents", ) ``` The error: ``` Created a chunk of size 1893, which is longer than the specified 1000 Created a chunk of size 1728, which is longer than the specified 1000 Created a chunk of size 1317, which is longer than the specified 1000 Created a chunk of size 1464, which is longer than the specified 1000 Created a chunk of size 2119, which is longer than the specified 1000 Created a chunk of size 1106, which is longer than the specified 1000 Created a chunk of size 1822, which is longer than the specified 1000 Created a chunk of size 3658, which is longer than the specified 1000 Created a chunk of size 1233, which is longer than the specified 1000 Created a chunk of size 1522, which is longer than the specified 1000 --------------------------------------------------------------------------- TypeError Traceback (most recent call last) Cell In[3], line 20 16 docs = text_splitter.split_documents(documents) 17 docs ---> 20 qdrant = Qdrant.from_documents( 21 docs, 22 embeddings, 23 location=":memory:", # Local mode with in-memory storage only 24 collection_name="my_documents", 25 ) File /opt/conda/lib/python3.11/site-packages/langchain_core/vectorstores.py:510, in VectorStore.from_documents(cls, documents, embedding, **kwargs) 508 texts = [d.page_content for d in documents] 509 metadatas = [d.metadata for d in documents] --> 510 return cls.from_texts(texts, embedding, metadatas=metadatas, **kwargs) File /opt/conda/lib/python3.11/site-packages/langchain/vectorstores/qdrant.py:1345, in Qdrant.from_texts(cls, texts, embedding, metadatas, ids, location, url, port, grpc_port, prefer_grpc, https, api_key, prefix, timeout, host, path, collection_name, distance_func, content_payload_key, metadata_payload_key, vector_name, batch_size, shard_number, replication_factor, write_consistency_factor, on_disk_payload, hnsw_config, optimizers_config, wal_config, quantization_config, init_from, on_disk, force_recreate, **kwargs) 1210 """Construct Qdrant wrapper from a list of texts. 1211 1212 Args: (...) 1311 qdrant = Qdrant.from_texts(texts, embeddings, "localhost") 1312 """ 1313 qdrant = cls.construct_instance( 1314 texts, 1315 embedding, (...) 1343 **kwargs, 1344 ) -> 1345 qdrant.add_texts(texts, metadatas, ids, batch_size) 1346 return qdrant File /opt/conda/lib/python3.11/site-packages/langchain/vectorstores/qdrant.py:190, in Qdrant.add_texts(self, texts, metadatas, ids, batch_size, **kwargs) 174 """Run more texts through the embeddings and add to the vectorstore. 175 176 Args: (...) 187 List of ids from adding the texts into the vectorstore. 188 """ 189 added_ids = [] --> 190 for batch_ids, points in self._generate_rest_batches( 191 texts, metadatas, ids, batch_size 192 ): 193 self.client.upsert( 194 collection_name=self.collection_name, points=points, **kwargs 195 ) 196 added_ids.extend(batch_ids) File /opt/conda/lib/python3.11/site-packages/langchain/vectorstores/qdrant.py:2136, in Qdrant._generate_rest_batches(self, texts, metadatas, ids, batch_size) 2122 # Generate the embeddings for all the texts in a batch 2123 batch_embeddings = self._embed_texts(batch_texts) 2125 points = [ 2126 rest.PointStruct( 2127 id=point_id, 2128 vector=vector 2129 if self.vector_name is None 2130 else {self.vector_name: vector}, 2131 payload=payload, 2132 ) 2133 for point_id, vector, payload in zip( 2134 batch_ids, 2135 batch_embeddings, -> 2136 self._build_payloads( 2137 batch_texts, 2138 batch_metadatas, 2139 self.content_payload_key, 2140 self.metadata_payload_key, 2141 ), 2142 ) 2143 ] 2145 yield batch_ids, points File /opt/conda/lib/python3.11/site-packages/langchain/vectorstores/qdrant.py:1918, in Qdrant._build_payloads(cls, texts, metadatas, content_payload_key, metadata_payload_key) 1912 raise ValueError( 1913 "At least one of the texts is None. Please remove it before " 1914 "calling .from_texts or .add_texts on Qdrant instance." 1915 ) 1916 metadata = metadatas[i] if metadatas is not None else None 1917 payloads.append( -> 1918 { 1919 content_payload_key: text, 1920 metadata_payload_key: metadata, 1921 } 1922 ) 1924 return payloads TypeError: unhashable type: 'list' ``` ### Expected behavior It should not raise an error.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14378/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14378/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14377
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14377/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14377/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14377/events
https://github.com/langchain-ai/langchain/issues/14377
2,029,920,632
I_kwDOIPDwls54_iF4
14,377
OpenAIEmbeddings bug
{ "login": "youfak", "id": 27138744, "node_id": "MDQ6VXNlcjI3MTM4NzQ0", "avatar_url": "https://avatars.githubusercontent.com/u/27138744?v=4", "gravatar_id": "", "url": "https://api.github.com/users/youfak", "html_url": "https://github.com/youfak", "followers_url": "https://api.github.com/users/youfak/followers", "following_url": "https://api.github.com/users/youfak/following{/other_user}", "gists_url": "https://api.github.com/users/youfak/gists{/gist_id}", "starred_url": "https://api.github.com/users/youfak/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/youfak/subscriptions", "organizations_url": "https://api.github.com/users/youfak/orgs", "repos_url": "https://api.github.com/users/youfak/repos", "events_url": "https://api.github.com/users/youfak/events{/privacy}", "received_events_url": "https://api.github.com/users/youfak/received_events", "type": "User", "site_admin": false }
[ { "id": 5541141061, "node_id": "LA_kwDOIPDwls8AAAABSkcaRQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20embeddings", "name": "area: embeddings", "color": "C5DEF5", "default": false, "description": "Related to text embedding models module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" } ]
closed
false
null
[]
null
3
2023-12-07T05:16:19
2023-12-11T04:28:11
2023-12-11T04:28:11
NONE
null
### System Info langchain==0.0.344 langchain-experimental>=0.0.42 python==3.10.12 ``` embeddings = OpenAIEmbeddings(model_name=model, openai_api_key=get_model_path(model), chunk_size=CHUNK_SIZE) ``` error ``` WARNING! model_name is not default parameter. model_name was transferred to model_kwargs. Please confirm that model_name is what you intended. warnings.warn( 2023-12-07 12:36:12,645 - embeddings_api.py[line:39] - ERROR: Embeddings.create() got an unexpected keyword argument 'model_name' AttributeError: 'NoneType' object has no attribute 'conjugate' ``` ### Who can help? @hwchase17 ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [X] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ``` from langchain.embeddings.openai import OpenAIEmbeddings embeddings = OpenAIEmbeddings(model_name="text-embedding-ada-002", openai_api_key='xxxx', chunk_size=512) data = embeddings.embed_documents(texts) ``` ### Expected behavior Normal loading
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14377/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14377/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14376
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14376/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14376/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14376/events
https://github.com/langchain-ai/langchain/pull/14376
2,029,801,196
PR_kwDOIPDwls5hXu4q
14,376
Triyam/bedrock Exception bug resolved
{ "login": "triyam", "id": 55938092, "node_id": "MDQ6VXNlcjU1OTM4MDky", "avatar_url": "https://avatars.githubusercontent.com/u/55938092?v=4", "gravatar_id": "", "url": "https://api.github.com/users/triyam", "html_url": "https://github.com/triyam", "followers_url": "https://api.github.com/users/triyam/followers", "following_url": "https://api.github.com/users/triyam/following{/other_user}", "gists_url": "https://api.github.com/users/triyam/gists{/gist_id}", "starred_url": "https://api.github.com/users/triyam/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/triyam/subscriptions", "organizations_url": "https://api.github.com/users/triyam/orgs", "repos_url": "https://api.github.com/users/triyam/repos", "events_url": "https://api.github.com/users/triyam/events{/privacy}", "received_events_url": "https://api.github.com/users/triyam/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
5
2023-12-07T03:16:37
2024-01-03T06:40:59
2024-01-03T06:40:58
NONE
null
Issue #14347 - **Description:** There a minor bug in error catching in `bedrockbase` class `langchain/llms/bedrock.py` file, - **Issue:** exception was providing a broad error - **Changes:** >pytest = "^7.4.3", >content-hash = "fea3d6ece1f52d59a144dd626f61be20bda6306dfe4f786b815d7a2f1e82d486" > This file is automatically @generated by Poetry 1.7.1 and should not be changed by hand. - **Twitter handle:** https://twitter.com/Triyambaka58284?t=X5gMJFL7PcijWDzP5zgp6g ```diff Removed: -except Exception as e: - raise ValueError(f"Error raised by bedrock service: {e}") Added: +except Exception as e: + if "ThrottlingException" in str(e): + raise ValueError( + f"ThrottlingException raised by bedrock service: {e}" + ) from e + else: + raise ValueError(f"Error raised by bedrock service: {e}") from e ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14376/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14376/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14376", "html_url": "https://github.com/langchain-ai/langchain/pull/14376", "diff_url": "https://github.com/langchain-ai/langchain/pull/14376.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14376.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14375
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14375/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14375/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14375/events
https://github.com/langchain-ai/langchain/pull/14375
2,029,789,826
PR_kwDOIPDwls5hXtPC
14,375
[Feature] RecursiveURLLoader: Custom PreventOutside
{ "login": "hinthornw", "id": 13333726, "node_id": "MDQ6VXNlcjEzMzMzNzI2", "avatar_url": "https://avatars.githubusercontent.com/u/13333726?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hinthornw", "html_url": "https://github.com/hinthornw", "followers_url": "https://api.github.com/users/hinthornw/followers", "following_url": "https://api.github.com/users/hinthornw/following{/other_user}", "gists_url": "https://api.github.com/users/hinthornw/gists{/gist_id}", "starred_url": "https://api.github.com/users/hinthornw/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hinthornw/subscriptions", "organizations_url": "https://api.github.com/users/hinthornw/orgs", "repos_url": "https://api.github.com/users/hinthornw/repos", "events_url": "https://api.github.com/users/hinthornw/events{/privacy}", "received_events_url": "https://api.github.com/users/hinthornw/received_events", "type": "User", "site_admin": false }
[]
open
false
null
[]
null
1
2023-12-07T03:06:43
2023-12-07T03:06:49
null
COLLABORATOR
null
For websites where you start at a .html file, you aren't able to load sibling paths. If we allow prevent_outside to be another url, you can do things like: start at `https://api.python.langchain.com/en/latest/core_api_reference.html` and prevent_outside to be `https://api.python.langchain.com/en/latest/`
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14375/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14375/timeline
null
null
true
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14375", "html_url": "https://github.com/langchain-ai/langchain/pull/14375", "diff_url": "https://github.com/langchain-ai/langchain/pull/14375.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14375.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14374
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14374/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14374/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14374/events
https://github.com/langchain-ai/langchain/issues/14374
2,029,776,848
I_kwDOIPDwls54--_Q
14,374
Add support for private endpoint(Private Service Connect) for Vertex AI LLM
{ "login": "onesolpark", "id": 32834020, "node_id": "MDQ6VXNlcjMyODM0MDIw", "avatar_url": "https://avatars.githubusercontent.com/u/32834020?v=4", "gravatar_id": "", "url": "https://api.github.com/users/onesolpark", "html_url": "https://github.com/onesolpark", "followers_url": "https://api.github.com/users/onesolpark/followers", "following_url": "https://api.github.com/users/onesolpark/following{/other_user}", "gists_url": "https://api.github.com/users/onesolpark/gists{/gist_id}", "starred_url": "https://api.github.com/users/onesolpark/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/onesolpark/subscriptions", "organizations_url": "https://api.github.com/users/onesolpark/orgs", "repos_url": "https://api.github.com/users/onesolpark/repos", "events_url": "https://api.github.com/users/onesolpark/events{/privacy}", "received_events_url": "https://api.github.com/users/onesolpark/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700863, "node_id": "LA_kwDOIPDwls8AAAABUpidvw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:enhancement", "name": "auto:enhancement", "color": "C2E0C6", "default": false, "description": "A large net-new component, integration, or chain. Use sparingly. The largest features" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
1
2023-12-07T02:53:41
2023-12-07T02:55:58
null
NONE
null
### Feature request Add support for Private Service Connect endpoints in Vertex AI LLM. ### Motivation Currently api_endpoint for VertexAIModelGarden LLM is hard coded to ```aiplatform.googleapis.com``` https://github.com/langchain-ai/langchain/blob/db6bf8b022c17353b46f97ab3b9f44ff9e88a488/libs/langchain/langchain/llms/vertexai.py#L380-L382 Google supports Private Service Connect or private endpoints to google services. https://cloud.google.com/vpc/docs/configure-private-service-connect-apis#using-endpoints Users can use private domains i.e. ```us-central1-aiplatform-xxxx.p.googleapis.com``` to call models in vertex ai. ### Your contribution I can create a PR to add api_endpoint_base to let users specify google api endpoint for VertexAIModelGarden. Currently pretrained models in ```vertexai.language_models```doesn't support specifying googleapi endpoint. I'll also create an issue on vertex ai python sdk. Changes to pretrained model can be made if necessary changes are made to vertex ai python sdk.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14374/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14374/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14373
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14373/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14373/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14373/events
https://github.com/langchain-ai/langchain/pull/14373
2,029,738,476
PR_kwDOIPDwls5hXjsn
14,373
core[patch], langchain[patch]: fix required deps
{ "login": "baskaryan", "id": 22008038, "node_id": "MDQ6VXNlcjIyMDA4MDM4", "avatar_url": "https://avatars.githubusercontent.com/u/22008038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/baskaryan", "html_url": "https://github.com/baskaryan", "followers_url": "https://api.github.com/users/baskaryan/followers", "following_url": "https://api.github.com/users/baskaryan/following{/other_user}", "gists_url": "https://api.github.com/users/baskaryan/gists{/gist_id}", "starred_url": "https://api.github.com/users/baskaryan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/baskaryan/subscriptions", "organizations_url": "https://api.github.com/users/baskaryan/orgs", "repos_url": "https://api.github.com/users/baskaryan/repos", "events_url": "https://api.github.com/users/baskaryan/events{/privacy}", "received_events_url": "https://api.github.com/users/baskaryan/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T02:18:34
2023-12-07T22:25:00
2023-12-07T22:24:59
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14373/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14373/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14373", "html_url": "https://github.com/langchain-ai/langchain/pull/14373", "diff_url": "https://github.com/langchain-ai/langchain/pull/14373.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14373.patch", "merged_at": "2023-12-07T22:24:59" }
https://api.github.com/repos/langchain-ai/langchain/issues/14372
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14372/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14372/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14372/events
https://github.com/langchain-ai/langchain/issues/14372
2,029,730,782
I_kwDOIPDwls54-zve
14,372
Issue: How can we specify multiple types when initialize an agent
{ "login": "zhengxingmao", "id": 40750002, "node_id": "MDQ6VXNlcjQwNzUwMDAy", "avatar_url": "https://avatars.githubusercontent.com/u/40750002?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhengxingmao", "html_url": "https://github.com/zhengxingmao", "followers_url": "https://api.github.com/users/zhengxingmao/followers", "following_url": "https://api.github.com/users/zhengxingmao/following{/other_user}", "gists_url": "https://api.github.com/users/zhengxingmao/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhengxingmao/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhengxingmao/subscriptions", "organizations_url": "https://api.github.com/users/zhengxingmao/orgs", "repos_url": "https://api.github.com/users/zhengxingmao/repos", "events_url": "https://api.github.com/users/zhengxingmao/events{/privacy}", "received_events_url": "https://api.github.com/users/zhengxingmao/received_events", "type": "User", "site_admin": false }
[ { "id": 4899412369, "node_id": "LA_kwDOIPDwls8AAAABJAcZkQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20agent", "name": "area: agent", "color": "BFD4F2", "default": false, "description": "Related to agents module" }, { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" } ]
closed
false
null
[]
null
10
2023-12-07T02:10:55
2023-12-07T05:41:04
2023-12-07T05:41:03
NONE
null
### Issue you'd like to raise. Can the 'AgentType parameter of ‘initialize_agent’ function only be of one type? How can I specify multiple types? I want to set agent type to 'STRUCTURED_CHAT_ZERO_SHOT_REACT_DESCRIPTION' and 'ZERO_SHOT_REACT_DESCRIPTION' at the same time ? ### Suggestion: Set agent type to 'STRUCTURED_CHAT_ZERO_SHOT_REACT_DESCRIPTION' and 'ZERO_SHOT_REACT_DESCRIPTION' at the same time when create a agent?
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14372/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14372/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14371
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14371/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14371/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14371/events
https://github.com/langchain-ai/langchain/issues/14371
2,029,727,951
I_kwDOIPDwls54-zDP
14,371
Issue: No module named 'langchain'
{ "login": "markredito", "id": 64991342, "node_id": "MDQ6VXNlcjY0OTkxMzQy", "avatar_url": "https://avatars.githubusercontent.com/u/64991342?v=4", "gravatar_id": "", "url": "https://api.github.com/users/markredito", "html_url": "https://github.com/markredito", "followers_url": "https://api.github.com/users/markredito/followers", "following_url": "https://api.github.com/users/markredito/following{/other_user}", "gists_url": "https://api.github.com/users/markredito/gists{/gist_id}", "starred_url": "https://api.github.com/users/markredito/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/markredito/subscriptions", "organizations_url": "https://api.github.com/users/markredito/orgs", "repos_url": "https://api.github.com/users/markredito/repos", "events_url": "https://api.github.com/users/markredito/events{/privacy}", "received_events_url": "https://api.github.com/users/markredito/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" } ]
open
false
null
[]
null
7
2023-12-07T02:09:09
2023-12-07T23:15:20
null
NONE
null
### Issue you'd like to raise. Issue: ``` PS E:\CODE\research-agents> python app.py Traceback (most recent call last): File "E:\CODE\research-agents\app.py", line 3, in <module> from langchain.text_splitter import RecursiveCharacterTextSplitter ModuleNotFoundError: No module named 'langchain' ``` What I've tried: - Upgrading to langchain newest version - Downgrading to langchain version==0.0.340 - Adding python path to environment variables - Fresh environment with Python 3.10.x - Fresh environment with Python 3.11.5 System: Python ver: 3.11.5 (Anaconda) Langchain ver: 0.0.340 OS: Windows 10 Thoughts, suggestions and tips are great appreciated. Thanks in advance! ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14371/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14371/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14370
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14370/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14370/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14370/events
https://github.com/langchain-ai/langchain/pull/14370
2,029,679,451
PR_kwDOIPDwls5hXYBW
14,370
Add ChatGLM3 llm usage
{ "login": "169", "id": 10000925, "node_id": "MDQ6VXNlcjEwMDAwOTI1", "avatar_url": "https://avatars.githubusercontent.com/u/10000925?v=4", "gravatar_id": "", "url": "https://api.github.com/users/169", "html_url": "https://github.com/169", "followers_url": "https://api.github.com/users/169/followers", "following_url": "https://api.github.com/users/169/following{/other_user}", "gists_url": "https://api.github.com/users/169/gists{/gist_id}", "starred_url": "https://api.github.com/users/169/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/169/subscriptions", "organizations_url": "https://api.github.com/users/169/orgs", "repos_url": "https://api.github.com/users/169/repos", "events_url": "https://api.github.com/users/169/events{/privacy}", "received_events_url": "https://api.github.com/users/169/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700863, "node_id": "LA_kwDOIPDwls8AAAABUpidvw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:enhancement", "name": "auto:enhancement", "color": "C2E0C6", "default": false, "description": "A large net-new component, integration, or chain. Use sparingly. The largest features" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
2
2023-12-07T01:30:11
2023-12-28T11:41:44
2023-12-28T11:41:44
CONTRIBUTOR
null
Add [ChatGLM3](https://github.com/THUDM/ChatGLM3) and updated [chatglm.ipynb](https://python.langchain.com/docs/integrations/llms/chatglm)
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14370/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14370/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14370", "html_url": "https://github.com/langchain-ai/langchain/pull/14370", "diff_url": "https://github.com/langchain-ai/langchain/pull/14370.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14370.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14369
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14369/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14369/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14369/events
https://github.com/langchain-ai/langchain/pull/14369
2,029,623,769
PR_kwDOIPDwls5hXMIM
14,369
langchain[patch]: fix ChatVertexAI streaming
{ "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T00:25:45
2023-12-07T17:46:13
2023-12-07T17:46:12
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14369/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14369/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14369", "html_url": "https://github.com/langchain-ai/langchain/pull/14369", "diff_url": "https://github.com/langchain-ai/langchain/pull/14369.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14369.patch", "merged_at": "2023-12-07T17:46:12" }
https://api.github.com/repos/langchain-ai/langchain/issues/14368
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14368/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14368/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14368/events
https://github.com/langchain-ai/langchain/pull/14368
2,029,599,992
PR_kwDOIPDwls5hXGzW
14,368
langchain[patch]: Release 0.0.347
{ "login": "baskaryan", "id": 22008038, "node_id": "MDQ6VXNlcjIyMDA4MDM4", "avatar_url": "https://avatars.githubusercontent.com/u/22008038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/baskaryan", "html_url": "https://github.com/baskaryan", "followers_url": "https://api.github.com/users/baskaryan/followers", "following_url": "https://api.github.com/users/baskaryan/following{/other_user}", "gists_url": "https://api.github.com/users/baskaryan/gists{/gist_id}", "starred_url": "https://api.github.com/users/baskaryan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/baskaryan/subscriptions", "organizations_url": "https://api.github.com/users/baskaryan/orgs", "repos_url": "https://api.github.com/users/baskaryan/repos", "events_url": "https://api.github.com/users/baskaryan/events{/privacy}", "received_events_url": "https://api.github.com/users/baskaryan/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-07T00:05:55
2023-12-07T00:13:31
2023-12-07T00:13:30
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14368/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14368/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14368", "html_url": "https://github.com/langchain-ai/langchain/pull/14368", "diff_url": "https://github.com/langchain-ai/langchain/pull/14368.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14368.patch", "merged_at": "2023-12-07T00:13:30" }
https://api.github.com/repos/langchain-ai/langchain/issues/14367
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14367/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14367/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14367/events
https://github.com/langchain-ai/langchain/pull/14367
2,029,583,965
PR_kwDOIPDwls5hXDTH
14,367
core[patch]: Release 0.0.11
{ "login": "baskaryan", "id": 22008038, "node_id": "MDQ6VXNlcjIyMDA4MDM4", "avatar_url": "https://avatars.githubusercontent.com/u/22008038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/baskaryan", "html_url": "https://github.com/baskaryan", "followers_url": "https://api.github.com/users/baskaryan/followers", "following_url": "https://api.github.com/users/baskaryan/following{/other_user}", "gists_url": "https://api.github.com/users/baskaryan/gists{/gist_id}", "starred_url": "https://api.github.com/users/baskaryan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/baskaryan/subscriptions", "organizations_url": "https://api.github.com/users/baskaryan/orgs", "repos_url": "https://api.github.com/users/baskaryan/repos", "events_url": "https://api.github.com/users/baskaryan/events{/privacy}", "received_events_url": "https://api.github.com/users/baskaryan/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-06T23:48:13
2023-12-06T23:53:50
2023-12-06T23:53:49
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14367/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14367/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14367", "html_url": "https://github.com/langchain-ai/langchain/pull/14367", "diff_url": "https://github.com/langchain-ai/langchain/pull/14367.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14367.patch", "merged_at": "2023-12-06T23:53:49" }
https://api.github.com/repos/langchain-ai/langchain/issues/14366
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14366/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14366/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14366/events
https://github.com/langchain-ai/langchain/pull/14366
2,029,578,602
PR_kwDOIPDwls5hXCKE
14,366
docs: notebook linting
{ "login": "leo-gan", "id": 2256422, "node_id": "MDQ6VXNlcjIyNTY0MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/2256422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/leo-gan", "html_url": "https://github.com/leo-gan", "followers_url": "https://api.github.com/users/leo-gan/followers", "following_url": "https://api.github.com/users/leo-gan/following{/other_user}", "gists_url": "https://api.github.com/users/leo-gan/gists{/gist_id}", "starred_url": "https://api.github.com/users/leo-gan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leo-gan/subscriptions", "organizations_url": "https://api.github.com/users/leo-gan/orgs", "repos_url": "https://api.github.com/users/leo-gan/repos", "events_url": "https://api.github.com/users/leo-gan/events{/privacy}", "received_events_url": "https://api.github.com/users/leo-gan/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-06T23:41:30
2023-12-08T01:11:51
2023-12-07T23:47:48
COLLABORATOR
null
Many jupyter notebooks didn't pass linting. List of these files are presented in the [tool.ruff.lint.per-file-ignores] section of the pyproject.toml . Addressed these bugs: - fixed bugs; added missed imports; updated pyproject.toml @efriis Only the `document_loaders/tensorflow_datasets.ipyn`, `cookbook/gymnasium_agent_simulation.ipynb` are not completely fixed. I'm not sure about imports.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14366/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14366/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14366", "html_url": "https://github.com/langchain-ai/langchain/pull/14366", "diff_url": "https://github.com/langchain-ai/langchain/pull/14366.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14366.patch", "merged_at": "2023-12-07T23:47:48" }
https://api.github.com/repos/langchain-ai/langchain/issues/14364
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14364/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14364/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14364/events
https://github.com/langchain-ai/langchain/pull/14364
2,029,444,289
PR_kwDOIPDwls5hWkMm
14,364
all[patch]: change ci title in event of no matrix expansion
{ "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
2
2023-12-06T21:51:07
2023-12-06T21:59:22
2023-12-06T21:59:21
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14364/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14364/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14364", "html_url": "https://github.com/langchain-ai/langchain/pull/14364", "diff_url": "https://github.com/langchain-ai/langchain/pull/14364.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14364.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14363
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14363/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14363/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14363/events
https://github.com/langchain-ai/langchain/issues/14363
2,029,429,941
I_kwDOIPDwls549qS1
14,363
Issue: agent output parser
{ "login": "xasxin", "id": 113810081, "node_id": "U_kgDOBsiaoQ", "avatar_url": "https://avatars.githubusercontent.com/u/113810081?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xasxin", "html_url": "https://github.com/xasxin", "followers_url": "https://api.github.com/users/xasxin/followers", "following_url": "https://api.github.com/users/xasxin/following{/other_user}", "gists_url": "https://api.github.com/users/xasxin/gists{/gist_id}", "starred_url": "https://api.github.com/users/xasxin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xasxin/subscriptions", "organizations_url": "https://api.github.com/users/xasxin/orgs", "repos_url": "https://api.github.com/users/xasxin/repos", "events_url": "https://api.github.com/users/xasxin/events{/privacy}", "received_events_url": "https://api.github.com/users/xasxin/received_events", "type": "User", "site_admin": false }
[ { "id": 4899412369, "node_id": "LA_kwDOIPDwls8AAAABJAcZkQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20agent", "name": "area: agent", "color": "BFD4F2", "default": false, "description": "Related to agents module" }, { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" } ]
open
false
null
[]
null
1
2023-12-06T21:40:20
2023-12-06T21:56:14
null
NONE
null
### Issue you'd like to raise. Hi, I'm trying to make a Chinese agent using customized tools and prompt in Chinese. However the pre-defined output parser and streaming didn't work well. For example, the thought process was printed out even if I'm using the FinalStreamingStdOutCallbackHandler. I was wondering if you can help me 1, to understand how the prompt, output parser and streaming works in agent; 2 provide me some suggestions of making my own prompt, output parser and streaming class for Chinese processing. ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14363/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14363/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14362
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14362/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14362/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14362/events
https://github.com/langchain-ai/langchain/pull/14362
2,029,424,677
PR_kwDOIPDwls5hWf5E
14,362
MongoDB agent fixes
{ "login": "amiaxys", "id": 70973560, "node_id": "MDQ6VXNlcjcwOTczNTYw", "avatar_url": "https://avatars.githubusercontent.com/u/70973560?v=4", "gravatar_id": "", "url": "https://api.github.com/users/amiaxys", "html_url": "https://github.com/amiaxys", "followers_url": "https://api.github.com/users/amiaxys/followers", "following_url": "https://api.github.com/users/amiaxys/following{/other_user}", "gists_url": "https://api.github.com/users/amiaxys/gists{/gist_id}", "starred_url": "https://api.github.com/users/amiaxys/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/amiaxys/subscriptions", "organizations_url": "https://api.github.com/users/amiaxys/orgs", "repos_url": "https://api.github.com/users/amiaxys/repos", "events_url": "https://api.github.com/users/amiaxys/events{/privacy}", "received_events_url": "https://api.github.com/users/amiaxys/received_events", "type": "User", "site_admin": false }
[ { "id": 4899412369, "node_id": "LA_kwDOIPDwls8AAAABJAcZkQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20agent", "name": "area: agent", "color": "BFD4F2", "default": false, "description": "Related to agents module" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-06T21:35:55
2023-12-06T22:31:11
2023-12-06T22:31:10
NONE
null
<!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** a description of the change, - **Issue:** the issue # it fixes (if applicable), - **Dependencies:** any dependencies required for this change, - **Tag maintainer:** for a quicker response, tag the relevant maintainer (see below), - **Twitter handle:** we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out! Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. --> - **Description:** Moved the agent designed to interact with and query a MongoDB database using PyMongo into experimental, and fixed the unit test issues that came about using MongoDB Unix sockets. - **Issue:** There were some some test workflows not running in `Harrison/mongo-agent` due to using nonexistent sockets, and Mongo agent should have been moved to experimental due to concerns mentioned in #13991 - **Dependencies:** `pymongo` in experimental, not optional - Reason: Github workflows were throwing `pymongo ModuleNotFound` errors when it was optional, even after adding it to extended testing, running poetry lock, doing everything that the testing documentation said to do - **Related:** #14056, #13991 - **Tag maintainers:** @hwchase17 @efriis
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14362/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14362/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14362", "html_url": "https://github.com/langchain-ai/langchain/pull/14362", "diff_url": "https://github.com/langchain-ai/langchain/pull/14362.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14362.patch", "merged_at": "2023-12-06T22:31:10" }
https://api.github.com/repos/langchain-ai/langchain/issues/14361
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14361/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14361/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14361/events
https://github.com/langchain-ai/langchain/pull/14361
2,029,410,063
PR_kwDOIPDwls5hWcrX
14,361
core[patch]: message history error typo
{ "login": "efriis", "id": 9557659, "node_id": "MDQ6VXNlcjk1NTc2NTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9557659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/efriis", "html_url": "https://github.com/efriis", "followers_url": "https://api.github.com/users/efriis/followers", "following_url": "https://api.github.com/users/efriis/following{/other_user}", "gists_url": "https://api.github.com/users/efriis/gists{/gist_id}", "starred_url": "https://api.github.com/users/efriis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/efriis/subscriptions", "organizations_url": "https://api.github.com/users/efriis/orgs", "repos_url": "https://api.github.com/users/efriis/repos", "events_url": "https://api.github.com/users/efriis/events{/privacy}", "received_events_url": "https://api.github.com/users/efriis/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-06T21:24:45
2023-12-06T22:20:11
2023-12-06T22:20:10
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14361/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14361/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14361", "html_url": "https://github.com/langchain-ai/langchain/pull/14361", "diff_url": "https://github.com/langchain-ai/langchain/pull/14361.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14361.patch", "merged_at": "2023-12-06T22:20:10" }
https://api.github.com/repos/langchain-ai/langchain/issues/14360
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14360/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14360/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14360/events
https://github.com/langchain-ai/langchain/issues/14360
2,029,399,684
I_kwDOIPDwls549i6E
14,360
DOC: Explain how to continue the conversation with OllamaFunctions
{ "login": "tonylampada", "id": 218821, "node_id": "MDQ6VXNlcjIxODgyMQ==", "avatar_url": "https://avatars.githubusercontent.com/u/218821?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tonylampada", "html_url": "https://github.com/tonylampada", "followers_url": "https://api.github.com/users/tonylampada/followers", "following_url": "https://api.github.com/users/tonylampada/following{/other_user}", "gists_url": "https://api.github.com/users/tonylampada/gists{/gist_id}", "starred_url": "https://api.github.com/users/tonylampada/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tonylampada/subscriptions", "organizations_url": "https://api.github.com/users/tonylampada/orgs", "repos_url": "https://api.github.com/users/tonylampada/repos", "events_url": "https://api.github.com/users/tonylampada/events{/privacy}", "received_events_url": "https://api.github.com/users/tonylampada/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
open
false
null
[]
null
4
2023-12-06T21:17:30
2023-12-28T21:43:48
null
NONE
null
### Issue with current documentation: https://python.langchain.com/docs/integrations/chat/ollama_functions Ollama functions page shows how to start a conversation where the llm calls a function. But it stops there. How do we keep the conversation going? (i.e. I should give the llm the answer to the function call, and then it should give a text reply with his explanation of the weather in Paris, right?) Here's what I tried ``` >>> from langchain_experimental.llms.ollama_functions import OllamaFunctions >>> from langchain.schema import HumanMessage, FunctionMessage >>> import json >>> model = OllamaFunctions(model="mistral") >>> model = model.bind( ... functions=[ ... { ... "name": "get_current_weather", ... "description": "Get the current weather in a given location", ... "parameters": { ... "type": "object", ... "properties": { ... "location": { ... "type": "string", ... "description": "The city and state, " "e.g. San Francisco, CA", ... }, ... "unit": { ... "type": "string", ... "enum": ["celsius", "fahrenheit"], ... }, ... }, ... "required": ["location"], ... }, ... } ... ], ... function_call={"name": "get_current_weather"}, ... ) >>> >>> messages = [HumanMessage(content="how is the weather in Paris?")] >>> aim = model.invoke(messages) >>> aim AIMessage(content='', additional_kwargs={'function_call': {'name': 'get_current_weather', 'arguments': '{"location": "Paris, FR", "unit": "celsius"}'}}) >>> messages.append(aim) >>> fm = FunctionMessage(name='get_current_weather', content=json.dumps({'temperature': '25 celsius'})) >>> messages.append(fm) >>> aim = model.invoke(messages) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/runnables/base.py", line 2871, in invoke return self.bound.invoke( ^^^^^^^^^^^^^^^^^^ File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 160, in invoke self.generate_prompt( File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 491, in generate_prompt return self.generate(prompt_messages, stop=stop, callbacks=callbacks, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 378, in generate raise e File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 368, in generate self._generate_with_cache( File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 524, in _generate_with_cache return self._generate( ^^^^^^^^^^^^^^^ File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_experimental/llms/ollama_functions.py", line 90, in _generate response_message = self.llm.predict_messages( ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 685, in predict_messages return self(messages, stop=_stop, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 632, in __call__ generation = self.generate( ^^^^^^^^^^^^^^ File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 378, in generate raise e File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 368, in generate self._generate_with_cache( File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 524, in _generate_with_cache return self._generate( ^^^^^^^^^^^^^^^ File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain/chat_models/ollama.py", line 97, in _generate prompt = self._format_messages_as_text(messages) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain/chat_models/ollama.py", line 70, in _format_messages_as_text [self._format_message_as_text(message) for message in messages] File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain/chat_models/ollama.py", line 70, in <listcomp> [self._format_message_as_text(message) for message in messages] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/tony/.pyenv/versions/functionary/lib/python3.11/site-packages/langchain/chat_models/ollama.py", line 65, in _format_message_as_text raise ValueError(f"Got unknown type {message}") ValueError: Got unknown type content='{"temperature": "25 celsius"}' name='get_current_weather' >>> ``` ### Idea or request for content: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14360/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14360/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14358
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14358/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14358/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14358/events
https://github.com/langchain-ai/langchain/pull/14358
2,029,384,446
PR_kwDOIPDwls5hWXCy
14,358
Use extend method for embeddings concatenation in mlflow_gateway
{ "login": "jamesev15", "id": 84110446, "node_id": "MDQ6VXNlcjg0MTEwNDQ2", "avatar_url": "https://avatars.githubusercontent.com/u/84110446?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jamesev15", "html_url": "https://github.com/jamesev15", "followers_url": "https://api.github.com/users/jamesev15/followers", "following_url": "https://api.github.com/users/jamesev15/following{/other_user}", "gists_url": "https://api.github.com/users/jamesev15/gists{/gist_id}", "starred_url": "https://api.github.com/users/jamesev15/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jamesev15/subscriptions", "organizations_url": "https://api.github.com/users/jamesev15/orgs", "repos_url": "https://api.github.com/users/jamesev15/repos", "events_url": "https://api.github.com/users/jamesev15/events{/privacy}", "received_events_url": "https://api.github.com/users/jamesev15/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541141061, "node_id": "LA_kwDOIPDwls8AAAABSkcaRQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20embeddings", "name": "area: embeddings", "color": "C5DEF5", "default": false, "description": "Related to text embedding models module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
open
false
null
[]
null
3
2023-12-06T21:06:40
2024-01-15T20:33:16
null
NONE
null
## Description There is a bug in the concatenation of embeddings obtained from MLflow that does not conform to the type hint requested by the function. ``` python def _query(self, texts: List[str]) -> List[List[float]]: ``` It is logical to expect a **List[List[float]]** for a **List[str]**. However, the append method encapsulates the response in a global List. To avoid this, the extend method should be used, which will add the embeddings of all strings at the same list level. ## Testing I have tried using OpenAI-ADA to obtain the embeddings, and the result of executing this snippet is as follows: ``` python embeds = await MlflowAIGatewayEmbeddings().aembed_documents(texts=["hi", "how are you?"]) print(embeds) ``` ``` python [[[-0.03512698, -0.020624293, -0.015343423, ...], [-0.021260535, -0.011461929, -0.00033121882, ...]]] ``` When in reality, the expected result should be: ``` python [[-0.03512698, -0.020624293, -0.015343423, ...], [-0.021260535, -0.011461929, -0.00033121882, ...]] ``` The above result complies with the expected type hint: **List[List[float]]** . As I mentioned, we can achieve that by using the extend method instead of the append method.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14358/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14358/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14358", "html_url": "https://github.com/langchain-ai/langchain/pull/14358", "diff_url": "https://github.com/langchain-ai/langchain/pull/14358.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14358.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14356
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14356/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14356/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14356/events
https://github.com/langchain-ai/langchain/pull/14356
2,029,328,787
PR_kwDOIPDwls5hWK25
14,356
prevent regexparser output for map_rerank from failing
{ "login": "Siddhant-Ray", "id": 34578406, "node_id": "MDQ6VXNlcjM0NTc4NDA2", "avatar_url": "https://avatars.githubusercontent.com/u/34578406?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Siddhant-Ray", "html_url": "https://github.com/Siddhant-Ray", "followers_url": "https://api.github.com/users/Siddhant-Ray/followers", "following_url": "https://api.github.com/users/Siddhant-Ray/following{/other_user}", "gists_url": "https://api.github.com/users/Siddhant-Ray/gists{/gist_id}", "starred_url": "https://api.github.com/users/Siddhant-Ray/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Siddhant-Ray/subscriptions", "organizations_url": "https://api.github.com/users/Siddhant-Ray/orgs", "repos_url": "https://api.github.com/users/Siddhant-Ray/repos", "events_url": "https://api.github.com/users/Siddhant-Ray/events{/privacy}", "received_events_url": "https://api.github.com/users/Siddhant-Ray/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714119, "node_id": "LA_kwDOIPDwls8AAAABc3-rhw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:M", "name": "size:M", "color": "C5DEF5", "default": false, "description": "This PR changes 30-99 lines, ignoring generated files." } ]
closed
false
null
[]
null
3
2023-12-06T20:27:24
2024-01-03T06:45:00
2024-01-03T06:45:00
NONE
null
Description: The Map Rerank chain fails if, for any of the intermediate outputs, a score is not generated. This happens because the regex parser is an exact match on the "Score" keyword. No exception handling is done if this score is not generated and the pipeline fails. This is cumbersome to fix manually for a large set of queries. Fix: Add an exception case that if a score is not generated, add the "Score : 0" for that case. Logically this means the same as a score having no meaning. This fix resolves issue: #3970
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14356/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14356/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14356", "html_url": "https://github.com/langchain-ai/langchain/pull/14356", "diff_url": "https://github.com/langchain-ai/langchain/pull/14356.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14356.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14355
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14355/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14355/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14355/events
https://github.com/langchain-ai/langchain/pull/14355
2,029,279,594
PR_kwDOIPDwls5hWACG
14,355
Update to use multi-modal prompt template
{ "login": "rlancemartin", "id": 122662504, "node_id": "U_kgDOB0-uaA", "avatar_url": "https://avatars.githubusercontent.com/u/122662504?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rlancemartin", "html_url": "https://github.com/rlancemartin", "followers_url": "https://api.github.com/users/rlancemartin/followers", "following_url": "https://api.github.com/users/rlancemartin/following{/other_user}", "gists_url": "https://api.github.com/users/rlancemartin/gists{/gist_id}", "starred_url": "https://api.github.com/users/rlancemartin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rlancemartin/subscriptions", "organizations_url": "https://api.github.com/users/rlancemartin/orgs", "repos_url": "https://api.github.com/users/rlancemartin/repos", "events_url": "https://api.github.com/users/rlancemartin/events{/privacy}", "received_events_url": "https://api.github.com/users/rlancemartin/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 5924999838, "node_id": "LA_kwDOIPDwls8AAAABYShSng", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/integration:%20chroma", "name": "integration: chroma", "color": "B78AF8", "default": false, "description": "Related to ChromaDB" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
open
false
null
[]
null
1
2023-12-06T19:53:02
2023-12-06T20:01:39
null
COLLABORATOR
null
Builds on https://github.com/langchain-ai/langchain/pull/14263
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14355/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14355/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14355", "html_url": "https://github.com/langchain-ai/langchain/pull/14355", "diff_url": "https://github.com/langchain-ai/langchain/pull/14355.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14355.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14354
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14354/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14354/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14354/events
https://github.com/langchain-ai/langchain/pull/14354
2,029,261,192
PR_kwDOIPDwls5hV8BZ
14,354
langchain[patch]: import nits
{ "login": "baskaryan", "id": 22008038, "node_id": "MDQ6VXNlcjIyMDA4MDM4", "avatar_url": "https://avatars.githubusercontent.com/u/22008038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/baskaryan", "html_url": "https://github.com/baskaryan", "followers_url": "https://api.github.com/users/baskaryan/followers", "following_url": "https://api.github.com/users/baskaryan/following{/other_user}", "gists_url": "https://api.github.com/users/baskaryan/gists{/gist_id}", "starred_url": "https://api.github.com/users/baskaryan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/baskaryan/subscriptions", "organizations_url": "https://api.github.com/users/baskaryan/orgs", "repos_url": "https://api.github.com/users/baskaryan/repos", "events_url": "https://api.github.com/users/baskaryan/events{/privacy}", "received_events_url": "https://api.github.com/users/baskaryan/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700883, "node_id": "LA_kwDOIPDwls8AAAABUpid0w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:nit", "name": "auto:nit", "color": "FEF2C0", "default": false, "description": "Small modifications/deletions, fixes, deps or improvements to existing code or docs" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714108, "node_id": "LA_kwDOIPDwls8AAAABc3-rfA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:S", "name": "size:S", "color": "BFDADC", "default": false, "description": "This PR changes 10-29 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-06T19:40:18
2023-12-06T19:45:07
2023-12-06T19:45:06
COLLABORATOR
null
import from core instead of langchain.schema
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14354/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14354/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14354", "html_url": "https://github.com/langchain-ai/langchain/pull/14354", "diff_url": "https://github.com/langchain-ai/langchain/pull/14354.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14354.patch", "merged_at": "2023-12-06T19:45:06" }
https://api.github.com/repos/langchain-ai/langchain/issues/14353
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14353/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14353/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14353/events
https://github.com/langchain-ai/langchain/pull/14353
2,029,101,232
PR_kwDOIPDwls5hVY5x
14,353
Update readthedocs_documentation.ipynb
{ "login": "Prish10", "id": 145656290, "node_id": "U_kgDOCK6J4g", "avatar_url": "https://avatars.githubusercontent.com/u/145656290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Prish10", "html_url": "https://github.com/Prish10", "followers_url": "https://api.github.com/users/Prish10/followers", "following_url": "https://api.github.com/users/Prish10/following{/other_user}", "gists_url": "https://api.github.com/users/Prish10/gists{/gist_id}", "starred_url": "https://api.github.com/users/Prish10/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Prish10/subscriptions", "organizations_url": "https://api.github.com/users/Prish10/orgs", "repos_url": "https://api.github.com/users/Prish10/repos", "events_url": "https://api.github.com/users/Prish10/events{/privacy}", "received_events_url": "https://api.github.com/users/Prish10/received_events", "type": "User", "site_admin": false }
[ { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 6232714104, "node_id": "LA_kwDOIPDwls8AAAABc3-reA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:XS", "name": "size:XS", "color": "C2E0C6", "default": false, "description": "This PR changes 0-9 lines, ignoring generated files." } ]
open
false
null
[]
null
1
2023-12-06T17:57:13
2023-12-06T17:59:15
null
NONE
null
Have added latest implementation of ReadTheDocsLoader that I tried out on Langchain docs. The important parameter here is "encoding". Many users face the issue of 'UnicodeDecodeError':'character maps to Undefined. So, they need to change encoding according to their html files to utilize full power of ReadTheDocsLoader. <!-- Thank you for contributing to LangChain! Replace this entire comment with: - **Description:** Have added latest implementation of ReadTheDocsLoader that I tried out on Langchain docs. The important parameter here is "encoding". Many users face the issue of 'UnicodeDecodeError':'character maps to <Undefined>. So, they need to change encoding according to their html files to use ReadTheDocsLoader. - **Issue:** NA, - **Dependencies:** No, - **Tag maintainer:** @hotchpotch , - **Twitter handle:** NA Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/extras` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14353/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14353/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14353", "html_url": "https://github.com/langchain-ai/langchain/pull/14353", "diff_url": "https://github.com/langchain-ai/langchain/pull/14353.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14353.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14352
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14352/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14352/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14352/events
https://github.com/langchain-ai/langchain/pull/14352
2,029,079,706
PR_kwDOIPDwls5hVUUi
14,352
Masked the API key for Predibase LLM
{ "login": "lwunder", "id": 47267548, "node_id": "MDQ6VXNlcjQ3MjY3NTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/47267548?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lwunder", "html_url": "https://github.com/lwunder", "followers_url": "https://api.github.com/users/lwunder/followers", "following_url": "https://api.github.com/users/lwunder/following{/other_user}", "gists_url": "https://api.github.com/users/lwunder/gists{/gist_id}", "starred_url": "https://api.github.com/users/lwunder/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lwunder/subscriptions", "organizations_url": "https://api.github.com/users/lwunder/orgs", "repos_url": "https://api.github.com/users/lwunder/repos", "events_url": "https://api.github.com/users/lwunder/events{/privacy}", "received_events_url": "https://api.github.com/users/lwunder/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714108, "node_id": "LA_kwDOIPDwls8AAAABc3-rfA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:S", "name": "size:S", "color": "BFDADC", "default": false, "description": "This PR changes 10-29 lines, ignoring generated files." } ]
open
false
null
[]
null
1
2023-12-06T17:43:11
2023-12-06T17:43:24
null
NONE
null
- **Description:** Added the masking of the API key for the Predibase LLM using `SecretStr` - **Issue:** #12165 - **Dependencies:** N/A - **Tag maintainer:** @eyurtsev
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14352/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14352/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14352", "html_url": "https://github.com/langchain-ai/langchain/pull/14352", "diff_url": "https://github.com/langchain-ai/langchain/pull/14352.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14352.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/14351
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14351/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14351/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14351/events
https://github.com/langchain-ai/langchain/pull/14351
2,029,047,343
PR_kwDOIPDwls5hVNNY
14,351
Update RunnableWithMessageHistory
{ "login": "eyurtsev", "id": 3205522, "node_id": "MDQ6VXNlcjMyMDU1MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/3205522?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eyurtsev", "html_url": "https://github.com/eyurtsev", "followers_url": "https://api.github.com/users/eyurtsev/followers", "following_url": "https://api.github.com/users/eyurtsev/following{/other_user}", "gists_url": "https://api.github.com/users/eyurtsev/gists{/gist_id}", "starred_url": "https://api.github.com/users/eyurtsev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eyurtsev/subscriptions", "organizations_url": "https://api.github.com/users/eyurtsev/orgs", "repos_url": "https://api.github.com/users/eyurtsev/repos", "events_url": "https://api.github.com/users/eyurtsev/events{/privacy}", "received_events_url": "https://api.github.com/users/eyurtsev/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
3
2023-12-06T17:23:54
2023-12-12T02:34:51
2023-12-12T02:34:50
COLLABORATOR
null
This PR updates RunnableWithMessage history to support user specific configuration for the factory. It extends support to passing multiple named arguments into the factory if the factory takes more than a single argument.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14351/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14351/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14351", "html_url": "https://github.com/langchain-ai/langchain/pull/14351", "diff_url": "https://github.com/langchain-ai/langchain/pull/14351.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14351.patch", "merged_at": "2023-12-12T02:34:50" }
https://api.github.com/repos/langchain-ai/langchain/issues/14350
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14350/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14350/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14350/events
https://github.com/langchain-ai/langchain/pull/14350
2,028,976,911
PR_kwDOIPDwls5hU9l3
14,350
Fix multi vector retriever subclassing
{ "login": "jacoblee93", "id": 6952323, "node_id": "MDQ6VXNlcjY5NTIzMjM=", "avatar_url": "https://avatars.githubusercontent.com/u/6952323?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jacoblee93", "html_url": "https://github.com/jacoblee93", "followers_url": "https://api.github.com/users/jacoblee93/followers", "following_url": "https://api.github.com/users/jacoblee93/following{/other_user}", "gists_url": "https://api.github.com/users/jacoblee93/gists{/gist_id}", "starred_url": "https://api.github.com/users/jacoblee93/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jacoblee93/subscriptions", "organizations_url": "https://api.github.com/users/jacoblee93/orgs", "repos_url": "https://api.github.com/users/jacoblee93/repos", "events_url": "https://api.github.com/users/jacoblee93/events{/privacy}", "received_events_url": "https://api.github.com/users/jacoblee93/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 6232714126, "node_id": "LA_kwDOIPDwls8AAAABc3-rjg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:L", "name": "size:L", "color": "BFD4F2", "default": false, "description": "This PR changes 100-499 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-06T16:47:14
2023-12-06T19:12:51
2023-12-06T19:12:50
CONTRIBUTOR
null
Caused by my misunderstanding of `__init__` and Pydantic :( Fixes #14342 @eyurtsev @baskaryan
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14350/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14350/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14350", "html_url": "https://github.com/langchain-ai/langchain/pull/14350", "diff_url": "https://github.com/langchain-ai/langchain/pull/14350.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14350.patch", "merged_at": "2023-12-06T19:12:50" }
https://api.github.com/repos/langchain-ai/langchain/issues/14349
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14349/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14349/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14349/events
https://github.com/langchain-ai/langchain/pull/14349
2,028,974,714
PR_kwDOIPDwls5hU9HA
14,349
docs[patch]: Fix broken link 'tip' in docs
{ "login": "bracesproul", "id": 46789226, "node_id": "MDQ6VXNlcjQ2Nzg5MjI2", "avatar_url": "https://avatars.githubusercontent.com/u/46789226?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bracesproul", "html_url": "https://github.com/bracesproul", "followers_url": "https://api.github.com/users/bracesproul/followers", "following_url": "https://api.github.com/users/bracesproul/following{/other_user}", "gists_url": "https://api.github.com/users/bracesproul/gists{/gist_id}", "starred_url": "https://api.github.com/users/bracesproul/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bracesproul/subscriptions", "organizations_url": "https://api.github.com/users/bracesproul/orgs", "repos_url": "https://api.github.com/users/bracesproul/repos", "events_url": "https://api.github.com/users/bracesproul/events{/privacy}", "received_events_url": "https://api.github.com/users/bracesproul/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700918, "node_id": "LA_kwDOIPDwls8AAAABUpid9g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:documentation", "name": "auto:documentation", "color": "C5DEF5", "default": false, "description": "Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" }, { "id": 6232714119, "node_id": "LA_kwDOIPDwls8AAAABc3-rhw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/size:M", "name": "size:M", "color": "C5DEF5", "default": false, "description": "This PR changes 30-99 lines, ignoring generated files." } ]
closed
false
null
[]
null
1
2023-12-06T16:45:57
2023-12-06T17:45:00
2023-12-06T17:44:54
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14349/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14349/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/14349", "html_url": "https://github.com/langchain-ai/langchain/pull/14349", "diff_url": "https://github.com/langchain-ai/langchain/pull/14349.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/14349.patch", "merged_at": "2023-12-06T17:44:54" }
https://api.github.com/repos/langchain-ai/langchain/issues/14348
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14348/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14348/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14348/events
https://github.com/langchain-ai/langchain/issues/14348
2,028,892,316
I_kwDOIPDwls547nCc
14,348
Unexpected behaviour: CharacterTextSpitter
{ "login": "dheerajiiitv", "id": 24246192, "node_id": "MDQ6VXNlcjI0MjQ2MTky", "avatar_url": "https://avatars.githubusercontent.com/u/24246192?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dheerajiiitv", "html_url": "https://github.com/dheerajiiitv", "followers_url": "https://api.github.com/users/dheerajiiitv/followers", "following_url": "https://api.github.com/users/dheerajiiitv/following{/other_user}", "gists_url": "https://api.github.com/users/dheerajiiitv/gists{/gist_id}", "starred_url": "https://api.github.com/users/dheerajiiitv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dheerajiiitv/subscriptions", "organizations_url": "https://api.github.com/users/dheerajiiitv/orgs", "repos_url": "https://api.github.com/users/dheerajiiitv/repos", "events_url": "https://api.github.com/users/dheerajiiitv/events{/privacy}", "received_events_url": "https://api.github.com/users/dheerajiiitv/received_events", "type": "User", "site_admin": false }
[ { "id": 5541144676, "node_id": "LA_kwDOIPDwls8AAAABSkcoZA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20doc%20loader", "name": "area: doc loader", "color": "D4C5F9", "default": false, "description": "Related to document loader module (not documentation)" }, { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" } ]
open
false
null
[]
null
3
2023-12-06T16:02:29
2023-12-07T03:44:22
null
CONTRIBUTOR
null
### System Info langchain version: 0.0.315 python3.9 ### Who can help? @hwchase17 @eyurtsev ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [X] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ``` splitter = CharacterTextSplitter( separator="\n", chunk_size=1000, chunk_overlap=i0 ) paragraphs = splitter.split_text("This is the first paragraph.\n\nThis is the second paragraph.") print(paragraphs) paragraphs = splitter.split_text("This is the first paragraph.\n \nThis is the second paragraph.") print(paragraphs) ``` Returns ``` This is the first paragraph.\nThis is the second paragraph. #seems wrong, as It omits a new line character. This is the first paragraph.\n \nThis is the second paragraph. #correct ``` ### Expected behavior ``` This is the first paragraph.\n\nThis is the second paragraph. This is the first paragraph.\n \nThis is the second paragraph. ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14348/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14348/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14347
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14347/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14347/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14347/events
https://github.com/langchain-ai/langchain/issues/14347
2,028,739,597
I_kwDOIPDwls547BwN
14,347
Error catching in BedrockBase
{ "login": "JuR-0", "id": 94719392, "node_id": "U_kgDOBaVNoA", "avatar_url": "https://avatars.githubusercontent.com/u/94719392?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JuR-0", "html_url": "https://github.com/JuR-0", "followers_url": "https://api.github.com/users/JuR-0/followers", "following_url": "https://api.github.com/users/JuR-0/following{/other_user}", "gists_url": "https://api.github.com/users/JuR-0/gists{/gist_id}", "starred_url": "https://api.github.com/users/JuR-0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JuR-0/subscriptions", "organizations_url": "https://api.github.com/users/JuR-0/orgs", "repos_url": "https://api.github.com/users/JuR-0/repos", "events_url": "https://api.github.com/users/JuR-0/events{/privacy}", "received_events_url": "https://api.github.com/users/JuR-0/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" }, { "id": 5820539098, "node_id": "LA_kwDOIPDwls8AAAABWu5g2g", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20models", "name": "area: models", "color": "bfdadc", "default": false, "description": "Related to LLMs or chat model modules" } ]
closed
false
null
[]
null
3
2023-12-06T14:54:05
2024-01-03T01:25:50
2024-01-03T01:25:50
CONTRIBUTOR
null
### System Info I want to use the `with_retry` from the Runnable class with Bedrock class to initiate a retry if Bedrock is raising a ThrottlingException (too many requests) the problem is the error catching in `BedrockBase` class in the `_prepare_input_and_invoke` method is too broad. (line 269) ``` except Exception as e: raise ValueError(f"Error raised by bedrock service: {e}") ``` Is it possible to use something like : ``` except Exception as e: raise ValueError(f"Error raised by bedrock service: {e}") from e ``` Or: ``` except Exception as e: raise ValueError(f"Error raised by bedrock service: {e}")with_traceback(e.__traceback__) ``` To keep the initial exception type. Am I missing something that would explain this broad error catching? ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction No reproduction needed ### Expected behavior Expected behavior explained previously
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14347/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14347/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14346
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14346/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14346/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14346/events
https://github.com/langchain-ai/langchain/issues/14346
2,028,506,571
I_kwDOIPDwls546I3L
14,346
Embedding very sensitive to punctuation
{ "login": "yasmina-daoudi", "id": 69973577, "node_id": "MDQ6VXNlcjY5OTczNTc3", "avatar_url": "https://avatars.githubusercontent.com/u/69973577?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yasmina-daoudi", "html_url": "https://github.com/yasmina-daoudi", "followers_url": "https://api.github.com/users/yasmina-daoudi/followers", "following_url": "https://api.github.com/users/yasmina-daoudi/following{/other_user}", "gists_url": "https://api.github.com/users/yasmina-daoudi/gists{/gist_id}", "starred_url": "https://api.github.com/users/yasmina-daoudi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yasmina-daoudi/subscriptions", "organizations_url": "https://api.github.com/users/yasmina-daoudi/orgs", "repos_url": "https://api.github.com/users/yasmina-daoudi/repos", "events_url": "https://api.github.com/users/yasmina-daoudi/events{/privacy}", "received_events_url": "https://api.github.com/users/yasmina-daoudi/received_events", "type": "User", "site_admin": false }
[ { "id": 5541141061, "node_id": "LA_kwDOIPDwls8AAAABSkcaRQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20embeddings", "name": "area: embeddings", "color": "C5DEF5", "default": false, "description": "Related to text embedding models module" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700848, "node_id": "LA_kwDOIPDwls8AAAABUpidsA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:question", "name": "auto:question", "color": "BFD4F2", "default": false, "description": "A specific question about the codebase, product, project, or how to use a feature" } ]
open
false
null
[]
null
1
2023-12-06T13:00:05
2023-12-06T13:07:00
null
NONE
null
### System Info I have been using OpenAI Embeddings specifically text-embedding-ada-002 and noticed it was very sensitive to punctuation even. I have around 1000 chunks and need to extract each time the 15 most similar chunks to my query. I have been testing my query without punctuation and when I add a dot '.' at the end of my query it changes the initial set I got from the retriever with the query without punctuation (some chunks are the same but new ones may appear or the initial order is different). - Have you noticed anything similar ? - Is it the basic behaviour of this embedding to be that sensitive to punctuation ? - Is there a way to make it more robust to minor changes in the query ? FYI: I am using PGvector to store my chunks vectors ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [X] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction - ### Expected behavior -
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14346/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14346/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/14345
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/14345/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/14345/comments
https://api.github.com/repos/langchain-ai/langchain/issues/14345/events
https://github.com/langchain-ai/langchain/issues/14345
2,028,418,418
I_kwDOIPDwls545zVy
14,345
`PythonREPL` removal from langchain library
{ "login": "Vegoo89", "id": 34243210, "node_id": "MDQ6VXNlcjM0MjQzMjEw", "avatar_url": "https://avatars.githubusercontent.com/u/34243210?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Vegoo89", "html_url": "https://github.com/Vegoo89", "followers_url": "https://api.github.com/users/Vegoo89/followers", "following_url": "https://api.github.com/users/Vegoo89/following{/other_user}", "gists_url": "https://api.github.com/users/Vegoo89/gists{/gist_id}", "starred_url": "https://api.github.com/users/Vegoo89/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Vegoo89/subscriptions", "organizations_url": "https://api.github.com/users/Vegoo89/orgs", "repos_url": "https://api.github.com/users/Vegoo89/repos", "events_url": "https://api.github.com/users/Vegoo89/events{/privacy}", "received_events_url": "https://api.github.com/users/Vegoo89/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700839, "node_id": "LA_kwDOIPDwls8AAAABUpidpw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:bug", "name": "auto:bug", "color": "E99695", "default": false, "description": "Related to a bug, vulnerability, unexpected error with an existing feature" } ]
open
false
{ "login": "eyurtsev", "id": 3205522, "node_id": "MDQ6VXNlcjMyMDU1MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/3205522?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eyurtsev", "html_url": "https://github.com/eyurtsev", "followers_url": "https://api.github.com/users/eyurtsev/followers", "following_url": "https://api.github.com/users/eyurtsev/following{/other_user}", "gists_url": "https://api.github.com/users/eyurtsev/gists{/gist_id}", "starred_url": "https://api.github.com/users/eyurtsev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eyurtsev/subscriptions", "organizations_url": "https://api.github.com/users/eyurtsev/orgs", "repos_url": "https://api.github.com/users/eyurtsev/repos", "events_url": "https://api.github.com/users/eyurtsev/events{/privacy}", "received_events_url": "https://api.github.com/users/eyurtsev/received_events", "type": "User", "site_admin": false }
[ { "login": "eyurtsev", "id": 3205522, "node_id": "MDQ6VXNlcjMyMDU1MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/3205522?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eyurtsev", "html_url": "https://github.com/eyurtsev", "followers_url": "https://api.github.com/users/eyurtsev/followers", "following_url": "https://api.github.com/users/eyurtsev/following{/other_user}", "gists_url": "https://api.github.com/users/eyurtsev/gists{/gist_id}", "starred_url": "https://api.github.com/users/eyurtsev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eyurtsev/subscriptions", "organizations_url": "https://api.github.com/users/eyurtsev/orgs", "repos_url": "https://api.github.com/users/eyurtsev/repos", "events_url": "https://api.github.com/users/eyurtsev/events{/privacy}", "received_events_url": "https://api.github.com/users/eyurtsev/received_events", "type": "User", "site_admin": false } ]
null
2
2023-12-06T12:20:42
2024-01-05T09:17:37
null
NONE
null
### System Info Langchain version: 0.0.346 Python version: 3.9.16 ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction `PythonREPL` which has been moved to `experimental` still exists in based library under path: `libs/langchain/langchain/utilities/python.py` which triggers security scans vulnerabilities (`exec()` call) and doesn't allow us to use the package on the production environment. Since https://nvd.nist.gov/vuln/detail/CVE-2023-39631 Should be most likely closed soon, this is only vulnerability that would have to be addressed so we can freely use `langchain`. ### Expected behavior `PythonREPL` should only exist in `experimental` version of `langchain`
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/14345/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/14345/timeline
null
null
null
null