mamiksik/annotated-diff-metadata · Datasets at Hugging Face

sha stringlengths 1 40	author stringlengths 1 63 ⌀	committer stringlengths 1 41 ⌀	message stringlengths 1 65.5k ⌀	subject stringlengths 1 5.64k ⌀	subject_length float64 1 5.64k ⌀	is_chore bool 2 classes	is_bot bool 2 classes	subject_word_count float64 1 806 ⌀	verb_object_spacy bool 2 classes	verb_object_stanza bool 2 classes	fits_requirements bool 2 classes	owner stringlengths 2 15	repo stringlengths 2 21	__index_level_0__ int64 0 85.4k
70b98dac9e0b54b498c85d68162b560580654bc9	Katie Gengler	Katie Gengler	Add v4.9.0 to CHANGELOG (cherry picked from commit 4d4200dfe09d79a5b836123916701daddb7f3dd2)	add v4.9.0 to changelog	23	false	false	4	true	true	true	emberjs	ember.js	100
636e36ede0c26c900ad1f3eeb72095af268ec583	Chris Krycho	GitHub	Merge pull request #20280 from emberjs/fix-stable-types-script Don't double-run tsc for generating types	merge pull request from emberjs/fix-stable-types-script	56	true	false	5	true	false	false	emberjs	ember.js	101
6c071ec27f7390c1274542f1b6862887be64452d	Chris Krycho	Chris Krycho	Don't double-run tsc for generating types The package script here was duplicating what the script does.	don't double-run tsc for generating types	41	false	false	6	false	false	false	emberjs	ember.js	102
d212443f9ed06ef534489ff9e1e242eb664aa269	Chris Krycho	GitHub	Merge pull request #20278 from emberjs/fix-typesVersions [BUGFIX] Fix `typesVersions` key for stable types	merge pull request from emberjs/fix-typesversions	50	true	false	5	true	false	false	emberjs	ember.js	103
374db4ed4f65617dc03c149d4186b7b924e5950a	Chris Krycho	Chris Krycho	[BUGFIX] Fix `typesVersions` key for stable types This does not affect existing consumers of the preview types, for whom the existing configuration worked correctly, and we are not actually publishing stable types yet, so this doesn't need to get backported, but it is important that we have it in place as we start publishing stable types.	[bugfix] fix `typesversions` key for stable types	49	false	false	7	false	false	false	emberjs	ember.js	104
ee6729f0344390d1f21feb1a393c142e12eb15c3	Chris Krycho	GitHub	Merge pull request #20277 from nbibler/fix-typo-in-destroyable-docs [DOC] Fix typo in destroyable docs	merge pull request from nbibler/fix-typo-in-destroyable-docs	61	true	false	5	true	false	false	emberjs	ember.js	105
8e147578b4635bad93c1d25048d2d55fd29813b7	dependabot[bot]	GitHub	Bump mocha from 9.2.2 to 10.1.0 Bumps [mocha](https://github.com/mochajs/mocha) from 9.2.2 to 10.1.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v9.2.2...v10.1.0) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	bump mocha from 9.2.2 to 10.1.0	31	true	true	6	true	true	false	emberjs	ember.js	106
3f89e156f612fc0ed79caea9a0b087ac8c0caef3	Chris Krycho	GitHub	Merge pull request #20274 from wagenet/types-tweaks More Type Tweaks	merge pull request from wagenet/types-tweaks	45	true	false	5	true	false	false	emberjs	ember.js	107
38e5499bf9f53fdd247770ff2f5d0e5e107d4b29	Chris Krycho	GitHub	Merge pull request #20275 from emberjs/stable-types-infra [FEATURE] Stable types infra	merge pull request from emberjs/stable-types-infra	51	true	false	5	true	false	false	emberjs	ember.js	108
d425480252cfa903ec4fcd591d8c467d7de47cb6	Nathaniel Bibler	GitHub	[DOC] Fix typo in destroyable docs	[doc] fix typo in destroyable docs	34	false	false	6	false	false	false	emberjs	ember.js	109
26a0923a4fa589c70f5a3ce1069daa803c02a5d3	Chris Krycho	Chris Krycho	Exit with `1` if `types/publish` script fails	exit with `1` if `types/publish` script fails	45	false	false	7	false	false	false	emberjs	ember.js	110
7bef3141fa8ed1c82f213e5d95a661186b9324cd	Chris Krycho	GitHub	Fix typo in internal comments for @ember/object Co-authored-by: Dan Freeman <dfreeman@salsify.com>	fix typo in internal comments for @ember/object	47	false	false	7	true	true	true	emberjs	ember.js	111
f37f561ac5a333d577749cb80c37b17ecdfef5c0	Chris Krycho	Chris Krycho	Fix incomplete sentence in stable types module doc	fix incomplete sentence in stable types module doc	50	false	false	8	true	true	true	emberjs	ember.js	112
af61302dbb55dca2c7b6cd6113eca5ce31f9b5d0	Chris Krycho	GitHub	Merge pull request #20276 from bertdeblock/add-missing-closing-bracket-in-router-service-docs [DOC] Add missing closing bracket in `RouterService` docs	merge pull request from bertdeblock/add-missing-closing-bracket-in-router-service-docs	87	true	false	5	true	false	false	emberjs	ember.js	113
24c0e4a8a30bcc624d4d47272eae1901ad346f90	Chris Krycho	Chris Krycho	Tweak/improve/fix type side-effect package docs	tweak/improve/fix type side-effect package docs	47	false	false	5	false	false	false	emberjs	ember.js	114
f28818fbd134745e7229b0e887e840aeb672097a	Bert De Block	Bert De Block	[DOC] Add missing closing bracket in `RouterService` docs	[doc] add missing closing bracket in `routerservice` docs	57	false	false	8	false	false	false	emberjs	ember.js	115
63e59ca6460e5378736ab3bf36240e5fdb5e4df5	Chris Krycho	Chris Krycho	Update module-level documentation for preview types Align the text with the module docs for the stable types, clarifying the updated current status.	update module-level documentation for preview types	51	false	false	6	false	false	false	emberjs	ember.js	116
752f13318b35613c7c0b617a89999e0ba66c1e41	Chris Krycho	Chris Krycho	Exclude generated stable types from Git	exclude generated stable types from git	39	false	false	6	false	true	false	emberjs	ember.js	117
845b60e84d06ba123064c9b451ee8614060d2c93	Chris Krycho	Chris Krycho	Introduce a script to publish stable types Provide a script which runs the compiler against a new tsconfig for generating types, wraps all the generated modules in `declare module` statements, and then creates an `index.d.ts` which uses side-effect style imports to expose them all, just the same as the preview types but generated from source. Critically, this infrastructure does not expose any stable types in and of itself. Instead, it introduces a list of all the types still in preview mode which acts as a filter, and currently all modules are in that filter. Stabilizing the types for a given module will mean removing modules from that list and removing the corresponding preview types definitions.	introduce a script to publish stable types	42	false	false	7	true	true	true	emberjs	ember.js	118
4e62cd659f296361ad76de47ebc063e938160db0	Chris Krycho	Chris Krycho	Refactor tsconfigs to share compiler options This lets each config specify only how it actually does a build (or not!), while sharing the config explicitly. It also fixes an existing bug in the compilation settings which was not affecting normal TS compilation with `tsc`, but was generating noise in the `broccoli-typescript-compiler` pipeline because the packages happened to be resolved in a different order such that the `loader` "package" definition, and its declaration of the `require` module, was not present in the graph. Set it explicitly in `compilerOptiosn.paths` to fix that.	refactor tsconfigs to share compiler options	44	false	false	6	false	false	false	emberjs	ember.js	119
9c4962bc9d249d0107fb5b7613bddc1d9f6ec5de	Chris Krycho	Chris Krycho	Avoid exposing `OWNER` from `@glimmer/owner` There are pre-existing runtime shenanigans in `@ember/object/internals` to add debug-only errors to the class in dev builds. Those runtime shenanigans produce the need for type-level shenanigans to match: TS gets stuck here because the runtime shenanigans declare `FrameworkObject` with a class expression (rather than the usual class declaration form). That in turn means TS needs to be able to fully name the type produced by the clsas expression, which includes the `OWNER` symbol from `@glimmer/owner`. By explicitly giving the declaration a type when assigning it the class expression, instead of relying on inference, TS no longer needs to name the `OWNER` property key from the super class, eliminating the private name shenanigans. Co-authored-by: Dan Freeman <dfreeman@salsify.com>	avoid exposing `owner` from `@glimmer/owner`	44	false	false	5	false	false	false	emberjs	ember.js	120
74bc861919fd14ef8dccd89c2f098799885b3832	Chris Krycho	GitHub	Merge pull request #20272 from emberjs/rfc-0821-docs [DOC] Add documentation for RFC 0821 items	merge pull request from emberjs/rfc-0821-docs	46	true	false	5	true	true	false	emberjs	ember.js	121
cd0e945ef7b0d790d3bbbb0d4a2e217eb586c59f	Peter Wagenet	Peter Wagenet	Correct test file names	correct test file names	23	false	false	4	false	false	false	emberjs	ember.js	122
fb8fc0222624491abfcc4da6101e6d5ac14f3d0a	Peter Wagenet	Peter Wagenet	Correct some public types	correct some public types	25	false	false	4	true	true	true	emberjs	ember.js	123
d4e7180579ece302217e4223283d2ec1681d3d16	Chris Krycho	GitHub	Merge pull request #20269 from emberjs/dependabot/npm_and_yarn/loader-utils-1.4.2 Bump loader-utils from 1.4.1 to 1.4.2	merge pull request from emberjs/dependabot/npm_and_yarn/loader-utils-1.4.2	75	true	false	5	true	false	false	emberjs	ember.js	124
827a58433f7e94b793e4a01cc288cda6d9ac6676	Chris Krycho	Chris Krycho	[DOC] Add documentation for RFC 0821 items - Introduce or relocate documentation for all the `@ember/owner` types. - Make sure all documented owner and routing types correctly express their type hierarchies in the docs so linking and inheritance flags both work correctly. - Move the documentation for `RouteInfo` and `Transition` to their new modules. Additionally, eliminate the now-empty `lib` module for the `Transition` type since it only existed to provide documentation. - Update coverage expectation to include the new items.	[doc] add documentation for rfc 0821 items	42	false	false	7	false	false	false	emberjs	ember.js	125
737af5c8aad2810d22d4d9ccead36aa4656486d4	Chris Krycho	GitHub	Merge pull request #20271 from emberjs/rfc821-pt3 [FEATURE] Add new `@ember/owner` package (RFC 0821)	merge pull request from emberjs/rfc821-pt3	43	true	false	5	true	false	false	emberjs	ember.js	126
b08757b58c5b3c86ddf2d92dc6436a2f0a440ba3	Chris Krycho	Chris Krycho	Fix explanatory comments in `@ember/-internals/owner`	fix explanatory comments in `@ember/-internals/owner`	53	false	false	5	true	true	false	emberjs	ember.js	127
9763c717853dc7f374a915219c8c4ec2cb295c87	Chris Krycho	Chris Krycho	Disable one more type safety/correctness assertion The private `Router._setOutlets()` method should require that there be an actual `-application-instance:main` available, since otherwise it literally won't work at runtime. However, at least one test runs without it set correctly: Router Service - non application test: RouterService#transitionTo with basic route We should fix that, but separately from this types-focused change, which aims to change only the types and module graph.	disable one more type safety/correctness assertion	50	false	false	6	false	false	false	emberjs	ember.js	128
7785b6f6f413bb619771af496a7cf564a81c12c9	Chris Krycho	Chris Krycho	Disable another type safety/correctness assertion The `generateControllerFactory()` function should require that the class associated with the `FactoryManager` for a given controller name be a `Controller` subclass, but the tests today do not keep this contract. We should fix that, but separately from this types-focused change, which aims to change only the types and module graph.	disable another type safety/correctness assertion	49	false	false	5	false	false	false	emberjs	ember.js	129
9cc6a8d149462c143761a808c4348d994641d4df	Chris Krycho	Chris Krycho	Disable a type safety/correctness assertion In `CoreObject.create()`, we currently have an unsafe cast when constructing an instance with props, because the code assumes one of two things. Either: the `factory` is always set, or it is safe to call `setFactoryFor` with `undefined`. A number of acceptance tests are (incorrectly? Unclear!) relying on the ability to run through this path with `factory` being `undefined`. It's possible that actually means that the type for `setFactoryFor` should allow `undefined`, but we typed it the other way for good reason! Accordingly, this casts `factory`, and the commented-out `assert()` is here in the hope that we can enable it after addressing tests in the future.	disable a type safety/correctness assertion	43	false	false	5	false	false	false	emberjs	ember.js	130
2340d2d99ee7722c38cf888c04b7d3b02e4f3bab	Chris Krycho	Chris Krycho	Fix another linting issue in `@ember/engine` This is a bit annoying: the fixer actually makes the declaration worse by some interpretations. But :shrug:	fix another linting issue in `@ember/engine`	44	false	false	6	true	true	true	emberjs	ember.js	131
b2ce803496e1a0943acda75a927c736cc5b21425	Chris Krycho	Chris Krycho	Fix a type error in CoreObject on TS@next	fix a type error in coreobject on ts@next	41	false	false	8	true	true	true	emberjs	ember.js	132
7e49f29aab064ec5949e4c7afcdb353899a62152	Chris Krycho	Chris Krycho	Fix lint errors in Owner packages	fix lint errors in owner packages	33	false	false	6	true	true	true	emberjs	ember.js	133
c339f5f1704327ea4d169e6e42f86db1a7be6690	Chris Krycho	Chris Krycho	`Factory.create()` cannot be type safe This means our `.create()` type does not check against the types of the target object in any way, unfortunately. However, we actually cannot constrain it further than this without going down a very deep rabbit hole (see the historic types for `.create()` on DefinitelyTyped if you're curious), because we need (for historical reasons) to support classes which implement this contract to be able to provide a narrower interface than "exactly the public fields on the class" while still falling back to the "exactly the public fields on the class" for the general case. Unfortunately, Ember internally relies on the ability for items which implement `Factory` to be able to customize the arguments to the `.create()` call in just that way.	`factory.create()` cannot be type safe	38	false	false	5	false	false	false	emberjs	ember.js	134
3af52bca2baef5e402b2f02785eeb9c0f57408ee	Chris Krycho	Chris Krycho	`EngineInstance` explicitly implements `Owner`	`engineinstance` explicitly implements `owner`	46	false	false	4	false	false	false	emberjs	ember.js	135
63fb7cf65753b9da192d290948a6b16b9125f2bd	Chris Krycho	Chris Krycho	Fix white space in comments in `@ember/controller` Prettier!	fix white space in comments in `@ember/controller`	50	false	false	7	true	true	true	emberjs	ember.js	136
5658b13a400011d1b946b580565d79df91d65424	Chris Krycho	Chris Krycho	Update preview types to match the implementation Updates the preview types to include the `@ember/owner` types introduced in an earlier commit. Besides updating the other existing related exports to match the refactored types from the implementation, the refactoring involved in landing correct types internally result in a couple of key changes: 1. `getOwner()` always returns `Owner \| undefined`. The previous attempt to make it return `Owner` when working with a "known object" of some sort runs into significant issues: - Ember's public API allows the direct construction of many types which are normally managed by the framework. It is legal, if odd and not recommended, to instantiate any given `Factory` with its `.create()` method: import Component from '@glimmer/component'; import Session from '../services' export default class Example extends Component { session = Session.create(); } In this example, the `session` property on `Example` will not have an `Owner`, so it is not safe for `session` itself to rely on that. This is annoying, but type safe, and straightforward to work around. For example, a helper designed to look up services in templates might do something like this: import Helper from '@ember/component/helper'; import { getOwner } from '@ember/owner'; import { assert } from '@ember/debug'; class GetService extends Helper { compute([serviceName]) { let owner = getOwner(this); assert('unexpected missing an owner!', !!owner); return owner.lookup(`service:${name}`); } } Then if someone did `GetService.create()` instead of using a helper in a template or with `invokeHelper()`, they would get a useful error message. - For the same reasons we cannot guarantee that contract from a types perspective, it is actually impossible to implement it in a type safe manner. 2. The service registry now requires that its fields be `Service` subclasses. We added this constraint as part of generalizing the DI registry system to work well with the `Owner` APIs while avoiding introducing any circularity into the module graph. This should also be future-compatible with alternative future designs. This should not be breaking in practice, because items in the service registry were always expected to be service classes. (Note that this cannot be backported to the release because the modules it represents do not exist until this whole PR lands.)	update preview types to match the implementation	48	false	false	7	true	true	true	emberjs	ember.js	137
ecd3db7ea2fb4973913eb8c757c6ae7eea262c22	Chris Krycho	Chris Krycho	Introduce/update type tests for `Owner` internals For the moment, these aim to match the type tests for the public preview types for `@ember/owner` as much as possible, but with special cases covered for the bits which are actually internal. This makes for a stronger guarantee that we will not have a breaking change for end users in the future. However, the tests for `@ember/-internals/owner` over-reproduce those, since they also exist for `@ember/owner` itself. A future commit will therefore remove all of the bits which are not specifically internal for that type test package.	introduce/update type tests for `owner` internals	49	false	false	6	false	false	false	emberjs	ember.js	138
d01a89cec1fe81aeddc9d7dec8a7d2df523235cd	Chris Krycho	Chris Krycho	Update `@ember/application` type tests for new `@ember/owner` types	update `@ember/application` type tests for new `@ember/owner` types	67	false	false	8	false	false	false	emberjs	ember.js	139
94276b5744fba1e9a14acbaccbe8d630532c646e	Chris Krycho	Chris Krycho	Define a coherent `Owner` type hierarchy An earlier commit moved the definitions for the `ContainerProxy` and `RegistryProxy` types to `@ember/-internals/owner`, noting that further refactors were needed. Introduce those further refactors: - Define `ContainerProxy` and `RegistryProxy` as core parts of `Owner`. - Introduce `BasicRegistry` type as the root on which both `Owner` and `RegistryProxy` build, so they can have a shared definition without either (incorrectly!) extending the other. - Define the `ContainerProxyMixin` and `RegistryProxyMixin` types in terms of `ContainerProxy` and `RegistryProxy` respectively. Previously, these were named in terms of mixins, but the interfaces can (and hopefully at some point will) be implemented by non-mixin types (or else removed entirely). - Migrate the documentation from the mixin definitions to the types. Expand on some of the documentation, especially with examples, since there was a great deal missing for making sense of these types and their relationships.	define a coherent `owner` type hierarchy	40	false	false	6	false	false	false	emberjs	ember.js	140
52b7330344263db48e01f841a9e45211a1994702	Chris Krycho	Chris Krycho	Move docs for `getOwner` to `@ember/owner` This is a TSDoc-friendly/future-proofing change: most of the items which `@ember/owner` re-exports from `@ember/-internals/owner` can be documented at the definition site, because they are plain re-exports. `getOwner` is a bit different, because (as discussed in an earlier commit) the public `Owner` type it returns has much less detail than our `InternalOwner` type. We do this via a reassignment of the item, so the docs need to move to that reassignment to be visible for TS consumers and, in the future, for TSDoc extraction of docs. The existing YUIDoc infrastructure will be unaffected by this move.	move docs for `getowner` to `@ember/owner`	42	false	false	6	true	true	true	emberjs	ember.js	141
03bdc4cbdf9d9c7c53850f4a5b2fc14549558991	Chris Krycho	Chris Krycho	Deprecate `getOwner` and `setOwner` from `@ember/application` 1. This does not deprecate the `getOwner` and `setOwner` APIs, only the export from `@ember/application`. 2. This is purely an in-editor signal, not one which will start generating runtime deprecation notices. Per Ember's usual deprecation cycle policy, we will not introduce the runtime deprecation of this API until there has been an LTS release which includes the API which replaces it (in this case, `@ember/owner`). Accordingly, this API will continue to exist throughout Ember v5, since v4.12 is the next LTS release.	deprecate `getowner` and `setowner` from `@ember/application`	61	false	false	6	false	true	false	emberjs	ember.js	142
3a0bf77b7059a8c112d878cd01aaa3891c62da08	Chris Krycho	Chris Krycho	Move `ContainerProxy` and `RegistryProxy` to `@ember/-internals/owner` These two types are fundamental to the full public notion of an "owner" in Ember: an owner in practice is the combination of these two types, as when defining `EngineInstance` by applying the two mixins which they correspond to. Accordingly, the definition of `InternalOwner` must use them... but these internal packages must also use types from the `@ember/-internals/owner` package to define their own contract; and moreover those types are also part of the `Owner` API contract. Accordingly, move the types to be internal to `@ember/-internals/owner` and define the mixins as simply implementing these interfaces. (Note: because these are mixins, the type for "implementing" the interface is defining a new interface which `extends` the interface, as usual with our mixin system.) Here, we define them in terms of extensions of`Owner`, and then define `InternalOwner` in terms of these two APIs. This needs further tweaks, as made clear by the need to use `Pick` in one of the definitions and the fact that both APIs `extends Owner` even though that isn't actually quite right; a future commit will re-align them to the correct API.	move `containerproxy` and `registryproxy` to `@ember/-internals/owner`	70	false	false	6	false	true	false	emberjs	ember.js	143
d68baae140bed2df426e7c75cd7cf170c66fad73	Chris Krycho	Chris Krycho	Move `KnownForTypeResult` to `@ember/owner` This has two nice effects: 1. The `KnownForTypeResult` type (janky though it is) lives where it should per RFC 0821, maintaining `@ember/-internals/owner` as the source of truth and avoiding circularity. 2. The type for `Registry` is just the class itself, with no separate interface, because there is no expectation of a difference between that concrete class type and what it expects of its own `fallback`. This commit also catches a missed import of `FactoryClass`, needed to making the `Registry` type check.	move `knownfortyperesult` to `@ember/owner`	43	false	false	4	false	true	false	emberjs	ember.js	144
95ba2a555971bf63acb0355d85549291fe8c4818	Chris Krycho	Chris Krycho	Unify `Factory` and `DebugFactory` types in container If `DebugFactory` simply extends `Factory` with additional types, all optional, and we explicitly check and set them (as the implementation already does) then we don't need this intersection.	unify `factory` and `debugfactory` types in container	53	false	false	7	false	true	false	emberjs	ember.js	145
f85530327875bcb457752ab30f1c226af4959bf0	Chris Krycho	Chris Krycho	Improve type safety for `.create()` This attempts to make `.create()` type safe by constraining its argument to be `Partial<T>`.	improve type safety for `.create()`	35	false	false	5	true	true	true	emberjs	ember.js	146
18313f9cef2daa0396709fd7afe8900ba3b1f5ce	Chris Krycho	Chris Krycho	Distinguish `FactoryManager` and `InternalFactoryManager` This is the exact same kind of change previously made for `Owner` and `Factory`: providing a richer internal type for `FactoryManager` than is supported in our public API. Here, as with both of those earlier changes, there may be an opportunity to come back and switch back to using `FactoryManager` directly as part of a cleanup pass.	distinguish `factorymanager` and `internalfactorymanager`	57	false	false	4	true	true	false	emberjs	ember.js	147
c29244a828f4aaf3a3dc4090c8325da029f3538a	Chris Krycho	Chris Krycho	@ember/engine/instance: fix a lint, add some comments While working on `Owner` refactors, take the opportunity to clarify the semantics of both types and actual behaviors in the package, and add an explicit return type to a method which was missing it.	fix a lint, add some comments	29	false	false	6	false	true	false	emberjs	ember.js	148
414aa6cc9b22e839d2c6605e420175741901ce04	Chris Krycho	Chris Krycho	Propagate `FullName` type throughout the owner system The use of this type allows us to provide much more type safety for both internal and external callers, by requiring that relevant strings be (dynamically) validated to have the correct shape.	propagate `fullname` type throughout the owner system	53	false	false	7	false	true	false	emberjs	ember.js	149
6ddeeec3d6cc15d28247c9d7da57e4a9c88be74f	Chris Krycho	Chris Krycho	Combine some imports for clarity	combine some imports for clarity	32	false	false	5	true	true	true	emberjs	ember.js	150
18be345ea7cf90f389769f15a0ac4d20ea033aad	Chris Krycho	Chris Krycho	Distinguish `Factory` and `InternalFactory` Like with our distinction between `Owner` and `InternalOwner`, the notion of a `Factory` as we use it internally is somewhat richer than what we provide as a public interface. Thus, add an `InternalFactory` type which extends the public `Factory` interface, and update the internals which previously referred to `Factory` to refer to the new type instead. In a future cleanup pass, we can likely remove many of these uses of `InternalFactory` in favor of using only the public API for `Factory` from instead, and that will help smooth the path to removing many of these unnecessary extra details.	distinguish `factory` and `internalfactory`	43	false	false	4	true	true	true	emberjs	ember.js	151
50e6aac43df62bede934147157803b086d42a5d6	Chris Krycho	Chris Krycho	Debug-fail on type-unsafety with `assert`s In a number of places, fixing up the types caught issues with type safety which came down to optionality/nullability. Since the existing code assumes that is always valid, make that assumption visible to TS in the form of debug assertions.	debug-fail on type-unsafety with `assert`s	42	false	false	5	false	false	false	emberjs	ember.js	152
edc1cf11bc60be4286788f2c8a3ca41dcec3e9b7	Chris Krycho	Chris Krycho	Rename `Owner` to `InternalOwner` in `-internals` As described in an earlier commit, our public type for `Owner`, as specified by RFC 0821, is substantially narrower than the existing type we use as `Owner` internally: our internal notion of `Owner` is the union of `RegistryProxyMixin` and `ContainerProxyMixin`. The new `InternalOwner` type represents that union. (We intend, eventually, to carve away the additional parts of `InternalOwner` until it is just the specified public API for `Owner`, since that is sufficient for everything we actually do now.) In cases where the consumer does not need `InternalOwner`, switch to using this new `Owner` default export. As a knock-on, remove an `any` and actually specify a type which also uses `InternalOwner` internally, which involves an otherwise unrelated update to type imports and declarations.	rename `owner` to `internalowner` in `-internals`	49	false	false	6	false	true	false	emberjs	ember.js	153
3b01283c81892959fb4f31dd05b9ff079a1af8eb	Chris Krycho	Chris Krycho	Fix some incorrect `@module` comments	fix some incorrect `@module` comments	37	false	false	5	true	true	true	emberjs	ember.js	154
337118e9afef9f2bb497cbcaf037daaf455c7aec	Chris Krycho	Chris Krycho	squash w/whatever adds KnownForTypeResult	squash w/whatever adds knownfortyperesult	41	false	false	4	true	false	true	emberjs	ember.js	155
bbacfdbcbda6a38de66fd753ed7acad79e060fce	Chris Krycho	Chris Krycho	Move `TypeOptions` to `@ember/-internals/owner` as `RegisterOptions` As with moving the `Resolver` definition, this aligns us with RFC 0821 and provides an easy way for `@ember/owner` to rexport the definition.	move `typeoptions` to `@ember/-internals/owner` as `registeroptions`	68	false	false	6	false	true	false	emberjs	ember.js	156
cd27b2937803a4ea1073ac7908c910068ae16d6f	Chris Krycho	Chris Krycho	Move `Resolver` to `@ember/-internals/owner` This enables it to be re-exported correctly from `@ember/owner` with reference only to `@ember/-internals/owner`, while still providing it to the other `-internals` packages, which should never depend on the public packages like `@ember/owner`. In support of this (and many other changes), introduce a type helper for `FullName` types.	move `resolver` to `@ember/-internals/owner`	44	false	false	4	true	true	true	emberjs	ember.js	157
a4de4f02cb71a94e68ba895f54776b2349bdc1d4	Chris Krycho	Chris Krycho	Introduce `@ember/owner` package with re-exports Per [RFC 0821][rfc], this new package is the home of the `Owner` type and a number of supporting types, including the `Resolver` definition. Here, introduce the package on disk with a file which simply re-exports the existing definitions from `@ember/-internals/owner`. These definitions are not the final definitions: we also need to refactor the definitions within `@ember/-internals/owner` so that this package can supply only the public API defined in the RFC. [rfc]: https://rfcs.emberjs.com/id/0821-public-types/	introduce `@ember/owner` package with re-exports	48	false	false	5	false	false	false	emberjs	ember.js	158
e920637c7ed727e1fd54337bd033c716ee3a54d4	Chris Krycho	GitHub	Merge pull request #20270 from emberjs/rfc821-routing-impl [FEATURE] Introduce new `@ember/routing` sub-modules	merge pull request from emberjs/rfc821-routing-impl	52	true	false	5	true	false	false	emberjs	ember.js	159
6383470ec689a976330ec8ffc84ca0820e90eeb2	Chris Krycho	Chris Krycho	Introduce new `@ember/routing` sub-modules Add the `@ember/routing/transition` and `@ember/routing/route-info`, per RFC 0821. These match the existing public preview types.	introduce new `@ember/routing` sub-modules	42	false	false	4	false	false	false	emberjs	ember.js	160
8497a5b6268202f4e72c25bc26bdcc164f47f5af	Chris Krycho	GitHub	Merge pull request #20268 from emberjs/type-safe-intern [CLEANUP] Make intern utility type safe	merge pull request from emberjs/type-safe-intern	49	true	false	5	true	false	false	emberjs	ember.js	161
45dff403b03806652242367ab5f8b053cc92803b	dependabot[bot]	GitHub	Bump loader-utils from 1.4.1 to 1.4.2 Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	bump loader-utils from 1.4.1 to 1.4.2	37	true	true	6	true	true	false	emberjs	ember.js	162
3076f8cffcfdb280da483457a5e8a397906af37f	Chris Krycho	Chris Krycho	Make intern utility type safe Experimenting with removing/improving some other types while implementing RFC 0821. revealed that this function needed to preserve its input type when that type was narrower than just `string`, so introduce a type parameter to keep that information around. Then, switch to using `Object.create(null)` so it can be used in the `Record` type safely. Pulling this out into its own commit makes it easier to land, and it also allows us to guarantee that we are making changes only to the types and module layout for the PR implementing RFC 0821.	make intern utility type safe	29	false	false	5	false	true	false	emberjs	ember.js	163
792ca6cc82e28214228a27419d1f9caf370e352b	Katie Gengler	Katie Gengler	Add v4.9.0-beta.4 to CHANGELOG (cherry picked from commit 84e32c9234242ea45203409a1ea50e4e4beccc68)	add v4.9.0-beta.4 to changelog	30	false	false	4	true	true	true	emberjs	ember.js	164
64886c4b7cf17f36b39b437dd853f9beaa83d08e	Chris Krycho	GitHub	Merge pull request #20188 from emberjs/lookup-service Use service registry in owner.lookup	merge pull request from emberjs/lookup-service	47	true	false	5	true	false	false	emberjs	ember.js	165
802028cef2b81f702feaf6e4c2430504ea2d2eeb	Chris Krycho	GitHub	Merge pull request #20260 from azhar-beg/master Refactor overrides.js	merge pull request from azhar-beg/master	41	true	false	5	true	false	false	emberjs	ember.js	166
acb1627a9b1c008f445ead4ee2d3908b4a3420d9	Chris Krycho	GitHub	Merge pull request #20263 from emberjs/dependabot/npm_and_yarn/socket.io-parser-4.0.5 Bump socket.io-parser from 4.0.4 to 4.0.5	merge pull request from emberjs/dependabot/npm_and_yarn/socket.io-parser-4.0.5	79	true	false	5	true	false	false	emberjs	ember.js	167
df8960d95c6ecdacf8ebcc9fd6cd2dd0d6ef404c	Azhar Beg	Azhar Beg	Revert behavioral changes	revert behavioral changes	25	false	false	3	true	true	true	emberjs	ember.js	168
52da642703ad7c1ca728f51251e48ac1209ddb4a	dependabot[bot]	GitHub	Bump socket.io-parser from 4.0.4 to 4.0.5 Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io-parser/compare/4.0.4...4.0.5) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	bump socket.io-parser from 4.0.4 to 4.0.5	41	true	true	6	false	true	false	emberjs	ember.js	169
049d142023577f2d3843722dc1306739574ab418	Chris Krycho	GitHub	Merge pull request #20261 from wagenet/unnecessary-ember-a Remove some unnecessary uses of Ember.A	merge pull request from wagenet/unnecessary-ember-a	52	true	false	5	true	false	false	emberjs	ember.js	170
05fc0bbd4112b1151b768a77c3024dc18d294edc	Peter Wagenet	Peter Wagenet	Remove some unnecessary uses of Ember.A	remove some unnecessary uses of ember.a	39	false	false	6	true	true	true	emberjs	ember.js	171
fae849ce85d01689520ae7fb8d4ef0a392e459c4	Chris Krycho	GitHub	Merge pull request #20256 from wagenet/native-array-fixes [BUGFIX release] Correct types for Ember Arrays	merge pull request from wagenet/native-array-fixes	51	true	false	5	true	false	false	emberjs	ember.js	172
072830abb6a9a683f7a95dc8b6e2535bf39d3686	Chris Krycho	Chris Krycho	Rework `MethodsOf` type utilities for robustness 1. Using the keyof constraint feature introduced in 4.1, avoid ever introducing types with properties whose type is `never` for the non-method fields. 2. Handle recursively applying this constraint to nested methods for the `EmberMethodsOf` type, which has additional complexity to handle Ember's string-based dispatch. Combined with (1), this actually simplifies the types, eliminating one layer of conditional types.	rework `methodsof` type utilities for robustness	48	false	false	6	false	false	false	emberjs	ember.js	173
720c3021213ff8e530c809d37ec3493899448681	Peter Wagenet	Peter Wagenet	Improve types for Ember Arrays	improve types for ember arrays	30	false	false	5	true	true	true	emberjs	ember.js	174
c91a6c66b29d94f63570316a0d873791af6be7d0	Azhar Beg	Azhar Beg	Refactor overrides.js - Replaced `requirementFor` function to arrow function - Replaced `ef-else` blog to `ternary`, static method `for`. - Replaced for loop with array method reduce, `printList`. - Fixed spellings.	refactor overrides.js	21	false	false	2	false	false	false	emberjs	ember.js	175
4339725976299b24c69fb9dfbf13d18bf9917130	Chris Krycho	GitHub	Merge pull request #20258 from emberjs/dependabot/npm_and_yarn/loader-utils-1.4.1 Bump loader-utils from 1.4.0 to 1.4.1	merge pull request from emberjs/dependabot/npm_and_yarn/loader-utils-1.4.1	75	true	false	5	true	false	false	emberjs	ember.js	176
698674b55e9fa7895485d9b3b53072090771ff8b	Chris Krycho	GitHub	Merge pull request #20257 from emberjs/fix-types-FrameworkObject [BUGFIX release] Fix types for `getOwner` and GlimmerComponent	merge pull request from emberjs/fix-types-frameworkobject	58	true	false	5	true	false	false	emberjs	ember.js	177
1467e6c938cb27b7890b892d3a55ab245397e1c6	dependabot[bot]	GitHub	Bump loader-utils from 1.4.0 to 1.4.1 Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](https://github.com/webpack/loader-utils/compare/v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	bump loader-utils from 1.4.0 to 1.4.1	37	true	true	6	true	true	false	emberjs	ember.js	178
dff8831cdbb5583de443a1859e4f09054687119f	Chris Krycho	Chris Krycho	Explain the (un)safety of the type of `getOwner()` The type for `getOwner()` is technically unsafe, but this unsafety is one which end users will rarely hit in practice and, courtesy of Ember's current types, is unavoidable if `getOwner(someService)` is to correctly return `Owner` instead of `Owner \| undefined`. The Typed Ember folks have discussed this point at some length, but I realized on looking at this to make the changes in the preceding two commits that we didn't have it committed to the code base anywhere, so here I am just introducing a long comment explaining it. When we switch from preview to stable types, this comment should come along!	explain the (un)safety of the type of `getowner()`	50	false	false	8	true	false	true	emberjs	ember.js	179
fc09d4944e031ba0c7350b2249539daf365ef1f9	Chris Krycho	Chris Krycho	Fix type definition of `getOwner`, and explain it Use `GlimmerComponent<any>` instead of plain `GlimmerComponent`, since the latter resolves to the default `GlimmerComponent<unknown>`, which ends up being too narrow to resolve correctly with `getOwner` when any actual signature is applied. As a bonus, rename `FrameworkObject` in this context to the somewhat more verbose `KnownFrameworkObject`, which avoids a conflict with the actual `FrameworkObject` type used internally.	fix type definition of `getowner`, and explain it	49	false	false	8	false	true	false	emberjs	ember.js	180
cdd04dab708955e862166ce1a00bb2a74b06f26b	Chris Krycho	Chris Krycho	Add failing type test for `getOwner(Component<S>)` This catches the scenario where we have a component which actually has a signature defined: class Example extends Component<{ Args: { anyWillDo: true } }> { method() { getOwner(this); // should be `Owner`, not `\| undefined` } } Presently, we return `Owner \| undefined` instead.	add failing type test for `getowner(component<s>)`	50	false	false	6	true	true	true	emberjs	ember.js	181
0580eed5c18cdfcd239ccd475e04a1b4c222963c	Chris Krycho	Chris Krycho	Add v4.8.2 to CHANGELOG (cherry picked from commit de4ecf64304e04f1543bc1b59cb71ff448b8543c)	add v4.8.2 to changelog	23	false	false	4	true	true	true	emberjs	ember.js	182
52c13e5a890d6b8c688ac2a99f952ea3bba093ec	Chris Krycho	GitHub	Merge pull request #20253 from emberjs/rfc821-pt2 [FEATURE] Add the `Resolver` type to preview types	merge pull request from emberjs/rfc821-pt2	43	true	false	5	true	false	false	emberjs	ember.js	183
8699faac0f7212197e26ab6fbde80fda00de13b4	Chris Krycho	GitHub	Merge pull request #20248 from emberjs/dependabot/npm_and_yarn/ember-cli-dependency-checker-3.3.1 Bump ember-cli-dependency-checker from 3.2.0 to 3.3.1	merge pull request from emberjs/dependabot/npm_and_yarn/ember-cli-dependency-checker-3.3.1	91	true	false	5	true	false	false	emberjs	ember.js	184
7f98184e705fa2502bc6133afcfd167299a2688e	Chris Krycho	GitHub	Merge pull request #20252 from emberjs/dependabot/npm_and_yarn/aws-sdk-2.1245.0 Bump aws-sdk from 2.1166.0 to 2.1245.0	merge pull request from emberjs/dependabot/npm_and_yarn/aws-sdk-2.1245.0	73	true	false	5	true	false	false	emberjs	ember.js	185
33deaae416dfdd833042ae01c9140e74a2b18c1d	Chris Krycho	GitHub	Merge pull request #20249 from emberjs/dependabot/npm_and_yarn/core-js-3.26.0 Bump core-js from 2.6.5 to 3.26.0	merge pull request from emberjs/dependabot/npm_and_yarn/core-js-3.26.0	71	true	false	5	true	false	false	emberjs	ember.js	186
cca036eb575e10676e089f0d8efa01edd474cdb1	Katie Gengler	Katie Gengler	Add v4.9.0-beta.3 to CHANGELOG (cherry picked from commit 0de013590e92900e5aee664e804ac0fcddf611bd)	add v4.9.0-beta.3 to changelog	30	false	false	4	true	true	true	emberjs	ember.js	187
53ca013f87509315200c5969a8f55417af913786	Katie Gengler	Katie Gengler	Add v4.8.1 to CHANGELOG (cherry picked from commit 9c226d38d41b7845e27bbd34bf463cbcc1a06cec)	add v4.8.1 to changelog	23	false	false	4	true	true	true	emberjs	ember.js	188
6a17b8417e7e00e15b2b6f0441703f3c74f3fd0c	Katie Gengler	Katie Gengler	Add v4.4.4 to CHANGELOG (cherry picked from commit 1dad13a08ae0e1165d83b7d5927e33cd8498c708)	add v4.4.4 to changelog	23	false	false	4	true	true	true	emberjs	ember.js	189
7077f128fdf65149b5aad01d0a2852a3883e2aac	Chris Krycho	Chris Krycho	[FEATURE] Add the `Resolver` type to preview types Per the latest revision to RFC 0821, we need this public type for resolvers to use: Ember defines the contract, others (mostly, but not only, `ember-resolver`) implement the contract.	[feature] add the `resolver` type to preview types	50	false	false	8	false	false	false	emberjs	ember.js	190
701ee45b79b4ee3f860d2c380aa3d87212e3fad5	Katie Gengler	Katie Gengler	Add v3.28.10 to CHANGELOG (cherry picked from commit 198d7e168f3c857be4b7da539dd5b3785b2c1452)	add v3.28.10 to changelog	25	false	false	4	true	true	true	emberjs	ember.js	191
a20bff305ae45840deb07a4a36a09de55073e916	Katie Gengler	Katie Gengler	Add v3.24.7 to CHANGELOG (cherry picked from commit 44e20f73ab7c49003d185bef361353412d7a6518)	add v3.24.7 to changelog	24	false	false	4	true	true	true	emberjs	ember.js	192
3050628e9cfe0b8426deb9928ef718fb3f2dc026	Edward Faulkner	Katie Gengler	Fix prototype pollution bug (cherry picked from commit 0b6196a3e817b5b6793b5d9c1ba37f7d2d13d174)	fix prototype pollution bug	27	false	false	4	false	true	false	emberjs	ember.js	193
11d5973e8623a24e5f4f3b6686fbef970acd771d	dependabot[bot]	GitHub	Bump ember-cli-dependency-checker from 3.2.0 to 3.3.1 Bumps [ember-cli-dependency-checker](https://github.com/quaertym/ember-cli-dependency-checker) from 3.2.0 to 3.3.1. - [Release notes](https://github.com/quaertym/ember-cli-dependency-checker/releases) - [Commits](https://github.com/quaertym/ember-cli-dependency-checker/compare/v3.2.0...v3.3.1) --- updated-dependencies: - dependency-name: ember-cli-dependency-checker dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	bump ember-cli-dependency-checker from 3.2.0 to 3.3.1	53	true	true	6	false	true	false	emberjs	ember.js	194
7353d90cc90076ca499b6b14c0470de9d68518ca	dependabot[bot]	GitHub	Bump aws-sdk from 2.1166.0 to 2.1245.0 Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1166.0 to 2.1245.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1166.0...v2.1245.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	bump aws-sdk from 2.1166.0 to 2.1245.0	38	true	true	6	false	true	false	emberjs	ember.js	195
623b8c104a906f0b14a22512616043277d32a5aa	Chris Krycho	GitHub	Merge pull request #20250 from emberjs/dependabot/npm_and_yarn/eslint-8.26.0 Bump eslint from 8.11.0 to 8.26.0	merge pull request from emberjs/dependabot/npm_and_yarn/eslint-8.26.0	70	true	false	5	true	false	false	emberjs	ember.js	196
78dfbcda331e72dcd9cb8324439f49897a2e7fa7	Chris Krycho	GitHub	Merge pull request #20247 from emberjs/dependabot/npm_and_yarn/testem-3.9.0 Bump testem from 3.8.0 to 3.9.0	merge pull request from emberjs/dependabot/npm_and_yarn/testem-3.9.0	69	true	false	5	true	false	false	emberjs	ember.js	197
e784f69fd4cd2a845111d228921c665cd5a10732	dependabot[bot]	GitHub	Bump eslint from 8.11.0 to 8.26.0 Bumps [eslint](https://github.com/eslint/eslint) from 8.11.0 to 8.26.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.11.0...v8.26.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	bump eslint from 8.11.0 to 8.26.0	33	true	true	6	true	true	false	emberjs	ember.js	198
26c8e9be083b3769727f96e907ee80c37ab73c27	dependabot[bot]	GitHub	Bump core-js from 2.6.5 to 3.26.0 Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 2.6.5 to 3.26.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.26.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	bump core-js from 2.6.5 to 3.26.0	33	true	true	6	true	true	false	emberjs	ember.js	199

70b98dac9e0b54b498c85d68162b560580654bc9

Katie Gengler

Add v4.9.0 to CHANGELOG (cherry picked from commit 4d4200dfe09d79a5b836123916701daddb7f3dd2)

add v4.9.0 to changelog

23

false

4

true

emberjs

ember.js

100

636e36ede0c26c900ad1f3eeb72095af268ec583

Chris Krycho

GitHub

Merge pull request #20280 from emberjs/fix-stable-types-script Don't double-run tsc for generating types

merge pull request from emberjs/fix-stable-types-script

56

true

false

5

true

false

emberjs

ember.js

101

6c071ec27f7390c1274542f1b6862887be64452d

Chris Krycho

Don't double-run tsc for generating types The package script here was duplicating what the script does.

don't double-run tsc for generating types

41

false

6

false

emberjs

ember.js

102

d212443f9ed06ef534489ff9e1e242eb664aa269

Chris Krycho

GitHub

Merge pull request #20278 from emberjs/fix-typesVersions [BUGFIX] Fix `typesVersions` key for stable types

merge pull request from emberjs/fix-typesversions

50

true

false

5

true

false

emberjs

ember.js

103

374db4ed4f65617dc03c149d4186b7b924e5950a

Chris Krycho

[BUGFIX] Fix `typesVersions` key for stable types This does not affect existing consumers of the preview types, for whom the existing configuration worked correctly, and we are not actually *publishing* stable types yet, so this doesn't need to get backported, but it *is* important that we have it in place as we start publishing stable types.

[bugfix] fix `typesversions` key for stable types

49

false

7

false

emberjs

ember.js

104

ee6729f0344390d1f21feb1a393c142e12eb15c3

Chris Krycho

GitHub

Merge pull request #20277 from nbibler/fix-typo-in-destroyable-docs [DOC] Fix typo in destroyable docs

merge pull request from nbibler/fix-typo-in-destroyable-docs

61

true

false

5

true

false

emberjs

ember.js

105

8e147578b4635bad93c1d25048d2d55fd29813b7

dependabot[bot]

GitHub

Bump mocha from 9.2.2 to 10.1.0 Bumps [mocha](https://github.com/mochajs/mocha) from 9.2.2 to 10.1.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v9.2.2...v10.1.0) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

bump mocha from 9.2.2 to 10.1.0

31

true

6

true

false

emberjs

ember.js

106

3f89e156f612fc0ed79caea9a0b087ac8c0caef3

Chris Krycho

GitHub

Merge pull request #20274 from wagenet/types-tweaks More Type Tweaks

merge pull request from wagenet/types-tweaks

45

true

false

5

true

false

emberjs

ember.js

107

38e5499bf9f53fdd247770ff2f5d0e5e107d4b29

Chris Krycho

GitHub

Merge pull request #20275 from emberjs/stable-types-infra [FEATURE] Stable types infra

merge pull request from emberjs/stable-types-infra

51

true

false

5

true

false

emberjs

ember.js

108

d425480252cfa903ec4fcd591d8c467d7de47cb6

Nathaniel Bibler

GitHub

[DOC] Fix typo in destroyable docs

[doc] fix typo in destroyable docs

34

false

6

false

emberjs

ember.js

109

26a0923a4fa589c70f5a3ce1069daa803c02a5d3

Chris Krycho

Exit with `1` if `types/publish` script fails

exit with `1` if `types/publish` script fails

45

false

7

false

emberjs

ember.js

110

7bef3141fa8ed1c82f213e5d95a661186b9324cd

Chris Krycho

GitHub

Fix typo in internal comments for @ember/object Co-authored-by: Dan Freeman <dfreeman@salsify.com>

fix typo in internal comments for @ember/object

47

false

7

true

emberjs

ember.js

111

f37f561ac5a333d577749cb80c37b17ecdfef5c0

Chris Krycho

Fix incomplete sentence in stable types module doc

fix incomplete sentence in stable types module doc

50

false

8

true

emberjs

ember.js

112

af61302dbb55dca2c7b6cd6113eca5ce31f9b5d0

Chris Krycho

GitHub

Merge pull request #20276 from bertdeblock/add-missing-closing-bracket-in-router-service-docs [DOC] Add missing closing bracket in `RouterService` docs

merge pull request from bertdeblock/add-missing-closing-bracket-in-router-service-docs

87

true

false

5

true

false

emberjs

ember.js

113

24c0e4a8a30bcc624d4d47272eae1901ad346f90

Chris Krycho

Tweak/improve/fix type side-effect package docs

tweak/improve/fix type side-effect package docs

47

false

5

false

emberjs

ember.js

114

f28818fbd134745e7229b0e887e840aeb672097a

Bert De Block

[DOC] Add missing closing bracket in `RouterService` docs

[doc] add missing closing bracket in `routerservice` docs

57

false

8

false

emberjs

ember.js

115

63e59ca6460e5378736ab3bf36240e5fdb5e4df5

Chris Krycho

Update module-level documentation for preview types Align the text with the module docs for the stable types, clarifying the updated current status.

update module-level documentation for preview types

51

false

6

false

emberjs

ember.js

116

752f13318b35613c7c0b617a89999e0ba66c1e41

Chris Krycho

Exclude generated stable types from Git

exclude generated stable types from git

39

false

6

false

true

false

emberjs

ember.js

117

845b60e84d06ba123064c9b451ee8614060d2c93

Chris Krycho

Introduce a script to publish stable types Provide a script which runs the compiler against a new tsconfig for generating types, wraps all the generated modules in `declare module` statements, and then creates an `index.d.ts` which uses side-effect style imports to expose them all, just the same as the preview types but generated from source. Critically, this infrastructure does not expose *any* stable types in and of itself. Instead, it introduces a list of all the types still in preview mode which acts as a filter, and currently *all* modules are in that filter. Stabilizing the types for a given module will mean removing modules from that list and removing the corresponding preview types definitions.

introduce a script to publish stable types

42

false

7

true

emberjs

ember.js

118

4e62cd659f296361ad76de47ebc063e938160db0

Chris Krycho

Refactor tsconfigs to share compiler options This lets each config specify *only* how it actually does a build (or not!), while sharing the config explicitly. It also fixes an existing bug in the compilation settings which was not affecting *normal* TS compilation with `tsc`, but was generating noise in the `broccoli-typescript-compiler` pipeline because the packages happened to be resolved in a different order such that the `loader` "package" definition, and its declaration of the `require` module, was not present in the graph. Set it explicitly in `compilerOptiosn.paths` to fix that.

refactor tsconfigs to share compiler options

44

false

6

false

emberjs

ember.js

119

9c4962bc9d249d0107fb5b7613bddc1d9f6ec5de

Chris Krycho

Avoid exposing `OWNER` from `@glimmer/owner` There are pre-existing runtime shenanigans in `@ember/object/internals` to add debug-only errors to the class in dev builds. Those runtime shenanigans produce the need for type-level shenanigans to match: TS gets stuck here because the runtime shenanigans declare `FrameworkObject` with a class expression (rather than the usual class declaration form). That in turn means TS needs to be able to fully name the type produced by the clsas expression, which includes the `OWNER` symbol from `@glimmer/owner`. By explicitly giving the declaration a type when assigning it the class expression, instead of relying on inference, TS no longer needs to name the `OWNER` property key from the super class, eliminating the private name shenanigans. Co-authored-by: Dan Freeman <dfreeman@salsify.com>

avoid exposing `owner` from `@glimmer/owner`

44

false

5

false

emberjs

ember.js

120

74bc861919fd14ef8dccd89c2f098799885b3832

Chris Krycho

GitHub

Merge pull request #20272 from emberjs/rfc-0821-docs [DOC] Add documentation for RFC 0821 items

merge pull request from emberjs/rfc-0821-docs

46

true

false

5

true

false

emberjs

ember.js

121

cd0e945ef7b0d790d3bbbb0d4a2e217eb586c59f

Peter Wagenet

Correct test file names

correct test file names

23

false

4

false

emberjs

ember.js

122

fb8fc0222624491abfcc4da6101e6d5ac14f3d0a

Peter Wagenet

Correct some public types

correct some public types

25

false

4

true

emberjs

ember.js

123

d4e7180579ece302217e4223283d2ec1681d3d16

Chris Krycho

GitHub

Merge pull request #20269 from emberjs/dependabot/npm_and_yarn/loader-utils-1.4.2 Bump loader-utils from 1.4.1 to 1.4.2

merge pull request from emberjs/dependabot/npm_and_yarn/loader-utils-1.4.2

75

true

false

5

true

false

emberjs

ember.js

124

827a58433f7e94b793e4a01cc288cda6d9ac6676

Chris Krycho

[DOC] Add documentation for RFC 0821 items - Introduce or relocate documentation for all the `@ember/owner` types. - Make sure all documented owner and routing types correctly express their type hierarchies in the docs so linking and inheritance flags both work correctly. - Move the documentation for `RouteInfo` and `Transition` to their new modules. Additionally, eliminate the now-empty `lib` module for the `Transition` type since it *only* existed to provide documentation. - Update coverage expectation to include the new items.

[doc] add documentation for rfc 0821 items

42

false

7

false

emberjs

ember.js

125

737af5c8aad2810d22d4d9ccead36aa4656486d4

Chris Krycho

GitHub

Merge pull request #20271 from emberjs/rfc821-pt3 [FEATURE] Add new `@ember/owner` package (RFC 0821)

merge pull request from emberjs/rfc821-pt3

43

true

false

5

true

false

emberjs

ember.js

126

b08757b58c5b3c86ddf2d92dc6436a2f0a440ba3

Chris Krycho

Fix explanatory comments in `@ember/-internals/owner`

fix explanatory comments in `@ember/-internals/owner`

53

false

5

true

false

emberjs

ember.js

127

9763c717853dc7f374a915219c8c4ec2cb295c87

Chris Krycho

Disable one more type safety/correctness assertion The private `Router._setOutlets()` method *should* require that there be an actual `-application-instance:main` available, since otherwise it literally won't work at runtime. However, at least one test runs without it set correctly: Router Service - non application test: RouterService#transitionTo with basic route We should fix that, but *separately* from this types-focused change, which aims to change *only* the types and module graph.

disable one more type safety/correctness assertion

50

false

6

false

emberjs

ember.js

128

7785b6f6f413bb619771af496a7cf564a81c12c9

Chris Krycho

Disable another type safety/correctness assertion The `generateControllerFactory()` function *should* require that the class associated with the `FactoryManager` for a given controller name be a `Controller` subclass, but the tests today do *not* keep this contract. We should fix that, but *separately* from this types-focused change, which aims to change *only* the types and module graph.

disable another type safety/correctness assertion

49

false

5

false

emberjs

ember.js

129

9cc6a8d149462c143761a808c4348d994641d4df

Chris Krycho

Disable a type safety/correctness assertion In `CoreObject.create()`, we currently have an unsafe cast when constructing an instance with props, because the code assumes one of two things. Either: the `factory` is always set, *or* it is safe to call `setFactoryFor` with `undefined`. A number of acceptance tests are (incorrectly? Unclear!) relying on the ability to run through this path with `factory` being `undefined`. It's *possible* that actually means that the type for `setFactoryFor` should allow `undefined`, but we typed it the other way for good reason! Accordingly, this *casts* `factory`, and the commented-out `assert()` is here in the hope that we can enable it after addressing tests in the future.

disable a type safety/correctness assertion

43

false

5

false

emberjs

ember.js

130

2340d2d99ee7722c38cf888c04b7d3b02e4f3bab

Chris Krycho

Fix another linting issue in `@ember/engine` This is a bit annoying: the fixer actually makes the declaration *worse* by some interpretations. But :shrug:

fix another linting issue in `@ember/engine`

44

false

6

true

emberjs

ember.js

131

b2ce803496e1a0943acda75a927c736cc5b21425

Chris Krycho

Fix a type error in CoreObject on TS@next

fix a type error in coreobject on ts@next

41

false

8

true

emberjs

ember.js

132

7e49f29aab064ec5949e4c7afcdb353899a62152

Chris Krycho

Fix lint errors in Owner packages

fix lint errors in owner packages

33

false

6

true

emberjs

ember.js

133

c339f5f1704327ea4d169e6e42f86db1a7be6690

Chris Krycho

`Factory.create()` cannot be type safe This means our `.create()` type does not check against the types of the target object in any way, unfortunately. However, we actually *cannot* constrain it further than this without going down a *very* deep rabbit hole (see the historic types for `.create()` on DefinitelyTyped if you're curious), because we need (for historical reasons) to support classes which implement this contract to be able to provide a *narrower* interface than "exactly the public fields on the class" while still falling back to the "exactly the public fields on the class" for the general case. Unfortunately, Ember internally relies on the ability for items which implement `Factory` to be able to customize the arguments to the `.create()` call in just that way.

`factory.create()` cannot be type safe

38

false

5

false

emberjs

ember.js

134

3af52bca2baef5e402b2f02785eeb9c0f57408ee

Chris Krycho

`EngineInstance` explicitly implements `Owner`

`engineinstance` explicitly implements `owner`

46

false

4

false

emberjs

ember.js

135

63fb7cf65753b9da192d290948a6b16b9125f2bd

Chris Krycho

Fix white space in comments in `@ember/controller` Prettier!

fix white space in comments in `@ember/controller`

50

false

7

true

emberjs

ember.js

136

5658b13a400011d1b946b580565d79df91d65424

Chris Krycho

Update preview types to match the implementation Updates the preview types to include the `@ember/owner` types introduced in an earlier commit. Besides updating the other existing related exports to match the refactored types from the implementation, the refactoring involved in landing correct types internally result in a couple of key changes: 1. `getOwner()` always returns `Owner | undefined`. The previous attempt to make it return `Owner` when working with a "known object" of some sort runs into significant issues: - Ember's public API allows the direct construction of many types which are *normally* managed by the framework. It is legal, if odd and *not recommended*, to instantiate any given `Factory` with its `.create()` method: import Component from '@glimmer/component'; import Session from '../services' export default class Example extends Component { session = Session.create(); } In this example, the `session` property on `Example` will *not* have an `Owner`, so it is not safe for `session` itself to rely on that. This is annoying, but type safe, and straightforward to work around. For example, a helper designed to look up services in templates might do something like this: import Helper from '@ember/component/helper'; import { getOwner } from '@ember/owner'; import { assert } from '@ember/debug'; class GetService extends Helper { compute([serviceName]) { let owner = getOwner(this); assert('unexpected missing an owner!', !!owner); return owner.lookup(`service:${name}`); } } Then if someone did `GetService.create()` instead of using a helper in a template *or* with `invokeHelper()`, they would get a useful error message. - For the same reasons we cannot guarantee that contract from a types perspective, it is actually impossible to *implement* it in a type safe manner. 2. The service registry now *requires* that its fields be `Service` subclasses. We added this constraint as part of generalizing the DI registry system to work well with the `Owner` APIs while avoiding introducing any circularity into the module graph. This should also be future-compatible with alternative future designs. This should not be breaking in practice, because items in the service registry were always expected to be service classes. (Note that this cannot be backported to the release because the modules it represents do not exist until this whole PR lands.)

update preview types to match the implementation

48

false

7

true

emberjs

ember.js

137

ecd3db7ea2fb4973913eb8c757c6ae7eea262c22

Chris Krycho

Introduce/update type tests for `Owner` internals For the moment, these aim to match the type tests for the public preview types for `@ember/owner` as much as possible, but with special cases covered for the bits which are actually internal. This makes for a stronger guarantee that we will not have a breaking change for end users in the future. However, the tests for `@ember/-internals/owner` *over*-reproduce those, since they also exist for `@ember/owner` itself. A future commit will therefore remove all of the bits which are *not* specifically internal for that type test package.

introduce/update type tests for `owner` internals

49

false

6

false

emberjs

ember.js

138

d01a89cec1fe81aeddc9d7dec8a7d2df523235cd

Chris Krycho

Update `@ember/application` type tests for new `@ember/owner` types

update `@ember/application` type tests for new `@ember/owner` types

67

false

8

false

emberjs

ember.js

139

94276b5744fba1e9a14acbaccbe8d630532c646e

Chris Krycho

Define a coherent `Owner` type hierarchy An earlier commit moved the definitions for the `ContainerProxy` and `RegistryProxy` types to `@ember/-internals/owner`, noting that further refactors were needed. Introduce those further refactors: - Define `ContainerProxy` and `RegistryProxy` as core parts of `Owner`. - Introduce `BasicRegistry` type as the root on which both `Owner` and `RegistryProxy` build, so they can have a shared definition without either (incorrectly!) extending the other. - Define the `ContainerProxyMixin` and `RegistryProxyMixin` types in terms of `ContainerProxy` and `RegistryProxy` respectively. Previously, these were named in terms of mixins, but the interfaces can (and hopefully at some point *will*) be implemented by non-mixin types (or else removed entirely). - Migrate the documentation from the mixin definitions to the types. Expand on some of the documentation, especially with examples, since there was a great deal missing for making sense of these types and their relationships.

define a coherent `owner` type hierarchy

40

false

6

false

emberjs

ember.js

140

52b7330344263db48e01f841a9e45211a1994702

Chris Krycho

Move docs for `getOwner` to `@ember/owner` This is a TSDoc-friendly/future-proofing change: most of the items which `@ember/owner` re-exports from `@ember/-internals/owner` can be documented at the definition site, because they are plain re-exports. `getOwner` is a bit different, because (as discussed in an earlier commit) the public `Owner` type it returns has much less detail than our `InternalOwner` type. We do this via a reassignment of the item, so the docs need to move to that reassignment to be visible for TS consumers and, in the future, for TSDoc extraction of docs. The existing YUIDoc infrastructure will be unaffected by this move.

move docs for `getowner` to `@ember/owner`

42

false

6

true

emberjs

ember.js

141

03bdc4cbdf9d9c7c53850f4a5b2fc14549558991

Chris Krycho

Deprecate `getOwner` and `setOwner` from `@ember/application` 1. This does *not* deprecate the `getOwner` and `setOwner` APIs, *only* the export from `@ember/application`. 2. This is purely an in-editor signal, *not* one which will start generating runtime deprecation notices. Per Ember's usual deprecation cycle policy, we will not introduce the runtime deprecation of this API until there has been an LTS release which includes the API which replaces it (in this case, `@ember/owner`). Accordingly, this API will continue to exist throughout Ember v5, since v4.12 is the next LTS release.

deprecate `getowner` and `setowner` from `@ember/application`

61

false

6

false

true

false

emberjs

ember.js

142

3a0bf77b7059a8c112d878cd01aaa3891c62da08

Chris Krycho

Move `ContainerProxy` and `RegistryProxy` to `@ember/-internals/owner` These two types are fundamental to the full public notion of an "owner" in Ember: an owner *in practice* is the combination of these two types, as when defining `EngineInstance` by applying the two mixins which they correspond to. Accordingly, the definition of `InternalOwner` *must* use them... but these internal packages must also use types from the `@ember/-internals/owner` package to define their own contract; and moreover those types are *also* part of the `Owner` API contract. Accordingly, move the types to be internal to `@ember/-internals/owner` and define the mixins as simply *implementing* these interfaces. (Note: because these are mixins, the type for "implementing" the interface is defining a new interface which `extends` the interface, as usual with our mixin system.) Here, we define them in terms of extensions of`Owner`, and then define `InternalOwner` in terms of these two APIs. This needs further tweaks, as made clear by the need to use `Pick` in one of the definitions and the fact that both APIs `extends Owner` even though that isn't actually quite right; a future commit will re-align them to the correct API.

move `containerproxy` and `registryproxy` to `@ember/-internals/owner`

70

false

6

false

true

false

emberjs

ember.js

143

d68baae140bed2df426e7c75cd7cf170c66fad73

Chris Krycho

Move `KnownForTypeResult` to `@ember/owner` This has two nice effects: 1. The `KnownForTypeResult` type (janky though it is) lives where it should per RFC 0821, maintaining `@ember/-internals/owner` as the source of truth and avoiding circularity. 2. The type for `Registry` is just the class itself, with no separate interface, because there is no expectation of a difference between that concrete class type and what it expects of its own `fallback`. This commit also catches a missed import of `FactoryClass`, needed to making the `Registry` type check.

move `knownfortyperesult` to `@ember/owner`

43

false

4

false

true

false

emberjs

ember.js

144

95ba2a555971bf63acb0355d85549291fe8c4818

Chris Krycho

Unify `Factory` and `DebugFactory` types in container If `DebugFactory` simply extends `Factory` with additional types, all optional, and we explicitly check and set them (as the implementation already does) then we don't need this intersection.

unify `factory` and `debugfactory` types in container

53

false

7

false

true

false

emberjs

ember.js

145

f85530327875bcb457752ab30f1c226af4959bf0

Chris Krycho

Improve type safety for `.create()` This attempts to make `.create()` type safe by constraining its argument to be `Partial<T>`.

improve type safety for `.create()`

35

false

5

true

emberjs

ember.js

146

18313f9cef2daa0396709fd7afe8900ba3b1f5ce

Chris Krycho

Distinguish `FactoryManager` and `InternalFactoryManager` This is the exact same kind of change previously made for `Owner` and `Factory`: providing a richer internal type for `FactoryManager` than is supported in our public API. Here, as with both of those earlier changes, there may be an opportunity to come back and switch *back* to using `FactoryManager` directly as part of a cleanup pass.

distinguish `factorymanager` and `internalfactorymanager`

57

false

4

true

false

emberjs

ember.js

147

c29244a828f4aaf3a3dc4090c8325da029f3538a

Chris Krycho

@ember/engine/instance: fix a lint, add some comments While working on `Owner` refactors, take the opportunity to clarify the semantics of both types and actual behaviors in the package, and add an explicit return type to a method which was missing it.

fix a lint, add some comments

29

false

6

false

true

false

emberjs

ember.js

148

414aa6cc9b22e839d2c6605e420175741901ce04

Chris Krycho

Propagate `FullName` type throughout the owner system The use of this type allows us to provide much more type safety for both internal and external callers, by requiring that relevant strings be (dynamically) validated to have the correct shape.

propagate `fullname` type throughout the owner system

53

false

7

false

true

false

emberjs

ember.js

149

6ddeeec3d6cc15d28247c9d7da57e4a9c88be74f

Chris Krycho

Combine some imports for clarity

combine some imports for clarity

32

false

5

true

emberjs

ember.js

150

18be345ea7cf90f389769f15a0ac4d20ea033aad

Chris Krycho

Distinguish `Factory` and `InternalFactory` Like with our distinction between `Owner` and `InternalOwner`, the notion of a `Factory` as we use it internally is somewhat richer than what we provide as a public interface. Thus, add an `InternalFactory` type which extends the public `Factory` interface, and update the internals which previously referred to `Factory` to refer to the new type instead. In a future cleanup pass, we can likely remove many of these uses of `InternalFactory` in favor of using *only* the public API for `Factory` from instead, and that will help smooth the path to removing many of these unnecessary extra details.

distinguish `factory` and `internalfactory`

43

false

4

true

emberjs

ember.js

151

50e6aac43df62bede934147157803b086d42a5d6

Chris Krycho

Debug-fail on type-unsafety with `assert`s In a number of places, fixing up the types caught issues with type safety which came down to optionality/nullability. Since the existing code *assumes* that is always valid, make that assumption visible to TS in the form of debug assertions.

debug-fail on type-unsafety with `assert`s

42

false

5

false

emberjs

ember.js

152

edc1cf11bc60be4286788f2c8a3ca41dcec3e9b7

Chris Krycho

Rename `Owner` to `InternalOwner` in `-internals` As described in an earlier commit, our public type for `Owner`, as specified by RFC 0821, is substantially narrower than the existing type we use as `Owner` internally: our *internal* notion of `Owner` is the union of `RegistryProxyMixin` and `ContainerProxyMixin`. The new `InternalOwner` type represents that union. (We intend, eventually, to carve away the additional parts of `InternalOwner` until it *is* just the specified public API for `Owner`, since that is sufficient for everything we actually do now.) In cases where the consumer does not need `InternalOwner`, switch to using this new `Owner` default export. As a knock-on, remove an `any` and actually specify a type which *also* uses `InternalOwner` internally, which involves an otherwise unrelated update to type imports and declarations.

rename `owner` to `internalowner` in `-internals`

49

false

6

false

true

false

emberjs

ember.js

153

3b01283c81892959fb4f31dd05b9ff079a1af8eb

Chris Krycho

Fix some incorrect `@module` comments

fix some incorrect `@module` comments

37

false

5

true

emberjs

ember.js

154

337118e9afef9f2bb497cbcaf037daaf455c7aec

Chris Krycho

squash w/whatever adds KnownForTypeResult

squash w/whatever adds knownfortyperesult

41

false

4

true

false

true

emberjs

ember.js

155

bbacfdbcbda6a38de66fd753ed7acad79e060fce

Chris Krycho

Move `TypeOptions` to `@ember/-internals/owner` as `RegisterOptions` As with moving the `Resolver` definition, this aligns us with RFC 0821 and provides an easy way for `@ember/owner` to rexport the definition.

move `typeoptions` to `@ember/-internals/owner` as `registeroptions`

68

false

6

false

true

false

emberjs

ember.js

156

cd27b2937803a4ea1073ac7908c910068ae16d6f

Chris Krycho

Move `Resolver` to `@ember/-internals/owner` This enables it to be re-exported correctly from `@ember/owner` with reference *only* to `@ember/-internals/owner`, while still providing it to the other `-internals` packages, which should never depend on the public packages like `@ember/owner`. In support of this (and many other changes), introduce a type helper for `FullName` types.

move `resolver` to `@ember/-internals/owner`

44

false

4

true

emberjs

ember.js

157

a4de4f02cb71a94e68ba895f54776b2349bdc1d4

Chris Krycho

Introduce `@ember/owner` package with re-exports Per [RFC 0821][rfc], this new package is the home of the `Owner` type and a number of supporting types, including the `Resolver` definition. Here, introduce the package on disk with a file which simply re-exports the existing definitions from `@ember/-internals/owner`. These definitions are *not* the final definitions: we also need to refactor the definitions within `@ember/-internals/owner` so that this package can supply *only* the public API defined in the RFC. [rfc]: https://rfcs.emberjs.com/id/0821-public-types/

introduce `@ember/owner` package with re-exports

48

false

5

false

emberjs

ember.js

158

e920637c7ed727e1fd54337bd033c716ee3a54d4

Chris Krycho

GitHub

Merge pull request #20270 from emberjs/rfc821-routing-impl [FEATURE] Introduce new `@ember/routing` sub-modules

merge pull request from emberjs/rfc821-routing-impl

52

true

false

5

true

false

emberjs

ember.js

159

6383470ec689a976330ec8ffc84ca0820e90eeb2

Chris Krycho

Introduce new `@ember/routing` sub-modules Add the `@ember/routing/transition` and `@ember/routing/route-info`, per RFC 0821. These match the existing public preview types.

introduce new `@ember/routing` sub-modules

42

false

4

false

emberjs

ember.js

160

8497a5b6268202f4e72c25bc26bdcc164f47f5af

Chris Krycho

GitHub

Merge pull request #20268 from emberjs/type-safe-intern [CLEANUP] Make intern utility type safe

merge pull request from emberjs/type-safe-intern

49

true

false

5

true

false

emberjs

ember.js

161

45dff403b03806652242367ab5f8b053cc92803b

dependabot[bot]

GitHub

Bump loader-utils from 1.4.1 to 1.4.2 Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

bump loader-utils from 1.4.1 to 1.4.2

37

true

6

true

false

emberjs

ember.js

162

3076f8cffcfdb280da483457a5e8a397906af37f

Chris Krycho

Make intern utility type safe Experimenting with removing/improving some *other* types while implementing RFC 0821. revealed that this function needed to preserve its input type when that type was narrower than just `string`, so introduce a type parameter to keep that information around. Then, switch to using `Object.create(null)` so it can be used in the `Record` type safely. Pulling this out into its own commit makes it easier to land, and it also allows us to guarantee that we are making changes *only* to the types and module layout for the PR implementing RFC 0821.

make intern utility type safe

29

false

5

false

true

false

emberjs

ember.js

163

792ca6cc82e28214228a27419d1f9caf370e352b

Katie Gengler

Add v4.9.0-beta.4 to CHANGELOG (cherry picked from commit 84e32c9234242ea45203409a1ea50e4e4beccc68)

add v4.9.0-beta.4 to changelog

30

false

4

true

emberjs

ember.js

164

64886c4b7cf17f36b39b437dd853f9beaa83d08e

Chris Krycho

GitHub

Merge pull request #20188 from emberjs/lookup-service Use service registry in owner.lookup

merge pull request from emberjs/lookup-service

47

true

false

5

true

false

emberjs

ember.js

165

802028cef2b81f702feaf6e4c2430504ea2d2eeb

Chris Krycho

GitHub

Merge pull request #20260 from azhar-beg/master Refactor overrides.js

merge pull request from azhar-beg/master

41

true

false

5

true

false

emberjs

ember.js

166

acb1627a9b1c008f445ead4ee2d3908b4a3420d9

Chris Krycho

GitHub

Merge pull request #20263 from emberjs/dependabot/npm_and_yarn/socket.io-parser-4.0.5 Bump socket.io-parser from 4.0.4 to 4.0.5

merge pull request from emberjs/dependabot/npm_and_yarn/socket.io-parser-4.0.5

79

true

false

5

true

false

emberjs

ember.js

167

df8960d95c6ecdacf8ebcc9fd6cd2dd0d6ef404c

Azhar Beg

Revert behavioral changes

revert behavioral changes

25

false

3

true

emberjs

ember.js

168

52da642703ad7c1ca728f51251e48ac1209ddb4a

dependabot[bot]

GitHub

Bump socket.io-parser from 4.0.4 to 4.0.5 Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io-parser/compare/4.0.4...4.0.5) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

bump socket.io-parser from 4.0.4 to 4.0.5

41

true

6

false

true

false

emberjs

ember.js

169

049d142023577f2d3843722dc1306739574ab418

Chris Krycho

GitHub

Merge pull request #20261 from wagenet/unnecessary-ember-a Remove some unnecessary uses of Ember.A

merge pull request from wagenet/unnecessary-ember-a

52

true

false

5

true

false

emberjs

ember.js

170

05fc0bbd4112b1151b768a77c3024dc18d294edc

Peter Wagenet

Remove some unnecessary uses of Ember.A

remove some unnecessary uses of ember.a

39

false

6

true

emberjs

ember.js

171

fae849ce85d01689520ae7fb8d4ef0a392e459c4

Chris Krycho

GitHub

Merge pull request #20256 from wagenet/native-array-fixes [BUGFIX release] Correct types for Ember Arrays

merge pull request from wagenet/native-array-fixes

51

true

false

5

true

false

emberjs

ember.js

172

072830abb6a9a683f7a95dc8b6e2535bf39d3686

Chris Krycho

Rework `MethodsOf` type utilities for robustness 1. Using the keyof constraint feature introduced in 4.1, avoid ever introducing types with properties whose type is `never` for the non-method fields. 2. Handle recursively applying this constraint to nested methods for the `EmberMethodsOf` type, which has additional complexity to handle Ember's string-based dispatch. Combined with (1), this actually *simplifies* the types, eliminating one layer of conditional types.

rework `methodsof` type utilities for robustness

48

false

6

false

emberjs

ember.js

173

720c3021213ff8e530c809d37ec3493899448681

Peter Wagenet

Improve types for Ember Arrays

improve types for ember arrays

30

false

5

true

emberjs

ember.js

174

c91a6c66b29d94f63570316a0d873791af6be7d0

Azhar Beg

Refactor overrides.js - Replaced `requirementFor` function to arrow function - Replaced `ef-else` blog to `ternary`, static method `for`. - Replaced for loop with array method reduce, `printList`. - Fixed spellings.

refactor overrides.js

21

false

2

false

emberjs

ember.js

175

4339725976299b24c69fb9dfbf13d18bf9917130

Chris Krycho

GitHub

Merge pull request #20258 from emberjs/dependabot/npm_and_yarn/loader-utils-1.4.1 Bump loader-utils from 1.4.0 to 1.4.1

merge pull request from emberjs/dependabot/npm_and_yarn/loader-utils-1.4.1

75

true

false

5

true

false

emberjs

ember.js

176

698674b55e9fa7895485d9b3b53072090771ff8b

Chris Krycho

GitHub

Merge pull request #20257 from emberjs/fix-types-FrameworkObject [BUGFIX release] Fix types for `getOwner` and GlimmerComponent

merge pull request from emberjs/fix-types-frameworkobject

58

true

false

5

true

false

emberjs

ember.js

177

1467e6c938cb27b7890b892d3a55ab245397e1c6

dependabot[bot]

GitHub

Bump loader-utils from 1.4.0 to 1.4.1 Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](https://github.com/webpack/loader-utils/compare/v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

bump loader-utils from 1.4.0 to 1.4.1

37

true

6

true

false

emberjs

ember.js

178

dff8831cdbb5583de443a1859e4f09054687119f

Chris Krycho

Explain the (un)safety of the type of `getOwner()` The type for `getOwner()` is *technically* unsafe, but this unsafety is one which end users will rarely hit in practice and, courtesy of Ember's current types, is unavoidable if `getOwner(someService)` is to correctly return `Owner` instead of `Owner | undefined`. The Typed Ember folks have discussed this point at some length, but I realized on looking at this to make the changes in the preceding two commits that we didn't have it committed to the code base anywhere, so here I am just introducing a long comment explaining it. When we switch from preview to stable types, this comment should come along!

explain the (un)safety of the type of `getowner()`

50

false

8

true

false

true

emberjs

ember.js

179

fc09d4944e031ba0c7350b2249539daf365ef1f9

Chris Krycho

Fix type definition of `getOwner`, and explain it Use `GlimmerComponent<any>` instead of plain `GlimmerComponent`, since the latter resolves to the default `GlimmerComponent<unknown>`, which ends up being too narrow to resolve correctly with `getOwner` when any actual signature is applied. As a bonus, rename `FrameworkObject` in this context to the somewhat more verbose `KnownFrameworkObject`, which avoids a conflict with the actual `FrameworkObject` type used internally.

fix type definition of `getowner`, and explain it

49

false

8

false

true

false

emberjs

ember.js

180

cdd04dab708955e862166ce1a00bb2a74b06f26b

Chris Krycho

Add failing type test for `getOwner(Component<S>)` This catches the scenario where we have a component which actually has a signature defined: class Example extends Component<{ Args: { anyWillDo: true } }> { method() { getOwner(this); // should be `Owner`, not `| undefined` } } Presently, we return `Owner | undefined` instead.

add failing type test for `getowner(component<s>)`

50

false

6

true

emberjs

ember.js

181

0580eed5c18cdfcd239ccd475e04a1b4c222963c

Chris Krycho

Add v4.8.2 to CHANGELOG (cherry picked from commit de4ecf64304e04f1543bc1b59cb71ff448b8543c)

add v4.8.2 to changelog

23

false

4

true

emberjs

ember.js

182

52c13e5a890d6b8c688ac2a99f952ea3bba093ec

Chris Krycho

GitHub

Merge pull request #20253 from emberjs/rfc821-pt2 [FEATURE] Add the `Resolver` type to preview types

merge pull request from emberjs/rfc821-pt2

43

true

false

5

true

false

emberjs

ember.js

183

8699faac0f7212197e26ab6fbde80fda00de13b4

Chris Krycho

GitHub

Merge pull request #20248 from emberjs/dependabot/npm_and_yarn/ember-cli-dependency-checker-3.3.1 Bump ember-cli-dependency-checker from 3.2.0 to 3.3.1

merge pull request from emberjs/dependabot/npm_and_yarn/ember-cli-dependency-checker-3.3.1

91

true

false

5

true

false

emberjs

ember.js

184

7f98184e705fa2502bc6133afcfd167299a2688e

Chris Krycho

GitHub

Merge pull request #20252 from emberjs/dependabot/npm_and_yarn/aws-sdk-2.1245.0 Bump aws-sdk from 2.1166.0 to 2.1245.0

merge pull request from emberjs/dependabot/npm_and_yarn/aws-sdk-2.1245.0

73

true

false

5

true

false

emberjs

ember.js

185

33deaae416dfdd833042ae01c9140e74a2b18c1d

Chris Krycho

GitHub

Merge pull request #20249 from emberjs/dependabot/npm_and_yarn/core-js-3.26.0 Bump core-js from 2.6.5 to 3.26.0

merge pull request from emberjs/dependabot/npm_and_yarn/core-js-3.26.0

71

true

false

5

true

false

emberjs

ember.js

186

cca036eb575e10676e089f0d8efa01edd474cdb1

Katie Gengler

Add v4.9.0-beta.3 to CHANGELOG (cherry picked from commit 0de013590e92900e5aee664e804ac0fcddf611bd)

add v4.9.0-beta.3 to changelog

30

false

4

true

emberjs

ember.js

187

53ca013f87509315200c5969a8f55417af913786

Katie Gengler

Add v4.8.1 to CHANGELOG (cherry picked from commit 9c226d38d41b7845e27bbd34bf463cbcc1a06cec)

add v4.8.1 to changelog

23

false

4

true

emberjs

ember.js

188

6a17b8417e7e00e15b2b6f0441703f3c74f3fd0c

Katie Gengler

Add v4.4.4 to CHANGELOG (cherry picked from commit 1dad13a08ae0e1165d83b7d5927e33cd8498c708)

add v4.4.4 to changelog

23

false

4

true

emberjs

ember.js

189

7077f128fdf65149b5aad01d0a2852a3883e2aac

Chris Krycho

[FEATURE] Add the `Resolver` type to preview types Per the latest revision to RFC 0821, we need this public type for resolvers to use: Ember defines the contract, others (mostly, but not only, `ember-resolver`) implement the contract.

[feature] add the `resolver` type to preview types

50

false

8

false

emberjs

ember.js

190

701ee45b79b4ee3f860d2c380aa3d87212e3fad5

Katie Gengler

Add v3.28.10 to CHANGELOG (cherry picked from commit 198d7e168f3c857be4b7da539dd5b3785b2c1452)

add v3.28.10 to changelog

25

false

4

true

emberjs

ember.js

191

a20bff305ae45840deb07a4a36a09de55073e916

Katie Gengler

Add v3.24.7 to CHANGELOG (cherry picked from commit 44e20f73ab7c49003d185bef361353412d7a6518)

add v3.24.7 to changelog

24

false

4

true

emberjs

ember.js

192

3050628e9cfe0b8426deb9928ef718fb3f2dc026

Edward Faulkner

Katie Gengler

Fix prototype pollution bug (cherry picked from commit 0b6196a3e817b5b6793b5d9c1ba37f7d2d13d174)

fix prototype pollution bug

27

false

4

false

true

false

emberjs

ember.js

193

11d5973e8623a24e5f4f3b6686fbef970acd771d

dependabot[bot]

GitHub

Bump ember-cli-dependency-checker from 3.2.0 to 3.3.1 Bumps [ember-cli-dependency-checker](https://github.com/quaertym/ember-cli-dependency-checker) from 3.2.0 to 3.3.1. - [Release notes](https://github.com/quaertym/ember-cli-dependency-checker/releases) - [Commits](https://github.com/quaertym/ember-cli-dependency-checker/compare/v3.2.0...v3.3.1) --- updated-dependencies: - dependency-name: ember-cli-dependency-checker dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

bump ember-cli-dependency-checker from 3.2.0 to 3.3.1

53

true

6

false

true

false

emberjs

ember.js

194

7353d90cc90076ca499b6b14c0470de9d68518ca

dependabot[bot]

GitHub

Bump aws-sdk from 2.1166.0 to 2.1245.0 Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1166.0 to 2.1245.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1166.0...v2.1245.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

bump aws-sdk from 2.1166.0 to 2.1245.0

38

true

6

false

true

false

emberjs

ember.js

195

623b8c104a906f0b14a22512616043277d32a5aa

Chris Krycho

GitHub

Merge pull request #20250 from emberjs/dependabot/npm_and_yarn/eslint-8.26.0 Bump eslint from 8.11.0 to 8.26.0

merge pull request from emberjs/dependabot/npm_and_yarn/eslint-8.26.0

70

true

false

5

true

false

emberjs

ember.js

196

78dfbcda331e72dcd9cb8324439f49897a2e7fa7

Chris Krycho

GitHub

Merge pull request #20247 from emberjs/dependabot/npm_and_yarn/testem-3.9.0 Bump testem from 3.8.0 to 3.9.0

merge pull request from emberjs/dependabot/npm_and_yarn/testem-3.9.0

69

true

false

5

true

false

emberjs

ember.js

197

e784f69fd4cd2a845111d228921c665cd5a10732

dependabot[bot]

GitHub

Bump eslint from 8.11.0 to 8.26.0 Bumps [eslint](https://github.com/eslint/eslint) from 8.11.0 to 8.26.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.11.0...v8.26.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

bump eslint from 8.11.0 to 8.26.0

33

true

6

true

false

emberjs

ember.js

198

26c8e9be083b3769727f96e907ee80c37ab73c27

dependabot[bot]

GitHub

Bump core-js from 2.6.5 to 3.26.0 Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 2.6.5 to 3.26.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.26.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

bump core-js from 2.6.5 to 3.26.0

33

true

6

true

false

emberjs

ember.js

199