url
stringlengths 79
94
| original_message
stringlengths 5
2.73k
| message
stringlengths 0
2.61k
| original_label
stringclasses 4
values | is_good
bool 2
classes | is_bad
bool 2
classes | binary_label
float64 0
1
⌀ |
|---|---|---|---|---|---|---|
https://github.com/square/okhttp/commit/355c8b0ef12318994822b4095dcd9cdcec1e259a | Skip UTF-8 decode of keys, defer UTF-8 decode of data | Skip UTF-8 decode of keys, defer UTF-8 decode of data | No Why | false | false | null |
https://github.com/square/okhttp/commit/5fe3cc2d089810032671d6135ad137af6f491d28 | OkHttpClient.cache() is nullable. (#3916) | OkHttpClient.cache() is nullable. | No What | false | false | null |
https://github.com/square/okhttp/commit/69bdd6961ba294894620f850b6b01d7175ae8009 | Restricted ciphers (#3908)
Add a 'best practice' restricted TLS connection spec | Restricted ciphers
Add a 'best practice' restricted TLS connection spec | Why and What | false | false | null |
https://github.com/square/okhttp/commit/137e7de0454f10160370f105ac7d9d2fc5403c84 | New API, HandshakeCertificates.addPlatformTrustedCertificates()
Also rename HeldCertificate.Builder.issuedBy() to signedBy(). 'Issued' is the
word used by certificates; 'signed' is the word used by cryptographers. I prefer
'signed'. | New API, HandshakeCertificates.addPlatformTrustedCertificates()
Also rename HeldCertificate.Builder.issuedBy() to signedBy(). 'Issued' is the
word used by certificates; 'signed' is the word used by cryptographers. I prefer
'signed'. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/db2ae92156242255a0d42caaf50c7801e79de917 | Fixup HeldCertificate so that it's worthy of production use.
This changes the default from the insecure 1024-bit RSA to a secure 256-bit ECDSA
key. It adds a new option to use RSA keys for interoperating with older clients. | Fixup HeldCertificate so that it's worthy of production use.
This changes the default from the insecure 1024-bit RSA to a secure 256-bit ECDSA
key. It adds a new option to use RSA keys for interoperating with older clients. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/d908a676c25b6b3d547b45a9970f4bfb7a358010 | Support client authentication in MockWebServer
Also expose the handshake in the RecordedResponse.
https://github.com/square/okhttp/issues/3934 | Support client authentication in MockWebServer
Also expose the handshake in the RecordedResponse.
https://github.com/square/okhttp/issues/3934 | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/af6198a1e992b55ff4d16dcaeeacbb4e90e29c8a | Fail HTTP/2 connections if the pong is not received. (#3878)
This removes the Ping abstraction from our http2 package. This was written as
if it were a public API, but never exposed to any callers but tests. Removing
it makes it easier to lock down how pings are used.
This also removes the NullServer class, replacing it with a new SocketPolicy
on MockWebServer. The new SocketPolicy, STALL_SOCKET_AT_START, allows us to
do TLS and negotiate an HTTP/2 connection without actually building a proper
Http2Connection and without responding to pings.
The behavior in HTTP/2 connections is modeled after our behavior in web sockets.
We count outgoing pings, incoming pongs, and confirm that the pongs are keeping
up. If later we make this policy more sophisticated we can track the changes
in both places.
Closes: https://github.com/square/okhttp/issues/3261 | Fail HTTP/2 connections if the pong is not received.
This removes the Ping abstraction from our http2 package. This was written as
if it were a public API, but never exposed to any callers but tests. Removing
it makes it easier to lock down how pings are used.
This also removes the NullServer class, replacing it with a new SocketPolicy
on MockWebServer. The new SocketPolicy, STALL_SOCKET_AT_START, allows us to
do TLS and negotiate an HTTP/2 connection without actually building a proper
Http2Connection and without responding to pings.
The behavior in HTTP/2 connections is modeled after our behavior in web sockets.
We count outgoing pings, incoming pongs, and confirm that the pongs are keeping
up. If later we make this policy more sophisticated we can track the changes
in both places.
Closes: https://github.com/square/okhttp/issues/3261 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/abb0a790802996d1039c35424b70b0f3f06b94b7 | First step towards HTTP/2 automatic pings. (#3874)
This changes the executor services in HTTP/2 connection to split up
listener executors (of which there may be many threads) from writer
executors (of which there is one per connection).
This adds a scheduled executor job to send pings on an interval. We
don't yet fail the connection if pongs are not received.
For follow-up there's some work to remove exising APIs to send pings
through the HTTP/2 APIs. These are unused and make it awkard to
confirm that only the automatic pings are being replied to.
See https://github.com/square/okhttp/issues/3261 | First step towards HTTP/2 automatic pings.
This changes the executor services in HTTP/2 connection to split up
listener executors (of which there may be many threads) from writer
executors (of which there is one per connection).
This adds a scheduled executor job to send pings on an interval. We
don't yet fail the connection if pongs are not received.
For follow-up there's some work to remove exising APIs to send pings
through the HTTP/2 APIs. These are unused and make it awkard to
confirm that only the automatic pings are being replied to.
See https://github.com/square/okhttp/issues/3261 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/ea014716fd2a8712ee39888725f91bed43148cd3 | Remove CBC-mode ECDSA cipher suites
This removes the following cipher suites as supported-by-default:
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA
TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
This tracks a similar change in Chromium 56:
https://developers.google.com/web/updates/2016/12/chrome-56-deprecations#remove_cbc-mode_ecdsa_ciphers_in_tls
OkHttp's updated cipher suites, plus comparisons to Android, Java,
Chromium, Firefox, and Square's server-site configuration is here:
https://tinyurl.com/okhttp-cipher-suites
Closes: https://github.com/square/okhttp/issues/3035 | Remove CBC-mode ECDSA cipher suites
This removes the following cipher suites as supported-by-default:
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA
TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
This tracks a similar change in Chromium 56:
https://developers.google.com/web/updates/2016/12/chrome-56-deprecations#remove_cbc-mode_ecdsa_ciphers_in_tls
OkHttp's updated cipher suites, plus comparisons to Android, Java,
Chromium, Firefox, and Square's server-site configuration is here:
https://tinyurl.com/okhttp-cipher-suites
Closes: https://github.com/square/okhttp/issues/3035 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/0a4896a296c113c5fe0e82f0f052e615b95527bf | Transfer to/from FileChannel directly from Buffer. (#3846) | Transfer to/from FileChannel directly from Buffer. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/18f3564a4f2b17c3067e7f02337e3909ba5cb3ba | Update deploy_snapshot.sh to temporarily ignore javadoc errors and compile tests but not run (#3821) | Update deploy_snapshot.sh to temporarily ignore javadoc errors and compile tests but not run | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/0cf6f33c1fd1ff84970fa2400afb70a1ea176d5d | document buffer (#3748) | document buffer | No What | false | true | 0 |
https://github.com/square/okhttp/commit/c310d27440bd58c23a8cb7795fe1e9514488c962 | workaround broken system dns behaviour | workaround broken system dns behaviour | No Why | false | false | null |
https://github.com/square/okhttp/commit/d6fd0d3832907ff36789b89450df09320081fc66 | Fix travis build | Fix travis build | No What | false | true | 0 |
https://github.com/square/okhttp/commit/3646138247488c9832a7f325401fe0b12fcdbebf | Don't summarize the request and response headers. (#3576)
Just pass the Request and Response objects in directly. | Don't summarize the request and response headers.
Just pass the Request and Response objects in directly. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/a95ec06a5037f7ca84f4f596397ce6090734c59b | Fix a race in WebSocketHttpTest. (#3570)
We were assuming on a client failure the server wouldn't have any
further events. But it will get a failure if we give it a moment.
This was causing some test flakiness. | Fix a race in WebSocketHttpTest.
We were assuming on a client failure the server wouldn't have any
further events. But it will get a failure if we give it a moment.
This was causing some test flakiness. | No What | true | false | 1 |
https://github.com/square/okhttp/commit/1801d0cb2c7132a97c3e9c011a8546f883dfcf12 | update proguard rules on README.md (#3559) | update proguard rules on README.md | Why and What | false | false | null |
https://github.com/square/okhttp/commit/cdc48ba8b0e4bdfccc208985bfef200220096d9d | IOException instead of Throwable in EventListener API (#3543) | IOException instead of Throwable in EventListener API | Why and What | false | false | null |
https://github.com/square/okhttp/commit/2f1e59e16792f4204dd5d03482b4bdc67554d7d6 | Travis: Remove the duplicate addons directive (#3492) | Travis: Remove the duplicate addons directive | Why and What | false | false | null |
https://github.com/square/okhttp/commit/0d069f3b7bc524320fc76051408384f8ece77412 | Prefer ByteString.encodeString.
This saves cloning the byte array because the byte array can't be modified by the caller. | Prefer ByteString.encodeString.
This saves cloning the byte array because the byte array can't be modified by the caller. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/d4a9cf4772ae9d8991e58d934dea433798c9b8eb | `response` receives null explicitly from several catch clauses => Fix nullability (override default parameter nullability set at package-info). (#3449) | `response` receives null explicitly from several catch clauses => Fix nullability (override default parameter nullability set at package-info). | Why and What | false | false | null |
https://github.com/square/okhttp/commit/c7d508b79c9e201c91ec23f5eec47c18be206567 | Add support for connect start/end events. (#3434) | Add support for connect start/end events. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/a9942c7c902a4ecc3c96b97b34737c54b07b48d2 | Fix code reference in Javadoc. | Fix code reference in Javadoc. | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/f87d32984dd9b1f5a7092b52dbecbafd784bd764 | README: ProGuard changes for OkHttp 3.8.0 | README: ProGuard changes for OkHttp 3.8.0 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/e5c84e1aef9572adb493197c1b6c4e882aca085b | Update changelog for OkHttp 3.8. | Update changelog for OkHttp 3.8. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/e7e22feb12244b455c8f4961d7eeab7cd21965fe | Fix Javadoc builds with the jsr305 dependency.
Because multiple modules share a package we need to share the dependency on
everything in package-info.java. | Fix Javadoc builds with the jsr305 dependency.
Because multiple modules share a package we need to share the dependency on
everything in package-info.java. | No What | false | false | null |
https://github.com/square/okhttp/commit/29d56966c1ba932920b278467bb3d61f49709da9 | Forbid null for a response's message.
This was only ever null in test code. Everything that parses responses from
the network gets a non-null value. The message may be empty. | Forbid null for a response's message.
This was only ever null in test code. Everything that parses responses from
the network gets a non-null value. The message may be empty. | No Why | false | false | null |
https://github.com/square/okhttp/commit/1c2c57b1a9e037d81aeac3ad5088db9ec4358fb1 | Add error-prone compiler and fix its found issues. | Add error-prone compiler and fix its found issues. | No Why | true | false | 1 |
https://github.com/square/okhttp/commit/6651a9c15e06e8d1829aa00f970998be2f33b225 | Change MediaType's failure mode to not crash on charset problems.
As-is it throws unchecked exceptions on unexpected charsets. This is a problem
because it can cause a misbehaving webserver to crash the client.
I don't expect this to break existing clients; returning 'null' has always
been a possibility; it's just returned in more cases. | Change MediaType's failure mode to not crash on charset problems.
As-is it throws unchecked exceptions on unexpected charsets. This is a problem
because it can cause a misbehaving webserver to crash the client.
I don't expect this to break existing clients; returning 'null' has always
been a possibility; it's just returned in more cases. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/c9496d350c0c3bb4b9d9571c3ab97181726561e2 | Invalidate the cache even if the response has no body.
Closes: https://github.com/square/okhttp/issues/3203 | Invalidate the cache even if the response has no body.
Closes: https://github.com/square/okhttp/issues/3203 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/8864c5d687df432021a4409aad4e0448ed030c5a | Permit network interceptors to rewrite the host header.
This makes it possible to do domain fronting.
Closes https://github.com/square/okhttp/issues/3103 | Permit network interceptors to rewrite the host header.
This makes it possible to do domain fronting.
Closes https://github.com/square/okhttp/issues/3103 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/87b86a53c4a5c591b8e1c5ec94b4d81edece00a8 | Add ProGuard config to README | Add ProGuard config to README | Why and What | false | false | null |
https://github.com/square/okhttp/commit/ca76167504d5323f2a8c1011402907b9a755585c | Make the crawler a little better.
Name threads by their URLs. Don't follow all fragments of the same URL. | Make the crawler a little better.
Name threads by their URLs. Don't follow all fragments of the same URL. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/9e0b5b81b0ac25f59a25bd744dc788fe5c3e2971 | Make FakeDns more capable. | Make FakeDns more capable. | No What | false | false | null |
https://github.com/square/okhttp/commit/caec3c711887b16852c9a4b1bd6d795f3f1b9ca4 | fix CertificateChainCleanerTest for Java 9 | fix CertificateChainCleanerTest for Java 9 | No What | false | false | null |
https://github.com/square/okhttp/commit/ef6e605fafe8bd65045b42ae0decd5f91c3ec6c6 | Change HttpURL.redact() to return a String. | Change HttpURL.redact() to return a String. | No Why | false | true | 0 |
https://github.com/square/okhttp/commit/c3e31674ea267b6fc01cb5a857d5937ca3f7740b | Changelog for OkHttp 3.5.0. | Changelog for OkHttp 3.5.0. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/5d43df973ae841ca05a63580c6a225ff251c410b | Fix an invalid HTML entity in the SlackApi Javadoc.
And-per-se-and | Fix an invalid HTML entity in the SlackApi Javadoc.
And-per-se-and | Why and What | false | false | null |
https://github.com/square/okhttp/commit/22b250c1b87d2c8038a78f9aea5dec3b644ce977 | Correct UTF8 BOM is EFBBBF | Correct UTF8 BOM is EFBBBF | No Why | false | true | 0 |
https://github.com/square/okhttp/commit/02b08fbde7b1726d7a4c0dc971152751ac82ca0a | Allow HTAB in header values.
RFC 7230 section 3.2 allows HTAB (' ', 'u0009') inside header
values as long as there is not more than one in a row:
https://tools.ietf.org/html/rfc7230#section-3.2
Before this CL, OkHttp previously disallowed HTAB in header values.
This CL changes behavior to allow any number of consecutive HTABs
inside a header value; this is more permissive than the RFC, but
is consistent with how OkHttp currently treats space characters
(' ', 'u0020'). | Allow HTAB in header values.
RFC 7230 section 3.2 allows HTAB (' ', 'u0009') inside header
values as long as there is not more than one in a row:
https://tools.ietf.org/html/rfc7230#section-3.2
Before this CL, OkHttp previously disallowed HTAB in header values.
This CL changes behavior to allow any number of consecutive HTABs
inside a header value; this is more permissive than the RFC, but
is consistent with how OkHttp currently treats space characters
(' ', 'u0020'). | Why and What | false | false | null |
https://github.com/square/okhttp/commit/fd509b937c4a5438fe02ddf06ade5ad56736af5d | Inject a leading . for better matching under JavaNetCookieJar
Closes: https://github.com/square/okhttp/issues/2549 | Inject a leading . for better matching under JavaNetCookieJar
Closes: https://github.com/square/okhttp/issues/2549 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/bf40d52edbb88d5afaa35af24837e3b72ac84eab | Fix a test to not require a fallback IP address.
This might be an unexpected upside of the migration to the Call API.
Closes: https://github.com/square/okhttp/issues/2178 | Fix a test to not require a fallback IP address.
This might be an unexpected upside of the migration to the Call API.
Closes: https://github.com/square/okhttp/issues/2178 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/a0b9308d270c6d107c57adb1d017901897b5c9a4 | Update Javadoc example | Update Javadoc example | No Why | false | false | null |
https://github.com/square/okhttp/commit/8688f539f17b5fe1be9ffc8bf167b88b1558084a | More docs for HttpUrl.
Closes: https://github.com/square/okhttp/issues/2577
Closes: https://github.com/square/okhttp/issues/2263 | More docs for HttpUrl.
Closes: https://github.com/square/okhttp/issues/2577
Closes: https://github.com/square/okhttp/issues/2263 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/a5dc3106c54ae0aecd9237ffd942924e61ad5c0f | Do not allow remote peer to arbitrarily size the HPACK decoder dynamic table. | Do not allow remote peer to arbitrarily size the HPACK decoder dynamic table. | No Why | true | false | 1 |
https://github.com/square/okhttp/commit/5b8c043329b181d6d762d6192f3ded8abd84852e | Fix tests to share a common Dispatcher.
Also fix the memory limit, which may prevent Travis from failing
our tests. | Fix tests to share a common Dispatcher.
Also fix the memory limit, which may prevent Travis from failing
our tests. | No What | false | false | null |
https://github.com/square/okhttp/commit/15a5bc40a4520d935bbc02a3552f51dda77fcc9c | Collapse interceptors into a single chain.
Instead of having a chain of application interceptors and a separate chain
of network interceptors, this makes a single heterogeneous chain. It makes
the OkHttp core and network caller into interceptors. | Collapse interceptors into a single chain.
Instead of having a chain of application interceptors and a separate chain
of network interceptors, this makes a single heterogeneous chain. It makes
the OkHttp core and network caller into interceptors. | No Why | false | false | null |
https://github.com/square/okhttp/commit/e3cd9b9f1c9787c36d5ea82190bf1e2365377e66 | Fixes #2513 - NetworkSecurityPolicy based ConnectionSpec setup. | No What | false | false | null |
|
https://github.com/square/okhttp/commit/8f8018ce5d712af94c31254763d70d047adcb4e1 | updates junit version to v4.12 | updates junit version to v4.12 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/9b4e74f8c8ce6fff4281c2d7369fb25f6772a64e | A Pipe.
This is something we need to implement HttpURLConnection atop the native
OkHttp API. The application thread wants to be active, writing to its
OutputStream. But in OkHttp's API, this work wants to happen in the
RequestBody.writeTo() callback. To make this work we give the HttpUrlConnection
OutputStream the sink end of the pipe, and the RequestBody the source end
of the pipe. It's a bit of plumbing, but the benefit is that backpressure,
timeouts, and failures will propagate as expected. | A Pipe.
This is something we need to implement HttpURLConnection atop the native
OkHttp API. The application thread wants to be active, writing to its
OutputStream. But in OkHttp's API, this work wants to happen in the
RequestBody.writeTo() callback. To make this work we give the HttpUrlConnection
OutputStream the sink end of the pipe, and the RequestBody the source end
of the pipe. It's a bit of plumbing, but the benefit is that backpressure,
timeouts, and failures will propagate as expected. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/ad103f421ea546c1cb929eef0610eac5291a0607 | Use Moshi in OkHttp.
As discussed here: https://github.com/square/okhttp/pull/2492 | Use Moshi in OkHttp.
As discussed here: https://github.com/square/okhttp/pull/2492 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/6b9eeb18d4f42d0fbadaa6d7e83b0cbaf135a054 | Update changelog for OkHttp 3.3.0. | Update changelog for OkHttp 3.3.0. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/c63be3ee65184d119d5145e77986298287118c3a | document support for SNI | document support for SNI | Why and What | false | false | null |
https://github.com/square/okhttp/commit/85f74e2004eaf0d4ff339e8644df3d8e716361e5 | Accept user-provided trust managers in OkHttpClient.Builder
Closes: https://github.com/square/okhttp/issues/2427 | Accept user-provided trust managers in OkHttpClient.Builder
Closes: https://github.com/square/okhttp/issues/2427 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/881bfb826fe3f717da329d2c99df80733484091a | Remove untrue Callback statement from doc | Remove untrue Callback statement from doc | Why and What | false | false | null |
https://github.com/square/okhttp/commit/b8fd4e3de0098c44010800c8206000a21feeb252 | Update readme and changelog for 3.1.2. | Update readme and changelog for 3.1.2. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/18b2660873ed8f028ee72981c882ed676aa08030 | New CertificateAuthorityCouncil class to normalize certificate chains.
The goal of this is to get the root CA certificate into the certificate
chain, so that it can be considered by the certificate pinner. The work
to integrate CertificateAuthorityCouncil with CertificatePinner will
come in a follow-up PR.
See: https://github.com/square/okhttp/issues/1699 | New CertificateAuthorityCouncil class to normalize certificate chains.
The goal of this is to get the root CA certificate into the certificate
chain, so that it can be considered by the certificate pinner. The work
to integrate CertificateAuthorityCouncil with CertificatePinner will
come in a follow-up PR.
See: https://github.com/square/okhttp/issues/1699 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/6a79c3223c5ff2d556bbab8eb9909fffc4ca4387 | Update README.md -> Mockito moved to Github | Update README.md -> Mockito moved to Github | Why and What | false | false | null |
https://github.com/square/okhttp/commit/d0c7fd06bf4e412b5dd942ac590e7ac2585927ff | Update website to link to OkHttp 3.x Javadoc. | Update website to link to OkHttp 3.x Javadoc. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/fc238a225d6da5b8d6e8fcb580b9d66021953fd7 | Handle UnsupportedCharsetException in HttpLoggingInterceptor | Handle UnsupportedCharsetException in HttpLoggingInterceptor | No Why | true | false | 1 |
https://github.com/square/okhttp/commit/7826bcb2fb1facb697a4c512776756c05d8c9deb | Fix some get prefixes on Cache and ConnectionPool. | Fix some get prefixes on Cache and ConnectionPool. | No What | false | false | null |
https://github.com/square/okhttp/commit/efbbb47626ded93f304fabea17fd07bb362d5119 | Tweak error copy, add a couple tests | Tweak error copy, add a couple tests | No Why | false | false | null |
https://github.com/square/okhttp/commit/e991459c7c1f46d432ff4312cf7409884518655c | First step in parsing Set-Cookie headers. | First step in parsing Set-Cookie headers. | No Why | false | false | null |
https://github.com/square/okhttp/commit/e97bb77a0efc057e47e1692fdf7f858bdbdb65ed | adds optional request body for DELETE requests to ammend #610 | adds optional request body for DELETE requests to ammend #610 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/99f2bafe1c0abb2791131dde5a702d3bb3ba28f3 | Fix isClosed() when a cache has not been initialized
isClosed() now means 'has close() been called', after
commit ea565b2e30e15cd52ddfc2ddc6db4ea8f1c3de88
it meant 'has not been initialized or close() has been
called'.
Introduced explicit closed state. Minor tweak to use
initialized state to determine whether cleanup will
do anything. Added a test. | Fix isClosed() when a cache has not been initialized
isClosed() now means 'has close() been called', after
commit ea565b2e30e15cd52ddfc2ddc6db4ea8f1c3de88
it meant 'has not been initialized or close() has been
called'.
Introduced explicit closed state. Minor tweak to use
initialized state to determine whether cleanup will
do anything. Added a test. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/4ab6a8258b0df3a3528029f810e1f48952dba2d7 | Remove old SSL protocol method. | Remove old SSL protocol method. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/2d73da131dfa77de81ff8a54831c7385a0ce2d72 | fix #1919: PROPFIND request should not redirect to GET request | Why and What | false | false | null |
|
https://github.com/square/okhttp/commit/c5c4e7857cb25af822b9b3b1fbd158cbd168f48a | Expose Headers directly on MockResponse. | Expose Headers directly on MockResponse. | No Why | false | false | null |
https://github.com/square/okhttp/commit/8b6aa0dca55576a54e69fec59f40ddfaa3561adb | Use a Buffer for body contents. | Use a Buffer for body contents. | No Why | false | false | null |
https://github.com/square/okhttp/commit/a9a1f736b1ebbe2d44de570343685241db62600e | Correct comment. | Correct comment. | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/e960f78ce685bc67946816867ee4ac545086e328 | Support 204 and 205 'No Content' replies when application interceptor. | Support 204 and 205 'No Content' replies when application interceptor. | No Why | false | false | null |
https://github.com/square/okhttp/commit/f6c3ab9b16d1026d810a84c33f5476b26be5cd8d | Use Sources and Sinks for all IO. | Use Sources and Sinks for all IO. | No Why | false | false | null |
https://github.com/square/okhttp/commit/31ec212f84edbe04b9b705f521ed7dc3bd7ddc3a | Skip buffer allocation when not needed. | Skip buffer allocation when not needed. | No What | false | false | null |
https://github.com/square/okhttp/commit/4262a05f8e858ac9c39599b2e1dfc53c03020cd2 | Write some new connection pool tests.
These use the Call APIs. They're high-level so they won't break with the
implementation rewrite. | Write some new connection pool tests.
These use the Call APIs. They're high-level so they won't break with the
implementation rewrite. | No Why | false | false | null |
https://github.com/square/okhttp/commit/cc216c6f731f4f08ac29e5619943f502c50bfafd | Add Call.isExecuted().
Might be useful to expose this bookkeeping to app developers. | Add Call.isExecuted().
Might be useful to expose this bookkeeping to app developers. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/e36d7ecc26be18021da3555fc8b14381df7af34d | Fix flakiness in CallTest.cancelTagImmediatelyAfterEnqueue()
There's a race where the HTTP engine has been created, but not yet connected
and the cancel isn't as immediate as it could be. Fix the test by making sure
there's a response to be retrieved.
With the upcoming connection pool changes we might make the implementation
more robust.
Closes: https://github.com/square/okhttp/issues/2001 | Fix flakiness in CallTest.cancelTagImmediatelyAfterEnqueue()
There's a race where the HTTP engine has been created, but not yet connected
and the cancel isn't as immediate as it could be. Fix the test by making sure
there's a response to be retrieved.
With the upcoming connection pool changes we might make the implementation
more robust.
Closes: https://github.com/square/okhttp/issues/2001 | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/868ee844458eda9ee7b1b6f9a5238b7c3f84c0e4 | Drop our one remaining DSS cipher suite.
Tracking Chrome and Firefox, which have also dropped this cipher suite.
This is the only cipher suite change since the last update. See our cipher
suites spreadsheet for a comparison: https://goo.gl/dWXbi0
Closes https://github.com/square/okhttp/issues/1476 | Drop our one remaining DSS cipher suite.
Tracking Chrome and Firefox, which have also dropped this cipher suite.
This is the only cipher suite change since the last update. See our cipher
suites spreadsheet for a comparison: https://goo.gl/dWXbi0
Closes https://github.com/square/okhttp/issues/1476 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/a21a3d38e362626381e0a47cc9fbd349b31b0449 | Change COMPATIBLE_TLS to be TLSv1.0 and not SSLv3
Based on a discussion with Jesse Wilson during
https://github.com/square/okhttp/pull/1189. | Change COMPATIBLE_TLS to be TLSv1.0 and not SSLv3
Based on a discussion with Jesse Wilson during
https://github.com/square/okhttp/pull/1189. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/41bee9b70dfbe182697e32d2a8ad1f4b2885af02 | More interceptor tests.
Test interactions with the response cache and HttpURLConnection. | More interceptor tests.
Test interactions with the response cache and HttpURLConnection. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/117ebac9e235cf9e614237cd6c246d0dac5e0142 | Update to Okio 1.1.0. | Update to Okio 1.1.0. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/e4dd6cfd63b251fba7a37e773f91c6bb4150b6bf | Handle null fragments. | Handle null fragments. | No Why | false | false | null |
https://github.com/square/okhttp/commit/32b7675b726a1ca62f5080581f6daaf9b7c6a48e | Use ResponseBody to model the response body everywhere.
This makes cache writing and gzip layering work a bit nicer
because there are fewer fields in HttpEngine to track the
various competing streams. | Use ResponseBody to model the response body everywhere.
This makes cache writing and gzip layering work a bit nicer
because there are fewer fields in HttpEngine to track the
various competing streams. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/bebea4679ead5f9779ad00c3570ea68eb2a8dea7 | Log favicon request instead of using standard output | Log favicon request instead of using standard output | No Why | false | false | null |
https://github.com/square/okhttp/commit/e74e3f3bf744ef7f4d8ee724a7cf2347e486cfab | Move cache writing out of the transport.
This is necessary to unblock network interceptors, where the interceptor
may elect to rewrite the response body. If we've already cached the
original response body, we're too late. | Move cache writing out of the transport.
This is necessary to unblock network interceptors, where the interceptor
may elect to rewrite the response body. If we've already cached the
original response body, we're too late. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/0ad37cede4624e3d4764c400b1b46fc195420941 | Update to h2-16, hpack-10. | Update to h2-16, hpack-10. | No Why | false | false | null |
https://github.com/square/okhttp/commit/a4a79586d8aec87344ef81c0a46fcb3c8b61ce88 | Permit release candidates in version numbers. | Permit release candidates in version numbers. | No Why | false | false | null |
https://github.com/square/okhttp/commit/16f1d048165d2bf0aee4833ff7d8b415f537ce64 | api has changed, fixing the example | api has changed, fixing the example | Why and What | false | false | null |
https://github.com/square/okhttp/commit/92e64f0279f1ce10ddd280fe048a92f6a959203d | Partially revert connection timeout behavior
Related to issue #1790.
If there is a *connection* timeout the next route should
be tried. Timeouts during a request/response should
probably not be retried.
The timeout/interrupt behavior was changed in PR #1257
for issue #1146. This modified both connection and
request/response behavior. The issue reported was actually
about the use of Thread.interrupt(), not timeouts, but the
behavior change modified both behavior for interrupt and
timeout.
PR #1388 split the handling of exceptions so that separate
code now handles connection errors from that which handles
request/response errors. It faithfully kept the behavior
from PR #1257.
The modification of the timeout behavior during *connection*
caused problems on Android. Now that the two types of error
handling are split it's possible to deal with them
differently and return the connection behavior to trying
the next route. This does not modify behavior during
request/response. | Partially revert connection timeout behavior
Related to issue #1790.
If there is a *connection* timeout the next route should
be tried. Timeouts during a request/response should
probably not be retried.
The timeout/interrupt behavior was changed in PR #1257
for issue #1146. This modified both connection and
request/response behavior. The issue reported was actually
about the use of Thread.interrupt(), not timeouts, but the
behavior change modified both behavior for interrupt and
timeout.
PR #1388 split the handling of exceptions so that separate
code now handles connection errors from that which handles
request/response errors. It faithfully kept the behavior
from PR #1257.
The modification of the timeout behavior during *connection*
caused problems on Android. Now that the two types of error
handling are split it's possible to deal with them
differently and return the connection behavior to trying
the next route. This does not modify behavior during
request/response. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/7a3bb19ea44f6771a20d3f5c323cc8bd15d73a56 | Prevent MockSpdyPeer interfering with Android tests
On Android we run the OkHttp tests as an instrumented test case.
The default UncaughtExceptionHandler on Android will quit the
app, causing the current test to fail.
MockSpdyPeer creates a thread that fails for various reasons
that are not related to / required for the actual test. Often the
exception is thrown during a subsequent test.
This change logs the exception but prevent it from
propagating out of the top of the call stack. This decreases
overall flakiness. | Prevent MockSpdyPeer interfering with Android tests
On Android we run the OkHttp tests as an instrumented test case.
The default UncaughtExceptionHandler on Android will quit the
app, causing the current test to fail.
MockSpdyPeer creates a thread that fails for various reasons
that are not related to / required for the actual test. Often the
exception is thrown during a subsequent test.
This change logs the exception but prevent it from
propagating out of the top of the call stack. This decreases
overall flakiness. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/bffee2336725dde0f74933d5a7d12536c9bcbd06 | Introduce intermediate storage for frame contents.
This eliminates the need to always send a frame for every FrameSink#write and to always send an empty frame for FrameSink#close. Now, we only emit bytes once Okio reports complete segments. | Introduce intermediate storage for frame contents.
This eliminates the need to always send a frame for every FrameSink#write and to always send an empty frame for FrameSink#close. Now, we only emit bytes once Okio reports complete segments. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/426c11de7b411bd47e9ef5ba3ce08d8589a8a88c | Upstream commit of Android SNI / NPN fix
https://android-review.googlesource.com/#/c/111211
The change's to Android's Platform have been ported.
This does not include the introduction of PlatformTest,
which will be difficult to write so it works everywhere. | Upstream commit of Android SNI / NPN fix
https://android-review.googlesource.com/#/c/111211
The change's to Android's Platform have been ported.
This does not include the introduction of PlatformTest,
which will be difficult to write so it works everywhere. | No Why | false | false | null |
https://github.com/square/okhttp/commit/067aa1f4495f9c93bafca183a6d655fa81b139d6 | Throw UnknownHostException again from HttpURLConnection
This is to address issue #1827. | Throw UnknownHostException again from HttpURLConnection
This is to address issue #1827. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/8e996aadc5d7839f249399abac657e3c9df1dc4a | Fix bug where request body isn't sent when it should | Fix bug where request body isn't sent when it should | No What | true | false | 1 |
https://github.com/square/okhttp/commit/112f020c411c9d14f34e480b98325777b25a7434 | Change the cache to have non-shared semantics.
This means we'll cache responses that use an 'Authorization' header. This
means OkHttp's cache shouldn't be used on middleboxes that sit between
user agents and the origin server; in practice this is never a use case
for OkHttp.
Fixes https://github.com/square/okhttp/issues/1035 | Change the cache to have non-shared semantics.
This means we'll cache responses that use an 'Authorization' header. This
means OkHttp's cache shouldn't be used on middleboxes that sit between
user agents and the origin server; in practice this is never a use case
for OkHttp.
Fixes https://github.com/square/okhttp/issues/1035 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/a560f721937f7f7299167a4d1c3f3ca87998635b | Expose internal APIs for pluggable file systems.
We aren't yet ready to make FileSystem a public type, but I don't mind
making it _almost_ available via an internal API for those brave enough
to try that.
Also migrate all of our tests to use the in memory file system. It's simpler.
https://github.com/square/okhttp/issues/1459 | Expose internal APIs for pluggable file systems.
We aren't yet ready to make FileSystem a public type, but I don't mind
making it _almost_ available via an internal API for those brave enough
to try that.
Also migrate all of our tests to use the in memory file system. It's simpler.
https://github.com/square/okhttp/issues/1459 | No Why | false | false | null |
https://github.com/square/okhttp/commit/8d4230b78d283924842edbe963b10cfb43737338 | Don't append to a truncated line in the journal.
Fixes https://github.com/square/okhttp/issues/1099 | Don't append to a truncated line in the journal.
Fixes https://github.com/square/okhttp/issues/1099 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/c8c790a6c8862778cbf8f140b19944732316f0e7 | fix small types in the changelog | fix small types in the changelog | Why and What | false | false | null |
https://github.com/square/okhttp/commit/3bee7aca20ddde7137c874ab918d2dc603d3026e | Test that conditional misses update the cache.
Closes https://github.com/square/okhttp/issues/1712 | Test that conditional misses update the cache.
Closes https://github.com/square/okhttp/issues/1712 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/aaf2695b00dfd69df6fd915ba16665eee8c1962d | Fix ResponseCacheTest for Android
Pull #1011 broke ResponseCacheTest on Android.
The test was asserting a header generated
using a copy of the old broken implementation.
The test now just uses HttpDate, which now has its own
tests. | Fix ResponseCacheTest for Android
Pull #1011 broke ResponseCacheTest on Android.
The test was asserting a header generated
using a copy of the old broken implementation.
The test now just uses HttpDate, which now has its own
tests. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/8fe27a50c2c88d382e6dc6600836bcc57fc7b0cf | Crash on unexpected RuntimeExceptions.
Currently we're sweeping these under the rug. | Crash on unexpected RuntimeExceptions.
Currently we're sweeping these under the rug. | No What | false | false | null |