url
stringlengths
79
94
original_message
stringlengths
5
2.73k
message
stringlengths
0
2.61k
original_label
stringclasses
4 values
is_good
bool
2 classes
is_bad
bool
2 classes
binary_label
float64
0
1
https://github.com/square/retrofit/commit/6961f57ab97224073743b1f14a0395a493c52985
Combine MethodHandler and RequestFactory into ServiceMethod. This is once class that handles all of the annotations and binding for a service method.
Combine MethodHandler and RequestFactory into ServiceMethod. This is once class that handles all of the annotations and binding for a service method.
No Why
true
false
1
https://github.com/square/retrofit/commit/b28f9053fd92535f9d41f2010ead31191e79df36
Forbid null map values, and null maps.
Forbid null map values, and null maps.
No Why
false
false
null
https://github.com/square/retrofit/commit/cb5c9cec34490559f0332941dd6b22e29471b9cb
Propagate callback executor even when not explicitly specified. This lets custom CallAdapter implementations use the platform default for their callbacks.
Propagate callback executor even when not explicitly specified. This lets custom CallAdapter implementations use the platform default for their callbacks.
No Why
false
false
null
https://github.com/square/retrofit/commit/026a35e78a390e8941ee8b24149877ae51940c19
Speling.
Speling.
Neither Why nor What
false
true
0
https://github.com/square/retrofit/commit/d6cd2f42d5a48281f7e1346b1c52e1285e80e316
Issue template for retrofit.
Issue template for retrofit.
No Why
false
false
null
https://github.com/square/retrofit/commit/a19609a16359af66aec5410459899291b2c45cf1
Add example of using JSON converter as a String converter. This also adds the Retrofit instance as a param to the string converter to allow it to delegate to others directly. This brings it into parity with the method signatures of the other converter methods anyway.
Add example of using JSON converter as a String converter. This also adds the Retrofit instance as a param to the string converter to allow it to delegate to others directly. This brings it into parity with the method signatures of the other converter methods anyway.
Why and What
true
false
1
https://github.com/square/retrofit/commit/473fd2473cc41e68eb61c6d2d4316d720edd46fb
Use Gson instance as factory for reader to honor config. This allows settings like support for leniency to be honored.
Use Gson instance as factory for reader to honor config. This allows settings like support for leniency to be honored.
No Why
false
false
null
https://github.com/square/retrofit/commit/15f73966ee4e7d355cc0b9839f2103ae9684f72f
baseUrl should end with '/'
baseUrl should end with '/'
No What
true
false
1
https://github.com/square/retrofit/commit/291591e634a48ce6539d66164b0da3b8de179c6e
Write up Beta 4's current change log.
Write up Beta 4's current change log.
No Why
false
false
null
https://github.com/square/retrofit/commit/6a84e8bddcab818eafeeec7ec52d260402f358b8
Do not trap IO from request body conversion.
Do not trap IO from request body conversion.
No What
false
false
null
https://github.com/square/retrofit/commit/a0594600652b5f1716298e9c444abc0fb5cfc279
Add support for scalars from ResponseBody
Add support for scalars from ResponseBody
No Why
true
false
1
https://github.com/square/retrofit/commit/b3ea768567e9e1fb1ba987bea021dbc0ead4acd4
Provide ability to retrieve original Request object from Call.
Provide ability to retrieve original Request object from Call.
No Why
true
false
1
https://github.com/square/retrofit/commit/fed328ed8aa97dbdbaf7ff649af099f66050e39d
Update to the latest version of okhttp
Update to the latest version of okhttp
Why and What
false
true
0
https://github.com/square/retrofit/commit/452004af62ff790ca6d271bc80d36fa5e49dcda5
Prepare version 2.0.0-beta3.
Prepare version 2.0.0-beta3.
Why and What
false
true
0
https://github.com/square/retrofit/commit/f4ee9e28a6380662ea0ab8a9a02adbd021ef55e8
Added more tests for RxJava Single type support Single.toBlocking() is present since RxJava 1.0.16 version.
Added more tests for RxJava Single type support Single.toBlocking() is present since RxJava 1.0.16 version.
Why and What
false
false
null
https://github.com/square/retrofit/commit/78119485c2ee60cbeb2dc478679cfd7b9712ddbd
Use new OkHttp's non-throwing close and a simpler body copy.
Use new OkHttp's non-throwing close and a simpler body copy.
Why and What
true
false
1
https://github.com/square/retrofit/commit/af375bd4ac8892a23cb132cbb982b41be3af8b9f
Use Call.Factory in RequestBuilderTest.
Use Call.Factory in RequestBuilderTest.
No Why
false
false
null
https://github.com/square/retrofit/commit/8eed9f264c13710fc0ac8251b3c5382a129a10ce
Add missing Call wrappers as return type
Add missing Call wrappers as return type
Why and What
true
false
1
https://github.com/square/retrofit/commit/4cd675dcda829a9ec613770105909ab9cb36e722
Switch to a proper builder for MockRetrofit. This allows passing an explicit executor for test cases.
Switch to a proper builder for MockRetrofit. This allows passing an explicit executor for test cases.
No Why
true
false
1
https://github.com/square/retrofit/commit/c342d650a8abe8c87222d286a2c321ba9563e47b
Remove incorrect generic parameter.
Remove incorrect generic parameter.
Why and What
true
false
1
https://github.com/square/retrofit/commit/365b2104eceb9b0007395b849740c381d13a22a1
Extract iterable and array behavior from RequestAction.
Extract iterable and array behavior from RequestAction.
No Why
false
false
null
https://github.com/square/retrofit/commit/7e4beeb66e3b5e66907410b930b653ff5ad63ead
Tweaks from review.
Tweaks from review.
No Why
false
true
0
https://github.com/square/retrofit/commit/a1109549247be09db9a0de3d64fcecdd43a13d24
Documentation for endpoint resolving on a base URL.
Documentation for endpoint resolving on a base URL.
Why and What
false
false
null
https://github.com/square/retrofit/commit/8db48717825286e5d10a37a6600c34ba29b8822f
Added a checkstyle rule for the line indentation Change-Id: I94d7404cb05c192021a6f737ffa6cf8c3fe9a3fa Signed-off-by: Simon Scholz <simon.scholz@vogella.com>
Added a checkstyle rule for the line indentation Change-Id: I94d7404cb05c192021a6f737ffa6cf8c3fe9a3fa Signed-off-by: Simon Scholz <simon.scholz@vogella.com>
No Why
false
false
null
https://github.com/square/retrofit/commit/408a975f4c35438118f613bbeed912e1b0f71ec3
Update multipart documentation.
Update multipart documentation.
Why and What
false
false
null
https://github.com/square/retrofit/commit/a9c0512fa6f88933702bf0e12243f5a584c01f66
Use a correct implementation of path encoding.
Use a correct implementation of path encoding.
No Why
false
false
null
https://github.com/square/retrofit/commit/9885c9d7b894fde3cdf90acfde8585788a646f11
Prepare for 2.0.0-beta2.
Prepare for 2.0.0-beta2.
Why and What
false
true
0
https://github.com/square/retrofit/commit/6843b42c3761cc4bea261ac86c2ea6bc70b04334
Remove outdated reference
Remove outdated reference
Why and What
false
false
null
https://github.com/square/retrofit/commit/7bcdfb3f5b2cf23965eac5f4779612313c4e652b
Provide option for eagerly validating an interface.
Provide option for eagerly validating an interface.
No Why
false
false
null
https://github.com/square/retrofit/commit/6c0ea7deefe4a884ac50080547654e4dee27cf3d
Updating dependencies version
Updating dependencies version
Why and What
false
false
null
https://github.com/square/retrofit/commit/42b6f8c5de4d63c01425a8b5c7c4765b84f798ec
Switch to a generic to/from converter, explicit factory. This allows for specialization based on for what purpose the converter is being created. For the built-in converter factory, for example, types like `ResponseBody` and `Void` only apply to the response type and types like `RequestBody` only apply to a body/part type.
Switch to a generic to/from converter, explicit factory. This allows for specialization based on for what purpose the converter is being created. For the built-in converter factory, for example, types like `ResponseBody` and `Void` only apply to the response type and types like `RequestBody` only apply to a body/part type.
No Why
false
false
null
https://github.com/square/retrofit/commit/8a70ac168500cc60c0ccf8ec6c8c9e34885e3dac
Consolidate response body specializations as inner classes.
Consolidate response body specializations as inner classes.
No Why
false
false
null
https://github.com/square/retrofit/commit/5f0fab05a93372060d0019803895897de3e6166c
Change log for 2.0.0-beta1.
Change log for 2.0.0-beta1.
No Why
false
true
0
https://github.com/square/retrofit/commit/c0cc4cb5bbf688a11dda5531f009300b20005e61
RxJava 1.0.14 with an important Android fix. Just in case someone is relying on the transitive dependency.
RxJava 1.0.14 with an important Android fix. Just in case someone is relying on the transitive dependency.
Why and What
false
false
null
https://github.com/square/retrofit/commit/21f327cc70d010af01d57ddb2ff209bef7f05033
Naming, API changes, and documentation around mock services.
Naming, API changes, and documentation around mock services.
No Why
false
false
null
https://github.com/square/retrofit/commit/26d19ea8877696a253be8c00b2baed6b359baaa2
Java 7 is required since 2ca19506
Java 7 is required since 2ca19506
Why and What
false
false
null
https://github.com/square/retrofit/commit/0973ca61da4fb5d293e53c8334fe5f7ae3cfdfd2
Restore mock module for creating delayed and erroring Calls.
Restore mock module for creating delayed and erroring Calls.
No Why
false
false
null
https://github.com/square/retrofit/commit/cf392789e4d1a4e7b8e450ccd708f4ad128e3c1c
Rename Callback.success() to onSuccess(), and failure() to onFailure().
Rename Callback.success() to onSuccess(), and failure() to onFailure().
Why and What
false
false
null
https://github.com/square/retrofit/commit/d9300dd040a7ca9523d35d1cc49417fa73182639
Also refer to the latest OkHttp version.
Also refer to the latest OkHttp version.
Why and What
false
false
null
https://github.com/square/retrofit/commit/75077e0a18ab9dcbb836f14afa736ab251a56a8e
Move response Converter lookup to happen during method parsing.
Move response Converter lookup to happen during method parsing.
No Why
false
false
null
https://github.com/square/retrofit/commit/fe6d0f9b2a68063a086fa9da80d04293fbe3becf
Introduce factory for converter concept. This is still highly-inefficient in its internal use and there are no tests proving that we now fail earlier in configuring a service method. Both of those will come in follow up commits
Introduce factory for converter concept. This is still highly-inefficient in its internal use and there are no tests proving that we now fail earlier in configuring a service method. Both of those will come in follow up commits
Why and What
false
false
null
https://github.com/square/retrofit/commit/580d31ae906ac28f608427d4c4d2318a0e8b658a
Rename main class to Retrofit.
Rename main class to Retrofit.
Why and What
false
false
null
https://github.com/square/retrofit/commit/74d6a855eb4ca0c11ec9fcc2e898b0fe540e787e
Add a test to verify unused and potentially invalid path params are allowed.
Add a test to verify unused and potentially invalid path params are allowed.
Why and What
true
false
1
https://github.com/square/retrofit/commit/9b203b66891c1d363529a1b2b46c8968bf54d7cc
Move converter into the main package, remove Gson from core. This change means that only RequestBody and ResponseBody are the types which are allowed for their respective objects by default. If you want serialization of any kind, you need to opt-in with either your own converter or one of the provided ones.
Move converter into the main package, remove Gson from core. This change means that only RequestBody and ResponseBody are the types which are allowed for their respective objects by default. If you want serialization of any kind, you need to opt-in with either your own converter or one of the provided ones.
No Why
false
false
null
https://github.com/square/retrofit/commit/49bba7d60f2a920e138e9388c515ee58fc8c4bcf
Rewrite RxJava call adapter tests to be more understandable.
Rewrite RxJava call adapter tests to be more understandable.
Why and What
true
false
1
https://github.com/square/retrofit/commit/3b1fd0302627da520cc99b7eda060c6228a32f81
Includes this repo in our open source bug bounty program.
Includes this repo in our open source bug bounty program.
No Why
false
false
null
https://github.com/square/retrofit/commit/52be441605e6fc469ec718b2da954ad553491746
Fix foo/bar/baz in @Query documentation
Fix foo/bar/baz in @Query documentation
Why and What
false
false
null
https://github.com/square/retrofit/commit/79a2a501b5964bd831bd3c4b9554d35fb2e584c2
OkHttp 2.0 only.
OkHttp 2.0 only.
No What
false
true
0
https://github.com/square/retrofit/commit/0316bae5bd503462883bc8ea2ddd317b5bf9f222
Formatting.
Formatting.
Neither Why nor What
false
true
0
https://github.com/square/retrofit/commit/e0f446499197658f05e5a41403ec5ca101e9ed86
Restore Form URL encoding support.
Restore Form URL encoding support.
No Why
false
false
null
https://github.com/square/retrofit/commit/7a06832e3cee1f4d90ac8fd24fc39f90e3787b4c
Remove unused classes from 56f11374c2f5d037e57d274a3c72f9694cd9e05c.
Remove unused classes from 56f11374c2f5d037e57d274a3c72f9694cd9e05c.
Why and What
false
false
null
https://github.com/square/retrofit/commit/fe1d01684c96d55224c67e67c31c3fd8faa05c24
Ensure we don't crash on null header values.
Ensure we don't crash on null header values.
No What
true
false
1
https://github.com/square/retrofit/commit/757278c7ab7f6c8e5a40d16a5707c35e0f61c5ab
Update to OkHttp 2.2. Fix a tiny potential NPE.
Update to OkHttp 2.2. Fix a tiny potential NPE.
Why and What
false
false
null
https://github.com/square/retrofit/commit/ed1122ae27c0503e3182e9a7d817097b7febcebb
Fix annotation link. EncodedPath is gone.
Fix annotation link. EncodedPath is gone.
Why and What
false
false
null
https://github.com/square/retrofit/commit/478e1ddfc774ae990a5efd3143c9e7e95994942c
Provide a setter to set strict mode to false
Provide a setter to set strict mode to false
No Why
false
false
null
https://github.com/square/retrofit/commit/f56cd02871aa8c8f94a2354cdaf9e7c6dc9b1091
Use new central artifact redirect link.
Use new central artifact redirect link.
No Why
false
false
null
https://github.com/square/retrofit/commit/745e29b7832c3cc37e7b6d395aded79a908c3bbc
Remove deprecated error identifier. This whole class is probably going to die or morph, but killing off tech debt before major refactorings makes me feel good.
Remove deprecated error identifier. This whole class is probably going to die or morph, but killing off tech debt before major refactorings makes me feel good.
Why and What
false
false
null
https://github.com/square/retrofit/commit/04c6e762c708de36f62f288a105ea67c5d1c8010
Switch to io.reactivex version of rxjava
Switch to io.reactivex version of rxjava
No Why
false
false
null
https://github.com/square/retrofit/commit/bc2c3c5a31a5ebec5df5790588c25cfd10d7a4a6
Prepare for 1.7.0.
Prepare for 1.7.0.
Why and What
false
true
0
https://github.com/square/retrofit/commit/93371a4c37f22b83df32edca3b0af376642a6d7d
Favor an immutable singleton list over immutable list view.
Favor an immutable singleton list over immutable list view.
No What
true
false
1
https://github.com/square/retrofit/commit/f29e29761f9b44e5fbfaf6e37460e6fde88c9a03
Next version will be 1.7.0.
Next version will be 1.7.0.
No What
false
true
0
https://github.com/square/retrofit/commit/46598adb1da0f6d2498d9f8b815b170bf95fe1f8
Use the annotations directly for parameter handling. Before we attempted to normalize the parameter annotations into a name and type model. The introduction of multi-part transfer encodings required something more expressive so the annotation instances themselves were used. This change removes the name and type in favor of using the annotation for everything. Deprecate the pre-encoded annotations in favor of boolean fields on the corresponding 'regular' annotation.
Use the annotations directly for parameter handling. Before we attempted to normalize the parameter annotations into a name and type model. The introduction of multi-part transfer encodings required something more expressive so the annotation instances themselves were used. This change removes the name and type in favor of using the annotation for everything. Deprecate the pre-encoded annotations in favor of boolean fields on the corresponding 'regular' annotation.
Why and What
true
false
1
https://github.com/square/retrofit/commit/42727183bebe8256ccd4acb648e3ad56d8af7b76
Bump Wire dependency.
Bump Wire dependency.
No Why
false
false
null
https://github.com/square/retrofit/commit/3a6b251633bf533751c66594ded8b827ff67c300
Migrate most behavior tests to be whitebox(ish). Eliminate the blackbox inspection into RestMethodInfo and direct invocation of RequestBuilder by combining the two.
Migrate most behavior tests to be whitebox(ish). Eliminate the blackbox inspection into RestMethodInfo and direct invocation of RequestBuilder by combining the two.
No Why
false
false
null
https://github.com/square/retrofit/commit/5795931d159f0a591e5dad3d9de6f8d0e9785413
Add transfer encoding to multipart parts. Also: * Reject multiple annotations on method parameters. * Pre-size StringBuilder instances to their likely size.
Add transfer encoding to multipart parts. Also: * Reject multiple annotations on method parameters. * Pre-size StringBuilder instances to their likely size.
No Why
false
false
null
https://github.com/square/retrofit/commit/cc37ab8d370379fa025395d5256bc7ac068a8980
Bump Guava dependency.
Bump Guava dependency.
No Why
false
true
0
https://github.com/square/retrofit/commit/f986cde7323b8a0656f98de4bc88d14f7d126779
Bump test dependencies.
Bump test dependencies.
No Why
false
true
0
https://github.com/square/retrofit/commit/89daa8ca994ee5cc193dc93849abd7672dc59c1d
Add @Override annotations
Add @Override annotations
Why and What
false
false
null
https://github.com/square/retrofit/commit/fb746cb2f67a51c100e368844ac26dedb9e8eac4
Expose success type on RetrofitError. There's a bit of a test gap going on for all the variants of successful and erroneous handling of sync, async, and rx. This new behavior is fully tested in all three but more general behavior testing for them will be needed in in a follow-up.
Expose success type on RetrofitError. There's a bit of a test gap going on for all the variants of successful and erroneous handling of sync, async, and rx. This new behavior is fully tested in all three but more general behavior testing for them will be needed in in a follow-up.
Why and What
false
false
null
https://github.com/square/retrofit/commit/54c8e17ad51bd35e75009233c3be6cdc3afe310e
Update documentation for handling of @Field and @Part values.
Update documentation for handling of @Field and @Part values.
Why and What
false
false
null
https://github.com/square/retrofit/commit/863030b551bc2e3447c5dde55d6bcc312218de6f
Add docs about null responses.
Add docs about null responses.
Why and What
true
false
1
https://github.com/square/retrofit/commit/17bc62131d9b7ee88277bbc63d2cdb94a25b4a75
add paragraph clarifying logging
add paragraph clarifying logging
No Why
true
false
1
https://github.com/square/retrofit/commit/2d2fa49fc094d8e5c04b06a54b1c09db430ca3b0
Remove synchronous from ErrorHandler docs
Remove synchronous from ErrorHandler docs
Why and What
false
false
null
https://github.com/square/retrofit/commit/07548db79012d3ccacc5d883f3e71d24d0de359a
Add @PartMap annotation.
Add @PartMap annotation.
Why and What
false
false
null
https://github.com/square/retrofit/commit/00f4c420166eb070a035cdd641b7afa101f65602
MockRestAdapter should use ErrorHandler.
MockRestAdapter should use ErrorHandler.
No Why
false
false
null
https://github.com/square/retrofit/commit/05d6797c3c0de7b9abafb9e15491fb61df194100
Use latest release plugin.
Use latest release plugin.
No Why
false
false
null
https://github.com/square/retrofit/commit/990521c87677903cd18841a5454d52bc37bc2985
switch to assertj
switch to assertj
No Why
false
false
null
https://github.com/square/retrofit/commit/dfe5d9eb51352d6cad8ac618e19577525adcab87
Correct map parameter type detection for query and field.
Correct map parameter type detection for query and field.
No Why
false
false
null
https://github.com/square/retrofit/commit/bcfc6ff673a9344172920415a04eaa904a90e78a
Update Jackson converter to latest. Add default constructor.
Update Jackson converter to latest. Add default constructor.
No Why
false
false
null
https://github.com/square/retrofit/commit/18e1dd8a067cd7927b2a7adb3dbdb9019f2cd35f
Prepare version 1.4.0.
Prepare version 1.4.0.
Why and What
false
true
0
https://github.com/square/retrofit/commit/9e93fc566670cde1cf873d92e7a27cdfeff494dd
Add simple package info to root package.
Add simple package info to root package.
No Why
false
true
0
https://github.com/square/retrofit/commit/d7da1cdc2406b88aae75ebfeaca93bbf3c94d505
Retain old parameter type.
Retain old parameter type.
No Why
false
false
null
https://github.com/square/retrofit/commit/810bb53ee4a10fabd2632568b669a35572575347
Style tweaks to new endpoint code.
Style tweaks to new endpoint code.
No Why
false
false
null
https://github.com/square/retrofit/commit/0284a813dbd69be3f13fb60fe3be128379df7a64
RequestBuilder: Support Iterable / Map for @Field
RequestBuilder: Support Iterable / Map for @Field
No Why
false
false
null
https://github.com/square/retrofit/commit/00d3f9070e15e514430e5dbb2aec602547c3c92d
AndroidLog: Added getTag() and logChunk() methods ?for easier subclassing.
AndroidLog: Added getTag() and logChunk() methods ?for easier subclassing.
Why and What
false
false
null
https://github.com/square/retrofit/commit/932f228158e6bea03700f62cda93113c7b9c7a7d
whitespace.
whitespace.
Neither Why nor What
false
true
0
https://github.com/square/retrofit/commit/ed2e8a5b52e933034b74e5aa66bc42862bfd30de
client: Reintroduced deprecated Response constructor
client: Reintroduced deprecated Response constructor
No Why
true
false
1
https://github.com/square/retrofit/commit/985355d26bbe7b0760203c8ff53d7f40c1b09593
client: Added url field to Response class
client: Added url field to Response class
No Why
false
false
null
https://github.com/square/retrofit/commit/3bdad39745db76928fce0f31b3c2a8e8922c40b3
Properly name ignored exception in 'catch' block.
Properly name ignored exception in 'catch' block.
Why and What
true
false
1
https://github.com/square/retrofit/commit/884593d0e46c4eb30dd6e9ac8056bfdc2848345e
Changing Server to implement IServer interface.
Changing Server to implement IServer interface.
No Why
true
false
1
https://github.com/square/retrofit/commit/e8e30931a53393becb20556f579685141e733a19
Add default constructor to SimpleXmlConverter
Add default constructor to SimpleXmlConverter
No Why
false
false
null
https://github.com/square/retrofit/commit/ddebcaa0e0203874f2f84d29b97645bbac51ae28
Add docs for setting Headers with RequestInterceptor
Add docs for setting Headers with RequestInterceptor
Why and What
true
false
1
https://github.com/square/retrofit/commit/1ef130b80bf608d3d33273be02a57455692e84f8
Fix small wording issues in custom converter docs
Fix small wording issues in custom converter docs
Why and What
true
false
1
https://github.com/square/retrofit/commit/497d672e1f3b038d6aa936ddc5498c2679f6ad70
Update custom conversion docs per feedback * Clarify that Gson is just the default converter * Add section on other built-in converters * Add section on implementing your own custom converters
Update custom conversion docs per feedback * Clarify that Gson is just the default converter * Add section on other built-in converters * Add section on implementing your own custom converters
No Why
true
false
1
https://github.com/square/retrofit/commit/8c490570f6ffe3c699ab227fbddbac9de88273c7
Added blurb about GSON documentation
Added blurb about GSON documentation
No Why
false
false
null
https://github.com/square/retrofit/commit/f1d7acb377874a102a5e14eb64a70271975c167a
fixed javadoc
fixed javadoc
No What
false
true
0
https://github.com/square/retrofit/commit/9159571ec483f5b798e85c2ee94673fa1075384c
Last argument should be handled for observable methods
Last argument should be handled for observable methods
No Why
false
false
null
https://github.com/square/retrofit/commit/5590cade0203bebe3d6e900eaee3b66d70ff487a
add support for Observable requests with RxJava Service interface methods may now specify Observable as a return type.
add support for Observable requests with RxJava Service interface methods may now specify Observable as a return type.
No Why
false
false
null
https://github.com/square/retrofit/commit/25c15a7e3fd60f0b581a0ae6b1c2d6beb777b47d
Add some static factory methods to MockHttpException.
Add some static factory methods to MockHttpException.
No Why
false
false
null
https://github.com/square/retrofit/commit/1f0920af8eb159eec3c41f159adb3d790fdff5b8
UserService example in MockRestAdapter should be an interface
UserService example in MockRestAdapter should be an interface
No What
false
false
null