Wrong name

#3
by roelfrenkema - opened

Its a fish eye lens LoRa. Panoramic would be if it produces long strips.

I chose the word panorama as it is commonly used by multiple apps and tools related to spherical panorama rendering. I suppose I could also have called it spherical-panorama-lora (if that is a critical issue, I can rename it)

Under the hood, what the model does is to generate equirectangular images, ie. long strips spanning horizontally (this technical term could be put in the name of the model as well, to precisely reflect the type of data it was trained on - a dataset of equirectangular panoramas - but it felt a bit verbose)

Now you are totally right, a fisheye can be used to take those images! I just think it would be strange to call the model like that when other techniques exist that can also produce equirectangular images without ever using an actual fisheye lens, if you see what I mean (like filming or taking multiple pictures to blend them together into a spherical image using software eg. on an iPhone app).

Its a fish eye lens LoRa. Panoramic would be if it produces long strips.

Not correct.

The author is correct. These are 360 degree rectilinear panoramas ... I have been doing them in real life for over 20 years... :D

This is a great LoRA and you took my idea right from my mind. I had wanted to train Flux using some of my rectilinears but had not done so... I accidently found your lora searching for Flux.1 Dev on Huggingface.

Thank you. I will test and report back my findings.

Cheers!

ComfyUI__00017_.png

Very cool.

Very cool.

Sign up or log in to comment