Add bos token or not?
#33
by
CISCai
- opened
@FrankC0st1e
I see you enabled add_bos_token again in f3e7d16, however this is not enough if the model requires <s> to be prefixed to the conversation, it must also be in the chat template (which it never was, which was why I disabled it in my chat template PR).
In short, if the model indeed needs <s> at the beginning of the conversation you need to add bos_token to the beginning of the chat template too... :)