Remove env variables subprocess call
#4
by
pdufour
- opened
Given that the parent process includes variables like HF_TOKEN, it's safer to not pass in any env variables to the subprocess because there is always the chance that the script could get maliciously modified for instance to extract HF tokens.
Test plan
I tested these changes in my private space and converted a model and saw that it was correctly created.
Nice catch!
I've updated the app.py to contain the changes from the previous PR. I don't see a rebase on main or merge main option for this PR-branch. So I hope that merging it will just work. Let's see!
Felladrin
changed pull request status to
merged