Datasets:

amartyobanerjee

/

github-issues

like 0

{ "login": "rahul-art", "id": 56379013, "node_id": "MDQ6VXNlcjU2Mzc5MDEz", "avatar_url": "https://avatars.githubusercontent.com/u/56379013?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rahul-art", "html_url": "https://github.com/rahul-art", "followers_url": "https://api.github.com/users/rahul-art/followers", "following_url": "https://api.github.com/users/rahul-art/following{/other_user}", "gists_url": "https://api.github.com/users/rahul-art/gists{/gist_id}", "starred_url": "https://api.github.com/users/rahul-art/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rahul-art/subscriptions", "organizations_url": "https://api.github.com/users/rahul-art/orgs", "repos_url": "https://api.github.com/users/rahul-art/repos", "events_url": "https://api.github.com/users/rahul-art/events{/privacy}", "received_events_url": "https://api.github.com/users/rahul-art/received_events", "type": "User", "site_admin": false }

[]

[]

[ "welcome, awesome " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1588/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1588", "html_url": "https://github.com/huggingface/datasets/pull/1588", "diff_url": "https://github.com/huggingface/datasets/pull/1588.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1588.patch", "merged_at": 1608139228000 }

{ "login": "Nilanshrajput", "id": 28673745, "node_id": "MDQ6VXNlcjI4NjczNzQ1", "avatar_url": "https://avatars.githubusercontent.com/u/28673745?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Nilanshrajput", "html_url": "https://github.com/Nilanshrajput", "followers_url": "https://api.github.com/users/Nilanshrajput/followers", "following_url": "https://api.github.com/users/Nilanshrajput/following{/other_user}", "gists_url": "https://api.github.com/users/Nilanshrajput/gists{/gist_id}", "starred_url": "https://api.github.com/users/Nilanshrajput/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Nilanshrajput/subscriptions", "organizations_url": "https://api.github.com/users/Nilanshrajput/orgs", "repos_url": "https://api.github.com/users/Nilanshrajput/repos", "events_url": "https://api.github.com/users/Nilanshrajput/events{/privacy}", "received_events_url": "https://api.github.com/users/Nilanshrajput/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@SBrandeis all checks passing" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1587/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1587", "html_url": "https://github.com/huggingface/datasets/pull/1587", "diff_url": "https://github.com/huggingface/datasets/pull/1587.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1587.patch", "merged_at": 1608221230000 }

{ "login": "dhruvjoshi1998", "id": 32560035, "node_id": "MDQ6VXNlcjMyNTYwMDM1", "avatar_url": "https://avatars.githubusercontent.com/u/32560035?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhruvjoshi1998", "html_url": "https://github.com/dhruvjoshi1998", "followers_url": "https://api.github.com/users/dhruvjoshi1998/followers", "following_url": "https://api.github.com/users/dhruvjoshi1998/following{/other_user}", "gists_url": "https://api.github.com/users/dhruvjoshi1998/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhruvjoshi1998/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhruvjoshi1998/subscriptions", "organizations_url": "https://api.github.com/users/dhruvjoshi1998/orgs", "repos_url": "https://api.github.com/users/dhruvjoshi1998/repos", "events_url": "https://api.github.com/users/dhruvjoshi1998/events{/privacy}", "received_events_url": "https://api.github.com/users/dhruvjoshi1998/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq sorry, this was the only way I was able to fix the pull request ", "@lhoestq Thank you for the feedback. I wondering whether I should be passing an 'id' field in the dictionary since the 'connections' reference the 'id' of the linked messages. This 'id' would just be the same as the id_ that is in the yielded tuple.", "Yes indeed it would be cool to have the ids in the dictionary. This way the dataset can be shuffled and all without losing information about the connections. Can you add it if you don't mind ?", "Thanks :) could you also add the ids in the dictionary since they're useful for the connection links ?", "Thanks !\r\nAlso it looks like the dummy_data.zip were regenerated and are now back to being too big (300KB each).\r\nCan you reduce their sizes ? You can actually just revert to the ones you had before the last commit" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1586/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1586", "html_url": "https://github.com/huggingface/datasets/pull/1586", "diff_url": "https://github.com/huggingface/datasets/pull/1586.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1586.patch", "merged_at": 1611916133000 }

{ "login": "phtephanx", "id": 24647404, "node_id": "MDQ6VXNlcjI0NjQ3NDA0", "avatar_url": "https://avatars.githubusercontent.com/u/24647404?v=4", "gravatar_id": "", "url": "https://api.github.com/users/phtephanx", "html_url": "https://github.com/phtephanx", "followers_url": "https://api.github.com/users/phtephanx/followers", "following_url": "https://api.github.com/users/phtephanx/following{/other_user}", "gists_url": "https://api.github.com/users/phtephanx/gists{/gist_id}", "starred_url": "https://api.github.com/users/phtephanx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/phtephanx/subscriptions", "organizations_url": "https://api.github.com/users/phtephanx/orgs", "repos_url": "https://api.github.com/users/phtephanx/repos", "events_url": "https://api.github.com/users/phtephanx/events{/privacy}", "received_events_url": "https://api.github.com/users/phtephanx/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @phtephanx , the `amazon_polarity` dataset has not been released yet. It will be available in the coming soon v2of `datasets` :) \r\n\r\nYou can still access it now if you want, but you will need to install datasets via the master branch:\r\n`pip install git+https://github.com/huggingface/datasets.git@master`" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1585/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rahul-art", "id": 56379013, "node_id": "MDQ6VXNlcjU2Mzc5MDEz", "avatar_url": "https://avatars.githubusercontent.com/u/56379013?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rahul-art", "html_url": "https://github.com/rahul-art", "followers_url": "https://api.github.com/users/rahul-art/followers", "following_url": "https://api.github.com/users/rahul-art/following{/other_user}", "gists_url": "https://api.github.com/users/rahul-art/gists{/gist_id}", "starred_url": "https://api.github.com/users/rahul-art/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rahul-art/subscriptions", "organizations_url": "https://api.github.com/users/rahul-art/orgs", "repos_url": "https://api.github.com/users/rahul-art/repos", "events_url": "https://api.github.com/users/rahul-art/events{/privacy}", "received_events_url": "https://api.github.com/users/rahul-art/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1584/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1584", "html_url": "https://github.com/huggingface/datasets/pull/1584", "diff_url": "https://github.com/huggingface/datasets/pull/1584.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1584.patch", "merged_at": null }

{ "login": "Fraser-Greenlee", "id": 8402500, "node_id": "MDQ6VXNlcjg0MDI1MDA=", "avatar_url": "https://avatars.githubusercontent.com/u/8402500?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Fraser-Greenlee", "html_url": "https://github.com/Fraser-Greenlee", "followers_url": "https://api.github.com/users/Fraser-Greenlee/followers", "following_url": "https://api.github.com/users/Fraser-Greenlee/following{/other_user}", "gists_url": "https://api.github.com/users/Fraser-Greenlee/gists{/gist_id}", "starred_url": "https://api.github.com/users/Fraser-Greenlee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Fraser-Greenlee/subscriptions", "organizations_url": "https://api.github.com/users/Fraser-Greenlee/orgs", "repos_url": "https://api.github.com/users/Fraser-Greenlee/repos", "events_url": "https://api.github.com/users/Fraser-Greenlee/events{/privacy}", "received_events_url": "https://api.github.com/users/Fraser-Greenlee/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1583/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1583", "html_url": "https://github.com/huggingface/datasets/pull/1583", "diff_url": "https://github.com/huggingface/datasets/pull/1583.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1583.patch", "merged_at": 1608316746000 }

{ "login": "katnoria", "id": 7674948, "node_id": "MDQ6VXNlcjc2NzQ5NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/7674948?v=4", "gravatar_id": "", "url": "https://api.github.com/users/katnoria", "html_url": "https://github.com/katnoria", "followers_url": "https://api.github.com/users/katnoria/followers", "following_url": "https://api.github.com/users/katnoria/following{/other_user}", "gists_url": "https://api.github.com/users/katnoria/gists{/gist_id}", "starred_url": "https://api.github.com/users/katnoria/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/katnoria/subscriptions", "organizations_url": "https://api.github.com/users/katnoria/orgs", "repos_url": "https://api.github.com/users/katnoria/repos", "events_url": "https://api.github.com/users/katnoria/events{/privacy}", "received_events_url": "https://api.github.com/users/katnoria/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1582/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1582", "html_url": "https://github.com/huggingface/datasets/pull/1582", "diff_url": "https://github.com/huggingface/datasets/pull/1582.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1582.patch", "merged_at": 1608228405000 }

{ "login": "eduardofv", "id": 702586, "node_id": "MDQ6VXNlcjcwMjU4Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/702586?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eduardofv", "html_url": "https://github.com/eduardofv", "followers_url": "https://api.github.com/users/eduardofv/followers", "following_url": "https://api.github.com/users/eduardofv/following{/other_user}", "gists_url": "https://api.github.com/users/eduardofv/gists{/gist_id}", "starred_url": "https://api.github.com/users/eduardofv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eduardofv/subscriptions", "organizations_url": "https://api.github.com/users/eduardofv/orgs", "repos_url": "https://api.github.com/users/eduardofv/repos", "events_url": "https://api.github.com/users/eduardofv/events{/privacy}", "received_events_url": "https://api.github.com/users/eduardofv/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for reporting !\r\nYou can override the directory in which cache file are stored using for example\r\n```\r\nENV HF_HOME=\"/root/cache/hf_cache_home\"\r\n```\r\n\r\nThis way both `transformers` and `datasets` will use this directory instead of the default `.cache`", "Great, thanks. I didn't see documentation about than ENV variable, looks like an obvious solution. ", "> Thanks for reporting !\r\n> You can override the directory in which cache file are stored using for example\r\n> \r\n> ```\r\n> ENV HF_HOME=\"/root/cache/hf_cache_home\"\r\n> ```\r\n> \r\n> This way both `transformers` and `datasets` will use this directory instead of the default `.cache`\r\n\r\ncan we disable caching directly?", "Hi ! Unfortunately no since we need this directory to load datasets.\r\nWhen you load a dataset, it downloads the raw data files in the cache directory inside <cache_dir>/downloads. Then it builds the dataset and saves it as arrow data inside <cache_dir>/<dataset_name>.\r\n\r\nHowever you can specify the directory of your choice, and it can be a temporary directory if you want to clean everything up at one point.", "I'm closing this to keep issues a bit cleaner" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1581/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "MisbahKhan789", "id": 15351802, "node_id": "MDQ6VXNlcjE1MzUxODAy", "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MisbahKhan789", "html_url": "https://github.com/MisbahKhan789", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1580/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1580", "html_url": "https://github.com/huggingface/datasets/pull/1580", "diff_url": "https://github.com/huggingface/datasets/pull/1580.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1580.patch", "merged_at": 1608114472000 }

{ "login": "tdiggelm", "id": 1658969, "node_id": "MDQ6VXNlcjE2NTg5Njk=", "avatar_url": "https://avatars.githubusercontent.com/u/1658969?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tdiggelm", "html_url": "https://github.com/tdiggelm", "followers_url": "https://api.github.com/users/tdiggelm/followers", "following_url": "https://api.github.com/users/tdiggelm/following{/other_user}", "gists_url": "https://api.github.com/users/tdiggelm/gists{/gist_id}", "starred_url": "https://api.github.com/users/tdiggelm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tdiggelm/subscriptions", "organizations_url": "https://api.github.com/users/tdiggelm/orgs", "repos_url": "https://api.github.com/users/tdiggelm/repos", "events_url": "https://api.github.com/users/tdiggelm/events{/privacy}", "received_events_url": "https://api.github.com/users/tdiggelm/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I `git rebase`ed my branch to `upstream/master` as suggested in point 7 of <https://huggingface.co/docs/datasets/share_dataset.html> and subsequently used `git pull` to be able to push to my remote branch. However, I think this messed up the history.\r\n\r\nPlease let me know if I should create a clean new PR with my changes.\r\n\r\nUpdate: I also fixed the dataset name in the Dataset Card.", "Dear @SBrandeis , @lhoestq . I am not sure how to fix the PR with respect to the additional files that are currently included in the commits. Could you provide me with an example? Otherwise I would be happy to close/re-open another PR. Please let me know if anything is missing for the review.", "Hi @tdiggelm, thanks for the contribution! This dataset is really awesome.\r\nI believe creating a new branch from master and opening a new PR with your changes is the simplest option since no review has been done yet. Feel free to ping us when it's done.", "> Hi @tdiggelm, thanks for the contribution! This dataset is really awesome.\r\n> I believe creating a new branch from master and opening a new PR with your changes is the simplest option since no review has been done yet. Feel free to ping us when it's done.\r\n\r\nThank you very much for your quick reply! Will do ASAP and ping you when done.", "closing in favor of #1623" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1579/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1579", "html_url": "https://github.com/huggingface/datasets/pull/1579", "diff_url": "https://github.com/huggingface/datasets/pull/1579.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1579.patch", "merged_at": null }

{ "login": "yjernite", "id": 10469459, "node_id": "MDQ6VXNlcjEwNDY5NDU5", "avatar_url": "https://avatars.githubusercontent.com/u/10469459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yjernite", "html_url": "https://github.com/yjernite", "followers_url": "https://api.github.com/users/yjernite/followers", "following_url": "https://api.github.com/users/yjernite/following{/other_user}", "gists_url": "https://api.github.com/users/yjernite/gists{/gist_id}", "starred_url": "https://api.github.com/users/yjernite/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yjernite/subscriptions", "organizations_url": "https://api.github.com/users/yjernite/orgs", "repos_url": "https://api.github.com/users/yjernite/repos", "events_url": "https://api.github.com/users/yjernite/events{/privacy}", "received_events_url": "https://api.github.com/users/yjernite/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1578/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1578", "html_url": "https://github.com/huggingface/datasets/pull/1578", "diff_url": "https://github.com/huggingface/datasets/pull/1578.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1578.patch", "merged_at": 1608051989000 }

{ "login": "ricardorei", "id": 17256847, "node_id": "MDQ6VXNlcjE3MjU2ODQ3", "avatar_url": "https://avatars.githubusercontent.com/u/17256847?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ricardorei", "html_url": "https://github.com/ricardorei", "followers_url": "https://api.github.com/users/ricardorei/followers", "following_url": "https://api.github.com/users/ricardorei/following{/other_user}", "gists_url": "https://api.github.com/users/ricardorei/gists{/gist_id}", "starred_url": "https://api.github.com/users/ricardorei/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ricardorei/subscriptions", "organizations_url": "https://api.github.com/users/ricardorei/orgs", "repos_url": "https://api.github.com/users/ricardorei/repos", "events_url": "https://api.github.com/users/ricardorei/events{/privacy}", "received_events_url": "https://api.github.com/users/ricardorei/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I also thought a bit about the fact that \"sources\" can't be added to the batch.. but changing that would require a lot more changes. And I agree that the idea of adding them as part of the references is not ideal. Conceptually they are not references.\r\n\r\nI would keep it like this for now.. And in the future, work on a more consistent batch interface." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1577/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 2, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1577", "html_url": "https://github.com/huggingface/datasets/pull/1577", "diff_url": "https://github.com/huggingface/datasets/pull/1577.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1577.patch", "merged_at": 1610631190000 }

{ "login": "clmnt", "id": 821155, "node_id": "MDQ6VXNlcjgyMTE1NQ==", "avatar_url": "https://avatars.githubusercontent.com/u/821155?v=4", "gravatar_id": "", "url": "https://api.github.com/users/clmnt", "html_url": "https://github.com/clmnt", "followers_url": "https://api.github.com/users/clmnt/followers", "following_url": "https://api.github.com/users/clmnt/following{/other_user}", "gists_url": "https://api.github.com/users/clmnt/gists{/gist_id}", "starred_url": "https://api.github.com/users/clmnt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clmnt/subscriptions", "organizations_url": "https://api.github.com/users/clmnt/orgs", "repos_url": "https://api.github.com/users/clmnt/repos", "events_url": "https://api.github.com/users/clmnt/events{/privacy}", "received_events_url": "https://api.github.com/users/clmnt/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1576/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1576", "html_url": "https://github.com/huggingface/datasets/pull/1576", "diff_url": "https://github.com/huggingface/datasets/pull/1576.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1576.patch", "merged_at": 1608036826000 }

{ "login": "rahul-art", "id": 56379013, "node_id": "MDQ6VXNlcjU2Mzc5MDEz", "avatar_url": "https://avatars.githubusercontent.com/u/56379013?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rahul-art", "html_url": "https://github.com/rahul-art", "followers_url": "https://api.github.com/users/rahul-art/followers", "following_url": "https://api.github.com/users/rahul-art/following{/other_user}", "gists_url": "https://api.github.com/users/rahul-art/gists{/gist_id}", "starred_url": "https://api.github.com/users/rahul-art/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rahul-art/subscriptions", "organizations_url": "https://api.github.com/users/rahul-art/orgs", "repos_url": "https://api.github.com/users/rahul-art/repos", "events_url": "https://api.github.com/users/rahul-art/events{/privacy}", "received_events_url": "https://api.github.com/users/rahul-art/received_events", "type": "User", "site_admin": false }

[]

[]

[ "ALL TEST PASSED locally @yjernite ", "@rahul-art kindly run the following from the datasets folder \r\n\r\n```\r\nmake style \r\nflake8 datasets\r\n\r\n```\r\n", "@skyprince999 I did that before it says all done \r\n", "I did that again it gives the same output all done and then I synchronized my changes with this branch ", "@lhoestq i did all the changes you suggested but at the time of load_dataset it is giving me error\r\n`**`datasets.utils.info_utils.NonMatchingSplitsSizesError: [{'expected': SplitInfo(name='train', num_bytes=76591256, num_examples=1, dataset_name='hind_encorp'), 'recorded': SplitInfo(name='train', num_bytes=78945714, num_examples=273885, dataset_name='hind_encorp')}]`**`", "\r\n\r\n\r\nI cloned the branch and it seems to work fine at my end. try to clear the cache - \r\n\r\n```\r\nrm -rf /home/ubuntu/.cache/huggingface/datasets/\r\nrm -rf /home/ubuntu/.cache/huggingface/modules/datasets_modules//datasets/\r\n```\r\nBut the dataset has only one record. Is that correct? \r\n\r\n", "> @lhoestq i did all the changes you suggested but at the time of load_dataset it is giving me error\r\n> `**`datasets.utils.info_utils.NonMatchingSplitsSizesError: [{'expected': SplitInfo(name='train', num_bytes=76591256, num_examples=1, dataset_name='hind_encorp'), 'recorded': SplitInfo(name='train', num_bytes=78945714, num_examples=273885, dataset_name='hind_encorp')}]`**`\r\n\r\nYou can ignore this error by adding `ignore_verifications=True` to `load_dataset`.\r\n\r\nThis error is raised because you're loading a dataset that you've already loaded once in the past. Therefore the library does some verifications to make sure it's generated the same way. \r\n\r\nHowever since you've done changes in the dataset script you should ignore these verifications.\r\n\r\nYou can regenerate the dataset_infos.json with\r\n```\r\ndatasets-cli test ./datasets/hindi_encorp --save_infos --all_configs --ignore_verifications\r\n```\r\n\r\n\r\n> I cloned the branch and it seems to work fine at my end. try to clear the cache -\r\n> \r\n> ```\r\n> rm -rf /home/ubuntu/.cache/huggingface/datasets/\r\n> rm -rf /home/ubuntu/.cache/huggingface/modules/datasets_modules//datasets/\r\n> ```\r\n> \r\n> But the dataset has only one record. Is that correct?\r\n> \r\n\r\nYes the current parsing is wrong, I've already given @rahul-art some suggestions and it looks like it works way better now (num_examples=273885).\r\n\r\nThanks for fixing the parsing @rahul-art !\r\nFeel free to commit and push your changes once it's ready :) ", "i ran the command you provided datasets-cli test ./datasets/hindi_encorp --save_infos --all_configs --ignore_verifications \r\nbut now its giving this error @lhoestq \r\n\r\nFileNotFoundError: Couldn't find file locally at ./datasets/hindi_encorp/hindi_encorp.py, or remotely at https://raw.githubusercontent.com/huggingface/datasets/master/datasets/./datasets/hindi_encorp/hindi_encorp.py or https://s3.amazonaws.com/datasets.huggingface.co/datasets/datasets/./datasets/hindi_encorp/hindi_encorp.py.\r\nIf the dataset was added recently, you may need to to pass script_version=\"master\" to find the loading script on the master branch.\r\n", "whoops I meant `hind_encorp` instead of `hindi_encorp` sorry", "@lhoestq all changes have done successfully in this PR #1584", "Ok thanks ! closing this one in favor of #1584 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1575/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1575", "html_url": "https://github.com/huggingface/datasets/pull/1575", "diff_url": "https://github.com/huggingface/datasets/pull/1575.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1575.patch", "merged_at": null }

{ "login": "MisbahKhan789", "id": 15351802, "node_id": "MDQ6VXNlcjE1MzUxODAy", "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MisbahKhan789", "html_url": "https://github.com/MisbahKhan789", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1574/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1574", "html_url": "https://github.com/huggingface/datasets/pull/1574", "diff_url": "https://github.com/huggingface/datasets/pull/1574.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1574.patch", "merged_at": null }

{ "login": "MisbahKhan789", "id": 15351802, "node_id": "MDQ6VXNlcjE1MzUxODAy", "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MisbahKhan789", "html_url": "https://github.com/MisbahKhan789", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1573/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1573", "html_url": "https://github.com/huggingface/datasets/pull/1573", "diff_url": "https://github.com/huggingface/datasets/pull/1573.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1573.patch", "merged_at": null }

{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1572/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1572", "html_url": "https://github.com/huggingface/datasets/pull/1572", "diff_url": "https://github.com/huggingface/datasets/pull/1572.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1572.patch", "merged_at": 1608137550000 }

{ "login": "yjernite", "id": 10469459, "node_id": "MDQ6VXNlcjEwNDY5NDU5", "avatar_url": "https://avatars.githubusercontent.com/u/10469459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yjernite", "html_url": "https://github.com/yjernite", "followers_url": "https://api.github.com/users/yjernite/followers", "following_url": "https://api.github.com/users/yjernite/following{/other_user}", "gists_url": "https://api.github.com/users/yjernite/gists{/gist_id}", "starred_url": "https://api.github.com/users/yjernite/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yjernite/subscriptions", "organizations_url": "https://api.github.com/users/yjernite/orgs", "repos_url": "https://api.github.com/users/yjernite/repos", "events_url": "https://api.github.com/users/yjernite/events{/privacy}", "received_events_url": "https://api.github.com/users/yjernite/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1571/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1571", "html_url": "https://github.com/huggingface/datasets/pull/1571", "diff_url": "https://github.com/huggingface/datasets/pull/1571.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1571.patch", "merged_at": 1607987261000 }

{ "login": "onurgu", "id": 56893, "node_id": "MDQ6VXNlcjU2ODkz", "avatar_url": "https://avatars.githubusercontent.com/u/56893?v=4", "gravatar_id": "", "url": "https://api.github.com/users/onurgu", "html_url": "https://github.com/onurgu", "followers_url": "https://api.github.com/users/onurgu/followers", "following_url": "https://api.github.com/users/onurgu/following{/other_user}", "gists_url": "https://api.github.com/users/onurgu/gists{/gist_id}", "starred_url": "https://api.github.com/users/onurgu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/onurgu/subscriptions", "organizations_url": "https://api.github.com/users/onurgu/orgs", "repos_url": "https://api.github.com/users/onurgu/repos", "events_url": "https://api.github.com/users/onurgu/events{/privacy}", "received_events_url": "https://api.github.com/users/onurgu/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1570/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1570", "html_url": "https://github.com/huggingface/datasets/pull/1570", "diff_url": "https://github.com/huggingface/datasets/pull/1570.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1570.patch", "merged_at": 1608558429000 }

{ "login": "param087", "id": 26374564, "node_id": "MDQ6VXNlcjI2Mzc0NTY0", "avatar_url": "https://avatars.githubusercontent.com/u/26374564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/param087", "html_url": "https://github.com/param087", "followers_url": "https://api.github.com/users/param087/followers", "following_url": "https://api.github.com/users/param087/following{/other_user}", "gists_url": "https://api.github.com/users/param087/gists{/gist_id}", "starred_url": "https://api.github.com/users/param087/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/param087/subscriptions", "organizations_url": "https://api.github.com/users/param087/orgs", "repos_url": "https://api.github.com/users/param087/repos", "events_url": "https://api.github.com/users/param087/events{/privacy}", "received_events_url": "https://api.github.com/users/param087/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1569/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1569", "html_url": "https://github.com/huggingface/datasets/pull/1569", "diff_url": "https://github.com/huggingface/datasets/pull/1569.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1569.patch", "merged_at": 1608046138000 }

{ "login": "tsvm", "id": 1083319, "node_id": "MDQ6VXNlcjEwODMzMTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1083319?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tsvm", "html_url": "https://github.com/tsvm", "followers_url": "https://api.github.com/users/tsvm/followers", "following_url": "https://api.github.com/users/tsvm/following{/other_user}", "gists_url": "https://api.github.com/users/tsvm/gists{/gist_id}", "starred_url": "https://api.github.com/users/tsvm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tsvm/subscriptions", "organizations_url": "https://api.github.com/users/tsvm/orgs", "repos_url": "https://api.github.com/users/tsvm/repos", "events_url": "https://api.github.com/users/tsvm/events{/privacy}", "received_events_url": "https://api.github.com/users/tsvm/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @tsvm Great work! \r\nSince you have raised a clean PR could you close the earlier one - #1445 ? \r\n", "> Hi @tsvm Great work!\r\n> Since you have raised a clean PR could you close the earlier one - #1445 ?\r\n\r\nDone." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1568/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1568", "html_url": "https://github.com/huggingface/datasets/pull/1568", "diff_url": "https://github.com/huggingface/datasets/pull/1568.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1568.patch", "merged_at": 1608056936000 }

{ "login": "thomwolf", "id": 7353373, "node_id": "MDQ6VXNlcjczNTMzNzM=", "avatar_url": "https://avatars.githubusercontent.com/u/7353373?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomwolf", "html_url": "https://github.com/thomwolf", "followers_url": "https://api.github.com/users/thomwolf/followers", "following_url": "https://api.github.com/users/thomwolf/following{/other_user}", "gists_url": "https://api.github.com/users/thomwolf/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomwolf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomwolf/subscriptions", "organizations_url": "https://api.github.com/users/thomwolf/orgs", "repos_url": "https://api.github.com/users/thomwolf/repos", "events_url": "https://api.github.com/users/thomwolf/events{/privacy}", "received_events_url": "https://api.github.com/users/thomwolf/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1567/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1567", "html_url": "https://github.com/huggingface/datasets/pull/1567", "diff_url": "https://github.com/huggingface/datasets/pull/1567.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1567.patch", "merged_at": 1608036846000 }

{ "login": "mattbui", "id": 46804938, "node_id": "MDQ6VXNlcjQ2ODA0OTM4", "avatar_url": "https://avatars.githubusercontent.com/u/46804938?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mattbui", "html_url": "https://github.com/mattbui", "followers_url": "https://api.github.com/users/mattbui/followers", "following_url": "https://api.github.com/users/mattbui/following{/other_user}", "gists_url": "https://api.github.com/users/mattbui/gists{/gist_id}", "starred_url": "https://api.github.com/users/mattbui/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mattbui/subscriptions", "organizations_url": "https://api.github.com/users/mattbui/orgs", "repos_url": "https://api.github.com/users/mattbui/repos", "events_url": "https://api.github.com/users/mattbui/events{/privacy}", "received_events_url": "https://api.github.com/users/mattbui/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I proposed something a few weeks ago in #898 (un-merged) but I think that the way that @mattbui added the dataset in the present PR is smarter and simpler should replace my PR #898.\r\n\r\n(Narrator voice: *And it was around that time that Thomas realized that the community was now a lot smarter than him and he should hand-over the library he had started with @lhoestq to the community and stop pretending he knew everything about it.*)" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1566/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1566", "html_url": "https://github.com/huggingface/datasets/pull/1566", "diff_url": "https://github.com/huggingface/datasets/pull/1566.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1566.patch", "merged_at": 1608045862000 }

{ "login": "ManuelFay", "id": 43467008, "node_id": "MDQ6VXNlcjQzNDY3MDA4", "avatar_url": "https://avatars.githubusercontent.com/u/43467008?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ManuelFay", "html_url": "https://github.com/ManuelFay", "followers_url": "https://api.github.com/users/ManuelFay/followers", "following_url": "https://api.github.com/users/ManuelFay/following{/other_user}", "gists_url": "https://api.github.com/users/ManuelFay/gists{/gist_id}", "starred_url": "https://api.github.com/users/ManuelFay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ManuelFay/subscriptions", "organizations_url": "https://api.github.com/users/ManuelFay/orgs", "repos_url": "https://api.github.com/users/ManuelFay/repos", "events_url": "https://api.github.com/users/ManuelFay/events{/privacy}", "received_events_url": "https://api.github.com/users/ManuelFay/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@ManuelFay thanks you so much for adding a dataset card, this is such a cool contribution!\r\n\r\nThis looks like it uses an old template for the card we've moved things around a bit and we have an app you should be using to get the tags and the structure of the Data Fields paragraph :) Would you mind moving your text to the newer format (we're also asking contributors to keep the full template structure, even if some sections still have [More Information Needed] for the time being)\r\n\r\nHere's the link to the instructions:\r\nhttps://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md#tag-the-dataset-and-write-the-dataset-card\r\n\r\nOut of curiosity, what was your landing point for filling out the card? Did you follow the \"Update on Github\" when navigating the datasets? Trying to make the instructions as clear as possible :) ", "@yjernite \r\n\r\nPerfect, I'll follow the instructions when I have a bit more time tomorrow ! I was actually browsing the new contributions after the dataset sprint and realized most of the \"old\" datasets were not tagged, so I just copied and pasted the readme from another dataset and was not aware there was precise instructions... Will fix !\r\n\r\nBTW, amazing job with the retriBert work, I used the contrastive + in-batch negative quite a bit for various projects. Probably neither the time nor place to talk about that but I was curious as to why, in your original work, you prefered using a simple projection in the last layer to differentiate the question vs answer embedding, rather than allowing for bias in the dense layer or even just to fine-tune 2 different embedders for question + answer ? ", "Cool! Looking forward to the next version!\r\n\r\nQuick answer for retriBERT is that I expected a simple projection to generalize better and more importantly only having to store the gradients for the proj means training with larger batches :) If you want to keep chatting about it, feel free to send me an email!", "Hi @ManuelFay ! \r\nIf you're still interested in completing the FQuAD dataset card, note that we've generated one that is pre-filled.\r\nTherefore feel free to complete it with the content you already have in your README.md.\r\nThis would be awesome ! And thanks again for your contribution :)", "Yo @lhoestq , just not sure about the tag table at the top, I used @yjernite eli5 template so hope it's okay ! Also want to signal the streamlit app for dataset tagging has a weird behavior with the size categories when filling in the form. \r\n\r\nThanks to you guys for doing that and sorry about the time it took, i completely forgot about it ! \r\n" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1565/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1565", "html_url": "https://github.com/huggingface/datasets/pull/1565", "diff_url": "https://github.com/huggingface/datasets/pull/1565.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1565.patch", "merged_at": 1616680909000 }

{ "login": "abdulelahsm", "id": 28743265, "node_id": "MDQ6VXNlcjI4NzQzMjY1", "avatar_url": "https://avatars.githubusercontent.com/u/28743265?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abdulelahsm", "html_url": "https://github.com/abdulelahsm", "followers_url": "https://api.github.com/users/abdulelahsm/followers", "following_url": "https://api.github.com/users/abdulelahsm/following{/other_user}", "gists_url": "https://api.github.com/users/abdulelahsm/gists{/gist_id}", "starred_url": "https://api.github.com/users/abdulelahsm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abdulelahsm/subscriptions", "organizations_url": "https://api.github.com/users/abdulelahsm/orgs", "repos_url": "https://api.github.com/users/abdulelahsm/repos", "events_url": "https://api.github.com/users/abdulelahsm/events{/privacy}", "received_events_url": "https://api.github.com/users/abdulelahsm/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @abdulelahsm - This is an interesting dataset! But there are multiple issues with the PR. Some of them are listed below: \r\n- default builder config is not defined. There should be atleast one builder config \r\n- URL is incorrectly constructed so the data files are not being downloaded \r\n- dataset_info.json file was not created\r\n\r\nPlease have a look at some existing merged datasets to get a reference on building the data loader. If you are still stuck, reach out. \r\n", "@skyprince999 I totally agree. Thx for the feedback!", "Hi @abdulelahsm ! Thanks for adding this one :) \r\nyou don't actually have to add builder configurations if you don't need them. It's fine as it is now\r\n\r\nAnd as @skyprince999 noticed, the current URLs don't work. to download files.\r\nYou can use this one for example for the first batch instead:\r\nhttps://github.com/parallelfold/SaudiNewsNet/raw/master/dataset/2015-07-21.zip\r\n\r\nFeel free to ping me if you have questions or if you're ready for a review :) ", "@lhoestq Hey, I tried using the first batch instead, the data was downloaded but I got this error, not sure why it can't find the path?\r\n\r\nfor content, I ran ``` \"./datasets/saudinewsnet/test.py\"```\r\n\r\nwhich is a local test I'm running for the dataset, it contains the following code\r\n\r\n```\r\nfrom datasets import load_dataset\r\n\r\ndata = load_dataset(\"./datasets/saudinewsnet\", split= \"train\")\r\n\r\nprint(data)\r\n\r\nprint(data[1])\r\n```\r\n\r\nthis is the error I got \r\n\r\n```\r\n2020-12-18 21:45:39.403908: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory\r\n2020-12-18 21:45:39.403953: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.\r\nUsing custom data configuration default\r\nDownloading and preparing dataset saudi_news_net/default (download: Unknown size, generated: Unknown size, post-processed: Unknown size, total: Unknown size) to /home/mesfas/.cache/huggingface/datasets/saudi_news_net/default/0.0.0/62ece5ef0a991415352d4b1efac681d75b5b3404064fd4f6a1d659499dab18f4...\r\nDownloading: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3.42M/3.42M [00:03<00:00, 1.03MB/s]\r\nTraceback (most recent call last):\r\n File \"/home/mesfas/opensource/datasets/src/datasets/builder.py\", line 604, in _download_and_prepare\r\n self._prepare_split(split_generator, **prepare_split_kwargs)\r\n File \"/home/mesfas/opensource/datasets/src/datasets/builder.py\", line 902, in _prepare_split\r\n for key, record in utils.tqdm(\r\n File \"/home/mesfas/environments/ar_res_reviews/lib/python3.8/site-packages/tqdm/std.py\", line 1133, in __iter__\r\n for obj in iterable:\r\n File \"/home/mesfas/.cache/huggingface/modules/datasets_modules/datasets/saudinewsnet/62ece5ef0a991415352d4b1efac681d75b5b3404064fd4f6a1d659499dab18f4/saudinewsnet.py\", line 108, in _generate_examples\r\n with open(filepath, encoding=\"utf-8\").read() as f:\r\nIsADirectoryError: [Errno 21] Is a directory: '/home/mesfas/.cache/huggingface/datasets/downloads/extracted/314fd983aa07d3dada9429911a805270c3285f48759d3584a1343c2d86260765'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n File \"./datasets/saudinewsnet/test.py\", line 3, in <module>\r\n data = load_dataset(\"./datasets/saudinewsnet\", split= \"train\")\r\n File \"/home/mesfas/opensource/datasets/src/datasets/load.py\", line 607, in load_dataset\r\n builder_instance.download_and_prepare(\r\n File \"/home/mesfas/opensource/datasets/src/datasets/builder.py\", line 526, in download_and_prepare\r\n self._download_and_prepare(\r\n File \"/home/mesfas/opensource/datasets/src/datasets/builder.py\", line 606, in _download_and_prepare\r\n raise OSError(\r\nOSError: Cannot find data file. \r\nOriginal error:\r\n[Errno 21] Is a directory: '/home/mesfas/.cache/huggingface/datasets/downloads/extracted/314fd983aa07d3dada9429911a805270c3285f48759d3584a1343c2d86260765'\r\n```\r\n\r\n\r\nthis is the split code \r\n\r\n```\r\n def _split_generators(self, dl_manager):\r\n \"\"\"Returns SplitGenerators.\"\"\"\r\n my_urls = _URL\r\n datadir = dl_manager.download_and_extract(my_urls)\r\n return [\r\n datasets.SplitGenerator(\r\n name=datasets.Split.TRAIN,\r\n # These kwargs will be passed to _generate_examples\r\n gen_kwargs={\r\n \"filepath\": datadir,\r\n \"split\": \"train\"\r\n },\r\n ),\r\n ]\r\n```\r\nand this is how I'm generating the examples\r\n\r\n```\r\n def _generate_examples(self, filepath, split):\r\n \r\n #logging.info(\"generating examples from = %s\", filepath)\r\n with open(filepath, encoding=\"utf-8\") as f:\r\n articles = json.load(f)\r\n for article in articles:\r\n title = article.get(\"title\", \"\").strip()\r\n source = article.get(\"source\", \"\").strip()\r\n date = article.get(\"date_extracted\", \"\").strip()\r\n link = article.get(\"url\", \"\").strip()\r\n author = article.get(\"author\", \"\").strip()\r\n content = article.get(\"content\", \"\").strip()\r\n\r\n yield id_, {\r\n \"title\": title,\r\n \"source\": source,\r\n \"date\": date,\r\n \"link\": link,\r\n \"author\": author,\r\n \"content\": content\r\n }\r\n```", "What's `_URL` ?\r\n\r\nIt looks like you are downloading an archive.\r\nTherefore you may need to get to the file path using `filepath = os.path.join(datadir, \"actual_file_name_inside_the_downloaded_archive\")`", "@lhoestq you were 100% right. Thank you. All fixed", "@lhoestq ping!", "@lhoestq added the remaining 17 batches and modified the readme.md to reflect that + resolved the camel case comment", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1564/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1564", "html_url": "https://github.com/huggingface/datasets/pull/1564", "diff_url": "https://github.com/huggingface/datasets/pull/1564.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1564.patch", "merged_at": 1608630664000 }

{ "login": "forest1988", "id": 2755894, "node_id": "MDQ6VXNlcjI3NTU4OTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/2755894?v=4", "gravatar_id": "", "url": "https://api.github.com/users/forest1988", "html_url": "https://github.com/forest1988", "followers_url": "https://api.github.com/users/forest1988/followers", "following_url": "https://api.github.com/users/forest1988/following{/other_user}", "gists_url": "https://api.github.com/users/forest1988/gists{/gist_id}", "starred_url": "https://api.github.com/users/forest1988/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/forest1988/subscriptions", "organizations_url": "https://api.github.com/users/forest1988/orgs", "repos_url": "https://api.github.com/users/forest1988/repos", "events_url": "https://api.github.com/users/forest1988/events{/privacy}", "received_events_url": "https://api.github.com/users/forest1988/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Thank you for your code review! I think I could do the necessary corrections. Could you please check it again when you have time?", "Thank you for merging!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1563/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1563", "html_url": "https://github.com/huggingface/datasets/pull/1563", "diff_url": "https://github.com/huggingface/datasets/pull/1563.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1563.patch", "merged_at": 1608545233000 }

{ "login": "arkhalid", "id": 14899066, "node_id": "MDQ6VXNlcjE0ODk5MDY2", "avatar_url": "https://avatars.githubusercontent.com/u/14899066?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arkhalid", "html_url": "https://github.com/arkhalid", "followers_url": "https://api.github.com/users/arkhalid/followers", "following_url": "https://api.github.com/users/arkhalid/following{/other_user}", "gists_url": "https://api.github.com/users/arkhalid/gists{/gist_id}", "starred_url": "https://api.github.com/users/arkhalid/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arkhalid/subscriptions", "organizations_url": "https://api.github.com/users/arkhalid/orgs", "repos_url": "https://api.github.com/users/arkhalid/repos", "events_url": "https://api.github.com/users/arkhalid/events{/privacy}", "received_events_url": "https://api.github.com/users/arkhalid/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Just a small revision from simon's review: 20KB for the dummy_data.zip is fine, you can keep them this way.", "Also the CI is failing because of an error `tests/test_file_utils.py::TempSeedTest::test_tensorflow` that is not related to your dataset and is fixed on master. You can ignore it", "merging since the Ci is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1562/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1562", "html_url": "https://github.com/huggingface/datasets/pull/1562", "diff_url": "https://github.com/huggingface/datasets/pull/1562.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1562.patch", "merged_at": 1608556486000 }

{ "login": "ontocord", "id": 8900094, "node_id": "MDQ6VXNlcjg5MDAwOTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8900094?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ontocord", "html_url": "https://github.com/ontocord", "followers_url": "https://api.github.com/users/ontocord/followers", "following_url": "https://api.github.com/users/ontocord/following{/other_user}", "gists_url": "https://api.github.com/users/ontocord/gists{/gist_id}", "starred_url": "https://api.github.com/users/ontocord/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ontocord/subscriptions", "organizations_url": "https://api.github.com/users/ontocord/orgs", "repos_url": "https://api.github.com/users/ontocord/repos", "events_url": "https://api.github.com/users/ontocord/events{/privacy}", "received_events_url": "https://api.github.com/users/ontocord/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Let me know why the pyarrow test is failing. For one of the config \"trex\", I had to load an initial datafile for a dictionary which is used to augment the rest of the datasets. In the dummy data, the dictionary file was truncated so I had to fudge that. I'm not sure if that is the issue.\r\n", "@ontocord it just needs a rerun and it will be good to go.", "THanks @tanmoyio. How do I do a rerun?", "@ontocord contributor can’t rerun it, the maintainers will rerun it, it may take lil bit of time as there are so many PRs left to be reviewed and merged ", "@lhoestq not sure why it is failing. i've made all modifications. ", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1561/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1561", "html_url": "https://github.com/huggingface/datasets/pull/1561", "diff_url": "https://github.com/huggingface/datasets/pull/1561.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1561.patch", "merged_at": 1609149107000 }

{ "login": "jonatasgrosman", "id": 5097052, "node_id": "MDQ6VXNlcjUwOTcwNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/5097052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatasgrosman", "html_url": "https://github.com/jonatasgrosman", "followers_url": "https://api.github.com/users/jonatasgrosman/followers", "following_url": "https://api.github.com/users/jonatasgrosman/following{/other_user}", "gists_url": "https://api.github.com/users/jonatasgrosman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatasgrosman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatasgrosman/subscriptions", "organizations_url": "https://api.github.com/users/jonatasgrosman/orgs", "repos_url": "https://api.github.com/users/jonatasgrosman/repos", "events_url": "https://api.github.com/users/jonatasgrosman/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatasgrosman/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1560/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1560", "html_url": "https://github.com/huggingface/datasets/pull/1560", "diff_url": "https://github.com/huggingface/datasets/pull/1560.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1560.patch", "merged_at": 1608307015000 }

{ "login": "yjernite", "id": 10469459, "node_id": "MDQ6VXNlcjEwNDY5NDU5", "avatar_url": "https://avatars.githubusercontent.com/u/10469459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yjernite", "html_url": "https://github.com/yjernite", "followers_url": "https://api.github.com/users/yjernite/followers", "following_url": "https://api.github.com/users/yjernite/following{/other_user}", "gists_url": "https://api.github.com/users/yjernite/gists{/gist_id}", "starred_url": "https://api.github.com/users/yjernite/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yjernite/subscriptions", "organizations_url": "https://api.github.com/users/yjernite/orgs", "repos_url": "https://api.github.com/users/yjernite/repos", "events_url": "https://api.github.com/users/yjernite/events{/privacy}", "received_events_url": "https://api.github.com/users/yjernite/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1559/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1559", "html_url": "https://github.com/huggingface/datasets/pull/1559", "diff_url": "https://github.com/huggingface/datasets/pull/1559.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1559.patch", "merged_at": 1607968503000 }

{ "login": "purvimisal", "id": 22298787, "node_id": "MDQ6VXNlcjIyMjk4Nzg3", "avatar_url": "https://avatars.githubusercontent.com/u/22298787?v=4", "gravatar_id": "", "url": "https://api.github.com/users/purvimisal", "html_url": "https://github.com/purvimisal", "followers_url": "https://api.github.com/users/purvimisal/followers", "following_url": "https://api.github.com/users/purvimisal/following{/other_user}", "gists_url": "https://api.github.com/users/purvimisal/gists{/gist_id}", "starred_url": "https://api.github.com/users/purvimisal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/purvimisal/subscriptions", "organizations_url": "https://api.github.com/users/purvimisal/orgs", "repos_url": "https://api.github.com/users/purvimisal/repos", "events_url": "https://api.github.com/users/purvimisal/events{/privacy}", "received_events_url": "https://api.github.com/users/purvimisal/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for the PR @purvimisal. \r\n\r\nFew comments below. ", "Hi, @lhoestq Thank you for the review. I have made all the changes. PTAL! ", "the CI error is not related to your dataset, merging" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1558/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1558", "html_url": "https://github.com/huggingface/datasets/pull/1558", "diff_url": "https://github.com/huggingface/datasets/pull/1558.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1558.patch", "merged_at": 1608561500000 }

{ "login": "rahul-art", "id": 56379013, "node_id": "MDQ6VXNlcjU2Mzc5MDEz", "avatar_url": "https://avatars.githubusercontent.com/u/56379013?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rahul-art", "html_url": "https://github.com/rahul-art", "followers_url": "https://api.github.com/users/rahul-art/followers", "following_url": "https://api.github.com/users/rahul-art/following{/other_user}", "gists_url": "https://api.github.com/users/rahul-art/gists{/gist_id}", "starred_url": "https://api.github.com/users/rahul-art/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rahul-art/subscriptions", "organizations_url": "https://api.github.com/users/rahul-art/orgs", "repos_url": "https://api.github.com/users/rahul-art/repos", "events_url": "https://api.github.com/users/rahul-art/events{/privacy}", "received_events_url": "https://api.github.com/users/rahul-art/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yes this has the right files!!!\r\n\r\nI'll close the previous one then :) \r\n\r\nNow to pass the tests, you will need to:\r\n- `make style` and run `flake8 datasets` from your repository root directory\r\n- fix the dummy data\r\n\r\nDid you generate the dummy data with the auto-generation tool (see the guide) or manually?", "manually with the tool, it is not able to create", "Cool, in that case you need to pay special attention to the directory structure given to you by the tool, most failures are because the files are in the wrong directory or at the wrong level :) \r\n\r\nAlso, make sure that the tests pass locally before pushing to the branch, it should help you get the structure right ;) ", "yes I have give proper directory structure datasets/hind_encorp/dummy/0.0.0/dummy_data.zip but in my dummy_data.zip only 1 file hind_encorp.plaintext is present because the dataset I got has only 1 file with both English and Hindi languages on 1 file itself may be this is causing issue", "Looks like the name of the file is the issue here: you have a file called `hindencorp05.plaintext`, but it should be called `hindencorp05.plaintext.gz%3Fsequence%3D3%26isAllowed%3Dy`. You just have to rename it to pass the test:\r\n```\r\ncd datasets/hind_encorp/dummy/0.0.0\r\nrm -rf dummy_data\r\nunzip dummy_data.zip\r\nrm dummy_data.zip\r\nmv dummy_data/hindencorp05.plaintext \"dummy_data/hindencorp05.plaintext.gz%3Fsequence%3D3%26isAllowed%3Dy\"\r\nzip -r dummy_data.zip dummy_data \r\n```\r\n\r\nThen **once you pass the tests locally** you just have to remember to `make style` and `flake8 datasets` to pass the style checks, and you should be good to go :hugs: \r\n\r\nFor reference, here are the instructions given by the tool:\r\n```\r\n$ python datasets-cli dummy_data datasets/hind_encorp/\r\n2020-12-14 13:16:26.824828: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory\r\n2020-12-14 13:16:26.824846: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.\r\nUsing custom data configuration default\r\n\r\n==============================DUMMY DATA INSTRUCTIONS==============================\r\n- In order to create the dummy data for , please go into the folder 'datasets/hind_encorp/dummy/0.0.0' with `cd datasets/hind_encorp/dummy/0.0.0` . \r\n\r\n- Please create the following dummy data files 'dummy_data/hindencorp05.plaintext.gz%3Fsequence%3D3%26isAllowed%3Dy' from the folder 'datasets/hind_encorp/dummy/0.0.0'\r\n\r\n- For each of the splits 'train', make sure that one or more of the dummy data files provide at least one example \r\n\r\n- If the method `_generate_examples(...)` includes multiple `open()` statements, you might have to create other files in addition to 'dummy_data/hindencorp05.plaintext.gz%3Fsequence%3D3%26isAllowed%3Dy'. In this case please refer to the `_generate_examples(...)` method \r\n\r\n-After all dummy data files are created, they should be zipped recursively to 'dummy_data.zip' with the command `zip -r dummy_data.zip dummy_data/` \r\n\r\n-You can now delete the folder 'dummy_data' with the command `rm -r dummy_data` \r\n\r\n- To get the folder 'dummy_data' back for further changes to the dummy data, simply unzip dummy_data.zip with the command `unzip dummy_data.zip` \r\n\r\n- Make sure you have created the file 'dummy_data.zip' in 'datasets/hind_encorp/dummy/0.0.0' \r\n===================================================================================\r\n```\r\n", "all test passed locally. my new PR #1575 ", "Closing this one in favor of #1575 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1557/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1557", "html_url": "https://github.com/huggingface/datasets/pull/1557", "diff_url": "https://github.com/huggingface/datasets/pull/1557.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1557.patch", "merged_at": null }

{ "login": "IvanZidov", "id": 11391118, "node_id": "MDQ6VXNlcjExMzkxMTE4", "avatar_url": "https://avatars.githubusercontent.com/u/11391118?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IvanZidov", "html_url": "https://github.com/IvanZidov", "followers_url": "https://api.github.com/users/IvanZidov/followers", "following_url": "https://api.github.com/users/IvanZidov/following{/other_user}", "gists_url": "https://api.github.com/users/IvanZidov/gists{/gist_id}", "starred_url": "https://api.github.com/users/IvanZidov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IvanZidov/subscriptions", "organizations_url": "https://api.github.com/users/IvanZidov/orgs", "repos_url": "https://api.github.com/users/IvanZidov/repos", "events_url": "https://api.github.com/users/IvanZidov/events{/privacy}", "received_events_url": "https://api.github.com/users/IvanZidov/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1556/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1556", "html_url": "https://github.com/huggingface/datasets/pull/1556", "diff_url": "https://github.com/huggingface/datasets/pull/1556.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1556.patch", "merged_at": 1608304467000 }

{ "login": "rkc007", "id": 22396042, "node_id": "MDQ6VXNlcjIyMzk2MDQy", "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rkc007", "html_url": "https://github.com/rkc007", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "organizations_url": "https://api.github.com/users/rkc007/orgs", "repos_url": "https://api.github.com/users/rkc007/repos", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "received_events_url": "https://api.github.com/users/rkc007/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq I saw some common changes you made on the other PR's (Similar Opus Datasets). I fixed those changes here. Can you please review it once ? \r\nThanks.", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1555/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1555", "html_url": "https://github.com/huggingface/datasets/pull/1555", "diff_url": "https://github.com/huggingface/datasets/pull/1555.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1555.patch", "merged_at": 1608284683000 }

{ "login": "rkc007", "id": 22396042, "node_id": "MDQ6VXNlcjIyMzk2MDQy", "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rkc007", "html_url": "https://github.com/rkc007", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "organizations_url": "https://api.github.com/users/rkc007/orgs", "repos_url": "https://api.github.com/users/rkc007/repos", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "received_events_url": "https://api.github.com/users/rkc007/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq I saw some common changes you made on the other PR's (Similar Opus Datasets). I fixed those changes here. Can you please review it once ? \r\nThanks.", "Hi @rkc007 , thanks for the contribution.\r\nUnfortunately, the CAPES dataset has already been added here: #1307\r\nI'm closing the PR ", "@lhoestq FYI" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1554/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1554", "html_url": "https://github.com/huggingface/datasets/pull/1554", "diff_url": "https://github.com/huggingface/datasets/pull/1554.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1554.patch", "merged_at": null }

{ "login": "skyprince999", "id": 9033954, "node_id": "MDQ6VXNlcjkwMzM5NTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9033954?v=4", "gravatar_id": "", "url": "https://api.github.com/users/skyprince999", "html_url": "https://github.com/skyprince999", "followers_url": "https://api.github.com/users/skyprince999/followers", "following_url": "https://api.github.com/users/skyprince999/following{/other_user}", "gists_url": "https://api.github.com/users/skyprince999/gists{/gist_id}", "starred_url": "https://api.github.com/users/skyprince999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/skyprince999/subscriptions", "organizations_url": "https://api.github.com/users/skyprince999/orgs", "repos_url": "https://api.github.com/users/skyprince999/repos", "events_url": "https://api.github.com/users/skyprince999/events{/privacy}", "received_events_url": "https://api.github.com/users/skyprince999/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1553/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1553", "html_url": "https://github.com/huggingface/datasets/pull/1553", "diff_url": "https://github.com/huggingface/datasets/pull/1553.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1553.patch", "merged_at": 1608722439000 }

{ "login": "rkc007", "id": 22396042, "node_id": "MDQ6VXNlcjIyMzk2MDQy", "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rkc007", "html_url": "https://github.com/rkc007", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "organizations_url": "https://api.github.com/users/rkc007/orgs", "repos_url": "https://api.github.com/users/rkc007/repos", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "received_events_url": "https://api.github.com/users/rkc007/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq I saw some common changes you made on the other PR's (Similar Opus Datasets). I fixed those changes here. Can you please review it once ? \r\nThanks.", "@rkc007 @lhoestq just noticed a dataset named para_crawl has been added a long time ago: #91.", "They're not exactly the same so it's ok to have both.\r\n\r\nEspecially the `para_crawl` that already exists only uses the text from the ParaCrawl release 4.", "Could you regenerate the dataset_infos.json @rkc007 please ?\r\nIt looks like it has some issues due to the dataset class name change", "@SBrandeis Thank you for suggesting changes. I made the changes you suggested. \r\n\r\n@lhoestq I generated `dataset_infos.json` again. I ran both tests(Dummy & Real data) and it passed. Can you please review it again?", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1552/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1552", "html_url": "https://github.com/huggingface/datasets/pull/1552", "diff_url": "https://github.com/huggingface/datasets/pull/1552.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1552.patch", "merged_at": 1608544225000 }

{ "login": "iliemihai", "id": 2815308, "node_id": "MDQ6VXNlcjI4MTUzMDg=", "avatar_url": "https://avatars.githubusercontent.com/u/2815308?v=4", "gravatar_id": "", "url": "https://api.github.com/users/iliemihai", "html_url": "https://github.com/iliemihai", "followers_url": "https://api.github.com/users/iliemihai/followers", "following_url": "https://api.github.com/users/iliemihai/following{/other_user}", "gists_url": "https://api.github.com/users/iliemihai/gists{/gist_id}", "starred_url": "https://api.github.com/users/iliemihai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iliemihai/subscriptions", "organizations_url": "https://api.github.com/users/iliemihai/orgs", "repos_url": "https://api.github.com/users/iliemihai/repos", "events_url": "https://api.github.com/users/iliemihai/events{/privacy}", "received_events_url": "https://api.github.com/users/iliemihai/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @iliemihai - you need to add the Readme file! Otherwise seems good. \r\nAlso don't forget to run `make style` & `flake8 datasets` locally, from the datasets folder", "@skyprince999 I will add the README.d for it. Thank you :D " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1551/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1551", "html_url": "https://github.com/huggingface/datasets/pull/1551", "diff_url": "https://github.com/huggingface/datasets/pull/1551.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1551.patch", "merged_at": null }

{ "login": "jamespaultg", "id": 7421838, "node_id": "MDQ6VXNlcjc0MjE4Mzg=", "avatar_url": "https://avatars.githubusercontent.com/u/7421838?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jamespaultg", "html_url": "https://github.com/jamespaultg", "followers_url": "https://api.github.com/users/jamespaultg/followers", "following_url": "https://api.github.com/users/jamespaultg/following{/other_user}", "gists_url": "https://api.github.com/users/jamespaultg/gists{/gist_id}", "starred_url": "https://api.github.com/users/jamespaultg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jamespaultg/subscriptions", "organizations_url": "https://api.github.com/users/jamespaultg/orgs", "repos_url": "https://api.github.com/users/jamespaultg/repos", "events_url": "https://api.github.com/users/jamespaultg/events{/privacy}", "received_events_url": "https://api.github.com/users/jamespaultg/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks much!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1550/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1550", "html_url": "https://github.com/huggingface/datasets/pull/1550", "diff_url": "https://github.com/huggingface/datasets/pull/1550.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1550.patch", "merged_at": 1608301530000 }

{ "login": "bpatidar", "id": 12439573, "node_id": "MDQ6VXNlcjEyNDM5NTcz", "avatar_url": "https://avatars.githubusercontent.com/u/12439573?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bpatidar", "html_url": "https://github.com/bpatidar", "followers_url": "https://api.github.com/users/bpatidar/followers", "following_url": "https://api.github.com/users/bpatidar/following{/other_user}", "gists_url": "https://api.github.com/users/bpatidar/gists{/gist_id}", "starred_url": "https://api.github.com/users/bpatidar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bpatidar/subscriptions", "organizations_url": "https://api.github.com/users/bpatidar/orgs", "repos_url": "https://api.github.com/users/bpatidar/repos", "events_url": "https://api.github.com/users/bpatidar/events{/privacy}", "received_events_url": "https://api.github.com/users/bpatidar/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1549/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1549", "html_url": "https://github.com/huggingface/datasets/pull/1549", "diff_url": "https://github.com/huggingface/datasets/pull/1549.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1549.patch", "merged_at": 1608558909000 }

{ "login": "VIVelev", "id": 22171622, "node_id": "MDQ6VXNlcjIyMTcxNjIy", "avatar_url": "https://avatars.githubusercontent.com/u/22171622?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VIVelev", "html_url": "https://github.com/VIVelev", "followers_url": "https://api.github.com/users/VIVelev/followers", "following_url": "https://api.github.com/users/VIVelev/following{/other_user}", "gists_url": "https://api.github.com/users/VIVelev/gists{/gist_id}", "starred_url": "https://api.github.com/users/VIVelev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VIVelev/subscriptions", "organizations_url": "https://api.github.com/users/VIVelev/orgs", "repos_url": "https://api.github.com/users/VIVelev/repos", "events_url": "https://api.github.com/users/VIVelev/events{/privacy}", "received_events_url": "https://api.github.com/users/VIVelev/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1548/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1548", "html_url": "https://github.com/huggingface/datasets/pull/1548", "diff_url": "https://github.com/huggingface/datasets/pull/1548.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1548.patch", "merged_at": 1608036927000 }

{ "login": "vrindaprabhu", "id": 16264631, "node_id": "MDQ6VXNlcjE2MjY0NjMx", "avatar_url": "https://avatars.githubusercontent.com/u/16264631?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vrindaprabhu", "html_url": "https://github.com/vrindaprabhu", "followers_url": "https://api.github.com/users/vrindaprabhu/followers", "following_url": "https://api.github.com/users/vrindaprabhu/following{/other_user}", "gists_url": "https://api.github.com/users/vrindaprabhu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vrindaprabhu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vrindaprabhu/subscriptions", "organizations_url": "https://api.github.com/users/vrindaprabhu/orgs", "repos_url": "https://api.github.com/users/vrindaprabhu/repos", "events_url": "https://api.github.com/users/vrindaprabhu/events{/privacy}", "received_events_url": "https://api.github.com/users/vrindaprabhu/received_events", "type": "User", "site_admin": false }

[]

[]

[ "**NOTE:**\r\n\r\n- Train and Dev: Manually downloaded (auto download is repeatedly giving `ConnectionError` for one of the files), Test: Auto Download\r\n- Dummy test is passing\r\n- The json file has been created with hard-coded paths for the manual downloads _(hardcoding has been removed from the final uploaded script)_\r\n- datasets-cli is still **failing** . It is not picking the right directory for the config. For instance, my folder structure is as below:\r\n ```\r\n ~/Downloads/Data/\r\n |--- English-to-Polish\r\n |--- (corresponding files) \r\n |--- Russian-Polish\r\n |--- (corresponding files) \r\n```\r\n\r\nWhen ru-pl is selected, ideally it has to search in Russian-Polish folder, but it is searching in '/Downloads/Data/' folder and hence getting a FileNotFound error.\r\n\r\nThe command run is \r\n`python datasets-cli test datasets/poleval2019_mt/ --save_infos --all_configs --data_dir ~/Downloads/Data/\r\n`\r\n", "Hi !\r\nThanks for the changes :)\r\n\r\nThe only error left is the dummy data. Since we changed for standard downloads instead of manual downloads its structure changed. Fortunately you can auto-generate the dummy data with this command:\r\n\r\n```\r\ndatasets-cli dummy_data ./datasets/poleval2019_mt --auto_generate --match_text_files \"*\"\r\n```\r\n\r\nCan you regenerate the dummy data using this command please ?", "Thank you for the help @lhoestq !! I was generating the dummy dataset in a wrong way! That _--match_text_files \"*\"_ did the trick! Now all the tests have passed! :-)" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1547/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1547", "html_url": "https://github.com/huggingface/datasets/pull/1547", "diff_url": "https://github.com/huggingface/datasets/pull/1547.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1547.patch", "merged_at": 1608567201000 }

{ "login": "KMFODA", "id": 35491698, "node_id": "MDQ6VXNlcjM1NDkxNjk4", "avatar_url": "https://avatars.githubusercontent.com/u/35491698?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KMFODA", "html_url": "https://github.com/KMFODA", "followers_url": "https://api.github.com/users/KMFODA/followers", "following_url": "https://api.github.com/users/KMFODA/following{/other_user}", "gists_url": "https://api.github.com/users/KMFODA/gists{/gist_id}", "starred_url": "https://api.github.com/users/KMFODA/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KMFODA/subscriptions", "organizations_url": "https://api.github.com/users/KMFODA/orgs", "repos_url": "https://api.github.com/users/KMFODA/repos", "events_url": "https://api.github.com/users/KMFODA/events{/privacy}", "received_events_url": "https://api.github.com/users/KMFODA/received_events", "type": "User", "site_admin": false }

[]

[]

[ "HI @SBrandeis. Thanks for all the comments - very helpful. I realised that the tests had failed and had been trying to figure out what was causing them to do so. All the tests pass when I run the load_real_dataset test however when I run `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_persian_ner` I get the below error. One thing to note is that the automated dummy data file generation failed when I tried to run it so I manually created the dummy data and ensured that the last line in the file was an empty line as per your comments. Would appreciate your thoughts on what might be causing this:\r\n\r\n```\r\n__________________________________________________ LocalDatasetTest.test_load_dataset_all_configs_persian_ner __________________________________________________\r\n\r\nself = <tests.test_dataset_common.LocalDatasetTest testMethod=test_load_dataset_all_configs_persian_ner>, dataset_name = 'persian_ner'\r\n\r\n @slow\r\n def test_load_dataset_all_configs(self, dataset_name):\r\n configs = self.dataset_tester.load_all_configs(dataset_name, is_local=True)\r\n> self.dataset_tester.check_load_dataset(dataset_name, configs, is_local=True)\r\n\r\ntests/test_dataset_common.py:237: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\ntests/test_dataset_common.py:198: in check_load_dataset\r\n self.parent.assertTrue(len(dataset[split]) > 0)\r\nE AssertionError: False is not true\r\n--------------------------------------------------------------------- Captured stdout call ---------------------------------------------------------------------\r\nDownloading and preparing dataset persian_ner/fold1 (download: 1.00 MiB, generated: 1.00 MiB, post-processed: Unknown size, total: 2.00 MiB) to /var/folders/nk/yp5_m5c95cnc0cm_vbd7h7g80000gn/T/tmpzh495aac/persian_ner/fold1/1.1.0...\r\nDataset persian_ner downloaded and prepared to /var/folders/nk/yp5_m5c95cnc0cm_vbd7h7g80000gn/T/tmpzh495aac/persian_ner/fold1/1.1.0. Subsequent calls will reuse this data.\r\n--------------------------------------------------------------------- Captured stderr call ---------------------------------------------------------------------\r\n \r\n======================================================================= warnings summary =======================================================================\r\nenv/lib/python3.7/site-packages/tensorflow/python/autograph/utils/testing.py:21\r\n /Users/karimfoda/Documents/STUDIES/PYTHON/DATASETS/env/lib/python3.7/site-packages/tensorflow/python/autograph/utils/testing.py:21: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses\r\n import imp\r\n\r\nenv/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:693\r\n /Users/karimfoda/Documents/STUDIES/PYTHON/DATASETS/env/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:693: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working\r\n if not isinstance(type_params, collections.Iterable):\r\n\r\nenv/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:532\r\n /Users/karimfoda/Documents/STUDIES/PYTHON/DATASETS/env/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:532: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working\r\n if not isinstance(type_params, (collections.Sequence, set)):\r\n\r\nenv/lib/python3.7/site-packages/elasticsearch/compat.py:38\r\n /Users/karimfoda/Documents/STUDIES/PYTHON/DATASETS/env/lib/python3.7/site-packages/elasticsearch/compat.py:38: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working\r\n from collections import Mapping\r\n\r\n-- Docs: https://docs.pytest.org/en/stable/warnings.html\r\n=================================================================== short test summary info ====================================================================\r\nFAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_persian_ner - AssertionError: False is not true\r\n```", "Thanks @SBrandeis. It turns out the error was because I had to manually increase the n_lines variable to get the dummy data generation to cover at least one example. Should all be working okay now.", "Great, thanks!\r\nIt looks good to me, I'll let @lhoestq take over" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1546/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1546", "html_url": "https://github.com/huggingface/datasets/pull/1546", "diff_url": "https://github.com/huggingface/datasets/pull/1546.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1546.patch", "merged_at": 1608717183000 }

{ "login": "IvanZidov", "id": 11391118, "node_id": "MDQ6VXNlcjExMzkxMTE4", "avatar_url": "https://avatars.githubusercontent.com/u/11391118?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IvanZidov", "html_url": "https://github.com/IvanZidov", "followers_url": "https://api.github.com/users/IvanZidov/followers", "following_url": "https://api.github.com/users/IvanZidov/following{/other_user}", "gists_url": "https://api.github.com/users/IvanZidov/gists{/gist_id}", "starred_url": "https://api.github.com/users/IvanZidov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IvanZidov/subscriptions", "organizations_url": "https://api.github.com/users/IvanZidov/orgs", "repos_url": "https://api.github.com/users/IvanZidov/repos", "events_url": "https://api.github.com/users/IvanZidov/events{/privacy}", "received_events_url": "https://api.github.com/users/IvanZidov/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1545/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1545", "html_url": "https://github.com/huggingface/datasets/pull/1545", "diff_url": "https://github.com/huggingface/datasets/pull/1545.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1545.patch", "merged_at": 1608298517000 }

{ "login": "tanmoyio", "id": 33005287, "node_id": "MDQ6VXNlcjMzMDA1Mjg3", "avatar_url": "https://avatars.githubusercontent.com/u/33005287?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tanmoyio", "html_url": "https://github.com/tanmoyio", "followers_url": "https://api.github.com/users/tanmoyio/followers", "following_url": "https://api.github.com/users/tanmoyio/following{/other_user}", "gists_url": "https://api.github.com/users/tanmoyio/gists{/gist_id}", "starred_url": "https://api.github.com/users/tanmoyio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tanmoyio/subscriptions", "organizations_url": "https://api.github.com/users/tanmoyio/orgs", "repos_url": "https://api.github.com/users/tanmoyio/repos", "events_url": "https://api.github.com/users/tanmoyio/events{/privacy}", "received_events_url": "https://api.github.com/users/tanmoyio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq why my tests are not running?", "Maybe an issue with CircleCI, let me try to make them run", "The CI error `tests/test_file_utils.py::TempSeedTest::test_tensorflow` is not related to this dataset and is fixed on master, you can ignore it", "what I need to do now", "Now the delimiter of the csv reader is fixed, thanks :) \r\n\r\nI just added a comment suggesting to try using actual URLS instead of a manual download if possible.\r\nThis would make things more convenient for the users. Can you try using the `dl_manager` to download the train/dev/test csv files instead of requiring manual download ?", "Also pinging @m3hrdadfi , since I just noticed that there's already a dataset script that was created 3 weeks ago for this dataset here: https://github.com/m3hrdadfi/wiki-summary/tree/master/datasets/wiki_summary_persian", "@lhoestq I am getting this error while generating the dummy data\r\n\r\n", "Can you try by adding the flag `--match_text_files \"*\"` ?", "now it worked", "@lhoestq pytest on dummy data passed, but on real data raising this issue\r\n\r\nhow to resolve it\r\n", "I see ! This is because the library did some verification to make sure it downloads the same files as in the first time you ran the `datasets-cli test` command with `--save_infos`. Since we're now downloading files, the verification fails. \r\n\r\nTo fix that you just need to regenerate the dataset_infos.json file:\r\n```\r\ndatasets-cli test ./datasets/wiki_summary --save_infos --all_configs --ignore_verifications\r\n```", "@lhoestq I have modified everything and It worked fine, dont know why it is not passing the tests ", "Awesome thank you !\r\n\r\nThe CI error `tests/test_file_utils.py::TempSeedTest::test_tensorflow` is not related to your dataset and is fixed on master.\r\nYou can ignore it :) ", "@lhoestq anything left to do ?", "The dataset script is all good now ! The dummy data and the dataset_infos.json file are good too :) ", "@lhoestq yay, thanks for helping me out , ", "merging since the CI is fixed on master", "@tanmoyio @lhoestq \r\n\r\nThank you both!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1544/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1544", "html_url": "https://github.com/huggingface/datasets/pull/1544", "diff_url": "https://github.com/huggingface/datasets/pull/1544.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1544.patch", "merged_at": 1608308238000 }

{ "login": "rahul-art", "id": 56379013, "node_id": "MDQ6VXNlcjU2Mzc5MDEz", "avatar_url": "https://avatars.githubusercontent.com/u/56379013?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rahul-art", "html_url": "https://github.com/rahul-art", "followers_url": "https://api.github.com/users/rahul-art/followers", "following_url": "https://api.github.com/users/rahul-art/following{/other_user}", "gists_url": "https://api.github.com/users/rahul-art/gists{/gist_id}", "starred_url": "https://api.github.com/users/rahul-art/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rahul-art/subscriptions", "organizations_url": "https://api.github.com/users/rahul-art/orgs", "repos_url": "https://api.github.com/users/rahul-art/repos", "events_url": "https://api.github.com/users/rahul-art/events{/privacy}", "received_events_url": "https://api.github.com/users/rahul-art/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq I have created a new PR by reforking and creating a new branch ", "@rahul-art unfortunately this didn't quite work, here's how you can try again:\r\n- `git checkout master` to go back to the main branch\r\n- `git pull upstream master` to make it up to date\r\n- `git checkout -b add_hind_encorp` to create a new branch\r\n\r\nThen add the dataset script, `README.md`, `dummy_data.zip`, and `dataset_infos.json` to the tracked files for the branch with `git add` (please add all of these files individually, NOT the whole directory as we don't want the other data files)\r\nThen after you have passed the style checks and the local tests, do:\r\n- `git commit . -m initial_commit`\r\n- `git push --set-upstream origin add_hind_encorp`\r\n\r\nThen you can go to this branch on the WebApp and open a new PR", "@yjernite #1557 created new PR" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1543/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1543", "html_url": "https://github.com/huggingface/datasets/pull/1543", "diff_url": "https://github.com/huggingface/datasets/pull/1543.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1543.patch", "merged_at": null }

{ "login": "clmnt", "id": 821155, "node_id": "MDQ6VXNlcjgyMTE1NQ==", "avatar_url": "https://avatars.githubusercontent.com/u/821155?v=4", "gravatar_id": "", "url": "https://api.github.com/users/clmnt", "html_url": "https://github.com/clmnt", "followers_url": "https://api.github.com/users/clmnt/followers", "following_url": "https://api.github.com/users/clmnt/following{/other_user}", "gists_url": "https://api.github.com/users/clmnt/gists{/gist_id}", "starred_url": "https://api.github.com/users/clmnt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clmnt/subscriptions", "organizations_url": "https://api.github.com/users/clmnt/orgs", "repos_url": "https://api.github.com/users/clmnt/repos", "events_url": "https://api.github.com/users/clmnt/events{/privacy}", "received_events_url": "https://api.github.com/users/clmnt/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1542/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1542", "html_url": "https://github.com/huggingface/datasets/pull/1542", "diff_url": "https://github.com/huggingface/datasets/pull/1542.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1542.patch", "merged_at": 1607879800000 }

{ "login": "rabeehkarimimahabadi", "id": 73364383, "node_id": "MDQ6VXNlcjczMzY0Mzgz", "avatar_url": "https://avatars.githubusercontent.com/u/73364383?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rabeehkarimimahabadi", "html_url": "https://github.com/rabeehkarimimahabadi", "followers_url": "https://api.github.com/users/rabeehkarimimahabadi/followers", "following_url": "https://api.github.com/users/rabeehkarimimahabadi/following{/other_user}", "gists_url": "https://api.github.com/users/rabeehkarimimahabadi/gists{/gist_id}", "starred_url": "https://api.github.com/users/rabeehkarimimahabadi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rabeehkarimimahabadi/subscriptions", "organizations_url": "https://api.github.com/users/rabeehkarimimahabadi/orgs", "repos_url": "https://api.github.com/users/rabeehkarimimahabadi/repos", "events_url": "https://api.github.com/users/rabeehkarimimahabadi/events{/privacy}", "received_events_url": "https://api.github.com/users/rabeehkarimimahabadi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "could you tell me how I can avoid download, by pre-downloading the data first, put them in a folder so the code does not try to redownload? could you tell me the path to put the downloaded data, and how to do it? thanks\r\n@lhoestq ", "Does your instance have an internet connection ?\r\n\r\nIf you don't have an internet connection you'll need to have the dataset on the instance disk.\r\nTo do so first download the dataset on another machine using `load_dataset` and then you can save it in a folder using `my_dataset.save_to_disk(\"path/to/folder\")`. Once the folder is copied on your instance you can reload the dataset with `datasets.load_from_disk(\"path/to/folder\")`" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1541/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "yavuzKomecoglu", "id": 5150963, "node_id": "MDQ6VXNlcjUxNTA5NjM=", "avatar_url": "https://avatars.githubusercontent.com/u/5150963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yavuzKomecoglu", "html_url": "https://github.com/yavuzKomecoglu", "followers_url": "https://api.github.com/users/yavuzKomecoglu/followers", "following_url": "https://api.github.com/users/yavuzKomecoglu/following{/other_user}", "gists_url": "https://api.github.com/users/yavuzKomecoglu/gists{/gist_id}", "starred_url": "https://api.github.com/users/yavuzKomecoglu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yavuzKomecoglu/subscriptions", "organizations_url": "https://api.github.com/users/yavuzKomecoglu/orgs", "repos_url": "https://api.github.com/users/yavuzKomecoglu/repos", "events_url": "https://api.github.com/users/yavuzKomecoglu/events{/privacy}", "received_events_url": "https://api.github.com/users/yavuzKomecoglu/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq, can you help with creating dummy_data?\r\n", "Hi @yavuzKomecoglu did you manage to build the dummy data ?", "> Hi @yavuzKomecoglu did you manage to build the dummy data ?\r\n\r\nHi, sorry for the return. I've created dummy_data.zip manually.", "> Nice thank you !\r\n> \r\n> Before we merge can you fill the two sections of the dataset card I suggested ?\r\n> And also remove one remaining print statement\r\n\r\nI updated your suggestions. Thank you very much for your support.", "I think you accidentally pushed the readme of another dataset (name_to_nation).\r\nI removed it so you have to `git pull`\r\n\r\nBecause of that I guess your changes about the ttc4900 was not included.\r\nFeel free to ping me once they're added\r\n\r\n\r\n", "> I think you accidentally pushed the readme of another dataset (name_to_nation).\r\n> I removed it so you have to `git pull`\r\n> \r\n> Because of that I guess your changes about the ttc4900 was not included.\r\n> Feel free to ping me once they're added\r\n\r\nI did `git pull` and updated readme **ttc4900**.", "merging since the Ci is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1540/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1540", "html_url": "https://github.com/huggingface/datasets/pull/1540", "diff_url": "https://github.com/huggingface/datasets/pull/1540.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1540.patch", "merged_at": 1608286141000 }

{ "login": "katnoria", "id": 7674948, "node_id": "MDQ6VXNlcjc2NzQ5NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/7674948?v=4", "gravatar_id": "", "url": "https://api.github.com/users/katnoria", "html_url": "https://github.com/katnoria", "followers_url": "https://api.github.com/users/katnoria/followers", "following_url": "https://api.github.com/users/katnoria/following{/other_user}", "gists_url": "https://api.github.com/users/katnoria/gists{/gist_id}", "starred_url": "https://api.github.com/users/katnoria/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/katnoria/subscriptions", "organizations_url": "https://api.github.com/users/katnoria/orgs", "repos_url": "https://api.github.com/users/katnoria/repos", "events_url": "https://api.github.com/users/katnoria/events{/privacy}", "received_events_url": "https://api.github.com/users/katnoria/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> Awesome thank you !\r\n> \r\n> I just left one comment.\r\n> \r\n> Also it looks like the dummy_data.zip files are quite big (around 500KB each)\r\n> Can you try to reduce their sizes please ? Ideally they should be <20KB each\r\n> \r\n> To do so feel free to take a look inside them and in the jsonl files only keep 1 or 2 samples instead of 5 and also remove big chunks of text to only keep a few passages.\r\n\r\nThanks, I have updated the dummy data to keep each domain <20/30KB.", "> > Awesome thank you !\r\n> > I just left one comment.\r\n> > Also it looks like the dummy_data.zip files are quite big (around 500KB each)\r\n> > Can you try to reduce their sizes please ? Ideally they should be <20KB each\r\n> > To do so feel free to take a look inside them and in the jsonl files only keep 1 or 2 samples instead of 5 and also remove big chunks of text to only keep a few passages.\r\n> \r\n> Thanks, I have updated the dummy data to keep each domain <20/30KB.\r\n\r\nLooks like this branch has other commits. I will open a new PR with suggested changes.", "opened a new PR #1612 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1539/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1539", "html_url": "https://github.com/huggingface/datasets/pull/1539", "diff_url": "https://github.com/huggingface/datasets/pull/1539.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1539.patch", "merged_at": null }

{ "login": "darshan-gandhi", "id": 44197177, "node_id": "MDQ6VXNlcjQ0MTk3MTc3", "avatar_url": "https://avatars.githubusercontent.com/u/44197177?v=4", "gravatar_id": "", "url": "https://api.github.com/users/darshan-gandhi", "html_url": "https://github.com/darshan-gandhi", "followers_url": "https://api.github.com/users/darshan-gandhi/followers", "following_url": "https://api.github.com/users/darshan-gandhi/following{/other_user}", "gists_url": "https://api.github.com/users/darshan-gandhi/gists{/gist_id}", "starred_url": "https://api.github.com/users/darshan-gandhi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/darshan-gandhi/subscriptions", "organizations_url": "https://api.github.com/users/darshan-gandhi/orgs", "repos_url": "https://api.github.com/users/darshan-gandhi/repos", "events_url": "https://api.github.com/users/darshan-gandhi/events{/privacy}", "received_events_url": "https://api.github.com/users/darshan-gandhi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @lhoestq I have added this new dataset for tweet's hate speech detection. \r\n\r\nPlease if u could review it. \r\n\r\nThank you", "Hi @darshan-gandhi have you add a chance to take a look at my suggestions ?\r\n\r\nFeel free to ping me when you're ready for the final review", "Closing in favor of #1607" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1538/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1538", "html_url": "https://github.com/huggingface/datasets/pull/1538", "diff_url": "https://github.com/huggingface/datasets/pull/1538.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1538.patch", "merged_at": null }

{ "login": "skyprince999", "id": 9033954, "node_id": "MDQ6VXNlcjkwMzM5NTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9033954?v=4", "gravatar_id": "", "url": "https://api.github.com/users/skyprince999", "html_url": "https://github.com/skyprince999", "followers_url": "https://api.github.com/users/skyprince999/followers", "following_url": "https://api.github.com/users/skyprince999/following{/other_user}", "gists_url": "https://api.github.com/users/skyprince999/gists{/gist_id}", "starred_url": "https://api.github.com/users/skyprince999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/skyprince999/subscriptions", "organizations_url": "https://api.github.com/users/skyprince999/orgs", "repos_url": "https://api.github.com/users/skyprince999/repos", "events_url": "https://api.github.com/users/skyprince999/events{/privacy}", "received_events_url": "https://api.github.com/users/skyprince999/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1537/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1537", "html_url": "https://github.com/huggingface/datasets/pull/1537", "diff_url": "https://github.com/huggingface/datasets/pull/1537.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1537.patch", "merged_at": 1608229696000 }

{ "login": "manandey", "id": 6687858, "node_id": "MDQ6VXNlcjY2ODc4NTg=", "avatar_url": "https://avatars.githubusercontent.com/u/6687858?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manandey", "html_url": "https://github.com/manandey", "followers_url": "https://api.github.com/users/manandey/followers", "following_url": "https://api.github.com/users/manandey/following{/other_user}", "gists_url": "https://api.github.com/users/manandey/gists{/gist_id}", "starred_url": "https://api.github.com/users/manandey/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manandey/subscriptions", "organizations_url": "https://api.github.com/users/manandey/orgs", "repos_url": "https://api.github.com/users/manandey/repos", "events_url": "https://api.github.com/users/manandey/events{/privacy}", "received_events_url": "https://api.github.com/users/manandey/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> Before we merge can you try to reduce the size of the dummy_data.zip file ?\r\n> \r\n> To do so feel free to only keep a few lines of the csv files ans also remove unnecessary chunks of texts (for example keep only the first sentences of a story).\r\n\r\nHi @lhoestq, I have reduced the size of the dummy_data.zip file by making the necessary changes you had suggested. ", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1536/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1536", "html_url": "https://github.com/huggingface/datasets/pull/1536", "diff_url": "https://github.com/huggingface/datasets/pull/1536.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1536.patch", "merged_at": 1608039611000 }

{ "login": "purvimisal", "id": 22298787, "node_id": "MDQ6VXNlcjIyMjk4Nzg3", "avatar_url": "https://avatars.githubusercontent.com/u/22298787?v=4", "gravatar_id": "", "url": "https://api.github.com/users/purvimisal", "html_url": "https://github.com/purvimisal", "followers_url": "https://api.github.com/users/purvimisal/followers", "following_url": "https://api.github.com/users/purvimisal/following{/other_user}", "gists_url": "https://api.github.com/users/purvimisal/gists{/gist_id}", "starred_url": "https://api.github.com/users/purvimisal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/purvimisal/subscriptions", "organizations_url": "https://api.github.com/users/purvimisal/orgs", "repos_url": "https://api.github.com/users/purvimisal/repos", "events_url": "https://api.github.com/users/purvimisal/events{/privacy}", "received_events_url": "https://api.github.com/users/purvimisal/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Thank you for the review. I have made all the changes you mentioned. PTAL! " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1535/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1535", "html_url": "https://github.com/huggingface/datasets/pull/1535", "diff_url": "https://github.com/huggingface/datasets/pull/1535.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1535.patch", "merged_at": 1608561588000 }

{ "login": "MisbahKhan789", "id": 15351802, "node_id": "MDQ6VXNlcjE1MzUxODAy", "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MisbahKhan789", "html_url": "https://github.com/MisbahKhan789", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Requested changes made and new PR submitted here: https://github.com/huggingface/datasets/pull/1580 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1534/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1534", "html_url": "https://github.com/huggingface/datasets/pull/1534", "diff_url": "https://github.com/huggingface/datasets/pull/1534.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1534.patch", "merged_at": null }

{ "login": "cahya-wirawan", "id": 7669893, "node_id": "MDQ6VXNlcjc2Njk4OTM=", "avatar_url": "https://avatars.githubusercontent.com/u/7669893?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cahya-wirawan", "html_url": "https://github.com/cahya-wirawan", "followers_url": "https://api.github.com/users/cahya-wirawan/followers", "following_url": "https://api.github.com/users/cahya-wirawan/following{/other_user}", "gists_url": "https://api.github.com/users/cahya-wirawan/gists{/gist_id}", "starred_url": "https://api.github.com/users/cahya-wirawan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cahya-wirawan/subscriptions", "organizations_url": "https://api.github.com/users/cahya-wirawan/orgs", "repos_url": "https://api.github.com/users/cahya-wirawan/repos", "events_url": "https://api.github.com/users/cahya-wirawan/events{/privacy}", "received_events_url": "https://api.github.com/users/cahya-wirawan/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @lhoestq, thanks for the review. I will have a look and update it accordingly.", "Strange error message :-)\r\n\r\n```\r\n> tf_context = tf.python.context.context() # eager mode context\r\nE AttributeError: module 'tensorflow' has no attribute 'python'\r\n```\r\n" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1533/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1533", "html_url": "https://github.com/huggingface/datasets/pull/1533", "diff_url": "https://github.com/huggingface/datasets/pull/1533.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1533.patch", "merged_at": 1608547236000 }

{ "login": "MisbahKhan789", "id": 15351802, "node_id": "MDQ6VXNlcjE1MzUxODAy", "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MisbahKhan789", "html_url": "https://github.com/MisbahKhan789", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "type": "User", "site_admin": false }

[]

[]

[ "made suggested changes and a new PR created here : https://github.com/huggingface/datasets/pull/1597" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1532/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1532", "html_url": "https://github.com/huggingface/datasets/pull/1532", "diff_url": "https://github.com/huggingface/datasets/pull/1532.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1532.patch", "merged_at": null }

{ "login": "MisbahKhan789", "id": 15351802, "node_id": "MDQ6VXNlcjE1MzUxODAy", "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MisbahKhan789", "html_url": "https://github.com/MisbahKhan789", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1531/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1531", "html_url": "https://github.com/huggingface/datasets/pull/1531", "diff_url": "https://github.com/huggingface/datasets/pull/1531.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1531.patch", "merged_at": null }

{ "login": "yasirabd", "id": 6518504, "node_id": "MDQ6VXNlcjY1MTg1MDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6518504?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yasirabd", "html_url": "https://github.com/yasirabd", "followers_url": "https://api.github.com/users/yasirabd/followers", "following_url": "https://api.github.com/users/yasirabd/following{/other_user}", "gists_url": "https://api.github.com/users/yasirabd/gists{/gist_id}", "starred_url": "https://api.github.com/users/yasirabd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yasirabd/subscriptions", "organizations_url": "https://api.github.com/users/yasirabd/orgs", "repos_url": "https://api.github.com/users/yasirabd/repos", "events_url": "https://api.github.com/users/yasirabd/events{/privacy}", "received_events_url": "https://api.github.com/users/yasirabd/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1530/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1530", "html_url": "https://github.com/huggingface/datasets/pull/1530", "diff_url": "https://github.com/huggingface/datasets/pull/1530.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1530.patch", "merged_at": 1608117103000 }

{ "login": "iliemihai", "id": 2815308, "node_id": "MDQ6VXNlcjI4MTUzMDg=", "avatar_url": "https://avatars.githubusercontent.com/u/2815308?v=4", "gravatar_id": "", "url": "https://api.github.com/users/iliemihai", "html_url": "https://github.com/iliemihai", "followers_url": "https://api.github.com/users/iliemihai/followers", "following_url": "https://api.github.com/users/iliemihai/following{/other_user}", "gists_url": "https://api.github.com/users/iliemihai/gists{/gist_id}", "starred_url": "https://api.github.com/users/iliemihai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iliemihai/subscriptions", "organizations_url": "https://api.github.com/users/iliemihai/orgs", "repos_url": "https://api.github.com/users/iliemihai/repos", "events_url": "https://api.github.com/users/iliemihai/events{/privacy}", "received_events_url": "https://api.github.com/users/iliemihai/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @iliemihai, it looks like this PR holds changes from your previous PR #1493 .\r\nWould you mind removing them from the branch please ?", "@SBrandeis I am sorry. Yes I will remove them. Thank you :D ", "Hi @lhoestq @SBrandeis @iliemihai\r\n\r\nIs this still in progress or can I take over this one?\r\n\r\nThanks,\r\nGunjan", "Hi,\r\nWhile trying to add this dataset, I found some potential issues. \r\nThe homepage mentioned is : https://github.com/katakonst/sentiment-analysis-tensorflow/tree/master/datasets/ro/, where the dataset is different from the URLs: https://raw.githubusercontent.com/dumitrescustefan/Romanian-Transformers/examples/examples/sentiment_analysis/ro/train.csv. It is unclear which dataset is \"correct\". I checked the total examples (train+test) in both places and they do not match.", "We should use the data from dumitrescustefan and set the homepage to his repo IMO, since he's first author of the paper of the dataset.", "Hi @lhoestq,\r\n\r\nCool, I'll get working on it.\r\n\r\nThanks", "Hi @lhoestq, \r\n\r\nThis PR can be closed.", "Closing in favor of #2011 \r\nThanks again for adding it !" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1529/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1529", "html_url": "https://github.com/huggingface/datasets/pull/1529", "diff_url": "https://github.com/huggingface/datasets/pull/1529.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1529.patch", "merged_at": null }

{ "login": "Karthik-Bhaskar", "id": 13200370, "node_id": "MDQ6VXNlcjEzMjAwMzcw", "avatar_url": "https://avatars.githubusercontent.com/u/13200370?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Karthik-Bhaskar", "html_url": "https://github.com/Karthik-Bhaskar", "followers_url": "https://api.github.com/users/Karthik-Bhaskar/followers", "following_url": "https://api.github.com/users/Karthik-Bhaskar/following{/other_user}", "gists_url": "https://api.github.com/users/Karthik-Bhaskar/gists{/gist_id}", "starred_url": "https://api.github.com/users/Karthik-Bhaskar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthik-Bhaskar/subscriptions", "organizations_url": "https://api.github.com/users/Karthik-Bhaskar/orgs", "repos_url": "https://api.github.com/users/Karthik-Bhaskar/repos", "events_url": "https://api.github.com/users/Karthik-Bhaskar/events{/privacy}", "received_events_url": "https://api.github.com/users/Karthik-Bhaskar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you :)" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1528/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1528", "html_url": "https://github.com/huggingface/datasets/pull/1528", "diff_url": "https://github.com/huggingface/datasets/pull/1528.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1528.patch", "merged_at": 1608286952000 }

{ "login": "rkc007", "id": 22396042, "node_id": "MDQ6VXNlcjIyMzk2MDQy", "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rkc007", "html_url": "https://github.com/rkc007", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "organizations_url": "https://api.github.com/users/rkc007/orgs", "repos_url": "https://api.github.com/users/rkc007/repos", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "received_events_url": "https://api.github.com/users/rkc007/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1527/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1527", "html_url": "https://github.com/huggingface/datasets/pull/1527", "diff_url": "https://github.com/huggingface/datasets/pull/1527.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1527.patch", "merged_at": 1607886864000 }

{ "login": "imvladikon", "id": 10088963, "node_id": "MDQ6VXNlcjEwMDg4OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/10088963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/imvladikon", "html_url": "https://github.com/imvladikon", "followers_url": "https://api.github.com/users/imvladikon/followers", "following_url": "https://api.github.com/users/imvladikon/following{/other_user}", "gists_url": "https://api.github.com/users/imvladikon/gists{/gist_id}", "starred_url": "https://api.github.com/users/imvladikon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imvladikon/subscriptions", "organizations_url": "https://api.github.com/users/imvladikon/orgs", "repos_url": "https://api.github.com/users/imvladikon/repos", "events_url": "https://api.github.com/users/imvladikon/events{/privacy}", "received_events_url": "https://api.github.com/users/imvladikon/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1526/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1526", "html_url": "https://github.com/huggingface/datasets/pull/1526", "diff_url": "https://github.com/huggingface/datasets/pull/1526.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1526.patch", "merged_at": 1608288450000 }

{ "login": "ontocord", "id": 8900094, "node_id": "MDQ6VXNlcjg5MDAwOTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8900094?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ontocord", "html_url": "https://github.com/ontocord", "followers_url": "https://api.github.com/users/ontocord/followers", "following_url": "https://api.github.com/users/ontocord/following{/other_user}", "gists_url": "https://api.github.com/users/ontocord/gists{/gist_id}", "starred_url": "https://api.github.com/users/ontocord/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ontocord/subscriptions", "organizations_url": "https://api.github.com/users/ontocord/orgs", "repos_url": "https://api.github.com/users/ontocord/repos", "events_url": "https://api.github.com/users/ontocord/events{/privacy}", "received_events_url": "https://api.github.com/users/ontocord/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1525/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1525", "html_url": "https://github.com/huggingface/datasets/pull/1525", "diff_url": "https://github.com/huggingface/datasets/pull/1525.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1525.patch", "merged_at": 1609170671000 }

{ "login": "akshayb7", "id": 29649801, "node_id": "MDQ6VXNlcjI5NjQ5ODAx", "avatar_url": "https://avatars.githubusercontent.com/u/29649801?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akshayb7", "html_url": "https://github.com/akshayb7", "followers_url": "https://api.github.com/users/akshayb7/followers", "following_url": "https://api.github.com/users/akshayb7/following{/other_user}", "gists_url": "https://api.github.com/users/akshayb7/gists{/gist_id}", "starred_url": "https://api.github.com/users/akshayb7/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akshayb7/subscriptions", "organizations_url": "https://api.github.com/users/akshayb7/orgs", "repos_url": "https://api.github.com/users/akshayb7/repos", "events_url": "https://api.github.com/users/akshayb7/events{/privacy}", "received_events_url": "https://api.github.com/users/akshayb7/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1524/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1524", "html_url": "https://github.com/huggingface/datasets/pull/1524", "diff_url": "https://github.com/huggingface/datasets/pull/1524.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1524.patch", "merged_at": 1608223036000 }

{ "login": "mariagrandury", "id": 57645283, "node_id": "MDQ6VXNlcjU3NjQ1Mjgz", "avatar_url": "https://avatars.githubusercontent.com/u/57645283?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mariagrandury", "html_url": "https://github.com/mariagrandury", "followers_url": "https://api.github.com/users/mariagrandury/followers", "following_url": "https://api.github.com/users/mariagrandury/following{/other_user}", "gists_url": "https://api.github.com/users/mariagrandury/gists{/gist_id}", "starred_url": "https://api.github.com/users/mariagrandury/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mariagrandury/subscriptions", "organizations_url": "https://api.github.com/users/mariagrandury/orgs", "repos_url": "https://api.github.com/users/mariagrandury/repos", "events_url": "https://api.github.com/users/mariagrandury/events{/privacy}", "received_events_url": "https://api.github.com/users/mariagrandury/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you very much for your review @lewtun ! \r\n\r\nI've updated the script metadata, created the README and fixed the two details you commented.\r\n\r\nReady for another review! 🤗 ", "I've updated the task tag as we discussed and also added a couple of lines of code to make sure I include all the available examples.\r\n\r\nThank you again!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1523/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1523", "html_url": "https://github.com/huggingface/datasets/pull/1523", "diff_url": "https://github.com/huggingface/datasets/pull/1523.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1523.patch", "merged_at": 1608223736000 }

{ "login": "ZacharySBrown", "id": 7950786, "node_id": "MDQ6VXNlcjc5NTA3ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/7950786?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ZacharySBrown", "html_url": "https://github.com/ZacharySBrown", "followers_url": "https://api.github.com/users/ZacharySBrown/followers", "following_url": "https://api.github.com/users/ZacharySBrown/following{/other_user}", "gists_url": "https://api.github.com/users/ZacharySBrown/gists{/gist_id}", "starred_url": "https://api.github.com/users/ZacharySBrown/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ZacharySBrown/subscriptions", "organizations_url": "https://api.github.com/users/ZacharySBrown/orgs", "repos_url": "https://api.github.com/users/ZacharySBrown/repos", "events_url": "https://api.github.com/users/ZacharySBrown/events{/privacy}", "received_events_url": "https://api.github.com/users/ZacharySBrown/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@SBrandeis : Thanks for the feedback! Just updated to use context manager for the `open`s and removed the placeholder text from the `README`!", "Great, thanks @ZacharySBrown !\r\nFailing tests seem to be unrelated to your changes, merging the current master branch into yours should fix them.\r\n" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1522/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1522", "html_url": "https://github.com/huggingface/datasets/pull/1522", "diff_url": "https://github.com/huggingface/datasets/pull/1522.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1522.patch", "merged_at": 1608050932000 }

{ "login": "ontocord", "id": 8900094, "node_id": "MDQ6VXNlcjg5MDAwOTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8900094?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ontocord", "html_url": "https://github.com/ontocord", "followers_url": "https://api.github.com/users/ontocord/followers", "following_url": "https://api.github.com/users/ontocord/following{/other_user}", "gists_url": "https://api.github.com/users/ontocord/gists{/gist_id}", "starred_url": "https://api.github.com/users/ontocord/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ontocord/subscriptions", "organizations_url": "https://api.github.com/users/ontocord/orgs", "repos_url": "https://api.github.com/users/ontocord/repos", "events_url": "https://api.github.com/users/ontocord/events{/privacy}", "received_events_url": "https://api.github.com/users/ontocord/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I had to create a new PR to fix git errors. See: https://github.com/huggingface/datasets/pull/1525\r\n\r\nI'm closing this PR. " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1521/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1521", "html_url": "https://github.com/huggingface/datasets/pull/1521", "diff_url": "https://github.com/huggingface/datasets/pull/1521.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1521.patch", "merged_at": null }

{ "login": "darshan-gandhi", "id": 44197177, "node_id": "MDQ6VXNlcjQ0MTk3MTc3", "avatar_url": "https://avatars.githubusercontent.com/u/44197177?v=4", "gravatar_id": "", "url": "https://api.github.com/users/darshan-gandhi", "html_url": "https://github.com/darshan-gandhi", "followers_url": "https://api.github.com/users/darshan-gandhi/followers", "following_url": "https://api.github.com/users/darshan-gandhi/following{/other_user}", "gists_url": "https://api.github.com/users/darshan-gandhi/gists{/gist_id}", "starred_url": "https://api.github.com/users/darshan-gandhi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/darshan-gandhi/subscriptions", "organizations_url": "https://api.github.com/users/darshan-gandhi/orgs", "repos_url": "https://api.github.com/users/darshan-gandhi/repos", "events_url": "https://api.github.com/users/darshan-gandhi/events{/privacy}", "received_events_url": "https://api.github.com/users/darshan-gandhi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @lhoestq \r\n\r\nI have added the readme as well \r\n\r\nPlease do have a look at it when suitable ", "Chatted with @darshan-gandhi on Slack about parsing examples into a separate text and sentiment field" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1520/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1520", "html_url": "https://github.com/huggingface/datasets/pull/1520", "diff_url": "https://github.com/huggingface/datasets/pull/1520.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1520.patch", "merged_at": null }

{ "login": "Karthik-Bhaskar", "id": 13200370, "node_id": "MDQ6VXNlcjEzMjAwMzcw", "avatar_url": "https://avatars.githubusercontent.com/u/13200370?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Karthik-Bhaskar", "html_url": "https://github.com/Karthik-Bhaskar", "followers_url": "https://api.github.com/users/Karthik-Bhaskar/followers", "following_url": "https://api.github.com/users/Karthik-Bhaskar/following{/other_user}", "gists_url": "https://api.github.com/users/Karthik-Bhaskar/gists{/gist_id}", "starred_url": "https://api.github.com/users/Karthik-Bhaskar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthik-Bhaskar/subscriptions", "organizations_url": "https://api.github.com/users/Karthik-Bhaskar/orgs", "repos_url": "https://api.github.com/users/Karthik-Bhaskar/repos", "events_url": "https://api.github.com/users/Karthik-Bhaskar/events{/privacy}", "received_events_url": "https://api.github.com/users/Karthik-Bhaskar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@yjernite Thank you for your help, generating the dummy data 🤗 Having that all the tests have passed 👍🏻", "merging since the CI is fixed on master", "Thank you :)" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1519/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1519", "html_url": "https://github.com/huggingface/datasets/pull/1519", "diff_url": "https://github.com/huggingface/datasets/pull/1519.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1519.patch", "merged_at": 1608224610000 }