Datasets:

amartyobanerjee

/

github-issues

like 0

{ "login": "ontocord", "id": 8900094, "node_id": "MDQ6VXNlcjg5MDAwOTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8900094?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ontocord", "html_url": "https://github.com/ontocord", "followers_url": "https://api.github.com/users/ontocord/followers", "following_url": "https://api.github.com/users/ontocord/following{/other_user}", "gists_url": "https://api.github.com/users/ontocord/gists{/gist_id}", "starred_url": "https://api.github.com/users/ontocord/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ontocord/subscriptions", "organizations_url": "https://api.github.com/users/ontocord/orgs", "repos_url": "https://api.github.com/users/ontocord/repos", "events_url": "https://api.github.com/users/ontocord/events{/privacy}", "received_events_url": "https://api.github.com/users/ontocord/received_events", "type": "User", "site_admin": false }

[]

[]

[ "hi @lhoestq, I wanted to push another change to this branch b/c I found a bug in the parsing. I need to swap arg1 and arg2. I tried to git push -u origin nell but it didn't work. So I tried to do git push --force -u origin nell which seems to work, but nothing is happening to this branch. I think this is because it's closed. Do I need to open another PR?\r\n\r\nThe change should be below in _generate_examples:\r\n best_arg1 = row[9]\r\n best_arg2 = row[8]\r\n", "Hi @ontocord !\r\n\r\nYup the easiest thing to do is to open a new PR with a title like \"Fix NELL dataset argument order\". If it's a simple fix we can look at it pretty fast :) " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1488/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1488", "html_url": "https://github.com/huggingface/datasets/pull/1488", "diff_url": "https://github.com/huggingface/datasets/pull/1488.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1488.patch", "merged_at": 1608561899000 }

{ "login": "rkc007", "id": 22396042, "node_id": "MDQ6VXNlcjIyMzk2MDQy", "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rkc007", "html_url": "https://github.com/rkc007", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "organizations_url": "https://api.github.com/users/rkc007/orgs", "repos_url": "https://api.github.com/users/rkc007/repos", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "received_events_url": "https://api.github.com/users/rkc007/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Thank you for suggesting changes. I fixed all the changes you suggested. Can you please review it again? ", "@lhoestq Thank you for reviewing and suggesting changes. I made the requested changes. Can you please review it again?", "Thanks @lhoestq for reviewing it again. I made the required changes. Can you please have a look ?", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1487/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1487", "html_url": "https://github.com/huggingface/datasets/pull/1487", "diff_url": "https://github.com/huggingface/datasets/pull/1487.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1487.patch", "merged_at": 1609148319000 }

{ "login": "czabo", "id": 75574105, "node_id": "MDQ6VXNlcjc1NTc0MTA1", "avatar_url": "https://avatars.githubusercontent.com/u/75574105?v=4", "gravatar_id": "", "url": "https://api.github.com/users/czabo", "html_url": "https://github.com/czabo", "followers_url": "https://api.github.com/users/czabo/followers", "following_url": "https://api.github.com/users/czabo/following{/other_user}", "gists_url": "https://api.github.com/users/czabo/gists{/gist_id}", "starred_url": "https://api.github.com/users/czabo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/czabo/subscriptions", "organizations_url": "https://api.github.com/users/czabo/orgs", "repos_url": "https://api.github.com/users/czabo/repos", "events_url": "https://api.github.com/users/czabo/events{/privacy}", "received_events_url": "https://api.github.com/users/czabo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The error `tests/test_file_utils.py::TempSeedTest::test_tensorflow` just appeared because of tensorflow's update.\r\nOnce it's fixed on master we'll be free to merge this one", "It's fixed on master now :) \r\n\r\nmerging this once" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1486/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1486", "html_url": "https://github.com/huggingface/datasets/pull/1486", "diff_url": "https://github.com/huggingface/datasets/pull/1486.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1486.patch", "merged_at": 1607974998000 }

{ "login": "aclifton314", "id": 53267795, "node_id": "MDQ6VXNlcjUzMjY3Nzk1", "avatar_url": "https://avatars.githubusercontent.com/u/53267795?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aclifton314", "html_url": "https://github.com/aclifton314", "followers_url": "https://api.github.com/users/aclifton314/followers", "following_url": "https://api.github.com/users/aclifton314/following{/other_user}", "gists_url": "https://api.github.com/users/aclifton314/gists{/gist_id}", "starred_url": "https://api.github.com/users/aclifton314/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aclifton314/subscriptions", "organizations_url": "https://api.github.com/users/aclifton314/orgs", "repos_url": "https://api.github.com/users/aclifton314/repos", "events_url": "https://api.github.com/users/aclifton314/events{/privacy}", "received_events_url": "https://api.github.com/users/aclifton314/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1485/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1485", "html_url": "https://github.com/huggingface/datasets/pull/1485", "diff_url": "https://github.com/huggingface/datasets/pull/1485.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1485.patch", "merged_at": 1607954902000 }

{ "login": "vinaykudari", "id": 34424769, "node_id": "MDQ6VXNlcjM0NDI0NzY5", "avatar_url": "https://avatars.githubusercontent.com/u/34424769?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vinaykudari", "html_url": "https://github.com/vinaykudari", "followers_url": "https://api.github.com/users/vinaykudari/followers", "following_url": "https://api.github.com/users/vinaykudari/following{/other_user}", "gists_url": "https://api.github.com/users/vinaykudari/gists{/gist_id}", "starred_url": "https://api.github.com/users/vinaykudari/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vinaykudari/subscriptions", "organizations_url": "https://api.github.com/users/vinaykudari/orgs", "repos_url": "https://api.github.com/users/vinaykudari/repos", "events_url": "https://api.github.com/users/vinaykudari/events{/privacy}", "received_events_url": "https://api.github.com/users/vinaykudari/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> Cool thank you !\r\n> \r\n> I left a few comments\r\n\r\nThank you @lhoestq addressed your comments. Haven't changed the code but I see that tests are failing now. Do I need to rebase or something? ", "The CI error is not related to your dataset and is fixed on master.\r\nYou can ignore it" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1484/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1484", "html_url": "https://github.com/huggingface/datasets/pull/1484", "diff_url": "https://github.com/huggingface/datasets/pull/1484.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1484.patch", "merged_at": 1608543650000 }

{ "login": "tanmoyio", "id": 33005287, "node_id": "MDQ6VXNlcjMzMDA1Mjg3", "avatar_url": "https://avatars.githubusercontent.com/u/33005287?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tanmoyio", "html_url": "https://github.com/tanmoyio", "followers_url": "https://api.github.com/users/tanmoyio/followers", "following_url": "https://api.github.com/users/tanmoyio/following{/other_user}", "gists_url": "https://api.github.com/users/tanmoyio/gists{/gist_id}", "starred_url": "https://api.github.com/users/tanmoyio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tanmoyio/subscriptions", "organizations_url": "https://api.github.com/users/tanmoyio/orgs", "repos_url": "https://api.github.com/users/tanmoyio/repos", "events_url": "https://api.github.com/users/tanmoyio/events{/privacy}", "received_events_url": "https://api.github.com/users/tanmoyio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq @abhishekkrthakur what happened here ?\r\n", "@lhoestq everything alright here ?", "@tanmoyio please have patience. @lhoestq has to look at 150+ PRs and it may take time. The PR looks good to me but we wait for his confirmation :) 🤗 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1483/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1483", "html_url": "https://github.com/huggingface/datasets/pull/1483", "diff_url": "https://github.com/huggingface/datasets/pull/1483.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1483.patch", "merged_at": 1607969287000 }

{ "login": "vrindaprabhu", "id": 16264631, "node_id": "MDQ6VXNlcjE2MjY0NjMx", "avatar_url": "https://avatars.githubusercontent.com/u/16264631?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vrindaprabhu", "html_url": "https://github.com/vrindaprabhu", "followers_url": "https://api.github.com/users/vrindaprabhu/followers", "following_url": "https://api.github.com/users/vrindaprabhu/following{/other_user}", "gists_url": "https://api.github.com/users/vrindaprabhu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vrindaprabhu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vrindaprabhu/subscriptions", "organizations_url": "https://api.github.com/users/vrindaprabhu/orgs", "repos_url": "https://api.github.com/users/vrindaprabhu/repos", "events_url": "https://api.github.com/users/vrindaprabhu/events{/privacy}", "received_events_url": "https://api.github.com/users/vrindaprabhu/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Let me know it that helps !\r\nAlso feel free to ping me if you have other questions or if I can help you.", "Now I am getting an Assertion Error!\r\n\r\n", "All tests have passed. However, PyTest is still failing with the `AssertionError` as before. Also _datasets_info.json_ actually does not seem to provide much info. Please review and let me know what has to be improved.\r\n\r\nThanks!", "[PR-1503](https://github.com/huggingface/datasets/pull/1503) on the COVID dialog dataset from the same University has similar features. I kept it separate because it is only on COVID qa. Also consists of only single files per language. Kindly let me know if it has to be added as two more configurations to this existing dataset itself. If it has to be added, then can I still freeze the file names like in PR-1503?", "It's ok to have them separate" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1482/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1482", "html_url": "https://github.com/huggingface/datasets/pull/1482", "diff_url": "https://github.com/huggingface/datasets/pull/1482.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1482.patch", "merged_at": 1608056633000 }

{ "login": "albertvillanova", "id": 8515462, "node_id": "MDQ6VXNlcjg1MTU0NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/albertvillanova", "html_url": "https://github.com/albertvillanova", "followers_url": "https://api.github.com/users/albertvillanova/followers", "following_url": "https://api.github.com/users/albertvillanova/following{/other_user}", "gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}", "starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions", "organizations_url": "https://api.github.com/users/albertvillanova/orgs", "repos_url": "https://api.github.com/users/albertvillanova/repos", "events_url": "https://api.github.com/users/albertvillanova/events{/privacy}", "received_events_url": "https://api.github.com/users/albertvillanova/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1481/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1481", "html_url": "https://github.com/huggingface/datasets/pull/1481", "diff_url": "https://github.com/huggingface/datasets/pull/1481.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1481.patch", "merged_at": 1610014220000 }

{ "login": "jonatasgrosman", "id": 5097052, "node_id": "MDQ6VXNlcjUwOTcwNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/5097052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatasgrosman", "html_url": "https://github.com/jonatasgrosman", "followers_url": "https://api.github.com/users/jonatasgrosman/followers", "following_url": "https://api.github.com/users/jonatasgrosman/following{/other_user}", "gists_url": "https://api.github.com/users/jonatasgrosman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatasgrosman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatasgrosman/subscriptions", "organizations_url": "https://api.github.com/users/jonatasgrosman/orgs", "repos_url": "https://api.github.com/users/jonatasgrosman/repos", "events_url": "https://api.github.com/users/jonatasgrosman/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatasgrosman/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1480/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1480", "html_url": "https://github.com/huggingface/datasets/pull/1480", "diff_url": "https://github.com/huggingface/datasets/pull/1480.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1480.patch", "merged_at": 1608545017000 }

{ "login": "ghomasHudson", "id": 13795113, "node_id": "MDQ6VXNlcjEzNzk1MTEz", "avatar_url": "https://avatars.githubusercontent.com/u/13795113?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghomasHudson", "html_url": "https://github.com/ghomasHudson", "followers_url": "https://api.github.com/users/ghomasHudson/followers", "following_url": "https://api.github.com/users/ghomasHudson/following{/other_user}", "gists_url": "https://api.github.com/users/ghomasHudson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghomasHudson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghomasHudson/subscriptions", "organizations_url": "https://api.github.com/users/ghomasHudson/orgs", "repos_url": "https://api.github.com/users/ghomasHudson/repos", "events_url": "https://api.github.com/users/ghomasHudson/events{/privacy}", "received_events_url": "https://api.github.com/users/ghomasHudson/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq this is now only failing some random windows test (it appears to be somewhere in wnut_17)", "This is a connection error, you can ignore it :) \r\nThe level of activity on the lib is quite overwhelming, it stresses a bit the CI ^^" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1479/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1479", "html_url": "https://github.com/huggingface/datasets/pull/1479", "diff_url": "https://github.com/huggingface/datasets/pull/1479.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1479.patch", "merged_at": 1607693603000 }

{ "login": "Fraser-Greenlee", "id": 8402500, "node_id": "MDQ6VXNlcjg0MDI1MDA=", "avatar_url": "https://avatars.githubusercontent.com/u/8402500?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Fraser-Greenlee", "html_url": "https://github.com/Fraser-Greenlee", "followers_url": "https://api.github.com/users/Fraser-Greenlee/followers", "following_url": "https://api.github.com/users/Fraser-Greenlee/following{/other_user}", "gists_url": "https://api.github.com/users/Fraser-Greenlee/gists{/gist_id}", "starred_url": "https://api.github.com/users/Fraser-Greenlee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Fraser-Greenlee/subscriptions", "organizations_url": "https://api.github.com/users/Fraser-Greenlee/orgs", "repos_url": "https://api.github.com/users/Fraser-Greenlee/repos", "events_url": "https://api.github.com/users/Fraser-Greenlee/events{/privacy}", "received_events_url": "https://api.github.com/users/Fraser-Greenlee/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Also for the `Accuracy` metric the `accuracy_score` method should have its args in the opposite order so `accuracy_score(predictions, references,,,)`.", "Thanks for pointing this out ! 🕵🏻 \r\nPredictions and references should indeed be swapped in the docstring.\r\nHowever, the call to `accuracy_score` should not be changed, it [signature](https://scikit-learn.org/stable/modules/generated/sklearn.metrics.accuracy_score.html#sklearn.metrics.accuracy_score) being:\r\n```\r\nsklearn.metrics.accuracy_score(y_true, y_pred, *, normalize=True, sample_weight=None)\r\n```\r\n\r\nFeel free to open a PR if you want to fix this :)" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1478/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "taihim", "id": 13764071, "node_id": "MDQ6VXNlcjEzNzY0MDcx", "avatar_url": "https://avatars.githubusercontent.com/u/13764071?v=4", "gravatar_id": "", "url": "https://api.github.com/users/taihim", "html_url": "https://github.com/taihim", "followers_url": "https://api.github.com/users/taihim/followers", "following_url": "https://api.github.com/users/taihim/following{/other_user}", "gists_url": "https://api.github.com/users/taihim/gists{/gist_id}", "starred_url": "https://api.github.com/users/taihim/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/taihim/subscriptions", "organizations_url": "https://api.github.com/users/taihim/orgs", "repos_url": "https://api.github.com/users/taihim/repos", "events_url": "https://api.github.com/users/taihim/events{/privacy}", "received_events_url": "https://api.github.com/users/taihim/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1477/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1477", "html_url": "https://github.com/huggingface/datasets/pull/1477", "diff_url": "https://github.com/huggingface/datasets/pull/1477.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1477.patch", "merged_at": 1607951975000 }

{ "login": "mariagrandury", "id": 57645283, "node_id": "MDQ6VXNlcjU3NjQ1Mjgz", "avatar_url": "https://avatars.githubusercontent.com/u/57645283?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mariagrandury", "html_url": "https://github.com/mariagrandury", "followers_url": "https://api.github.com/users/mariagrandury/followers", "following_url": "https://api.github.com/users/mariagrandury/following{/other_user}", "gists_url": "https://api.github.com/users/mariagrandury/gists{/gist_id}", "starred_url": "https://api.github.com/users/mariagrandury/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mariagrandury/subscriptions", "organizations_url": "https://api.github.com/users/mariagrandury/orgs", "repos_url": "https://api.github.com/users/mariagrandury/repos", "events_url": "https://api.github.com/users/mariagrandury/events{/privacy}", "received_events_url": "https://api.github.com/users/mariagrandury/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1476/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 1, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1476", "html_url": "https://github.com/huggingface/datasets/pull/1476", "diff_url": "https://github.com/huggingface/datasets/pull/1476.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1476.patch", "merged_at": 1607951671000 }

{ "login": "albertvillanova", "id": 8515462, "node_id": "MDQ6VXNlcjg1MTU0NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/albertvillanova", "html_url": "https://github.com/albertvillanova", "followers_url": "https://api.github.com/users/albertvillanova/followers", "following_url": "https://api.github.com/users/albertvillanova/following{/other_user}", "gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}", "starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions", "organizations_url": "https://api.github.com/users/albertvillanova/orgs", "repos_url": "https://api.github.com/users/albertvillanova/repos", "events_url": "https://api.github.com/users/albertvillanova/events{/privacy}", "received_events_url": "https://api.github.com/users/albertvillanova/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1475/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1475", "html_url": "https://github.com/huggingface/datasets/pull/1475", "diff_url": "https://github.com/huggingface/datasets/pull/1475.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1475.patch", "merged_at": 1608204526000 }

{ "login": "albertvillanova", "id": 8515462, "node_id": "MDQ6VXNlcjg1MTU0NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/albertvillanova", "html_url": "https://github.com/albertvillanova", "followers_url": "https://api.github.com/users/albertvillanova/followers", "following_url": "https://api.github.com/users/albertvillanova/following{/other_user}", "gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}", "starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions", "organizations_url": "https://api.github.com/users/albertvillanova/orgs", "repos_url": "https://api.github.com/users/albertvillanova/repos", "events_url": "https://api.github.com/users/albertvillanova/events{/privacy}", "received_events_url": "https://api.github.com/users/albertvillanova/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1474/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1474", "html_url": "https://github.com/huggingface/datasets/pull/1474", "diff_url": "https://github.com/huggingface/datasets/pull/1474.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1474.patch", "merged_at": null }

{ "login": "IvanZidov", "id": 11391118, "node_id": "MDQ6VXNlcjExMzkxMTE4", "avatar_url": "https://avatars.githubusercontent.com/u/11391118?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IvanZidov", "html_url": "https://github.com/IvanZidov", "followers_url": "https://api.github.com/users/IvanZidov/followers", "following_url": "https://api.github.com/users/IvanZidov/following{/other_user}", "gists_url": "https://api.github.com/users/IvanZidov/gists{/gist_id}", "starred_url": "https://api.github.com/users/IvanZidov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IvanZidov/subscriptions", "organizations_url": "https://api.github.com/users/IvanZidov/orgs", "repos_url": "https://api.github.com/users/IvanZidov/repos", "events_url": "https://api.github.com/users/IvanZidov/events{/privacy}", "received_events_url": "https://api.github.com/users/IvanZidov/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Connection error failed. Need rerun", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1473/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1473", "html_url": "https://github.com/huggingface/datasets/pull/1473", "diff_url": "https://github.com/huggingface/datasets/pull/1473.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1473.patch", "merged_at": 1608205259000 }

{ "login": "IvanZidov", "id": 11391118, "node_id": "MDQ6VXNlcjExMzkxMTE4", "avatar_url": "https://avatars.githubusercontent.com/u/11391118?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IvanZidov", "html_url": "https://github.com/IvanZidov", "followers_url": "https://api.github.com/users/IvanZidov/followers", "following_url": "https://api.github.com/users/IvanZidov/following{/other_user}", "gists_url": "https://api.github.com/users/IvanZidov/gists{/gist_id}", "starred_url": "https://api.github.com/users/IvanZidov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IvanZidov/subscriptions", "organizations_url": "https://api.github.com/users/IvanZidov/orgs", "repos_url": "https://api.github.com/users/IvanZidov/repos", "events_url": "https://api.github.com/users/IvanZidov/events{/privacy}", "received_events_url": "https://api.github.com/users/IvanZidov/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1472/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1472", "html_url": "https://github.com/huggingface/datasets/pull/1472", "diff_url": "https://github.com/huggingface/datasets/pull/1472.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1472.patch", "merged_at": null }

{ "login": "jonatasgrosman", "id": 5097052, "node_id": "MDQ6VXNlcjUwOTcwNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/5097052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatasgrosman", "html_url": "https://github.com/jonatasgrosman", "followers_url": "https://api.github.com/users/jonatasgrosman/followers", "following_url": "https://api.github.com/users/jonatasgrosman/following{/other_user}", "gists_url": "https://api.github.com/users/jonatasgrosman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatasgrosman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatasgrosman/subscriptions", "organizations_url": "https://api.github.com/users/jonatasgrosman/orgs", "repos_url": "https://api.github.com/users/jonatasgrosman/repos", "events_url": "https://api.github.com/users/jonatasgrosman/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatasgrosman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for the changes !\r\n\r\nSorry if I wasn't clear about the suggestion of adding the `raw` dataset as well.\r\nBy `raw` I meant the dataset with its original features, i.e. not tokenized to follow the conll format for NER.\r\nThe `raw` dataset has data fields `doc_text`, `doc_id` and `entities`.", "Alright, @lhoestq, now I understand your suggestion, but the JSON files the script downloads aren't actually the \"raw\" HAREM dataset, the [real raw version](https://www.linguateca.pt/primeiroHAREM/harem/ColeccaoDouradaHAREM.zip) of it is on XML format that needs a lot of preprocessing. Those JSON are just pre-processed versions of the dataset.\r\n\r\nI can make the config of the raw version of the pre-processed dataset, but I'll leave a comment on the dataset summary about those details.", "Oh I see ! Sorry I thought there really were the raw (i.e. original/unprocessed) files", "The original xml format doesn't seem very practical to use :/ \r\nWe can ignore that and only keep the default and selective configs then.\r\nCan you revert to the old configs ?\r\n\r\nThanks again for adding this dataset !", "Hi @lhoestq, I've reverted the changes and put more details on README about the dataset." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1471/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1471", "html_url": "https://github.com/huggingface/datasets/pull/1471", "diff_url": "https://github.com/huggingface/datasets/pull/1471.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1471.patch", "merged_at": 1608633453000 }

{ "login": "katnoria", "id": 7674948, "node_id": "MDQ6VXNlcjc2NzQ5NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/7674948?v=4", "gravatar_id": "", "url": "https://api.github.com/users/katnoria", "html_url": "https://github.com/katnoria", "followers_url": "https://api.github.com/users/katnoria/followers", "following_url": "https://api.github.com/users/katnoria/following{/other_user}", "gists_url": "https://api.github.com/users/katnoria/gists{/gist_id}", "starred_url": "https://api.github.com/users/katnoria/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/katnoria/subscriptions", "organizations_url": "https://api.github.com/users/katnoria/orgs", "repos_url": "https://api.github.com/users/katnoria/repos", "events_url": "https://api.github.com/users/katnoria/events{/privacy}", "received_events_url": "https://api.github.com/users/katnoria/received_events", "type": "User", "site_admin": false }

[]

[]

[ "it’s failing because of `RemoteDatasetTest.test_load_dataset_orange_sum`\r\nwhich i think is not the dataset you are doing a PR for. Try rebasing with:\r\n```\r\ngit fetch upstream\r\ngit rebase upstream/master\r\ngit push -u -f origin your_branch\r\n```", "> it’s failing because of `RemoteDatasetTest.test_load_dataset_orange_sum`\r\n> which i think is not the dataset you are doing a PR for. Try rebasing with:\r\n> \r\n> ```\r\n> git fetch upstream\r\n> git rebase upstream/master\r\n> git push -u -f origin your_branch\r\n> ```\r\n\r\nThanks, my branch seems to be up to date. \r\n```Current branch add-wiki-lingua-dataset is up to date.```", "Also where do the google drive urls come from ?", "looks like this PR includes changes about many other files than the ones for wiki_lingua.\r\n\r\nCan you create another branch and another PR ?\r\n(or you can try to fix this branch with rebase and push force if you're familiar with it)", "Thanks for fixing the dummy data and removing the glob call :) ", "> looks like this PR includes changes about many other files than the ones for wiki_lingua.\r\n> \r\n> Can you create another branch and another PR ?\r\n> (or you can try to fix this branch with rebase and push force if you're familiar with it)\r\n\r\nEasier to create a new branch and submit, I have submitted a new PR #1582 ", "Closing this one in favor of #1582 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1470/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1470", "html_url": "https://github.com/huggingface/datasets/pull/1470", "diff_url": "https://github.com/huggingface/datasets/pull/1470.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1470.patch", "merged_at": null }

{ "login": "akshayb7", "id": 29649801, "node_id": "MDQ6VXNlcjI5NjQ5ODAx", "avatar_url": "https://avatars.githubusercontent.com/u/29649801?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akshayb7", "html_url": "https://github.com/akshayb7", "followers_url": "https://api.github.com/users/akshayb7/followers", "following_url": "https://api.github.com/users/akshayb7/following{/other_user}", "gists_url": "https://api.github.com/users/akshayb7/gists{/gist_id}", "starred_url": "https://api.github.com/users/akshayb7/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akshayb7/subscriptions", "organizations_url": "https://api.github.com/users/akshayb7/orgs", "repos_url": "https://api.github.com/users/akshayb7/repos", "events_url": "https://api.github.com/users/akshayb7/events{/privacy}", "received_events_url": "https://api.github.com/users/akshayb7/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1469/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1469", "html_url": "https://github.com/huggingface/datasets/pull/1469", "diff_url": "https://github.com/huggingface/datasets/pull/1469.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1469.patch", "merged_at": 1607886837000 }

{ "login": "cahya-wirawan", "id": 7669893, "node_id": "MDQ6VXNlcjc2Njk4OTM=", "avatar_url": "https://avatars.githubusercontent.com/u/7669893?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cahya-wirawan", "html_url": "https://github.com/cahya-wirawan", "followers_url": "https://api.github.com/users/cahya-wirawan/followers", "following_url": "https://api.github.com/users/cahya-wirawan/following{/other_user}", "gists_url": "https://api.github.com/users/cahya-wirawan/gists{/gist_id}", "starred_url": "https://api.github.com/users/cahya-wirawan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cahya-wirawan/subscriptions", "organizations_url": "https://api.github.com/users/cahya-wirawan/orgs", "repos_url": "https://api.github.com/users/cahya-wirawan/repos", "events_url": "https://api.github.com/users/cahya-wirawan/events{/privacy}", "received_events_url": "https://api.github.com/users/cahya-wirawan/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Looks like there's a `Path` issue on windows. Could you try switching to\r\n`glob.glob(os.path.join(article_dir, \"*.json\"))`", "> Looks like there's a `Path` issue on windows. Could you try switching to\r\n> `glob.glob(os.path.join(article_dir, \"*.json\"))`\r\n\r\nThanks, I replaced it with glob. Let's see if it solves the issue. Anyway, the main directory has a space, could it make the issue on windows? the test on linux don't have this problem.", "It seems glob doesn't help also. Btw, one of the failing test tried to connect aws which failed:\r\n```\r\nC:\\tools\\miniconda3\\lib\\site-packages\\urllib3\\connection.py:160: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\n\r\naddress = ('s3.amazonaws.com', 443), timeout = 10, source_address = None\r\nsocket_options = [(6, 1, 1)]\r\n\r\n```\r\nWhy did it try to connect to aws? I don't use it.", "It seems that the circleci make a test for whole datasets repository, that means if only one of the dataset in the official repository has a download issue, this will also affect the test of a new dataset like mine, isn't it?\r\nI changed the url to my newspaper dataset which contains only few simple json files and simple directory structure. But it still failed. And it failed not only on windows test. This is one of the error message:\r\n```\r\n-- Docs: https://docs.pytest.org/en/stable/warnings.html\r\n=========================== short test summary info ============================\r\nFAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_ajgt_twitter_ar\r\nFAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_chr_en\r\nFAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_ajgt_twitter_ar\r\nFAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_chr_en\r\n===== 4 failed, 2667 passed, 2052 skipped, 4 warnings in 432.05s (0:07:12) =====\r\n\r\nExited with code exit status 1\r\nCircleCI received exit code 1\r\n```\r\nThe test failed on twitter dataset even my dataset has nothing to do with twitter? ", "merging since the CI is fixed on master", "Hi, thanks for merging the dataset. I create a new PR (#1499) since I need to update the link to the dataset. " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1468/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1468", "html_url": "https://github.com/huggingface/datasets/pull/1468", "diff_url": "https://github.com/huggingface/datasets/pull/1468.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1468.patch", "merged_at": 1607706281000 }

{ "login": "forest1988", "id": 2755894, "node_id": "MDQ6VXNlcjI3NTU4OTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/2755894?v=4", "gravatar_id": "", "url": "https://api.github.com/users/forest1988", "html_url": "https://github.com/forest1988", "followers_url": "https://api.github.com/users/forest1988/followers", "following_url": "https://api.github.com/users/forest1988/following{/other_user}", "gists_url": "https://api.github.com/users/forest1988/gists{/gist_id}", "starred_url": "https://api.github.com/users/forest1988/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/forest1988/subscriptions", "organizations_url": "https://api.github.com/users/forest1988/orgs", "repos_url": "https://api.github.com/users/forest1988/repos", "events_url": "https://api.github.com/users/forest1988/events{/privacy}", "received_events_url": "https://api.github.com/users/forest1988/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master", "Thank you for the updates and merging!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1467/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1467", "html_url": "https://github.com/huggingface/datasets/pull/1467", "diff_url": "https://github.com/huggingface/datasets/pull/1467.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1467.patch", "merged_at": 1608204334000 }

{ "login": "basakbuluz", "id": 41359672, "node_id": "MDQ6VXNlcjQxMzU5Njcy", "avatar_url": "https://avatars.githubusercontent.com/u/41359672?v=4", "gravatar_id": "", "url": "https://api.github.com/users/basakbuluz", "html_url": "https://github.com/basakbuluz", "followers_url": "https://api.github.com/users/basakbuluz/followers", "following_url": "https://api.github.com/users/basakbuluz/following{/other_user}", "gists_url": "https://api.github.com/users/basakbuluz/gists{/gist_id}", "starred_url": "https://api.github.com/users/basakbuluz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/basakbuluz/subscriptions", "organizations_url": "https://api.github.com/users/basakbuluz/orgs", "repos_url": "https://api.github.com/users/basakbuluz/repos", "events_url": "https://api.github.com/users/basakbuluz/events{/privacy}", "received_events_url": "https://api.github.com/users/basakbuluz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@SBrandeis, What exactly is it that makes the tests fail? Can you help me please?", "These errors\r\n```\r\n=========================== short test summary info ============================\r\nFAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_ajgt_twitter_ar\r\nFAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_chr_en\r\nFAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_ajgt_twitter_ar\r\nFAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_chr_en\r\n```\r\nappeared on master 3 hours ago and are now fixed.\r\n(it was due to today's update of `xlrd` that broke two datasets)\r\n\r\nYou can ignore them, they're not related to your dataset", "> These errors\r\n> \r\n> ```\r\n> =========================== short test summary info ============================\r\n> FAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_ajgt_twitter_ar\r\n> FAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_chr_en\r\n> FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_ajgt_twitter_ar\r\n> FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_chr_en\r\n> ```\r\n> \r\n> appeared on master 3 hours ago and are now fixed.\r\n> (it was due to today's update of `xlrd` that broke two datasets)\r\n> \r\n> You can ignore them, they're not related to your dataset\r\n\r\n**If it is not a problem caused by us, we have already completed the review notes. You can then check it out and confirm?**", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1466/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1466", "html_url": "https://github.com/huggingface/datasets/pull/1466", "diff_url": "https://github.com/huggingface/datasets/pull/1466.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1466.patch", "merged_at": 1607696834000 }

{ "login": "yvonnegitau", "id": 7923902, "node_id": "MDQ6VXNlcjc5MjM5MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/7923902?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yvonnegitau", "html_url": "https://github.com/yvonnegitau", "followers_url": "https://api.github.com/users/yvonnegitau/followers", "following_url": "https://api.github.com/users/yvonnegitau/following{/other_user}", "gists_url": "https://api.github.com/users/yvonnegitau/gists{/gist_id}", "starred_url": "https://api.github.com/users/yvonnegitau/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yvonnegitau/subscriptions", "organizations_url": "https://api.github.com/users/yvonnegitau/orgs", "repos_url": "https://api.github.com/users/yvonnegitau/repos", "events_url": "https://api.github.com/users/yvonnegitau/events{/privacy}", "received_events_url": "https://api.github.com/users/yvonnegitau/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq rerun the tests " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1465/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1465", "html_url": "https://github.com/huggingface/datasets/pull/1465", "diff_url": "https://github.com/huggingface/datasets/pull/1465.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1465.patch", "merged_at": 1607941821000 }

{ "login": "tanmoyio", "id": 33005287, "node_id": "MDQ6VXNlcjMzMDA1Mjg3", "avatar_url": "https://avatars.githubusercontent.com/u/33005287?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tanmoyio", "html_url": "https://github.com/tanmoyio", "followers_url": "https://api.github.com/users/tanmoyio/followers", "following_url": "https://api.github.com/users/tanmoyio/following{/other_user}", "gists_url": "https://api.github.com/users/tanmoyio/gists{/gist_id}", "starred_url": "https://api.github.com/users/tanmoyio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tanmoyio/subscriptions", "organizations_url": "https://api.github.com/users/tanmoyio/orgs", "repos_url": "https://api.github.com/users/tanmoyio/repos", "events_url": "https://api.github.com/users/tanmoyio/events{/privacy}", "received_events_url": "https://api.github.com/users/tanmoyio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq would you please rerun the test, ", "I re-started the test.\r\n\r\n@lhoestq let's hold off on merging for now though, having a conversation on Slack about some of the offensive content in the dataset and how/whether we want to present it." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1464/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1464", "html_url": "https://github.com/huggingface/datasets/pull/1464", "diff_url": "https://github.com/huggingface/datasets/pull/1464.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1464.patch", "merged_at": null }

{ "login": "TevenLeScao", "id": 26709476, "node_id": "MDQ6VXNlcjI2NzA5NDc2", "avatar_url": "https://avatars.githubusercontent.com/u/26709476?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TevenLeScao", "html_url": "https://github.com/TevenLeScao", "followers_url": "https://api.github.com/users/TevenLeScao/followers", "following_url": "https://api.github.com/users/TevenLeScao/following{/other_user}", "gists_url": "https://api.github.com/users/TevenLeScao/gists{/gist_id}", "starred_url": "https://api.github.com/users/TevenLeScao/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TevenLeScao/subscriptions", "organizations_url": "https://api.github.com/users/TevenLeScao/orgs", "repos_url": "https://api.github.com/users/TevenLeScao/repos", "events_url": "https://api.github.com/users/TevenLeScao/events{/privacy}", "received_events_url": "https://api.github.com/users/TevenLeScao/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1463/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1463", "html_url": "https://github.com/huggingface/datasets/pull/1463", "diff_url": "https://github.com/huggingface/datasets/pull/1463.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1463.patch", "merged_at": 1608201873000 }

{ "login": "rkc007", "id": 22396042, "node_id": "MDQ6VXNlcjIyMzk2MDQy", "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rkc007", "html_url": "https://github.com/rkc007", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "organizations_url": "https://api.github.com/users/rkc007/orgs", "repos_url": "https://api.github.com/users/rkc007/repos", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "received_events_url": "https://api.github.com/users/rkc007/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Looking perfect to me, need to rerun the tests\r\n", "Thanks, @tanmoyio. \r\nHow do I rerun the tests? Should I change something or push a new commit?", "@rkc007 you don't need to rerun it, @lhoestq @yjernite will rerun it, as there are huge number of PRs in the queue it might take lil bit of time. ", "ive just re-run the tests", "Thank you @abhishekkrthakur. Can you please rerun it again? It seems something was broken in CI during the previous test.", "@lhoestq Sorry for the mess. I don't know why this keeps on happening. I tried step by step process of updating the PR but seems something is wrong. This happened for 2nd time with the same PR. Apologies for that. \r\n\r\nNew PR -> https://github.com/huggingface/datasets/pull/1527\r\nAlso, I fixed everything in the new PR." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1462/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1462", "html_url": "https://github.com/huggingface/datasets/pull/1462", "diff_url": "https://github.com/huggingface/datasets/pull/1462.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1462.patch", "merged_at": null }

{ "login": "rsanjaykamath", "id": 18527321, "node_id": "MDQ6VXNlcjE4NTI3MzIx", "avatar_url": "https://avatars.githubusercontent.com/u/18527321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rsanjaykamath", "html_url": "https://github.com/rsanjaykamath", "followers_url": "https://api.github.com/users/rsanjaykamath/followers", "following_url": "https://api.github.com/users/rsanjaykamath/following{/other_user}", "gists_url": "https://api.github.com/users/rsanjaykamath/gists{/gist_id}", "starred_url": "https://api.github.com/users/rsanjaykamath/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rsanjaykamath/subscriptions", "organizations_url": "https://api.github.com/users/rsanjaykamath/orgs", "repos_url": "https://api.github.com/users/rsanjaykamath/repos", "events_url": "https://api.github.com/users/rsanjaykamath/events{/privacy}", "received_events_url": "https://api.github.com/users/rsanjaykamath/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Generate the dummy dataset then regenerate the dataset_info.json file, ", "> Generate the dummy dataset then regenerate the dataset_info.json file,\r\n\r\nThe pytest scripts do not accept manual directory inputs for the data provided manually. This is why the tests fail. ", "don't use the --auto-generate argument and you will get a brief instructions on how to create dummy data for your dataset,\r\nalso you dont have to run the pytest for main dataset if your data is needed to be downloaded manually, just run the pytest for dummy dataset, and when you will create the json you need to provide the main data directory path by using this argument --data_dir", "Thanks for your help, @tanmoyio \r\nI tried with and without --auto_generate flag. \r\nHere are the issues. \r\n\r\n**With --auto_generate**\r\n`python datasets-cli dummy_data datasets/newsqa/ --auto_generate `\r\n`Traceback (most recent call last):\r\n File \"datasets-cli\", line 36, in <module>\r\n service.run()\r\n File \"/Users/sanjaykamath/Python_Projects/HuggingFace/datasets/src/datasets/commands/dummy_data.py\", line 321, in run\r\n keep_uncompressed=self._keep_uncompressed,\r\n File \"/Users/sanjaykamath/Python_Projects/HuggingFace/datasets/src/datasets/commands/dummy_data.py\", line 340, in _autogenerate_dummy_data\r\n dataset_builder._split_generators(dl_manager)\r\n File \"/Users/sanjaykamath/.cache/huggingface/modules/datasets_modules/datasets/newsqa/7a565b204506c1fd91047290073be54d3ae05fa2b0ab17ae0bc6f709350fcbca/newsqa.py\", line 180, in _split_generators\r\n path_to_manual_folder = os.path.abspath(os.path.expanduser(dl_manager.manual_dir))\r\n File \"/Users/sanjaykamath/anaconda3/envs/huggingface/lib/python3.7/posixpath.py\", line 235, in expanduser\r\n path = os.fspath(path)\r\nTypeError: expected str, bytes or os.PathLike object, not NoneType\r\n`\r\n\r\n\r\n**Without --auto_generate**\r\n`python datasets-cli dummy_data datasets/newsqa/`\r\n`Dataset with config BuilderConfig(name='combined-csv', version=1.0.0, data_dir=None, data_files=None, description='This part of the dataset covers the whole dataset in the combined format of CSV as mentioned here: https://github.com/Maluuba/newsqa#csv') seems to already open files in the method `_split_generators(...)`. You might consider to instead only open files in the method `_generate_examples(...)` instead. If this is not possible the dummy data has to be created with less guidance. Make sure you create the file None.\r\nTraceback (most recent call last):\r\n File \"datasets-cli\", line 36, in <module>\r\n service.run()\r\n File \"/Users/sanjaykamath/Python_Projects/HuggingFace/datasets/src/datasets/commands/dummy_data.py\", line 326, in run\r\n dataset_builder=dataset_builder, mock_dl_manager=mock_dl_manager\r\n File \"/Users/sanjaykamath/Python_Projects/HuggingFace/datasets/src/datasets/commands/dummy_data.py\", line 406, in _print_dummy_data_instructions\r\n for split in generator_splits:\r\nUnboundLocalError: local variable 'generator_splits' referenced before assignment\r\n`\r\n", "Excellent comments. Thanks @lhoestq for your valuable comments. \r\nI've changed everything you had mentioned and the tests pass now. \r\nLet me know if something still needs to be changed. ", "Thank you very much @lhoestq @tanmoyio @yjernite @thomwolf for all your support :) " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1461/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1461", "html_url": "https://github.com/huggingface/datasets/pull/1461", "diff_url": "https://github.com/huggingface/datasets/pull/1461.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1461.patch", "merged_at": 1608229656000 }

{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq I think you might want to look at the dataset, and the first data instances mentioned in the README.md is very much offensive. Though this dataset is based on hate speech but I found the dataset heavily disturbing as Bengali is my native language.", "Hi @tanmoyio indeed you're right.\r\nWe should *at least* add very explicit mentions in the dataset card that the content of this dataset contains very offensive language. We should also put it in perspective with the tasks it tries to solve, the annotation process and the limitations.\r\n\r\nWe have to make sure that nothing is unclear/misleading nor could lead to bad usage of the dataset.\r\n\r\nWhat do you think @tanmoyio ?\r\nAlso feel free to suggest modifications in the dataset cards if you feel like some sections require corrections or more details", "> Hi @tanmoyio indeed you're right.\r\n> We should _at least_ add very explicit mentions in the dataset card that the content of this dataset contains very offensive language. We should also put it in perspective with the tasks it tries to solve, the annotation process and the limitations.\r\n> \r\n> We have to make sure that nothing is unclear/misleading nor could lead to bad usage of the dataset.\r\n> \r\n> What do you think @tanmoyio ?\r\n> Also feel free to suggest modifications in the dataset cards if you feel like some sections require corrections or more details\r\n\r\nyeah I agree with you. It would be good if \"Personal and Sensitive Information\" and \"Considerations for Using the Data\" is being explained properly in the README.md. @stevhliu ", "please let me know if there is anything else you'd like to see!", "This looks ok to merge for me. Let me know @stevhliu and @tanmoyio if you want to add something or if it looks good to you", "looks good to me @lhoestq 👍 ", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1460/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1460", "html_url": "https://github.com/huggingface/datasets/pull/1460", "diff_url": "https://github.com/huggingface/datasets/pull/1460.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1460.patch", "merged_at": 1609769309000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "_The documentation is not available anymore as the PR was closed or merged._" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1459/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1459", "html_url": "https://github.com/huggingface/datasets/pull/1459", "diff_url": "https://github.com/huggingface/datasets/pull/1459.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1459.patch", "merged_at": 1649941669000 }

{ "login": "cahya-wirawan", "id": 7669893, "node_id": "MDQ6VXNlcjc2Njk4OTM=", "avatar_url": "https://avatars.githubusercontent.com/u/7669893?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cahya-wirawan", "html_url": "https://github.com/cahya-wirawan", "followers_url": "https://api.github.com/users/cahya-wirawan/followers", "following_url": "https://api.github.com/users/cahya-wirawan/following{/other_user}", "gists_url": "https://api.github.com/users/cahya-wirawan/gists{/gist_id}", "starred_url": "https://api.github.com/users/cahya-wirawan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cahya-wirawan/subscriptions", "organizations_url": "https://api.github.com/users/cahya-wirawan/orgs", "repos_url": "https://api.github.com/users/cahya-wirawan/repos", "events_url": "https://api.github.com/users/cahya-wirawan/events{/privacy}", "received_events_url": "https://api.github.com/users/cahya-wirawan/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1458/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1458", "html_url": "https://github.com/huggingface/datasets/pull/1458", "diff_url": "https://github.com/huggingface/datasets/pull/1458.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1458.patch", "merged_at": 1608201915000 }

{ "login": "IvanZidov", "id": 11391118, "node_id": "MDQ6VXNlcjExMzkxMTE4", "avatar_url": "https://avatars.githubusercontent.com/u/11391118?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IvanZidov", "html_url": "https://github.com/IvanZidov", "followers_url": "https://api.github.com/users/IvanZidov/followers", "following_url": "https://api.github.com/users/IvanZidov/following{/other_user}", "gists_url": "https://api.github.com/users/IvanZidov/gists{/gist_id}", "starred_url": "https://api.github.com/users/IvanZidov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IvanZidov/subscriptions", "organizations_url": "https://api.github.com/users/IvanZidov/orgs", "repos_url": "https://api.github.com/users/IvanZidov/repos", "events_url": "https://api.github.com/users/IvanZidov/events{/privacy}", "received_events_url": "https://api.github.com/users/IvanZidov/received_events", "type": "User", "site_admin": false }

[]

[]

[ "duplicate" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1457", "html_url": "https://github.com/huggingface/datasets/pull/1457", "diff_url": "https://github.com/huggingface/datasets/pull/1457.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1457.patch", "merged_at": null }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1456/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1456", "html_url": "https://github.com/huggingface/datasets/pull/1456", "diff_url": "https://github.com/huggingface/datasets/pull/1456.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1456.patch", "merged_at": 1607941207000 }

{ "login": "mariagrandury", "id": 57645283, "node_id": "MDQ6VXNlcjU3NjQ1Mjgz", "avatar_url": "https://avatars.githubusercontent.com/u/57645283?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mariagrandury", "html_url": "https://github.com/mariagrandury", "followers_url": "https://api.github.com/users/mariagrandury/followers", "following_url": "https://api.github.com/users/mariagrandury/following{/other_user}", "gists_url": "https://api.github.com/users/mariagrandury/gists{/gist_id}", "starred_url": "https://api.github.com/users/mariagrandury/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mariagrandury/subscriptions", "organizations_url": "https://api.github.com/users/mariagrandury/orgs", "repos_url": "https://api.github.com/users/mariagrandury/repos", "events_url": "https://api.github.com/users/mariagrandury/events{/privacy}", "received_events_url": "https://api.github.com/users/mariagrandury/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you for your review @lhoestq, I've changed the types of `qid` and `ra` and now they are integers as `aid`.\r\n\r\nReady for another review!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1455/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1455", "html_url": "https://github.com/huggingface/datasets/pull/1455", "diff_url": "https://github.com/huggingface/datasets/pull/1455.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1455.patch", "merged_at": 1608224291000 }

{ "login": "saradhix", "id": 1351362, "node_id": "MDQ6VXNlcjEzNTEzNjI=", "avatar_url": "https://avatars.githubusercontent.com/u/1351362?v=4", "gravatar_id": "", "url": "https://api.github.com/users/saradhix", "html_url": "https://github.com/saradhix", "followers_url": "https://api.github.com/users/saradhix/followers", "following_url": "https://api.github.com/users/saradhix/following{/other_user}", "gists_url": "https://api.github.com/users/saradhix/gists{/gist_id}", "starred_url": "https://api.github.com/users/saradhix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/saradhix/subscriptions", "organizations_url": "https://api.github.com/users/saradhix/orgs", "repos_url": "https://api.github.com/users/saradhix/repos", "events_url": "https://api.github.com/users/saradhix/events{/privacy}", "received_events_url": "https://api.github.com/users/saradhix/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1454/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1454", "html_url": "https://github.com/huggingface/datasets/pull/1454", "diff_url": "https://github.com/huggingface/datasets/pull/1454.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1454.patch", "merged_at": 1608230056000 }

{ "login": "iamollas", "id": 22838900, "node_id": "MDQ6VXNlcjIyODM4OTAw", "avatar_url": "https://avatars.githubusercontent.com/u/22838900?v=4", "gravatar_id": "", "url": "https://api.github.com/users/iamollas", "html_url": "https://github.com/iamollas", "followers_url": "https://api.github.com/users/iamollas/followers", "following_url": "https://api.github.com/users/iamollas/following{/other_user}", "gists_url": "https://api.github.com/users/iamollas/gists{/gist_id}", "starred_url": "https://api.github.com/users/iamollas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iamollas/subscriptions", "organizations_url": "https://api.github.com/users/iamollas/orgs", "repos_url": "https://api.github.com/users/iamollas/repos", "events_url": "https://api.github.com/users/iamollas/events{/privacy}", "received_events_url": "https://api.github.com/users/iamollas/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> Thanks !\r\n\r\nThanks as well for your hard work 😊!!", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1453/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1453", "html_url": "https://github.com/huggingface/datasets/pull/1453", "diff_url": "https://github.com/huggingface/datasets/pull/1453.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1453.patch", "merged_at": 1607941884000 }

{ "login": "aarnetalman", "id": 11405654, "node_id": "MDQ6VXNlcjExNDA1NjU0", "avatar_url": "https://avatars.githubusercontent.com/u/11405654?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aarnetalman", "html_url": "https://github.com/aarnetalman", "followers_url": "https://api.github.com/users/aarnetalman/followers", "following_url": "https://api.github.com/users/aarnetalman/following{/other_user}", "gists_url": "https://api.github.com/users/aarnetalman/gists{/gist_id}", "starred_url": "https://api.github.com/users/aarnetalman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aarnetalman/subscriptions", "organizations_url": "https://api.github.com/users/aarnetalman/orgs", "repos_url": "https://api.github.com/users/aarnetalman/repos", "events_url": "https://api.github.com/users/aarnetalman/events{/privacy}", "received_events_url": "https://api.github.com/users/aarnetalman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I believe the `-1` label is used for missing/NULL data as per HuggingFace Dataset conventions. If I recall correctly SNLI has some entries with no (gold) labels in the dataset.", "Ah, you're right. The dataset has some pairs with missing labels. Thanks for reminding me." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1452/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "SBrandeis", "id": 33657802, "node_id": "MDQ6VXNlcjMzNjU3ODAy", "avatar_url": "https://avatars.githubusercontent.com/u/33657802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SBrandeis", "html_url": "https://github.com/SBrandeis", "followers_url": "https://api.github.com/users/SBrandeis/followers", "following_url": "https://api.github.com/users/SBrandeis/following{/other_user}", "gists_url": "https://api.github.com/users/SBrandeis/gists{/gist_id}", "starred_url": "https://api.github.com/users/SBrandeis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SBrandeis/subscriptions", "organizations_url": "https://api.github.com/users/SBrandeis/orgs", "repos_url": "https://api.github.com/users/SBrandeis/repos", "events_url": "https://api.github.com/users/SBrandeis/events{/privacy}", "received_events_url": "https://api.github.com/users/SBrandeis/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1451", "html_url": "https://github.com/huggingface/datasets/pull/1451", "diff_url": "https://github.com/huggingface/datasets/pull/1451.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1451.patch", "merged_at": 1607705409000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1450/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1450", "html_url": "https://github.com/huggingface/datasets/pull/1450", "diff_url": "https://github.com/huggingface/datasets/pull/1450.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1450.patch", "merged_at": 1607704840000 }

{ "login": "aseifert", "id": 4944799, "node_id": "MDQ6VXNlcjQ5NDQ3OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/4944799?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aseifert", "html_url": "https://github.com/aseifert", "followers_url": "https://api.github.com/users/aseifert/followers", "following_url": "https://api.github.com/users/aseifert/following{/other_user}", "gists_url": "https://api.github.com/users/aseifert/gists{/gist_id}", "starred_url": "https://api.github.com/users/aseifert/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aseifert/subscriptions", "organizations_url": "https://api.github.com/users/aseifert/orgs", "repos_url": "https://api.github.com/users/aseifert/repos", "events_url": "https://api.github.com/users/aseifert/events{/privacy}", "received_events_url": "https://api.github.com/users/aseifert/received_events", "type": "User", "site_admin": false }

[]

[]

[ "linter your code with flake8 and also run the commands present in Makefile for proper formatting \r\n", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1449/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1449", "html_url": "https://github.com/huggingface/datasets/pull/1449", "diff_url": "https://github.com/huggingface/datasets/pull/1449.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1449.patch", "merged_at": 1607706466000 }

{ "login": "cstorm125", "id": 15519308, "node_id": "MDQ6VXNlcjE1NTE5MzA4", "avatar_url": "https://avatars.githubusercontent.com/u/15519308?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cstorm125", "html_url": "https://github.com/cstorm125", "followers_url": "https://api.github.com/users/cstorm125/followers", "following_url": "https://api.github.com/users/cstorm125/following{/other_user}", "gists_url": "https://api.github.com/users/cstorm125/gists{/gist_id}", "starred_url": "https://api.github.com/users/cstorm125/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cstorm125/subscriptions", "organizations_url": "https://api.github.com/users/cstorm125/orgs", "repos_url": "https://api.github.com/users/cstorm125/repos", "events_url": "https://api.github.com/users/cstorm125/events{/privacy}", "received_events_url": "https://api.github.com/users/cstorm125/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1448/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1448", "html_url": "https://github.com/huggingface/datasets/pull/1448", "diff_url": "https://github.com/huggingface/datasets/pull/1448.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1448.patch", "merged_at": 1607703687000 }

{ "login": "thomwolf", "id": 7353373, "node_id": "MDQ6VXNlcjczNTMzNzM=", "avatar_url": "https://avatars.githubusercontent.com/u/7353373?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomwolf", "html_url": "https://github.com/thomwolf", "followers_url": "https://api.github.com/users/thomwolf/followers", "following_url": "https://api.github.com/users/thomwolf/following{/other_user}", "gists_url": "https://api.github.com/users/thomwolf/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomwolf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomwolf/subscriptions", "organizations_url": "https://api.github.com/users/thomwolf/orgs", "repos_url": "https://api.github.com/users/thomwolf/repos", "events_url": "https://api.github.com/users/thomwolf/events{/privacy}", "received_events_url": "https://api.github.com/users/thomwolf/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @thomwolf, for simplification purposes, I think you could remove the \"`pip install ...`\" steps from this commit, 'cause these deps (black, isort, flake8) are already installed on `pip install -e \".[dev]\"` on the [Start by preparing your environment](https://github.com/huggingface/datasets/blob/704107f924e74445f6f0fbde69a218b72178b588/ADD_NEW_DATASET.md#start-by-preparing-your-environment)\r\n" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1447/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1447", "html_url": "https://github.com/huggingface/datasets/pull/1447", "diff_url": "https://github.com/huggingface/datasets/pull/1447.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1447.patch", "merged_at": 1607592674000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1446/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1446", "html_url": "https://github.com/huggingface/datasets/pull/1446", "diff_url": "https://github.com/huggingface/datasets/pull/1446.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1446.patch", "merged_at": 1607706187000 }

{ "login": "tsvm", "id": 1083319, "node_id": "MDQ6VXNlcjEwODMzMTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1083319?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tsvm", "html_url": "https://github.com/tsvm", "followers_url": "https://api.github.com/users/tsvm/followers", "following_url": "https://api.github.com/users/tsvm/following{/other_user}", "gists_url": "https://api.github.com/users/tsvm/gists{/gist_id}", "starred_url": "https://api.github.com/users/tsvm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tsvm/subscriptions", "organizations_url": "https://api.github.com/users/tsvm/orgs", "repos_url": "https://api.github.com/users/tsvm/repos", "events_url": "https://api.github.com/users/tsvm/events{/privacy}", "received_events_url": "https://api.github.com/users/tsvm/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Looks like this PR includes changes about many other files than the ones for clickbait_news_bg\r\n\r\nCan you create another branch and another PR please ?", "I created a new branch with the dataset code and submitted a new PR for it: https://github.com/huggingface/datasets/pull/1568" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1445/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1445", "html_url": "https://github.com/huggingface/datasets/pull/1445", "diff_url": "https://github.com/huggingface/datasets/pull/1445.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1445.patch", "merged_at": null }

{ "login": "sadakmed", "id": 18331629, "node_id": "MDQ6VXNlcjE4MzMxNjI5", "avatar_url": "https://avatars.githubusercontent.com/u/18331629?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sadakmed", "html_url": "https://github.com/sadakmed", "followers_url": "https://api.github.com/users/sadakmed/followers", "following_url": "https://api.github.com/users/sadakmed/following{/other_user}", "gists_url": "https://api.github.com/users/sadakmed/gists{/gist_id}", "starred_url": "https://api.github.com/users/sadakmed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sadakmed/subscriptions", "organizations_url": "https://api.github.com/users/sadakmed/orgs", "repos_url": "https://api.github.com/users/sadakmed/repos", "events_url": "https://api.github.com/users/sadakmed/events{/privacy}", "received_events_url": "https://api.github.com/users/sadakmed/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This dataset will be available in version-2 of the library. If you want to use this dataset now, install datasets from `master` branch rather.\r\n\r\nCommand to install datasets from `master` branch:\r\n`!pip install git+https://github.com/huggingface/datasets.git@master`", "Closing this, thanks @VasudevGupta7 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1444/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1443/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1443", "html_url": "https://github.com/huggingface/datasets/pull/1443", "diff_url": "https://github.com/huggingface/datasets/pull/1443.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1443.patch", "merged_at": null }

{ "login": "albertvillanova", "id": 8515462, "node_id": "MDQ6VXNlcjg1MTU0NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/albertvillanova", "html_url": "https://github.com/albertvillanova", "followers_url": "https://api.github.com/users/albertvillanova/followers", "following_url": "https://api.github.com/users/albertvillanova/following{/other_user}", "gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}", "starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions", "organizations_url": "https://api.github.com/users/albertvillanova/orgs", "repos_url": "https://api.github.com/users/albertvillanova/repos", "events_url": "https://api.github.com/users/albertvillanova/events{/privacy}", "received_events_url": "https://api.github.com/users/albertvillanova/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1442/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1442", "html_url": "https://github.com/huggingface/datasets/pull/1442", "diff_url": "https://github.com/huggingface/datasets/pull/1442.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1442.patch", "merged_at": 1608199183000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1441/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1441", "html_url": "https://github.com/huggingface/datasets/pull/1441", "diff_url": "https://github.com/huggingface/datasets/pull/1441.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1441.patch", "merged_at": 1607702092000 }

{ "login": "purvimisal", "id": 22298787, "node_id": "MDQ6VXNlcjIyMjk4Nzg3", "avatar_url": "https://avatars.githubusercontent.com/u/22298787?v=4", "gravatar_id": "", "url": "https://api.github.com/users/purvimisal", "html_url": "https://github.com/purvimisal", "followers_url": "https://api.github.com/users/purvimisal/followers", "following_url": "https://api.github.com/users/purvimisal/following{/other_user}", "gists_url": "https://api.github.com/users/purvimisal/gists{/gist_id}", "starred_url": "https://api.github.com/users/purvimisal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/purvimisal/subscriptions", "organizations_url": "https://api.github.com/users/purvimisal/orgs", "repos_url": "https://api.github.com/users/purvimisal/repos", "events_url": "https://api.github.com/users/purvimisal/events{/privacy}", "received_events_url": "https://api.github.com/users/purvimisal/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @purvimisal, thanks for your contributions!\r\n\r\nThis jokes dataset has come up before, and after a conversation with the initial submitter, we decided not to add it then. Humor is important, but looking at the actual data points in this set raises several concerns :) \r\n\r\nThe main issue is the Reddit part of the dataset which has most of the examples. A cursory look at the data shows a large number of highly offensive jokes that reproduce some pretty harmful biases (the second one from the top is a Holocaust joke). \r\n\r\nThe other two sources have similar issues (especially the \"Blond Jokes\") to a slightly lesser extent.\r\n\r\nWhile such datasets can be useful in the right context, there is a real concern that people using the library might miss some of this context (however much we outline it), and end up unwittingly training models that rely on some pretty racist and sexist associations.\r\n\r\nWe would recommend skipping this dataset altogether.\r\n\r\nIf you feel really strongly about having a joke dataset, then we would ask that you:\r\n- remove the Reddit part of the dataset altogether\r\n- write an in-depth description of the social biases present in the remaining data\r\n\r\nLet us know which of the two you decide! And if you want recommendations on other datasets to add, hit us up on Slack 🤗 ", "Hi @yjernite, thanks so much. I should've totally thought about this earlier. The harmful biases make so much sense. I should've consulted before making a PR. \r\nI will be closing this one and skipping this dataset altogether. \r\nThanks again \r\n" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1440/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1440", "html_url": "https://github.com/huggingface/datasets/pull/1440", "diff_url": "https://github.com/huggingface/datasets/pull/1440.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1440.patch", "merged_at": null }

{ "login": "tuner007", "id": 46425391, "node_id": "MDQ6VXNlcjQ2NDI1Mzkx", "avatar_url": "https://avatars.githubusercontent.com/u/46425391?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tuner007", "html_url": "https://github.com/tuner007", "followers_url": "https://api.github.com/users/tuner007/followers", "following_url": "https://api.github.com/users/tuner007/following{/other_user}", "gists_url": "https://api.github.com/users/tuner007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tuner007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tuner007/subscriptions", "organizations_url": "https://api.github.com/users/tuner007/orgs", "repos_url": "https://api.github.com/users/tuner007/repos", "events_url": "https://api.github.com/users/tuner007/events{/privacy}", "received_events_url": "https://api.github.com/users/tuner007/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1439/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1439", "html_url": "https://github.com/huggingface/datasets/pull/1439", "diff_url": "https://github.com/huggingface/datasets/pull/1439.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1439.patch", "merged_at": 1607700173000 }

{ "login": "rahul-art", "id": 56379013, "node_id": "MDQ6VXNlcjU2Mzc5MDEz", "avatar_url": "https://avatars.githubusercontent.com/u/56379013?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rahul-art", "html_url": "https://github.com/rahul-art", "followers_url": "https://api.github.com/users/rahul-art/followers", "following_url": "https://api.github.com/users/rahul-art/following{/other_user}", "gists_url": "https://api.github.com/users/rahul-art/gists{/gist_id}", "starred_url": "https://api.github.com/users/rahul-art/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rahul-art/subscriptions", "organizations_url": "https://api.github.com/users/rahul-art/orgs", "repos_url": "https://api.github.com/users/rahul-art/repos", "events_url": "https://api.github.com/users/rahul-art/events{/privacy}", "received_events_url": "https://api.github.com/users/rahul-art/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I have noticed that the master branch of your fork has diverged from the one of the repo. This is probably what causes the mess in the github diff \"Files changed\".\r\n\r\nI would suggest to re-fork the `datasets` repo and recreate a new branch and a new PR. ", "You're pretty close to having all things ready to merge !\r\nFeel free to ping me when you have a new PR", "Closing this one in favor of #1575 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1438/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1438", "html_url": "https://github.com/huggingface/datasets/pull/1438", "diff_url": "https://github.com/huggingface/datasets/pull/1438.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1438.patch", "merged_at": null }

{ "login": "prasastoadi", "id": 11614678, "node_id": "MDQ6VXNlcjExNjE0Njc4", "avatar_url": "https://avatars.githubusercontent.com/u/11614678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/prasastoadi", "html_url": "https://github.com/prasastoadi", "followers_url": "https://api.github.com/users/prasastoadi/followers", "following_url": "https://api.github.com/users/prasastoadi/following{/other_user}", "gists_url": "https://api.github.com/users/prasastoadi/gists{/gist_id}", "starred_url": "https://api.github.com/users/prasastoadi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/prasastoadi/subscriptions", "organizations_url": "https://api.github.com/users/prasastoadi/orgs", "repos_url": "https://api.github.com/users/prasastoadi/repos", "events_url": "https://api.github.com/users/prasastoadi/events{/privacy}", "received_events_url": "https://api.github.com/users/prasastoadi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @prasastoadi have you had a chance to take a look at my suggestions ?\r\n\r\nFeel free to ping ;e if you have questions or when you're ready for a review" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1437/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1437", "html_url": "https://github.com/huggingface/datasets/pull/1437", "diff_url": "https://github.com/huggingface/datasets/pull/1437.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1437.patch", "merged_at": null }

{ "login": "chameleonTK", "id": 6429850, "node_id": "MDQ6VXNlcjY0Mjk4NTA=", "avatar_url": "https://avatars.githubusercontent.com/u/6429850?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chameleonTK", "html_url": "https://github.com/chameleonTK", "followers_url": "https://api.github.com/users/chameleonTK/followers", "following_url": "https://api.github.com/users/chameleonTK/following{/other_user}", "gists_url": "https://api.github.com/users/chameleonTK/gists{/gist_id}", "starred_url": "https://api.github.com/users/chameleonTK/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chameleonTK/subscriptions", "organizations_url": "https://api.github.com/users/chameleonTK/orgs", "repos_url": "https://api.github.com/users/chameleonTK/repos", "events_url": "https://api.github.com/users/chameleonTK/events{/privacy}", "received_events_url": "https://api.github.com/users/chameleonTK/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The errors in de CI are fixed on master so it's fine" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1436/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 2, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1436", "html_url": "https://github.com/huggingface/datasets/pull/1436", "diff_url": "https://github.com/huggingface/datasets/pull/1436.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1436.patch", "merged_at": 1607701961000 }

{ "login": "anaerobeth", "id": 3663322, "node_id": "MDQ6VXNlcjM2NjMzMjI=", "avatar_url": "https://avatars.githubusercontent.com/u/3663322?v=4", "gravatar_id": "", "url": "https://api.github.com/users/anaerobeth", "html_url": "https://github.com/anaerobeth", "followers_url": "https://api.github.com/users/anaerobeth/followers", "following_url": "https://api.github.com/users/anaerobeth/following{/other_user}", "gists_url": "https://api.github.com/users/anaerobeth/gists{/gist_id}", "starred_url": "https://api.github.com/users/anaerobeth/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anaerobeth/subscriptions", "organizations_url": "https://api.github.com/users/anaerobeth/orgs", "repos_url": "https://api.github.com/users/anaerobeth/repos", "events_url": "https://api.github.com/users/anaerobeth/events{/privacy}", "received_events_url": "https://api.github.com/users/anaerobeth/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@yjernite @lhoestq Any suggestions on how to get the dummy data generator to recognize the columns? The structure of the json is:\r\n```\r\n{\r\n \"Dataset\": \"FreebaseQA-eval\", \r\n \"Version\": \"1.0\", \r\n \"Questions\": [\r\n {\r\n \"Question-ID\": \"FreebaseQA-eval-0\", \r\n \"RawQuestion\": \"Who is the female presenter of the Channel 4 quiz show '1001 things you should know'?\", \r\n \"ProcessedQuestion\": \"who is the female presenter of the channel 4 quiz show '1001 things you should know'\", \r\n \"Parses\": [\r\n {\r\n \"Parse-Id\": \"FreebaseQA-eval-0.P0\", \r\n \"PotentialTopicEntityMention\": \"1001 things you should know\", \r\n \"TopicEntityName\": \"1001 things you should know\", \r\n \"TopicEntityMid\": \"m.0nd3t34\", \r\n \"InferentialChain\": \"tv.tv_program.regular_personal_appearances..tv.tv_regular_personal_appearance.person\", \r\n \"Answers\": [\r\n {\r\n \"AnswersMid\": \"m.0216y_\", \r\n \"AnswersName\": [\r\n \"sandi toksvig\"\r\n ]\r\n }\r\n ]\r\n }\r\n ]\r\n }, \r\n ...\r\n ]\r\n}\r\n```\r\n\r\nThanks!", "Unfortunately this json structure is not recognized by the auto-generation yet, so you'd have to create the dummy data manually. \r\nYou can get some instructions on how to do that with: `python datasets-cli dummy_data datasets/freebase_qa`\r\nWe can definitely help you with that if there are too many files! ", "@yjernite Thanks for the instructions. I manually added dummy data and created the zip file but one of the splits seem to return an empty list.\r\n\r\n```\r\ntests/test_dataset_common.py F [100%]\r\n\r\n========================= FAILURES ==========================\r\n_ LocalDatasetTest.test_load_dataset_all_configs_freebase_qa _\r\n\r\nself = <tests.test_dataset_common.LocalDatasetTest testMethod=test_load_dataset_all_configs_freebase_qa>\r\ndataset_name = 'freebase_qa'\r\n\r\n @slow\r\n def test_load_dataset_all_configs(self, dataset_name):\r\n configs = self.dataset_tester.load_all_configs(dataset_name, is_local=True)\r\n> self.dataset_tester.check_load_dataset(dataset_name, configs, is_local=True)\r\n\r\ntests/test_dataset_common.py:237:\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\ntests/test_dataset_common.py:198: in check_load_dataset\r\n self.parent.assertTrue(len(dataset[split]) > 0)\r\nE AssertionError: False is not true\r\n```\r\n\r\nNote that the dataset has `train`, `eval`, and `dev` (no test split). I am not sure if I am mapping them correctly when I called the Split Generator.\r\n", "The dummy json files must follow the exact same structure as the original json files.\r\n\r\nHowever it looks like the dummy json files you have in your dummy_data.zip file are not structured the same way.\r\nFor example the original json is a dict with a field \"Questions\" that is a list of items.\r\nHowever your dummy json is simply a list of items.\r\n\r\nCan you update your dummy json files to follow the same structure ?", "And I'm pretty sure that this structure is supported by the dummy data auto-generation tool\r\n```\r\npython datasets-cli dummy_data ./datasets/freebase_qa --json_field \"Questions\"\r\n```", "Hi @anaerobeth did you manage to get the dummy data right ?\r\n\r\nFeel free to ping me if you have questions or when you're ready for a review", "Thanks for your help! I am able to create the dummy data with the dict structure as suggested. I'll add the tags and update this PR shortly.", "Also don't forget to run `make style` to fix the code formatting check in the CI :)", "Hi @anaerobeth ! Have you had a chance to consider updating the dataset script to yield one example per question ?\r\n\r\nFeel free to ping me if you have questions or if I can help :) ", "Hi @lhoestq,\r\n\r\nI am willing to take this forward if you and @anaerobeth don't mind.\r\n", "Hi @gchhablani thanks for proposing your help :) \r\nSure if you want to take this forward feel free to do so.\r\nAlso pinging @anaerobeth to make sure that you both don't work on the same thing at the same time", "Hi ! Closing this one since the dataset was added in #1814 \r\n\r\nThanks you two @anaerobeth and @gchhablani for adding this dataset !" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1435/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1435", "html_url": "https://github.com/huggingface/datasets/pull/1435", "diff_url": "https://github.com/huggingface/datasets/pull/1435.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1435.patch", "merged_at": null }

{ "login": "ZacharySBrown", "id": 7950786, "node_id": "MDQ6VXNlcjc5NTA3ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/7950786?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ZacharySBrown", "html_url": "https://github.com/ZacharySBrown", "followers_url": "https://api.github.com/users/ZacharySBrown/followers", "following_url": "https://api.github.com/users/ZacharySBrown/following{/other_user}", "gists_url": "https://api.github.com/users/ZacharySBrown/gists{/gist_id}", "starred_url": "https://api.github.com/users/ZacharySBrown/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ZacharySBrown/subscriptions", "organizations_url": "https://api.github.com/users/ZacharySBrown/orgs", "repos_url": "https://api.github.com/users/ZacharySBrown/repos", "events_url": "https://api.github.com/users/ZacharySBrown/events{/privacy}", "received_events_url": "https://api.github.com/users/ZacharySBrown/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hey @lhoestq , thanks for the feedback on this! I updated the `_generate_examples` with some comments on the process, and reduced the `dummy_data.zip` down quite a bit as well. \r\n\r\nFor the dummy data, I reduced the text to only three sentences, and aligned the corresponding entity/token/sentence annotations to that (reduced accordingly). The frames file is a strange combined format for the annotations and I found if I reduced that that would break the parser no matter what I did, so I left that as is. The difference between a reduced frames and non-reduced frames file in the compressed dummy data was only about ~4kb, so hopefully leaving this as is will be ok!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1434/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1434", "html_url": "https://github.com/huggingface/datasets/pull/1434", "diff_url": "https://github.com/huggingface/datasets/pull/1434.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1434.patch", "merged_at": 1608199194000 }

{ "login": "jonatasgrosman", "id": 5097052, "node_id": "MDQ6VXNlcjUwOTcwNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/5097052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatasgrosman", "html_url": "https://github.com/jonatasgrosman", "followers_url": "https://api.github.com/users/jonatasgrosman/followers", "following_url": "https://api.github.com/users/jonatasgrosman/following{/other_user}", "gists_url": "https://api.github.com/users/jonatasgrosman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatasgrosman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatasgrosman/subscriptions", "organizations_url": "https://api.github.com/users/jonatasgrosman/orgs", "repos_url": "https://api.github.com/users/jonatasgrosman/repos", "events_url": "https://api.github.com/users/jonatasgrosman/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatasgrosman/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1433", "html_url": "https://github.com/huggingface/datasets/pull/1433", "diff_url": "https://github.com/huggingface/datasets/pull/1433.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1433.patch", "merged_at": 1607697176000 }

{ "login": "MaramHasanain", "id": 3918663, "node_id": "MDQ6VXNlcjM5MTg2NjM=", "avatar_url": "https://avatars.githubusercontent.com/u/3918663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaramHasanain", "html_url": "https://github.com/MaramHasanain", "followers_url": "https://api.github.com/users/MaramHasanain/followers", "following_url": "https://api.github.com/users/MaramHasanain/following{/other_user}", "gists_url": "https://api.github.com/users/MaramHasanain/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaramHasanain/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaramHasanain/subscriptions", "organizations_url": "https://api.github.com/users/MaramHasanain/orgs", "repos_url": "https://api.github.com/users/MaramHasanain/repos", "events_url": "https://api.github.com/users/MaramHasanain/events{/privacy}", "received_events_url": "https://api.github.com/users/MaramHasanain/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Thanks a lot for checking! I hope I addressed all your comments. ", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1432/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1432", "html_url": "https://github.com/huggingface/datasets/pull/1432", "diff_url": "https://github.com/huggingface/datasets/pull/1432.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1432.patch", "merged_at": 1607953864000 }

{ "login": "Fatima-Haouari", "id": 71061623, "node_id": "MDQ6VXNlcjcxMDYxNjIz", "avatar_url": "https://avatars.githubusercontent.com/u/71061623?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Fatima-Haouari", "html_url": "https://github.com/Fatima-Haouari", "followers_url": "https://api.github.com/users/Fatima-Haouari/followers", "following_url": "https://api.github.com/users/Fatima-Haouari/following{/other_user}", "gists_url": "https://api.github.com/users/Fatima-Haouari/gists{/gist_id}", "starred_url": "https://api.github.com/users/Fatima-Haouari/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Fatima-Haouari/subscriptions", "organizations_url": "https://api.github.com/users/Fatima-Haouari/orgs", "repos_url": "https://api.github.com/users/Fatima-Haouari/repos", "events_url": "https://api.github.com/users/Fatima-Haouari/events{/privacy}", "received_events_url": "https://api.github.com/users/Fatima-Haouari/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1431/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1431", "html_url": "https://github.com/huggingface/datasets/pull/1431", "diff_url": "https://github.com/huggingface/datasets/pull/1431.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1431.patch", "merged_at": 1607698883000 }

{ "login": "zaidalyafeai", "id": 15667714, "node_id": "MDQ6VXNlcjE1NjY3NzE0", "avatar_url": "https://avatars.githubusercontent.com/u/15667714?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zaidalyafeai", "html_url": "https://github.com/zaidalyafeai", "followers_url": "https://api.github.com/users/zaidalyafeai/followers", "following_url": "https://api.github.com/users/zaidalyafeai/following{/other_user}", "gists_url": "https://api.github.com/users/zaidalyafeai/gists{/gist_id}", "starred_url": "https://api.github.com/users/zaidalyafeai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zaidalyafeai/subscriptions", "organizations_url": "https://api.github.com/users/zaidalyafeai/orgs", "repos_url": "https://api.github.com/users/zaidalyafeai/repos", "events_url": "https://api.github.com/users/zaidalyafeai/events{/privacy}", "received_events_url": "https://api.github.com/users/zaidalyafeai/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Can't pass dummy data tests. For the instructions, it asks me to generate the following file `dummy_data/Youm7_XML_utf_8.rar/Youm7_utf_8.xml` which is strange, any ideas @lhoestq ?\r\n\r\ncc: I tested the data locally and it works, maybe the dummy tests doesn't support `rar` ? ", "In the dummy_data.zip files you must include the rar file as if is was already extracted.\r\nIn particular here `Youm7_XML_utf_8.rar` is a directory (not an archive).", "Also I'm getting `BadRarFile: Failed the read enough data: req=16384 got=51` while trying to download and extract the `Alittihad_XML_utf_8.rar` file. Do you have this issue as well ?\r\n\r\nI have rarfile 4.0", "Sorry it was my mistake, I missed up the directories, it works now. Not sure why you got that error. I have the same version of `rarfile`. Between, there were some suggestions to change the dataset from `1bn_words_arabic` to `arabic_billion_words` like https://github.com/huggingface/datasets/tree/master/datasets/spanish_billion_words. \r\n", "I'm ok with renaming the dataset `arabic_billion_words` if you want.\r\nNote that you will need to rename class name `ArabicBillionWords` instead of `BillionWords`\r\n(though `BillionWords` was not matching `1bn_words_arabic` anyway)\r\n\r\nYou will need to regenerate the dataset_infos.json file after this change.\r\nOR alternatively just replace all mentions of `billion_words` with `arabic_billion_words` in dataset_infos.json <- this trick should save you some time :)", "Hmmm I'm still not able to run it on my side because of the rar error (I'm running macos)\r\nI just tried with rarfile 3.1 and it didn't work either.\r\nI would like to be able to run it end-to-end on my side before merging if you don't mind. Let me investigate this issue a little bit", "No worries, I will investigate it as well. ", "I created a minimal example in [colab ](https://colab.research.google.com/drive/11ijesuGbrQylANka0VdsZ5vXwIuxkheY?usp=sharing).", "Nice thanks, maybe it's just an issue on my side then", "Ok I managed to solve the BadRarFile issue on my side :) \r\nTo fix it I had to install the `unrar` tool for macos (though it seems it's not available with `brew install` anymore, I had to install it from elsewhere)." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1430/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1430", "html_url": "https://github.com/huggingface/datasets/pull/1430", "diff_url": "https://github.com/huggingface/datasets/pull/1430.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1430.patch", "merged_at": 1608631439000 }

{ "login": "zaidalyafeai", "id": 15667714, "node_id": "MDQ6VXNlcjE1NjY3NzE0", "avatar_url": "https://avatars.githubusercontent.com/u/15667714?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zaidalyafeai", "html_url": "https://github.com/zaidalyafeai", "followers_url": "https://api.github.com/users/zaidalyafeai/followers", "following_url": "https://api.github.com/users/zaidalyafeai/following{/other_user}", "gists_url": "https://api.github.com/users/zaidalyafeai/gists{/gist_id}", "starred_url": "https://api.github.com/users/zaidalyafeai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zaidalyafeai/subscriptions", "organizations_url": "https://api.github.com/users/zaidalyafeai/orgs", "repos_url": "https://api.github.com/users/zaidalyafeai/repos", "events_url": "https://api.github.com/users/zaidalyafeai/events{/privacy}", "received_events_url": "https://api.github.com/users/zaidalyafeai/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1429/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1429", "html_url": "https://github.com/huggingface/datasets/pull/1429", "diff_url": "https://github.com/huggingface/datasets/pull/1429.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1429.patch", "merged_at": 1608303817000 }

{ "login": "dadelani", "id": 23586676, "node_id": "MDQ6VXNlcjIzNTg2Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dadelani", "html_url": "https://github.com/dadelani", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "organizations_url": "https://api.github.com/users/dadelani/orgs", "repos_url": "https://api.github.com/users/dadelani/repos", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "received_events_url": "https://api.github.com/users/dadelani/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1428/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1428", "html_url": "https://github.com/huggingface/datasets/pull/1428", "diff_url": "https://github.com/huggingface/datasets/pull/1428.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1428.patch", "merged_at": 1607695052000 }

{ "login": "imvladikon", "id": 10088963, "node_id": "MDQ6VXNlcjEwMDg4OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/10088963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/imvladikon", "html_url": "https://github.com/imvladikon", "followers_url": "https://api.github.com/users/imvladikon/followers", "following_url": "https://api.github.com/users/imvladikon/following{/other_user}", "gists_url": "https://api.github.com/users/imvladikon/gists{/gist_id}", "starred_url": "https://api.github.com/users/imvladikon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imvladikon/subscriptions", "organizations_url": "https://api.github.com/users/imvladikon/orgs", "repos_url": "https://api.github.com/users/imvladikon/repos", "events_url": "https://api.github.com/users/imvladikon/events{/privacy}", "received_events_url": "https://api.github.com/users/imvladikon/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1427/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1427", "html_url": "https://github.com/huggingface/datasets/pull/1427", "diff_url": "https://github.com/huggingface/datasets/pull/1427.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1427.patch", "merged_at": 1607708363000 }

{ "login": "Karthik-Bhaskar", "id": 13200370, "node_id": "MDQ6VXNlcjEzMjAwMzcw", "avatar_url": "https://avatars.githubusercontent.com/u/13200370?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Karthik-Bhaskar", "html_url": "https://github.com/Karthik-Bhaskar", "followers_url": "https://api.github.com/users/Karthik-Bhaskar/followers", "following_url": "https://api.github.com/users/Karthik-Bhaskar/following{/other_user}", "gists_url": "https://api.github.com/users/Karthik-Bhaskar/gists{/gist_id}", "starred_url": "https://api.github.com/users/Karthik-Bhaskar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthik-Bhaskar/subscriptions", "organizations_url": "https://api.github.com/users/Karthik-Bhaskar/orgs", "repos_url": "https://api.github.com/users/Karthik-Bhaskar/repos", "events_url": "https://api.github.com/users/Karthik-Bhaskar/events{/privacy}", "received_events_url": "https://api.github.com/users/Karthik-Bhaskar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "good dataset card as well :) ", "@lhoestq Thank you :) " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1426/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1426", "html_url": "https://github.com/huggingface/datasets/pull/1426", "diff_url": "https://github.com/huggingface/datasets/pull/1426.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1426.patch", "merged_at": 1607693828000 }

{ "login": "Phil1108", "id": 39518904, "node_id": "MDQ6VXNlcjM5NTE4OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/39518904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Phil1108", "html_url": "https://github.com/Phil1108", "followers_url": "https://api.github.com/users/Phil1108/followers", "following_url": "https://api.github.com/users/Phil1108/following{/other_user}", "gists_url": "https://api.github.com/users/Phil1108/gists{/gist_id}", "starred_url": "https://api.github.com/users/Phil1108/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Phil1108/subscriptions", "organizations_url": "https://api.github.com/users/Phil1108/orgs", "repos_url": "https://api.github.com/users/Phil1108/repos", "events_url": "https://api.github.com/users/Phil1108/events{/privacy}", "received_events_url": "https://api.github.com/users/Phil1108/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @Phil1108 !\r\nHave you had a chance to take a look at my suggestions ?\r\nFeel free to ping me if you have questions or if you're ready for a review\r\n\r\nThanks again for adding this dataset, this one is very useful !", "> \r\n> \r\n> Hi @Phil1108 !\r\n> Have you had a chance to take a look at my suggestions ?\r\n> Feel free to ping me if you have questions or if you're ready for a review\r\n> \r\n> Thanks again for adding this dataset, this one is very useful !\r\n\r\nHello @lhoestq , \r\n\r\nokay so should we go on with only the 2 parts or wait until the hosting of all 200 GB is cleared at HF? \r\nIf you want to merge it with the 2 parts only at first und upgrade later to all, sure I'll include the minor changes in the next few days and update it here", "I think we can wait a bit to find a solution for the hosting and update the PR to include all the files when it's done.\r\nIn the meantime you can update the PR to take into account the suggestions regarding the dataset card, the parallel downloads and the use of eval.\r\n\r\nA safer alternative to eval is `ast.literal_eval`, it should do the job" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1425/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1425", "html_url": "https://github.com/huggingface/datasets/pull/1425", "diff_url": "https://github.com/huggingface/datasets/pull/1425.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1425.patch", "merged_at": null }

{ "login": "dadelani", "id": 23586676, "node_id": "MDQ6VXNlcjIzNTg2Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dadelani", "html_url": "https://github.com/dadelani", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "organizations_url": "https://api.github.com/users/dadelani/orgs", "repos_url": "https://api.github.com/users/dadelani/repos", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "received_events_url": "https://api.github.com/users/dadelani/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1424/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1424", "html_url": "https://github.com/huggingface/datasets/pull/1424", "diff_url": "https://github.com/huggingface/datasets/pull/1424.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1424.patch", "merged_at": null }

{ "login": "aclifton314", "id": 53267795, "node_id": "MDQ6VXNlcjUzMjY3Nzk1", "avatar_url": "https://avatars.githubusercontent.com/u/53267795?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aclifton314", "html_url": "https://github.com/aclifton314", "followers_url": "https://api.github.com/users/aclifton314/followers", "following_url": "https://api.github.com/users/aclifton314/following{/other_user}", "gists_url": "https://api.github.com/users/aclifton314/gists{/gist_id}", "starred_url": "https://api.github.com/users/aclifton314/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aclifton314/subscriptions", "organizations_url": "https://api.github.com/users/aclifton314/orgs", "repos_url": "https://api.github.com/users/aclifton314/repos", "events_url": "https://api.github.com/users/aclifton314/events{/privacy}", "received_events_url": "https://api.github.com/users/aclifton314/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Feel free to ping me once you're ready for another review :) ", "For sure! Gonna work on this now!", "I incorporated all the changes but when I go to rebase I get the following error:\r\n```python\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git rebase upstream/master\r\nerror: cannot rebase: You have unstaged changes.\r\nerror: Please commit or stash them.\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git stash\r\nSaved working directory and index state WIP on imppres: 51736236 Incorporated secondary sets as configurations instead of splits.\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git rebase upstream/master\r\nCONFLICT (add/add): Merge conflict in datasets/wiki_movies/wiki_movies.py\r\nAuto-merging datasets/wiki_movies/wiki_movies.py\r\nCONFLICT (add/add): Merge conflict in datasets/wiki_movies/dataset_infos.json\r\nAuto-merging datasets/wiki_movies/dataset_infos.json\r\nCONFLICT (add/add): Merge conflict in datasets/wiki_movies/README.md\r\nAuto-merging datasets/wiki_movies/README.md\r\nerror: could not apply 04d08587... Created wiki_movies dataset.\r\nResolve all conflicts manually, mark them as resolved with\r\n\"git add/rm <conflicted_files>\", then run \"git rebase --continue\".\r\nYou can instead skip this commit: run \"git rebase --skip\".\r\nTo abort and get back to the state before \"git rebase\", run \"git rebase --abort\".\r\nCould not apply 04d08587... Created wiki_movies dataset.\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git branch\r\n* (no branch, rebasing imppres)\r\n imppres\r\n logiqa_en\r\n master\r\n wiki_movies\r\n wiki_movies_htl\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git checkout imppres \r\ndatasets/wiki_movies/README.md: needs merge\r\ndatasets/wiki_movies/dataset_infos.json: needs merge\r\ndatasets/wiki_movies/wiki_movies.py: needs merge\r\nerror: you need to resolve your current index first\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ \r\n```", "I think it's because the current branch includes changes about wiki_movies.\r\n\r\nCan you create a new branch from `master` and create another PR please ?", "I get this response when I try to switch to master:\r\n```\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git checkout master\r\ndatasets/wiki_movies/README.md: needs merge\r\ndatasets/wiki_movies/dataset_infos.json: needs merge\r\ndatasets/wiki_movies/wiki_movies.py: needs merge\r\nerror: you need to resolve your current index first\r\n```", "Maybe you have to remove the changes in wiki_movies before checkout to master\r\n```\r\ngit stash\r\n```\r\n\r\nshould do the job", "Here is what I get:\r\n```\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git stash\r\ndatasets/wiki_movies/README.md: needs merge\r\ndatasets/wiki_movies/dataset_infos.json: needs merge\r\ndatasets/wiki_movies/wiki_movies.py: needs merge\r\n```", "Ok I see\r\nLooks like you're in a `merge` process.\r\nYou can abort it with `git reset --merge`\r\n\r\nThen `git checkout master` should work", "So close! I got the new branch made and went through all the tests. When I went to push, I got the following:\r\n```\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git push -u origin imppres\r\nUsername for 'https://github.com': aclifton314\r\nPassword for 'https://aclifton314@github.com': \r\nTo https://github.com/aclifton314/datasets\r\n ! [rejected] imppres -> imppres (non-fast-forward)\r\nerror: failed to push some refs to 'https://github.com/aclifton314/datasets'\r\nhint: Updates were rejected because the tip of your current branch is behind\r\nhint: its remote counterpart. Integrate the remote changes (e.g.\r\nhint: 'git pull ...') before pushing again.\r\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\r\n```", "after a rebase you need to `git push --force`", "Done!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1423/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 2, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1423", "html_url": "https://github.com/huggingface/datasets/pull/1423", "diff_url": "https://github.com/huggingface/datasets/pull/1423.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1423.patch", "merged_at": 1608229634000 }

{ "login": "SolomidHero", "id": 28161779, "node_id": "MDQ6VXNlcjI4MTYxNzc5", "avatar_url": "https://avatars.githubusercontent.com/u/28161779?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SolomidHero", "html_url": "https://github.com/SolomidHero", "followers_url": "https://api.github.com/users/SolomidHero/followers", "following_url": "https://api.github.com/users/SolomidHero/following{/other_user}", "gists_url": "https://api.github.com/users/SolomidHero/gists{/gist_id}", "starred_url": "https://api.github.com/users/SolomidHero/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SolomidHero/subscriptions", "organizations_url": "https://api.github.com/users/SolomidHero/orgs", "repos_url": "https://api.github.com/users/SolomidHero/repos", "events_url": "https://api.github.com/users/SolomidHero/events{/privacy}", "received_events_url": "https://api.github.com/users/SolomidHero/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Please could you post the whole script? I can't reproduce your issue. After updating the feature names/labels to match with the data, everything works fine for me. Try to update datasets/transformers to the newest version.", "Actually, the problem was how `tokenize` function was defined. This was completely my side mistake, so there are really no needs in this issue anymore" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1422/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "MisbahKhan789", "id": 15351802, "node_id": "MDQ6VXNlcjE1MzUxODAy", "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MisbahKhan789", "html_url": "https://github.com/MisbahKhan789", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1421/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1421", "html_url": "https://github.com/huggingface/datasets/pull/1421", "diff_url": "https://github.com/huggingface/datasets/pull/1421.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1421.patch", "merged_at": null }

{ "login": "michael-aloys", "id": 1858628, "node_id": "MDQ6VXNlcjE4NTg2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1858628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/michael-aloys", "html_url": "https://github.com/michael-aloys", "followers_url": "https://api.github.com/users/michael-aloys/followers", "following_url": "https://api.github.com/users/michael-aloys/following{/other_user}", "gists_url": "https://api.github.com/users/michael-aloys/gists{/gist_id}", "starred_url": "https://api.github.com/users/michael-aloys/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/michael-aloys/subscriptions", "organizations_url": "https://api.github.com/users/michael-aloys/orgs", "repos_url": "https://api.github.com/users/michael-aloys/repos", "events_url": "https://api.github.com/users/michael-aloys/events{/privacy}", "received_events_url": "https://api.github.com/users/michael-aloys/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1420/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1420", "html_url": "https://github.com/huggingface/datasets/pull/1420", "diff_url": "https://github.com/huggingface/datasets/pull/1420.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1420.patch", "merged_at": 1607693644000 }

{ "login": "basakbuluz", "id": 41359672, "node_id": "MDQ6VXNlcjQxMzU5Njcy", "avatar_url": "https://avatars.githubusercontent.com/u/41359672?v=4", "gravatar_id": "", "url": "https://api.github.com/users/basakbuluz", "html_url": "https://github.com/basakbuluz", "followers_url": "https://api.github.com/users/basakbuluz/followers", "following_url": "https://api.github.com/users/basakbuluz/following{/other_user}", "gists_url": "https://api.github.com/users/basakbuluz/gists{/gist_id}", "starred_url": "https://api.github.com/users/basakbuluz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/basakbuluz/subscriptions", "organizations_url": "https://api.github.com/users/basakbuluz/orgs", "repos_url": "https://api.github.com/users/basakbuluz/repos", "events_url": "https://api.github.com/users/basakbuluz/events{/privacy}", "received_events_url": "https://api.github.com/users/basakbuluz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq, can you please review this PR?\r\n", "@SBrandeis,\r\nSorry. All of the latest version came to my branch. You can find final version. \r\nResubmitted as a clean final version of #1466\r\nI have completed all the review comments.", "Closing this as PR is now https://github.com/huggingface/datasets/pull/1466" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1419/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1419", "html_url": "https://github.com/huggingface/datasets/pull/1419", "diff_url": "https://github.com/huggingface/datasets/pull/1419.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1419.patch", "merged_at": null }